[webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Adam Barth
It seems that some of the build bots have now been broken longer than we have records on build.webkit.org: $ ./WebKitTools/Scripts/webkit-patch what-broke Tiger Intel Release : FAIL (blame-list: sometime before 56055?) Leopard Intel Release (Build) : ok Leopard Intel Release

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Maciej Stachowiak
On Mar 17, 2010, at 12:02 AM, Adam Barth wrote: Manual investigation seems to implicate http://trac.webkit.org/changeset/56074 for at least some of the brokenness in SnowLeopard Intel Release (Tests). There's a patch in https://bugs.webkit.org/show_bug.cgi?id=36194 that claims to fix things,

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Xan Lopez
On Wed, Mar 17, 2010 at 9:02 AM, Adam Barth aba...@webkit.org wrote: Manual investigation confirms http://trac.webkit.org/changeset/56079 broke GTK Linux 32-bit Release, GTK Linux 64-bit Release, and Qt Linux Release.  Is there some reason we didn't roll out the offending patch? FWIW this

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Kenneth Russell
On Wed, Mar 17, 2010 at 12:44 AM, Maciej Stachowiak m...@apple.com wrote: On Mar 17, 2010, at 12:02 AM, Adam Barth wrote: Manual investigation seems to implicate http://trac.webkit.org/changeset/56074 for at least some of the brokenness in SnowLeopard Intel Release (Tests).  There's a patch

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Maciej Stachowiak
On Mar 17, 2010, at 1:49 AM, Kenneth Russell wrote: On Wed, Mar 17, 2010 at 12:44 AM, Maciej Stachowiak m...@apple.com wrote: On Mar 17, 2010, at 12:02 AM, Adam Barth wrote: Manual investigation seems to implicate http://trac.webkit.org/changeset/56074 for at least some of the brokenness

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Kenneth Russell
On Wed, Mar 17, 2010 at 2:16 AM, Maciej Stachowiak m...@apple.com wrote: On Mar 17, 2010, at 1:49 AM, Kenneth Russell wrote: On Wed, Mar 17, 2010 at 12:44 AM, Maciej Stachowiak m...@apple.com wrote: On Mar 17, 2010, at 12:02 AM, Adam Barth wrote: Manual investigation seems to implicate

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Maciej Stachowiak
On Mar 17, 2010, at 2:31 AM, Kenneth Russell wrote: Our best current plan is more widespread testing. We will file a Radar bug as soon as we have more information about the nature of the failure -- by virtue of working around the bugs. If we knew the precise hardware configuration of the

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Alexey Proskuryakov
On 17.03.2010, at 0:45, Xan Lopez wrote: Manual investigation confirms http://trac.webkit.org/changeset/ 56079 broke GTK Linux 32-bit Release, GTK Linux 64-bit Release, and Qt Linux Release. Is there some reason we didn't roll out the offending patch? FWIW this patch seems to only add

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Kenneth Russell
On Wed, Mar 17, 2010 at 2:52 AM, Maciej Stachowiak m...@apple.com wrote: On Mar 17, 2010, at 2:31 AM, Kenneth Russell wrote: Our best current plan is more widespread testing. We will file a Radar bug as soon as we have more information about the nature of the failure -- by virtue of working

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Alexey Proskuryakov
On 17.03.2010, at 12:14, Kenneth Russell wrote: websocket/tests/frame-lengths.html is one. This tests needs to be broken into several pieces to reliably pass in the time allowed. Or perhaps timeouts in run-webkit-tests and DRT should be increased. I'm not sure which is better - the

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Maciej Stachowiak
On Mar 17, 2010, at 12:14 PM, Kenneth Russell wrote: I think what should be done is to get the tree green by skipping these flaky tests; file high-priority bugs against the test authors to fix the flakiness; and then figure out a way the commit queue can be used for the vast majority of