Re: [webkit-dev] embedding pixel result checksum in the png
Hi, The idea is awesome. ;) Getting rid of ~32k checksum files would speedup svn operations. I support you're works, please cc me to the bug report. br, Ossy Tony Chang írta: Yes, reading the checksum is the same speed as before. We write the png comment at the beginning of the file and only scan the first 2k of the file for the checksum. I also tried converting about 200 tests to use embedded checksums and found no speed difference. I've already updated new-run-webkit-tests, but plan on updating old-run-webkit-tests as well since it's a small amount of code (only about 20 lines of python, I imagine the amount of perl will be similar). ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] embedding pixel result checksum in the png
Yes, reading the checksum is the same speed as before. We write the png comment at the beginning of the file and only scan the first 2k of the file for the checksum. I also tried converting about 200 tests to use embedded checksums and found no speed difference. I've already updated new-run-webkit-tests, but plan on updating old-run-webkit-tests as well since it's a small amount of code (only about 20 lines of python, I imagine the amount of perl will be similar). On Tue, Apr 5, 2011 at 3:55 PM, Darin Adler wrote: > Sounds like a great idea, as long as reading the checksum is still fast. > > I couldn’t tell when you mentioned run-webkit-tests in your steps what your > specific plans are for old-run-webkit-tests and new-run-webkit-tests. > >-- Darin > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] embedding pixel result checksum in the png
This is awesome! On Wed, Apr 6, 2011 at 5:11 AM, Tony Chang wrote: > > c) Update webkit-patch rebaseline to not copy over the .checksum file. > I don't think you need to do this. webkit-patch rebaseline is very basic right now. I think it only does the right thing for dumpAsText tests. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] embedding pixel result checksum in the png
Sounds like a great idea, as long as reading the checksum is still fast. I couldn’t tell when you mentioned run-webkit-tests in your steps what your specific plans are for old-run-webkit-tests and new-run-webkit-tests. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] embedding pixel result checksum in the png
I propose that we move away from checking in separate .checksum files for pixel tests and instead embed the checksum in the .png file as a comment. There are two main benefits of doing this: 1) Less files in the tree -> faster git/svn operations. Currently, in LayoutTests, 32,650 out of 141,170 files are checksum files (23% of the files). 2) Less likely to accidentally check in a .checksum without a .png or a .png without a .checksum. We're currently trying this out in the Chromium port, but I would like to add this to the other ports as well. To make embedded checksums easier to use, I've added a script Tools/Scripts/read-checksum-from-png that will read the checksum from a png file passed in on the command line. I've also updated the flakiness dashboard and plan on updating PrettyPrint.rb so you can see the checksums in a diff. If there are other tools or workflows that might be interrupted by this change, please let me know and I will update those tools as well. If there are no objections to this, my plan is as follows: a) Update DRT to write the checksum to png files. b) Update run-webkit-tests to read the checksum from png files if the .checksum file is absent. c) Update webkit-patch rebaseline to not copy over the .checksum file. d) Update run-webkit-tests --reset-results and --new-baseline to not write .checksum files. e) Start converting old results to the new format (i.e., put the checksum in the png and delete the .checksum file). Thoughts or suggestions for improvement? tony ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
