Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-19 Thread Chris Jerdonek
On Sun, Apr 18, 2010 at 4:11 PM, Maciej Stachowiak m...@apple.com wrote: That reminds me, we should turn off the 80-column limit on bugs.webkit.org - there's no need for it to hard-wrap your text. Great, I was wondering about that. I filed a report for that here:

Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-18 Thread Chris Jerdonek
I wanted to add a couple comments and a question to this discussion. On Fri, Apr 16, 2010 at 2:54 PM, Maciej Stachowiak m...@apple.com wrote: I haven't contributed to WebKit's Python code yet, but I will say that I agree with Eric's sentiments here. 80-column limit is archaic and pointless.

Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-18 Thread Maciej Stachowiak
On Apr 18, 2010, at 12:33 PM, Chris Jerdonek wrote: I wanted to add a couple comments and a question to this discussion. On Fri, Apr 16, 2010 at 2:54 PM, Maciej Stachowiak m...@apple.com wrote: I haven't contributed to WebKit's Python code yet, but I will say that I agree with Eric's

Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-16 Thread Eric Seidel
bike-shedding I think 80 columns is a waste of time and hurts readability. Instead of being smart about when we wrap code, 80 adheres to a blanket rule, discourages long variable/function names, and needlessly expands code vertically ignoring modern wider-than-long monitors. The optparse code

Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-16 Thread Maciej Stachowiak
On Apr 16, 2010, at 1:48 PM, Eric Seidel wrote: bike-shedding I think 80 columns is a waste of time and hurts readability. Instead of being smart about when we wrap code, 80 adheres to a blanket rule, discourages long variable/function names, and needlessly expands code vertically ignoring

Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-16 Thread David Levin
(I have contributed but not often.) I also agree with 80 columns hurts readability. It doesn't take much looking to show a lothttp://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py#L135of

Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-16 Thread Dirk Pranke
I think having longer lines of code hurts readability. There is lots of typographic evidence to back this up ( e.g. http://webtypography.net/Rhythm_and_Proportion/Horizontal_Motion/2.1.2/. Of course, the typographic commentary applies to text rather than code, and most text isn't indented, but I

[webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-14 Thread Dirk Pranke
Hi all, As I'm sure the discussions in the webkit meeting over the past two days made clear, it looks like most of our non-C++ code is getting written in Python. Back in January, Adam Barth posted this thread [1] where I thought it was agreed we would attempt to follow PEP 8 ([2] - the standard