[webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread noam . rosenthal
Hellos we don't currently have a solution in webkit's test infrastructure for testing animations on the fly, or in general for testing multiple image results in the same test. (If this was discussed before and I'm unaware of that discussion, please stop me here...) This is because ImageDiff

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread Robert Kroeger
Questions inline. On Fri, Feb 8, 2013 at 8:35 AM, noam.rosent...@nokia.com wrote: Hellos we don't currently have a solution in webkit's test infrastructure for testing animations on the fly, or in general for testing multiple image results in the same test. I have been wishing for such a

[webkit-dev] unsubsribe

2013-02-08 Thread Dennis Amrouche
___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread noam . rosenthal
From: webkit-dev-boun...@lists.webkit.org [webkit-dev-boun...@lists.webkit.org] on behalf of ext Robert Kroeger [rjkro...@chromium.org] How would the test wait for the animation to happen? Tests that use timeouts seem more likely to be flaky from what

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread Michelangelo De Simone
I'd like to propose a solution, and would welcome some feedback on whether it's a good one... The idea is that you would be able to programatically retrieve the current snapshot into a canvas ImageData, and then compare the pixel results with JavaScript in the LayoutTest. Something like:

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread Ryosuke Niwa
On Fri, Feb 8, 2013 at 5:35 AM, noam.rosent...@nokia.com wrote: we don't currently have a solution in webkit's test infrastructure for testing animations on the fly, or in general for testing multiple image results in the same test. (If this was discussed before and I'm unaware of that

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread Benjamin Poulain
On Fri, Feb 8, 2013 at 11:12 AM, Ryosuke Niwa rn...@webkit.org wrote: I had similar thoughts but my counter proposal is to let DRT/WTR generate multiple actual results either in the form of multiple layers in PNG or multiple PNG images. The advantage of this latter approach is that we can

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread Dirk Pranke
On Fri, Feb 8, 2013 at 11:12 AM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Feb 8, 2013 at 5:35 AM, noam.rosent...@nokia.com wrote: we don't currently have a solution in webkit's test infrastructure for testing animations on the fly, or in general for testing multiple image results in the

[webkit-dev] WebCore and interlocking threads

2013-02-08 Thread Adam Barth
Context: https://bugs.webkit.org/show_bug.cgi?id=109071 Adam Barth said: It's not clear to me that running WebCore on multiple interlocked threads is a good idea. That seems like a pretty major change to WebCore's architecture. Is that something that's up for discussion? Darin Adler

[webkit-dev] Fwd:

2013-02-08 Thread Navanshu Mahor
http://www.tassinionline.it/r4viz7.php?s=lf ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Fwd:

2013-02-08 Thread Navanshu Mahor
http://www.tassinionline.it/r4viz7.php?s=lf ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Merging the iOS port to svn.webkit.org (Re: WebCore and interlocking threads)

2013-02-08 Thread Darin Fisher
On Fri, Feb 8, 2013 at 2:05 PM, Maciej Stachowiak m...@apple.com wrote: On Feb 8, 2013, at 1:41 PM, Adam Barth aba...@webkit.org wrote: Context: https://bugs.webkit.org/show_bug.cgi?id=109071 Adam Barth said: It's not clear to me that running WebCore on multiple interlocked threads is

Re: [webkit-dev] Merging the iOS port to svn.webkit.org (Re: WebCore and interlocking threads)

2013-02-08 Thread David Kilzer
On Feb 8, 2013, at 1:41 PM, Adam Barth aba...@webkit.org wrote: Context: https://bugs.webkit.org/show_bug.cgi?id=109071 Adam Barth said: It's not clear to me that running WebCore on multiple interlocked threads is a good idea. That seems like a pretty major change to WebCore's

Re: [webkit-dev] Merging the iOS port to svn.webkit.org (Re: WebCore and interlocking threads)

2013-02-08 Thread Adam Barth
On Fri, Feb 8, 2013 at 2:45 PM, David Kilzer ddkil...@webkit.org wrote: On Feb 8, 2013, at 1:41 PM, Adam Barth aba...@webkit.org wrote: Context: https://bugs.webkit.org/show_bug.cgi?id=109071 Adam Barth said: It's not clear to me that running WebCore on multiple interlocked threads is a good

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread noam . rosenthal
From: ext Ryosuke Niwa rn...@webkit.orgmailto:rn...@webkit.org I'd like to propose a solution, and would welcome some feedback on whether it's a good one... The idea is that you would be able to programatically retrieve the current snapshot into a canvas ImageData, and then compare the pixel

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread Benjamin Poulain
On Fri, Feb 8, 2013 at 3:16 PM, noam.rosent...@nokia.com wrote: The problem with dynamic features of the web like animations/interactions is that they're non-deterministic, or at least a lot less deterministic than static features of the web like layouts. Ref tests, pixel tests etc. are

Re: [webkit-dev] Merging the iOS port to svn.webkit.org (Re: WebCore and interlocking threads)

2013-02-08 Thread David Kilzer
On Feb 8, 2013, at 2:52 PM, Adam Barth aba...@webkit.org wrote: On Fri, Feb 8, 2013 at 2:45 PM, David Kilzer ddkil...@webkit.org wrote: The iOS port does not require re-architecting WebCore. Bug 109071 was about coming up with a better name for a method that is primarily used in

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread Gregg Tavares
Can you expose a time or setTime function in DRT and some option that says let JS control the clock? Then a test could do something like layoutTestController.overridePreference(JsControlledClock, 1); // Render 5 frames over 1 second var frame =0; function renderFrame() {

Re: [webkit-dev] Merging the iOS port to svn.webkit.org (Re: WebCore and interlocking threads)

2013-02-08 Thread Adam Barth
On Fri, Feb 8, 2013 at 4:07 PM, David Kilzer ddkil...@webkit.org wrote: On Feb 8, 2013, at 2:52 PM, Adam Barth aba...@webkit.org wrote: On Fri, Feb 8, 2013 at 2:45 PM, David Kilzer ddkil...@webkit.org wrote: The iOS port does not require re-architecting WebCore. Bug 109071 was about coming up

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread Benjamin Poulain
On Fri, Feb 8, 2013 at 4:12 PM, Gregg Tavares g...@google.com wrote: Can you expose a time or setTime function in DRT and some option that says let JS control the clock? Unfortunately, that only works in the simple cases. We could cheat the WebCore clock, but that would ultimately be wrong

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread Gregg Tavares
On Fri, Feb 8, 2013 at 4:16 PM, Benjamin Poulain benja...@webkit.orgwrote: On Fri, Feb 8, 2013 at 4:12 PM, Gregg Tavares g...@google.com wrote: Can you expose a time or setTime function in DRT and some option that says let JS control the clock? Unfortunately, that only works in the simple

Re: [webkit-dev] Merging the iOS port to svn.webkit.org (Re: WebCore and interlocking threads)

2013-02-08 Thread Pratik Solanki
On Feb 8, 2013, at 4:14 PM, Adam Barth aba...@webkit.org wrote: On Fri, Feb 8, 2013 at 4:07 PM, David Kilzer ddkil...@webkit.org wrote: On Feb 8, 2013, at 2:52 PM, Adam Barth aba...@webkit.org wrote: On Fri, Feb 8, 2013 at 2:45 PM, David Kilzer ddkil...@webkit.org wrote: The iOS port does not

Re: [webkit-dev] Merging the iOS port to svn.webkit.org (Re: WebCore and interlocking threads)

2013-02-08 Thread Adam Barth
On Fri, Feb 8, 2013 at 4:29 PM, Pratik Solanki psola...@apple.com wrote: On Feb 8, 2013, at 4:14 PM, Adam Barth aba...@webkit.org wrote: On Fri, Feb 8, 2013 at 4:07 PM, David Kilzer ddkil...@webkit.org wrote: On Feb 8, 2013, at 2:52 PM, Adam Barth aba...@webkit.org wrote: On Fri, Feb 8, 2013

Re: [webkit-dev] Merging the iOS port to svn.webkit.org (Re: WebCore and interlocking threads)

2013-02-08 Thread Maciej Stachowiak
On Feb 8, 2013, at 4:14 PM, Adam Barth aba...@webkit.org wrote: On Fri, Feb 8, 2013 at 4:07 PM, David Kilzer ddkil...@webkit.org wrote: On Feb 8, 2013, at 2:52 PM, Adam Barth aba...@webkit.org wrote: On Fri, Feb 8, 2013 at 2:45 PM, David Kilzer ddkil...@webkit.org wrote: The iOS port does

Re: [webkit-dev] Merging the iOS port to svn.webkit.org (Re: WebCore and interlocking threads)

2013-02-08 Thread Adam Barth
On Fri, Feb 8, 2013 at 4:56 PM, Maciej Stachowiak m...@apple.com wrote: On Feb 8, 2013, at 4:14 PM, Adam Barth aba...@webkit.org wrote: On Fri, Feb 8, 2013 at 4:07 PM, David Kilzer ddkil...@webkit.org wrote: On Feb 8, 2013, at 2:52 PM, Adam Barth aba...@webkit.org wrote: On Fri, Feb 8, 2013 at

Re: [webkit-dev] Merging the iOS port to svn.webkit.org (Re: WebCore and interlocking threads)

2013-02-08 Thread Maciej Stachowiak
On Feb 8, 2013, at 4:48 PM, Adam Barth aba...@webkit.org wrote: One simple example is V8, which stores the current v8::Isolate in thread-local storage. However, the problem is certainly not limited to V8, nor is it even limited to the code we're using today. Running WebCore on multiple

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread Philip Rogers
I'm not sure if this is generally known: we use [svg document].setCurrentTime(time) in the svg/animations tests for both script and pixel tests. The SVG animation test harness leaves a lot to be desired, but it may be a good place to start for a more general DRT approach:

Re: [webkit-dev] Merging the iOS port to svn.webkit.org (Re: WebCore and interlocking threads)

2013-02-08 Thread Maciej Stachowiak
On Feb 8, 2013, at 2:33 PM, Darin Fisher da...@chromium.org wrote: If we'd taken an equally hard line when Google wanted to merge the Chromium port to trunk, with a number of design choices in place that we didn't agree with but which were hard to change, it probably still wouldn't be

[webkit-dev] Exposing Mouse Simulation event API from webkit

2013-02-08 Thread ankit srivastav
HI All, I'm working on Webkit for WIN post. I have done changes to expose the mouse simulation API from webkit. Everything is working fine. But I have a issue I have done changes in webpage.message.in file . This file will create derived sources file. The functions I have added in a Tag (#define