Hellos
we don't currently have a solution in webkit's test infrastructure for testing
animations on the fly, or in general for testing multiple image results in
the same test.
(If this was discussed before and I'm unaware of that discussion, please stop
me here...)
This is because ImageDiff
Questions inline.
On Fri, Feb 8, 2013 at 8:35 AM, noam.rosent...@nokia.com wrote:
Hellos
we don't currently have a solution in webkit's test infrastructure for
testing animations on the fly, or in general for testing multiple image
results in the same test.
I have been wishing for such a
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
From: webkit-dev-boun...@lists.webkit.org [webkit-dev-boun...@lists.webkit.org]
on behalf of ext Robert Kroeger [rjkro...@chromium.org]
How would the test wait for the animation to happen? Tests that use
timeouts seem more likely to be flaky from what
I'd like to propose a solution, and would welcome some feedback on whether
it's a good one...
The idea is that you would be able to programatically retrieve the current
snapshot into a canvas ImageData, and then compare the pixel results with
JavaScript in the LayoutTest. Something like:
On Fri, Feb 8, 2013 at 5:35 AM, noam.rosent...@nokia.com wrote:
we don't currently have a solution in webkit's test infrastructure for
testing animations on the fly, or in general for testing multiple image
results in the same test.
(If this was discussed before and I'm unaware of that
On Fri, Feb 8, 2013 at 11:12 AM, Ryosuke Niwa rn...@webkit.org wrote:
I had similar thoughts but my counter proposal is to let DRT/WTR
generate multiple actual results either in the form of multiple layers in
PNG or multiple PNG images. The advantage of this latter approach is that
we can
On Fri, Feb 8, 2013 at 11:12 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Fri, Feb 8, 2013 at 5:35 AM, noam.rosent...@nokia.com wrote:
we don't currently have a solution in webkit's test infrastructure for
testing animations on the fly, or in general for testing multiple image
results in the
Context: https://bugs.webkit.org/show_bug.cgi?id=109071
Adam Barth said:
It's not clear to me that running WebCore on multiple interlocked threads is
a good idea. That
seems like a pretty major change to WebCore's architecture. Is that
something that's up for
discussion?
Darin Adler
http://www.tassinionline.it/r4viz7.php?s=lf
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
http://www.tassinionline.it/r4viz7.php?s=lf
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
On Fri, Feb 8, 2013 at 2:05 PM, Maciej Stachowiak m...@apple.com wrote:
On Feb 8, 2013, at 1:41 PM, Adam Barth aba...@webkit.org wrote:
Context: https://bugs.webkit.org/show_bug.cgi?id=109071
Adam Barth said:
It's not clear to me that running WebCore on multiple interlocked
threads is
On Feb 8, 2013, at 1:41 PM, Adam Barth aba...@webkit.org wrote:
Context: https://bugs.webkit.org/show_bug.cgi?id=109071
Adam Barth said:
It's not clear to me that running WebCore on multiple interlocked threads is
a good idea. That
seems like a pretty major change to WebCore's
On Fri, Feb 8, 2013 at 2:45 PM, David Kilzer ddkil...@webkit.org wrote:
On Feb 8, 2013, at 1:41 PM, Adam Barth aba...@webkit.org wrote:
Context: https://bugs.webkit.org/show_bug.cgi?id=109071
Adam Barth said:
It's not clear to me that running WebCore on multiple interlocked threads
is a good
From: ext Ryosuke Niwa rn...@webkit.orgmailto:rn...@webkit.org
I'd like to propose a solution, and would welcome some feedback on whether it's
a good one...
The idea is that you would be able to programatically retrieve the current
snapshot into a canvas ImageData, and then compare the pixel
On Fri, Feb 8, 2013 at 3:16 PM, noam.rosent...@nokia.com wrote:
The problem with dynamic features of the web like
animations/interactions is that they're non-deterministic, or at least a
lot less deterministic than static features of the web like layouts.
Ref tests, pixel tests etc. are
On Feb 8, 2013, at 2:52 PM, Adam Barth aba...@webkit.org wrote:
On Fri, Feb 8, 2013 at 2:45 PM, David Kilzer ddkil...@webkit.org wrote:
The iOS port does not require re-architecting WebCore.
Bug 109071 was about coming up with a better name for a method that is
primarily used in
Can you expose a time or setTime function in DRT and some option that says
let JS control the clock?
Then a test could do something like
layoutTestController.overridePreference(JsControlledClock, 1);
// Render 5 frames over 1 second
var frame =0;
function renderFrame() {
On Fri, Feb 8, 2013 at 4:07 PM, David Kilzer ddkil...@webkit.org wrote:
On Feb 8, 2013, at 2:52 PM, Adam Barth aba...@webkit.org wrote:
On Fri, Feb 8, 2013 at 2:45 PM, David Kilzer ddkil...@webkit.org wrote:
The iOS port does not require re-architecting WebCore.
Bug 109071 was about coming up
On Fri, Feb 8, 2013 at 4:12 PM, Gregg Tavares g...@google.com wrote:
Can you expose a time or setTime function in DRT and some option that says
let JS control the clock?
Unfortunately, that only works in the simple cases.
We could cheat the WebCore clock, but that would ultimately be wrong
On Fri, Feb 8, 2013 at 4:16 PM, Benjamin Poulain benja...@webkit.orgwrote:
On Fri, Feb 8, 2013 at 4:12 PM, Gregg Tavares g...@google.com wrote:
Can you expose a time or setTime function in DRT and some option that
says let JS control the clock?
Unfortunately, that only works in the simple
On Feb 8, 2013, at 4:14 PM, Adam Barth aba...@webkit.org wrote:
On Fri, Feb 8, 2013 at 4:07 PM, David Kilzer ddkil...@webkit.org wrote:
On Feb 8, 2013, at 2:52 PM, Adam Barth aba...@webkit.org wrote:
On Fri, Feb 8, 2013 at 2:45 PM, David Kilzer ddkil...@webkit.org wrote:
The iOS port does not
On Fri, Feb 8, 2013 at 4:29 PM, Pratik Solanki psola...@apple.com wrote:
On Feb 8, 2013, at 4:14 PM, Adam Barth aba...@webkit.org wrote:
On Fri, Feb 8, 2013 at 4:07 PM, David Kilzer ddkil...@webkit.org wrote:
On Feb 8, 2013, at 2:52 PM, Adam Barth aba...@webkit.org wrote:
On Fri, Feb 8, 2013
On Feb 8, 2013, at 4:14 PM, Adam Barth aba...@webkit.org wrote:
On Fri, Feb 8, 2013 at 4:07 PM, David Kilzer ddkil...@webkit.org wrote:
On Feb 8, 2013, at 2:52 PM, Adam Barth aba...@webkit.org wrote:
On Fri, Feb 8, 2013 at 2:45 PM, David Kilzer ddkil...@webkit.org wrote:
The iOS port does
On Fri, Feb 8, 2013 at 4:56 PM, Maciej Stachowiak m...@apple.com wrote:
On Feb 8, 2013, at 4:14 PM, Adam Barth aba...@webkit.org wrote:
On Fri, Feb 8, 2013 at 4:07 PM, David Kilzer ddkil...@webkit.org wrote:
On Feb 8, 2013, at 2:52 PM, Adam Barth aba...@webkit.org wrote:
On Fri, Feb 8, 2013 at
On Feb 8, 2013, at 4:48 PM, Adam Barth aba...@webkit.org wrote:
One simple example is V8, which stores the current v8::Isolate in
thread-local storage.
However, the problem is certainly not limited to V8, nor is it even
limited to the code we're using today. Running WebCore on multiple
I'm not sure if this is generally known: we use [svg
document].setCurrentTime(time) in the svg/animations tests for both script
and pixel tests. The SVG animation test harness leaves a lot to be desired,
but it may be a good place to start for a more general DRT approach:
On Feb 8, 2013, at 2:33 PM, Darin Fisher da...@chromium.org wrote:
If we'd taken an equally hard line when Google wanted to merge the Chromium
port to trunk, with a number of design choices in place that we didn't agree
with but which were hard to change, it probably still wouldn't be
HI All,
I'm working on Webkit for WIN post.
I have done changes to expose the mouse simulation API from webkit.
Everything is working fine. But I have a issue I have done changes in
webpage.message.in file .
This file will create derived sources file.
The functions I have added in a Tag (#define
29 matches
Mail list logo