Re: [webkit-dev] unified sources build + forwarding headers that are copies

"Huh, this seems to be a consequence of our conversion to #pragma once" Absolutely. #ifndef _MY_SPECIAL_HEADER_FILE_H #define _MY_SPECIAL_HEADER_FILE_H ... #endif You could then include this MySpecialHeaderFile.h from all sorts of places and the definitions would only appear to the compiler

Re: [webkit-dev] unified sources build + forwarding headers that are copies

14.11.2017, 14:54, "Salisbury, Mark" : > Hello, > > I’m building on Windows (WPE platform, perhaps I’m the first to try this!) > and I’m seeing some compile errors that I believe are arising from previously > untested combinations of source files. > > If I understand

Re: [webkit-dev] unified sources build + forwarding headers that are copies

Thanks for the replies Alex, Michael, Konstantin. I've submitted a bug with proposed patch here: https://bugs.webkit.org/show_bug.cgi?id=179814 -Mark -Original Message- From: achristen...@apple.com [mailto:achristen...@apple.com] Sent: Tuesday, November 14, 2017 12:25 PM To: Salisbury,

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

On Thu, Nov 16, 2017 at 11:10 AM, Alexey Proskuryakov wrote: Regression tests are taking an excessive amount of time to run for us (more than 1.5 hours in a debug build), a very large proportion of which is WPT. I do not think that the strategy of adopting WPT tests is

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

Hi Philip, We (at Igalia) are strong supporters of WPT tests and we've appreciated a lot the effort made by Youenn and others to make them possible in WebKit. They are very important for interoperability and make life much easier for developers working on different WebKit ports and different Web

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

16.11.2017, 20:10, "Alexey Proskuryakov" : > Migrating WebKit tests seems undesirable to me, as that would make us lose > all their modification history. As mentioned before, WPT tests are inherently > getting less attention in CI support, largely because of unclear benefit

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

17.11.2017, 18:19, "Maciej Stachowiak" : >>  On Nov 17, 2017, at 7:15 AM, Konstantin Tokarev wrote: >> >>  16.11.2017, 20:10, "Alexey Proskuryakov" : >>>  Migrating WebKit tests seems undesirable to me, as that would make us lose >>> all

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

On 17/11/2017 16:26, Maciej Stachowiak wrote: > WebKit has a lot of tests that were regression tests for a specific > bug fix, not as conformance tests (though they might b useful for that > too). In such cases, the association with the bugs.webkit.org bug is > more important than the spec URL.

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

Hi Danyao, I'm afraid that I don't yet have proper breakdown of this, but this is from some quick grepping in WebKit: - 3200k *-expected.html outside of LayoutTests/imported, that might work as reftests. - 60k files that aren't called *-expected.*, again outside of

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

> On Nov 17, 2017, at 7:05 AM, Frédéric WANG wrote: > > Hi Philip, > > We (at Igalia) are strong supporters of WPT tests and we've appreciated a lot > the effort made by Youenn and others to make them possible in WebKit. They > are very important for interoperability and

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

(re-sending from a correct address) > 17 нояб. 2017 г., в 9:18, youenn fablet > написал(а): > > Chris recently noticed that some heavily used files (testharness*) were > cacheable through Apache but not WPT. > This is now fixed and should improve

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

> On Nov 17, 2017, at 7:53 AM, Frédéric WANG wrote: > > On 17/11/2017 16:26, Maciej Stachowiak wrote: >> WebKit has a lot of tests that were regression tests for a specific >> bug fix, not as conformance tests (though they might b useful for that >> too). In such cases, the

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

> On Nov 17, 2017, at 9:18 AM, youenn fablet wrote: > > Chris recently noticed that some heavily used files (testharness*) were > cacheable through Apache but not WPT. Wasn’t me. Alexey reported this via Description

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

>From my experience, the people behind WPT are quite responsive to WebKit community. Here are two examples: Chris recently noticed that some heavily used files (testharness*) were cacheable through Apache but not WPT. This is now fixed and should improve WPT performances. In January, was discussed

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

Thanks for taking the time to share this additional information. I think this is helpful to make progress. Please see inline for some more comments related to the points you are bringing to the table. Stepping back from the WPT server specific issue, being optimistic and assuming that we are able

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

> On Nov 17, 2017, at 7:15 AM, Konstantin Tokarev wrote: > > > > 16.11.2017, 20:10, "Alexey Proskuryakov" : >> Migrating WebKit tests seems undesirable to me, as that would make us lose >> all their modification history. As mentioned before, WPT tests are