Re: [webkit-dev] Code Style: Opinion on returning void

I also prefer allowed returning void. Chris Dumez > On Feb 19, 2019, at 10:35 PM, Daniel Bates wrote: > > > >> On Feb 19, 2019, at 9:42 PM, Ryosuke Niwa wrote: >> >>> On Tue, Feb 19, 2019 at 8:59 PM Daniel Bates wrote: >> >>> > On Feb 7, 2019, at 12:47 PM, Daniel Bates wrote: >>> > >>>

Re: [webkit-dev] Code Style: Opinion on returning void

> On Feb 20, 2019, at 7:48 AM, Daniel Bates wrote: > > Okay, you’ve changed your mind from your earlier email of not having a strong > opinion. Would have been good to know from the get-go. Better late than never > knowing :/ I did not change my mind. I said I was using this pattern in my

[webkit-dev] Code Style: Opinion on returning void

Okay, you’ve changed your mind from your earlier email of not having a strong opinion. Would have been good to know from the get-go. Better late than never knowing :/ Dan On Feb 20, 2019, at 6:58 AM, Chris Dumez wrote: I also prefer allowed returning void. Chris Dumez On Feb 19, 2019, at

[webkit-dev] Code Style: Opinion on returning void

Thanks for the opinion! Dan On Feb 20, 2019, at 7:26 AM, Saam Barati wrote: I prefer it as well. - Saam On Feb 20, 2019, at 6:58 AM, Chris Dumez wrote: I also prefer allowed returning void. Chris Dumez On Feb 19, 2019, at 10:35 PM, Daniel Bates wrote: On Feb 19, 2019, at 9:42 PM,

[webkit-dev] Moving to Git

Hi, I was curious about the status of the proposal for migrating from SVN to Git (https://trac.webkit.org/wiki/Moving%20to%20Git). The relevant page on the Trac wiki hasn't been updated for over 5 years and since then Git has become much more popular (the de facto standard for new projects,

Re: [webkit-dev] Code Style: Opinion on returning void

I prefer it as well. - Saam > On Feb 20, 2019, at 6:58 AM, Chris Dumez wrote: > > I also prefer allowed returning void. > > Chris Dumez > >> On Feb 19, 2019, at 10:35 PM, Daniel Bates wrote: >> >> >> >>> On Feb 19, 2019, at 9:42 PM, Ryosuke Niwa wrote: >>> On Tue, Feb 19, 2019 at

Re: [webkit-dev] Moving to Git

Sorry, for the anonymous email. I opted for it because the list archives are public and concluded that it's not that useful to reveal my identity for the purposes of this question. In short, however, I am a graduate student interested in using WebKit for an academic project and thought that I

Re: [webkit-dev] Moving to Git

I considered this option, but my work will involve touching multiple parts of the codebase and thus I would like to be able to keep up / merge locally with the upstream every now and then (e.g. on each relatively stable release, such as Apple's Safari Technology Preview). However, all

Re: [webkit-dev] Moving to Git

On Wed, 2019-02-20 at 09:40 -0800, Ryosuke Niwa wrote: > > On Wed, Feb 20, 2019 at 8:28 AM Bug Tracker < > bug.tracking.acco...@protonmail.com> wrote: > > I was curious about the status of the proposal for migrating from > > SVN to Git (https://trac.webkit.org/wiki/Moving%20to%20Git). > > > >

Re: [webkit-dev] Moving to Git

On Wed, Feb 20, 2019 at 10:02 AM Philippe Normand wrote: > On Wed, 2019-02-20 at 09:40 -0800, Ryosuke Niwa wrote: > > > > On Wed, Feb 20, 2019 at 8:28 AM Bug Tracker < > > bug.tracking.acco...@protonmail.com> wrote: > > > I was curious about the status of the proposal for migrating from > > >

Re: [webkit-dev] Moving to Git

On Wed, Feb 20, 2019 at 8:28 AM Bug Tracker < bug.tracking.acco...@protonmail.com> wrote: > > I was curious about the status of the proposal for migrating from SVN to > Git (https://trac.webkit.org/wiki/Moving%20to%20Git). > > The relevant page on the Trac wiki hasn't been updated for over 5

Re: [webkit-dev] Code Style: Opinion on returning void

I find it mind bending. It makes me wonder if the author made a coding error. Simon > On Feb 20, 2019, at 7:48 AM, Daniel Bates wrote: > > Thanks for the opinion! > > Dan > > On Feb 20, 2019, at 7:26 AM, Saam Barati > wrote: > >> I prefer it as well. >> >> - Saam

Re: [webkit-dev] Moving to Git

Are you a WebKit developer? I can't tell from your email. Simon > On Feb 20, 2019, at 8:27 AM, Bug Tracker > wrote: > > Hi, > > I was curious about the status of the proposal for migrating from SVN to Git > (https://trac.webkit.org/wiki/Moving%20to%20Git >

Re: [webkit-dev] Code Style: Opinion on returning void

I also prefer it, and I think some coding patterns may require it e.g. in templates where sometimes we want to specialize into a void function, and other times into a function that returns a value. However, this is rarely needed in practice. Without being able to return void, writing such a

Re: [webkit-dev] Code Style: Opinion on returning void

> On Feb 20, 2019, at 10:35 AM, Mark Lam wrote: > > I also prefer it, and I think some coding patterns may require it e.g. in > templates where sometimes we want to specialize into a void function, and > other times into a function that returns a value. However, this is rarely > needed in

Re: [webkit-dev] Moving to Git

20.02.2019, 22:27, "Bug Tracker" : > Sorry, for the anonymous email. I opted for it because the list archives are > public and concluded that it's not that useful to reveal my identity for the > purposes of this question. > > In short, however, I am a graduate student interested in using

Re: [webkit-dev] Code Style: Opinion on returning void

It seems like `return foo();` where foo() is a void function can always be replaced with `foo(); return;` for greater clarity at the cost of one extra line break. For people who prefer the one-line style, can you say why you don’t like the other way? - Maciej > On Feb 20, 2019, at 10:33 AM,

Re: [webkit-dev] Moving to Git

FWIW, it's not hard to enforce fast-forward merges with a git hook; that way, we can guarantee that the history has no merge commits and is fully linear. GitLab has built-in support to enforce this for merge requests (though not for direct commits). I agree that linear history is a must for a

Re: [webkit-dev] Moving to Git

> On Feb 20, 2019, at 12:14 PM, Michael Catanzaro wrote: > > FWIW, it's not hard to enforce fast-forward merges with a git hook; that way, > we can guarantee that the history has no merge commits and is fully linear. > GitLab has built-in support to enforce this for merge requests (though

Re: [webkit-dev] Code Style: Opinion on returning void

> On Feb 20, 2019, at 1:14 PM, Maciej Stachowiak wrote: > > > It seems like `return foo();` where foo() is a void function can always be > replaced with `foo(); return;` for greater clarity at the cost of one extra > line break. For people who prefer the one-line style, can you say why you

Re: [webkit-dev] Moving to Git

On Wed, 20 Feb 2019 22:30:22 +0300, Konstantin Tokarev wrote: > 20.02.2019, 22:27, "Bug Tracker" : > > > Sorry, for the anonymous email. I opted for it because the list archives > > are public and concluded that it's not that useful to reveal my identity > > for the purposes of this

Re: [webkit-dev] Code Style: Opinion on returning void

On Wed, Feb 20, 2019 at 12:33 PM, Simon Fraser wrote: I find it mind bending. It makes me wonder if the author made a coding error. Yeah me too. It does seem to work nicely in Alex's CompletionHandler example, but still, I'd just add braces and return on an extra line if I was writing it.

Re: [webkit-dev] Code Style: Opinion on returning void

I like it mostly for its brevity, but I also think it would be strange that changing a return type from bool to void or vice versa would require touching all its call sites. > On Feb 20, 2019, at 1:20 PM, Chris Dumez wrote: > >> >> On Feb 20, 2019, at 1:14 PM, Maciej Stachowiak >