Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-08 Thread Ryosuke Niwa
Seems like there is a consensus here. Here's a patch to codify it in our code style guidelines: https://bugs.webkit.org/show_bug.cgi?id=204021 On Mon, Nov 4, 2019 at 8:06 AM Alex Christensen wrote: > When the lambda is mutable or has a trailing return type, the () is > currently required by the

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-08 Thread Ryosuke Niwa
There has been no more votes either way so no space wins. Here's a patch to codify it in our code style guidelines: https://bugs.webkit.org/show_bug.cgi?id=204021 - R. Niwa On Sat, Nov 2, 2019 at 8:26 PM Ryosuke Niwa wrote: > On Sat, Nov 2, 2019 at 10:16 AM Caitlin Potter wrote: > >> Not that

[webkit-dev] Supporting for finding ref tests

2019-11-08 Thread Simon Fraser
I'd like to land a patch to support finding test references via : https://bugs.webkit.org/show_bug.cgi?id=203784 There has been some discussion about this in the past: https://lists.webkit.org/pipermail/webkit-dev/2011-November/018470.html

Re: [webkit-dev] Supporting for finding ref tests

2019-11-08 Thread Ryosuke Niwa
On Fri, Nov 8, 2019 at 2:01 PM Simon Fraser wrote: > > I'd like to land a patch to support finding test references via rel="match/mismatch">: > https://bugs.webkit.org/show_bug.cgi?id=203784 > > There has been some discussion about this in the past: > https://lists.webkit.org/pipermail/webkit-dev

Re: [webkit-dev] Supporting for finding ref tests

2019-11-08 Thread Robert Ma
WPT has recently passed an RFC trying to simplify the reftest graph (although it has not been implemented yet), which eliminates a lot of the complexities and concerns. On Fri, Nov 8, 2019 at 5:07 PM Ryosuke Ni

Re: [webkit-dev] Supporting for finding ref tests

2019-11-08 Thread Simon Fraser
> On Nov 8, 2019, at 2:07 PM, Ryosuke Niwa wrote: > > On Fri, Nov 8, 2019 at 2:01 PM Simon Fraser wrote: >> >> I'd like to land a patch to support finding test references via > rel="match/mismatch">: >> https://bugs.webkit.org/show_bug.cgi?id=203784 >> >> There has been some discussion about

Re: [webkit-dev] Supporting for finding ref tests

2019-11-08 Thread Simon Fraser
> On Nov 8, 2019, at 2:15 PM, Robert Ma wrote: > > WPT has recently passed an RFC > > trying to simplify the reftest graph (although it has not been implemented > yet), which eliminates a lot of the comple

Re: [webkit-dev] Supporting for finding ref tests

2019-11-08 Thread Ryosuke Niwa
On Fri, Nov 8, 2019 at 2:15 PM Simon Fraser wrote: > > > On Nov 8, 2019, at 2:07 PM, Ryosuke Niwa wrote: > > > > On Fri, Nov 8, 2019 at 2:01 PM Simon Fraser wrote: > >> > >> I'd like to land a patch to support finding test references via >> rel="match/mismatch">: > >> https://bugs.webkit.org/sh