Re: [webkit-dev] Request for position on the aspect-ratio CSS property

2020-10-20 Thread Rob Buis
Hi, I was looking into aspect-ratio and there is one thing Christian did not mention yet. There is an existing aspect-ratio implementation (https://bugs.webkit.org/show_bug.cgi?id=47738) that uses the property -webkit-aspect-ratio and seems replaced elements only. Probably aspect-ratio can

Re: [webkit-dev] in WebKit?

2020-10-20 Thread Antti Koivisto
I landed the updated behavior. antti On Mon, Oct 19, 2020 at 11:29 AM Anders Hartvoll Ruud wrote: > Yes, there's css/selectors/is-where-error-recovery.tentative.html > > (.tentative tag to be dropped momentarily). > > On Sat, Oct 17, 2020 at 10:17 AM Antti Koivisto wrote: > >> Seems like a

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Andy Estes
Hi Sam, > On Oct 18, 2020, at 11:01, Sam Weinig wrote: > > One direct benefit of moving away from DerivedSources.make would likely be (I > say likely, as the details of how it works out are far from certain in my > mind) removing at least one place that a IDL file needs to be listed as we >

Re: [webkit-dev] in WebKit?

2020-10-20 Thread Anders Hartvoll Ruud
Nice, that's very quick, thanks Antti! On Tue, Oct 20, 2020 at 7:25 PM Antti Koivisto wrote: > I landed the updated behavior. > > > antti > > On Mon, Oct 19, 2020 at 11:29 AM Anders Hartvoll Ruud < > andr...@chromium.org> wrote: > >> Yes, there's

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Sam Weinig
> On Oct 20, 2020, at 3:36 PM, Darin Adler wrote: > >> On Oct 20, 2020, at 3:09 PM, Sam Weinig wrote: >> >> For the Platform.h issue, I think we could probably engineer things in the >> short term to have a script phase that produces a Defines.txt that the other >> script phases and build

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Sam Weinig
> On Oct 20, 2020, at 2:25 PM, Keith Rollin wrote: > >> On Oct 20, 2020, at 10:51, Andy Estes wrote: >> >>> On Oct 18, 2020, at 11:01, Sam Weinig wrote: >>> >>> One direct benefit of moving away from DerivedSources.make would likely be >>> (I say likely, as the details of how it works out

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Darin Adler
> On Oct 20, 2020, at 3:09 PM, Sam Weinig wrote: > > For the Platform.h issue, I think we could probably engineer things in the > short term to have a script phase that produces a Defines.txt that the other > script phases and build rules depend on. We definitely can, and it’s simpler than

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Darin Adler
> On Oct 20, 2020, at 4:08 PM, Sam Weinig wrote: > > For the ones conditionalizing adding to ADDITIONAL_BINDING_IDLS, those IDLs > should just have the appropriate Conditional=* extended attribute added, then > they can be included unconditionally in the makefile. > > For the ones

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Keith Rollin
> On Oct 20, 2020, at 10:51, Andy Estes wrote: > >> On Oct 18, 2020, at 11:01, Sam Weinig wrote: >> >> One direct benefit of moving away from DerivedSources.make would likely be >> (I say likely, as the details of how it works out are far from certain in my >> mind) removing at least one