> On Oct 20, 2020, at 3:09 PM, Sam Weinig <wei...@apple.com> wrote: > > For the Platform.h issue, I think we could probably engineer things in the > short term to have a script phase that produces a Defines.txt that the other > script phases and build rules depend on.
We definitely can, and it’s simpler than how we do it now. I have a patch that does this for the makefile partly done and set aside. My approach was to revise each script, one at a time, to take a file with the defines rather than requiring they be passed on the command line. It doesn’t work for the parts of the makefile itself that depend directly on checking the defines (grep for findstring.*FEATURE_AND_PLATFORM_DEFINES to see those). — Darin _______________________________________________ webkit-dev mailing list email@example.com https://lists.webkit.org/mailman/listinfo/webkit-dev