[webkit-dev] Running WebGL layout tests

2009-11-10 Thread Kenneth Russell
Hi, Trying to run the WebGL layout tests in LayoutTests/fast/canvas/webgl. Here's the command line I'm using: run-webkit-tests --debug LayoutTests/fast/canvas/webgl/[test name.html] (I built WebKit --debug.) All of the tests fail while attempting to fetch the 3D context. (TypeError: Result of

Re: [webkit-dev] Running WebGL layout tests

2009-11-11 Thread Kenneth Russell
On Wed, Nov 11, 2009 at 7:31 AM, Chris Marrin cmar...@apple.com wrote: On Nov 3, 2009, at 12:35 PM, Kenneth Russell wrote: Hi, Trying to run the WebGL layout tests in LayoutTests/fast/canvas/webgl. Here's the command line I'm using: run-webkit-tests --debug LayoutTests/fast/canvas/webgl

Re: [webkit-dev] Proposing style guide change regarding braces on conditional arms

2009-12-03 Thread Kenneth Russell
On Wed, Dec 2, 2009 at 11:35 PM, Maciej Stachowiak m...@apple.com wrote: I used to dislike everything about this rule; my original preference before we codified our style guidelines was to always put braces around the body of a control statement, even if it is only one line. Over time, I've

[webkit-dev] Commit queue blocked because of failing tests

2010-02-24 Thread Kenneth Russell
Adam Barth pointed out that the commit queue has been blocked for about 20 hours. Looking at the reason why: editing/undo/undo-deleteWord.html - failed editing/undo/undo-iframe-location-change.html - failed If you have made changes in this area recently, could you please fix these test failures?

Re: [webkit-dev] Commit queue blocked because of failing tests

2010-02-24 Thread Kenneth Russell
On Wed, Feb 24, 2010 at 12:02 PM, Alexey Proskuryakov a...@webkit.org wrote: On 24.02.2010, at 11:47, David Levin wrote: Actually, it doesn't appear to be do to recent changes in this area. They started failing after r55177 (http://build.webkit.org/waterfall?last_time=1266975298), but that

Re: [webkit-dev] Commit queue blocked because of failing tests

2010-02-24 Thread Kenneth Russell
the relevant person. On Wed, Feb 24, 2010 at 3:41 PM, Kenneth Russell k...@google.com wrote: On Wed, Feb 24, 2010 at 12:02 PM, Alexey Proskuryakov a...@webkit.org wrote: On 24.02.2010, at 11:47, David Levin wrote: Actually, it doesn't appear to be do to recent changes in this area

Re: [webkit-dev] Commit queue blocked because of failing tests

2010-02-24 Thread Kenneth Russell
would be good to have this fixed. If you'd like to help move this along, you can go to http://build.webkit.org/waterfall and find which patch caused the test to start failing. Then ping the relevant person. On Wed, Feb 24, 2010 at 3:41 PM, Kenneth Russell k...@google.com wrote: On Wed, Feb 24

[webkit-dev] Crashes during testing

2010-02-25 Thread Kenneth Russell
A change committed some time since yesterday evening has introduced many crashes in JSC's GC during testing. A representative stack trace is attached. If you have made changes in this area recently, can you please look into this? Thanks, -Ken Thread 0 Crashed: Dispatch queue:

Re: [webkit-dev] Crashes during testing

2010-02-25 Thread Kenneth Russell
OK, thanks, that appears to have fixed it. How about that commit queue? Would have caught the crashes before they were checked in. -Ken On Thu, Feb 25, 2010 at 2:53 PM, Oliver Hunt oli...@apple.com wrote: Update to r55258 or later :D --Oliver On Feb 25, 2010, at 2:46 PM, Kenneth Russell

[webkit-dev] Failing tests blocking commit queue

2010-03-11 Thread Kenneth Russell
Sorry to complain without going in and just fixing the issue, but it looks like the commit queue has been blocked for roughly 24 hours due to tests failing or timing out. A quick look points to these tests; if you've made changes in these areas recently, could you please take a look?

[webkit-dev] WebGL test breakage on build bots

2010-03-16 Thread Kenneth Russell
Earlier today I landed https://bugs.webkit.org/show_bug.cgi?id=33416 by hand (because the commit queue was blocked), and unfortunately this broke some of the WebGL layout tests on the bots. These tests are passing locally, so the best guess I can make is that the hardware or OpenGL versions on

Re: [webkit-dev] WebGL test breakage on build bots

2010-03-16 Thread Kenneth Russell
On Tue, Mar 16, 2010 at 1:56 PM, Maciej Stachowiak m...@apple.com wrote: On Mar 16, 2010, at 1:45 PM, Kenneth Russell wrote: Earlier today I landed https://bugs.webkit.org/show_bug.cgi?id=33416 by hand (because the commit queue was blocked), and unfortunately this broke some of the WebGL

Re: [webkit-dev] WebGL test breakage on build bots

2010-03-16 Thread Kenneth Russell
On Tue, Mar 16, 2010 at 2:06 PM, Kenneth Russell k...@google.com wrote: On Tue, Mar 16, 2010 at 1:56 PM, Maciej Stachowiak m...@apple.com wrote: On Mar 16, 2010, at 1:45 PM, Kenneth Russell wrote: Earlier today I landed https://bugs.webkit.org/show_bug.cgi?id=33416 by hand (because

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Kenneth Russell
On Wed, Mar 17, 2010 at 12:44 AM, Maciej Stachowiak m...@apple.com wrote: On Mar 17, 2010, at 12:02 AM, Adam Barth wrote: Manual investigation seems to implicate http://trac.webkit.org/changeset/56074 for at least some of the brokenness in SnowLeopard Intel Release (Tests).  There's a patch

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Kenneth Russell
On Wed, Mar 17, 2010 at 2:16 AM, Maciej Stachowiak m...@apple.com wrote: On Mar 17, 2010, at 1:49 AM, Kenneth Russell wrote: On Wed, Mar 17, 2010 at 12:44 AM, Maciej Stachowiak m...@apple.com wrote: On Mar 17, 2010, at 12:02 AM, Adam Barth wrote: Manual investigation seems to implicate

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Kenneth Russell
On Wed, Mar 17, 2010 at 2:52 AM, Maciej Stachowiak m...@apple.com wrote: On Mar 17, 2010, at 2:31 AM, Kenneth Russell wrote: Our best current plan is more widespread testing. We will file a Radar bug as soon as we have more information about the nature of the failure -- by virtue of working

Re: [webkit-dev] Overloads support in V8 JSC

2010-04-12 Thread Kenneth Russell
On Mon, Apr 12, 2010 at 11:13 AM, Yaar Schnitman y...@chromium.org wrote: Hi, I'm adding method overloading support to the V8 and JSC bindings generators. A significant portion of custom bindings are needed since these generators don't support re-declaration of functions with different sets of

Re: [webkit-dev] webkit-patch and SVN

2010-04-14 Thread Kenneth Russell
On Wed, Apr 14, 2010 at 2:13 PM, Eric Seidel e...@webkit.org wrote: Anders brought to my attention this afternoon that webkit-patch currently does all SVN operations from the root directory instead of being current-directory aware.  That behavior matches how Git operates, but does not need to

Re: [webkit-dev] WebKit-EFL finally merged, pay attention to CMake build system!

2010-05-17 Thread Kenneth Russell
On Sat, May 15, 2010 at 9:14 AM, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: Hi all, I'm glad to say that WebKit-EFL was finally merged as the last but definitely bit, the build system, was merged into tree today. Many, many thanks to all the friends that helped with this painful

Re: [webkit-dev] js binding: function argument type checking

2010-08-12 Thread Kenneth Russell
For what it's worth, I think this change should be made for all of the DOM bindings, not just those for WebGL. The IDL code generators' support for overloaded methods already generates TypeError when an incoming argument doesn't implement any of the interfaces required by the overloaded variants.

Re: [webkit-dev] Accelerated 2D Tesselation Implementation

2010-08-27 Thread Kenneth Russell
On Fri, Aug 27, 2010 at 10:18 AM, Chris Marrin cmar...@apple.com wrote: Hi Ken, It would help me, and I think many others, if we could have a discussion of how exactly your tessellation logic works and what it is intended to do. For instance, is the algorithm you're using based on Loop-Blinn?

Re: [webkit-dev] Accelerated 2D Tesselation Implementation

2010-08-27 Thread Kenneth Russell
On Fri, Aug 27, 2010 at 4:21 PM, Kenneth Russell k...@google.com wrote: On Fri, Aug 27, 2010 at 10:18 AM, Chris Marrin cmar...@apple.com wrote: Hi Ken, It would help me, and I think many others, if we could have a discussion of how exactly your tessellation logic works and what it is intended

Re: [webkit-dev] Accelerated 2D Tesselation Implementation

2010-08-27 Thread Kenneth Russell
On Fri, Aug 27, 2010 at 5:10 PM, Chris Marrin cmar...@apple.com wrote: On Aug 27, 2010, at 4:21 PM, Kenneth Russell wrote: On Fri, Aug 27, 2010 at 10:18 AM, Chris Marrin cmar...@apple.com wrote: Hi Ken, It would help me, and I think many others, if we could have a discussion of how exactly

Re: [webkit-dev] Accelerated 2D Tesselation Implementation

2010-08-30 Thread Kenneth Russell
On Mon, Aug 30, 2010 at 1:10 PM, Chris Marrin cmar...@apple.com wrote: On Aug 30, 2010, at 11:56 AM, Kenneth Russell wrote: On Sat, Aug 28, 2010 at 12:36 PM, Darin Fisher da...@chromium.org wrote: On Sat, Aug 28, 2010 at 11:32 AM, Adam Barth aba...@webkit.org wrote: On Sat, Aug 28, 2010

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Kenneth Russell
On Tue, Aug 31, 2010 at 11:05 AM, David Hyatt hy...@apple.com wrote: On Aug 31, 2010, at 10:36 AM, Chris Marrin wrote: Or should we get rid of Vector3, added the functionality it needs to FloatPoint3D and use that? Ken Russell already has plans to do add the functions to FloatPoint3D, so I

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Kenneth Russell
On Tue, Aug 31, 2010 at 3:39 PM, Chris Marrin cmar...@apple.com wrote: On Aug 31, 2010, at 3:25 PM, Maciej Stachowiak wrote: On Aug 31, 2010, at 2:06 PM, Chris Marrin wrote: On Aug 31, 2010, at 11:48 AM, Kenneth Russell wrote: On Tue, Aug 31, 2010 at 11:05 AM, David Hyatt hy...@apple.com

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Kenneth Russell
On Tue, Aug 31, 2010 at 4:22 PM, Maciej Stachowiak m...@apple.com wrote: On Aug 31, 2010, at 3:59 PM, Chris Marrin wrote: On Aug 31, 2010, at 3:43 PM, Kenneth Russell wrote: On Tue, Aug 31, 2010 at 3:39 PM, Chris Marrin cmar...@apple.com wrote: On Aug 31, 2010, at 3:25 PM, Maciej

Re: [webkit-dev] Arena is crufty?

2010-09-01 Thread Kenneth Russell
On Wed, Sep 1, 2010 at 5:08 PM, Chris Marrin cmar...@apple.com wrote: On Sep 1, 2010, at 4:39 PM, Maciej Stachowiak wrote: On Sep 1, 2010, at 4:20 PM, Chris Marrin wrote: Ken's PODRedBlackTree patch has made me go back and take a closer look at WebKit's Arena class. Turns out it's not a

Re: [webkit-dev] Arena is crufty?

2010-09-01 Thread Kenneth Russell
I would be happy to not add another Arena client, but the primary reason I need an arena is not just for performance but to avoid having to keep track of all of the objects I need to delete. Is there any consensus yet on how to proceed with https://bugs.webkit.org/show_bug.cgi?id=45059 ? I'm

Re: [webkit-dev] Arena is crufty?

2010-09-02 Thread Kenneth Russell
supposed to be _really_ optimized for exactly this use?  It seems like a good match--unless you have major issues with cycles...which might be the issue? J On Thu, Sep 2, 2010 at 3:20 AM, Kenneth Russell k...@google.com wrote: I would be happy to not add another Arena client, but the primary

Re: [webkit-dev] Arena is crufty?

2010-09-02 Thread Kenneth Russell
On Thu, Sep 2, 2010 at 8:51 AM, Chris Marrin cmar...@apple.com wrote: On Sep 1, 2010, at 7:20 PM, Kenneth Russell wrote: I would be happy to not add another Arena client, but the primary reason I need an arena is not just for performance but to avoid having to keep track of all

Re: [webkit-dev] Arena is crufty?

2010-09-02 Thread Kenneth Russell
On Thu, Sep 2, 2010 at 9:59 AM, Chris Marrin cmar...@apple.com wrote: On Sep 2, 2010, at 9:41 AM, Kenneth Russell wrote: On Thu, Sep 2, 2010 at 8:51 AM, Chris Marrin cmar...@apple.com wrote: On Sep 1, 2010, at 7:20 PM, Kenneth Russell wrote: I would be happy to not add another Arena client

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-28 Thread Kenneth Russell
On Tue, Sep 28, 2010 at 9:45 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 28, 2010, at 7:15 AM, Chris Marrin wrote: On Sep 27, 2010, at 6:37 PM, Maciej Stachowiak wrote: On Sep 27, 2010, at 3:19 PM, Michael Nordman wrote: Webkit's XHR currently does not keep two copies of the data

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-29 Thread Kenneth Russell
On Tue, Sep 28, 2010 at 11:26 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 28, 2010, at 11:05 AM, Kenneth Russell wrote: On Tue, Sep 28, 2010 at 9:45 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 28, 2010, at 7:15 AM, Chris Marrin wrote: On Sep 27, 2010, at 6:37 PM, Maciej

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-30 Thread Kenneth Russell
On Thu, Sep 30, 2010 at 7:09 AM, Chris Marrin cmar...@apple.com wrote: On Sep 29, 2010, at 6:34 PM, Maciej Stachowiak wrote: ...The idea is that when an ArrayBuffer is sent via postMessage, it is atomically closed on this side; its publicly visible length goes to 0, as do the lengths of

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-30 Thread Kenneth Russell
On Thu, Sep 30, 2010 at 11:51 AM, Chris Marrin cmar...@apple.com wrote: On Sep 30, 2010, at 10:46 AM, Kenneth Russell wrote: ... Sure, transfer semantics avoid shared mutable state, though it would be inconsistent with most other pure data types. But what if you have some data that doesn't

Re: [webkit-dev] ArrayBuffer supprot

2010-10-12 Thread Kenneth Russell
On Fri, Oct 8, 2010 at 2:46 PM, Jian Li jia...@chromium.org wrote: Hi, I am looking into hooking up ArrayBuffer support in FileReader and BlobBuilder. It seems that most of the typed array types (ArrayBuffer, ArrayBufferView, Uint8Array, and etc) have already been implemented in WebKit,

[webkit-dev] webkit-patch land on Windows and line endings in ChangeLogs

2010-10-22 Thread Kenneth Russell
Does anyone use webkit-patch land on Windows under Cygwin? While checking in some test expectations recently I tried to use it, but found that it wouldn't parse the ChangeLogs successfully. The problem appears to be that WebKit coding practice is to not set svn:eol-style on checked in text files,

Re: [webkit-dev] ArrayBuffer supprot

2010-11-15 Thread Kenneth Russell
this to make it work. How do you think? Thanks. On Wed, Oct 13, 2010 at 8:37 AM, Jian Li jia...@chromium.org wrote: On Tue, Oct 12, 2010 at 2:17 PM, Kenneth Russell k...@google.com wrote: On Fri, Oct 8, 2010 at 2:46 PM, Jian Li jia...@chromium.org wrote: Hi, I am looking into hooking up ArrayBuffer

Re: [webkit-dev] We released Firebug 1.6.0 with console.table(), time for Web Inspector?

2010-12-08 Thread Kenneth Russell
On Wed, Dec 8, 2010 at 4:06 PM, Steven Roussey srous...@gmail.com wrote: Oops, I didn't mean for that to be so short! This is probably my first time posting to this list (ok, now second), so let me know what I might be doing correctly, or incorrectly. I want to contribute to webkit and web

Re: [webkit-dev] We released Firebug 1.6.0 with console.table(), time for Web Inspector?

2010-12-08 Thread Kenneth Russell
On Wed, Dec 8, 2010 at 4:56 PM, Steven Roussey srous...@gmail.com wrote: Hi Ken! I would suggest manually finding qualified reviewers for the patch, I think it stalled since it was reviewed, but it needed some sort of API discussion on this list. At this point, such discussion is too late

[webkit-dev] Error checking out WebKit

2010-12-13 Thread Kenneth Russell
Hi all, Trying to check out a fresh WebKit tree on Windows using svn 1.6.6 (also tried 1.6.1), I'm consistently getting the following error: svn: PROPFIND of '/repository/webkit/!svn/bc/19963/trunk/LayoutTests/fast/xpath/4XPath/Core/test.js': 207 Multi-Status (http://svn.webkit.org) Looking at

Re: [webkit-dev] Renaming directories

2010-12-22 Thread Kenneth Russell
On Tue, Dec 21, 2010 at 11:40 PM, Adam Barth aba...@webkit.org wrote: On Tue, Dec 21, 2010 at 11:30 PM, Darin Adler da...@apple.com wrote: On Dec 21, 2010, at 11:20 PM, Adam Barth wrote: Looking through my working copy, there are a couple of things that aren't obvious to me where they would

Re: [webkit-dev] Renaming directories

2010-12-22 Thread Kenneth Russell
On Wed, Dec 22, 2010 at 10:26 AM, Mark Rowe mr...@apple.com wrote: On 2010-12-22, at 09:37, Kenneth Russell wrote: On Tue, Dec 21, 2010 at 11:40 PM, Adam Barth aba...@webkit.org wrote: On Tue, Dec 21, 2010 at 11:30 PM, Darin Adler da...@apple.com wrote: On Dec 21, 2010, at 11:20 PM, Adam

Re: [webkit-dev] Renaming directories

2010-12-22 Thread Kenneth Russell
On Wed, Dec 22, 2010 at 10:36 AM, Mark Rowe mr...@apple.com wrote: On 2010-12-22, at 10:36, Kenneth Russell wrote: On Wed, Dec 22, 2010 at 10:26 AM, Mark Rowe mr...@apple.com wrote: On 2010-12-22, at 09:37, Kenneth Russell wrote: On Tue, Dec 21, 2010 at 11:40 PM, Adam Barth aba

Re: [webkit-dev] Renaming directories

2010-12-22 Thread Kenneth Russell
On Wed, Dec 22, 2010 at 10:53 AM, Mark Rowe mr...@apple.com wrote: On 2010-12-22, at 10:45, Kenneth Russell wrote: I see. The GLU tessellator was integrated because it was the only viable option for helping implement GPU-accelerated path rendering in WebKit. (This work is still in early

Re: [webkit-dev] Renaming directories

2010-12-22 Thread Kenneth Russell
://oss.sgi.com/projects/FreeB/ , but it explains that the license is intended to mirror the X11 license exactly and why they revised the previous version of their license rather than switching licenses. -Ken - Mark On Wed, Dec 22, 2010 at 1:05 PM, Kenneth Russell k...@google.com wrote: On Wed, Dec

Re: [webkit-dev] code review tool changes

2011-02-01 Thread Kenneth Russell
On Tue, Feb 1, 2011 at 5:09 PM, Ojan Vafai o...@chromium.org wrote: There's been a slew of changes to the code review tool. It's probably a good time to send a summary now that I don't intend to add significant new features. -Side-by-side diffs: You can view the entire diff or individual files

Re: [webkit-dev] Sharing the OpenGL GraphicsContext3D implementation

2011-02-23 Thread Kenneth Russell
On Wed, Feb 23, 2011 at 12:40 PM, Zan Dobersek zandober...@gmail.com wrote: Forgot to reply to all, sorry for the mess, webkit-dev :/ On Wed, Feb 23, 2011 at 7:15 PM, Mo, Zhenyao zhen...@gmail.com wrote: You could just create a new Extension3DOpenGLGtk class that inherits from

Re: [webkit-dev] test runtimes treemap

2011-03-18 Thread Kenneth Russell
On Thu, Mar 17, 2011 at 11:50 PM, Ojan Vafai o...@chromium.org wrote: You can now see the test runtimes in treemap form for the lastest run of some of the layout test bots*. http://test-results.appspot.com/dashboards/treemap.html#testType=LayoutTests Also, the URLs are permalinked, so you can

Re: [webkit-dev] Cleaning up directories in WebCore

2011-11-18 Thread Kenneth Russell
On Fri, Nov 18, 2011 at 1:51 AM, Adam Barth aba...@webkit.org wrote: I've been looking for ways to improve the hackability of WebCore, and one thing that's been bothering me is the organization of our files. It seems like we're due for a bit of fall cleaning for directories. We've talked about

[webkit-dev] sheriffbot needs a kick

2011-12-15 Thread Kenneth Russell
The sheriffbot has been failing to handle rollout commands for a few days now. The failures reported are: sheriffbot: Exception executing command: Failed to run ['Tools/Scripts/update-webkit'] exit_code: 9 Looks to me like the workspace on the machine running sheriffbot needs to be blown away.

Re: [webkit-dev] sheriffbot needs a kick

2011-12-15 Thread Kenneth Russell
. Adam On Thu, Dec 15, 2011 at 4:26 PM, Adam Barth aba...@webkit.org wrote: I'll take a look.  Sorry for the disruption. Adam On Thu, Dec 15, 2011 at 4:24 PM, Kenneth Russell k...@google.com wrote: The sheriffbot has been failing to handle rollout commands for a few days now

[webkit-dev] Adding derived sources in Xcode 4.2

2012-01-17 Thread Kenneth Russell
WebKit developers, How does one perform the instructions on http://www.webkit.org/building/debug.html using Xcode 4.2? I've tried a couple of things locally but am pretty sure I've got it wrong. (After running build-webkit and changing the Build Products Path and Intermediate Build Files Path for

[webkit-dev] Style bot needs kick

2012-01-31 Thread Kenneth Russell
Looks like the workspace on the style bot is messed up. Example failure: http://queues.webkit.org/results/11388080 Could someone please take a look? Thanks, -Ken ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Blob will support ArrayBufferView instead of ArrayBuffer for Constructor Parameters

2012-06-05 Thread Kenneth Russell
I think that WebKit should continue to support the old constructor for a brief period of time, but warn about its use. I've commented on the patch indicating this. Li Yin, if you implement this, please file a follow-on bug about removing support for the old constructor. The new bug should depend

Re: [webkit-dev] New web-facing canvas feature: opaque attribute

2013-03-14 Thread Kenneth Russell
On Thu, Mar 14, 2013 at 1:55 PM, Dean Jackson d...@apple.com wrote: On 15/03/2013, at 7:45 AM, Kenneth Russell k...@google.com wrote: On Thu, Mar 14, 2013 at 1:38 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 14, 2013 at 12:55 PM, Dean Jackson d...@apple.com wrote: On 15/03/2013

Re: [webkit-dev] New web-facing canvas feature: opaque attribute

2013-03-15 Thread Kenneth Russell
On Fri, Mar 15, 2013 at 1:35 AM, Maciej Stachowiak m...@apple.com wrote: On Mar 15, 2013, at 1:19 AM, Gregg Tavares g...@google.com wrote: I don't understand the opposition to alpha You set colors in Canvas2d with rgb or rgba. That 'a' in rgba stands for alpha. You can set a global alpha

Re: [webkit-dev] Blob will support ArrayBufferView instead of ArrayBuffer for Constructor Parameters

2013-03-20 Thread Kenneth Russell
a new bug about removing support of ArrayBuffer. https://bugs.webkit.org/show_bug.cgi?id=88389 Thanks for your good comments. -- Li Yin -Original Message- From: Kenneth Russell [mailto:k...@google.com] Sent: Wednesday, June 06, 2012 5:21 AM To: Takashi Toyoshima Cc: Yin, Li