Hi everybody,
I’d like to verify whether there’s any specific reason that the
LayoutTests/sputnik directory continues to exist.
According to Wikipedia, “All current Sputnik tests have been incorporated into
ECMA's Test262 test suite.” (Here “current” evidently means June 2011.) And
indeed,
In that case, I'll point out that C++ Core Guidelines has a rule "Virtual
functions should specify exactly one of virtual, override, or final".
(http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-override)
Their tl;dr:
"
• virtual means exactly and only “this is a new virtual
On 12/5/18, 8:28 AM, "webkit-dev on behalf of Michael Catanzaro"
wrote:
On Tue, Dec 4, 2018 at 7:47 PM, Alexey Proskuryakov
wrote:
> Anyone can tag comments to make them invisible
How?
You can click Tag and enter "spam". (There's also the "obsolete" tag for
hiding,
APITests/ would seem like an improvement to me...although given that this would
be the seventh *Tests/ directly, it also makes me wonder if those should all be
moved under a top-level Tests/ directory? __
(Either way, I'd be happy to help with Xcode rearranging if needed, at least to
the point
That said, I would expect specifically the Tools/TestWebKitAPI/Tests
subdirectory to be the thing moved to APITests/, since the code that actually
runs the tests is as much a “tool” as DRT, WKTR, or various other test-running
scripts under Tools/Scripts are.
Ross
From: Ryosuke Niwa
Date:
Yeah, I think it's important to clarify that nobody is "using
non-Unified-Source building for their development", at least to my knowledge.
Being broken by the shifting sands of unified sources is an everybody problem
(or at the very least an "everybody that builds via CMake problem", which is
6 matches
Mail list logo
