[webkit-dev] Can we jettison Sputnik?

2019-01-15 Thread Ross . Kirsling
Hi everybody, I’d like to verify whether there’s any specific reason that the LayoutTests/sputnik directory continues to exist. According to Wikipedia, “All current Sputnik tests have been incorporated into ECMA's Test262 test suite.” (Here “current” evidently means June 2011.) And indeed,

Re: [webkit-dev] 'final' class specifier and 'final' method specifier

2018-12-19 Thread Ross . Kirsling
In that case, I'll point out that C++ Core Guidelines has a rule "Virtual functions should specify exactly one of virtual, override, or final". (http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-override) Their tl;dr: " • virtual means exactly and only “this is a new virtual

Re: [webkit-dev] Lots of spam on Bugzilla

2018-12-05 Thread Ross . Kirsling
On 12/5/18, 8:28 AM, "webkit-dev on behalf of Michael Catanzaro" wrote: On Tue, Dec 4, 2018 at 7:47 PM, Alexey Proskuryakov wrote: > Anyone can tag comments to make them invisible How? You can click Tag and enter "spam". (There's also the "obsolete" tag for hiding,

Re: [webkit-dev] Tools/TestWebKitAPI

2019-02-05 Thread Ross . Kirsling
APITests/ would seem like an improvement to me...although given that this would be the seventh *Tests/ directly, it also makes me wonder if those should all be moved under a top-level Tests/ directory? __ (Either way, I'd be happy to help with Xcode rearranging if needed, at least to the point

Re: [webkit-dev] Tools/TestWebKitAPI

2019-02-05 Thread Ross . Kirsling
That said, I would expect specifically the Tools/TestWebKitAPI/Tests subdirectory to be the thing moved to APITests/, since the code that actually runs the tests is as much a “tool” as DRT, WKTR, or various other test-running scripts under Tools/Scripts are. Ross From: Ryosuke Niwa Date: