On Mon, May 3 2021 at 12:21:57 PM -0700, Sam Weinig via webkit-dev
wrote:
So, does anyone have any recent measurements of clean build times
with and without unified sources enabled? If so, what is the current
delta?
That would be painful to check, because you would first have to fix all
the
Hi,
I am curious about the current state of our knowledge about the various
benefits we are gaining from Unified Source. I think it is important to
reevaluate it from time to time to ensure we are still getting the benefits we
want (as there are some not so insignificant downsides). I know
On Fri, Apr 30, 2021 at 10:16 AM Alexey Proskuryakov via webkit-dev <
webkit-dev@lists.webkit.org> wrote:
> These points from my yesterday email remain without responses:
>
> 1. Cannot have an EWS without corresponding post-commit queue.
>
Yeah, we should first add a bot.
2. It doesn't appear
On Thu, Apr 29, 2021 at 9:18 PM Darin Adler via webkit-dev <
webkit-dev@lists.webkit.org> wrote:
> > On Apr 29, 2021, at 9:06 PM, Tim Horton via webkit-dev <
> webkit-dev@lists.webkit.org> wrote:
> >
> > it is definitely highly annoying
>
> It’s possible that where my thinking differs from others
This seems to be a discussion around “when is doing things lazily valuable.” If
the work will always have to be done eventually, then doing it lazily is worse
than doing it up front. But of the work has a significant chance of never being
needed to be done, then doing it lazily is better.
I
(Re-sending from correct address)
These points from my yesterday email remain without responses:
1. Cannot have an EWS without corresponding post-commit queue.
2. It doesn't appear like we looked into whether there are any ways to mitigate
the problem other that this most costly one.
- Alexey
OK. I acknowledge my view on this is different from the others commenting here,
perhaps because of different ideas about what is hard and requires expertise. I
won’t stand in the way of changes you want to make. You know my view now.
— Darin
___
On 30/04/2021 06:17, Darin Adler via webkit-dev wrote:
>> On Apr 29, 2021, at 9:06 PM, Tim Horton via webkit-dev
>> wrote:
>>
>> it is definitely highly annoying
>
> It’s possible that where my thinking differs from others on this is that I
> don’t think shifting annoying work from one set of
> On Apr 29, 2021, at 9:06 PM, Tim Horton via webkit-dev
> wrote:
>
> it is definitely highly annoying
It’s possible that where my thinking differs from others on this is that I
don’t think shifting annoying work from one set of commits (the ones adding a
new file) to a different set (the
> On Apr 29, 2021, at 9:02 PM, Darin Adler wrote:
>
>> On Apr 29, 2021, at 9:01 PM, Tim Horton wrote:
>>
>> This is a huge problem for people on the Apple platforms using the Xcode
>> projects. Nearly every time someone adds a file they have to add random
>> headers to unrelated code.
>
>
> On Apr 29, 2021, at 7:15 PM, Darin Adler via webkit-dev
> wrote:
>
>> On Apr 29, 2021, at 12:04 PM, Ross Kirsling via webkit-dev
>> wrote:
>>
>> Yeah, I think it's important to clarify that nobody is "using
>> non-Unified-Source building for their development", at least to my
>>
> On Apr 29, 2021, at 9:01 PM, Tim Horton wrote:
>
> This is a huge problem for people on the Apple platforms using the Xcode
> projects. Nearly every time someone adds a file they have to add random
> headers to unrelated code.
OK, sorry, I must be out of touch with the rest of you about how
> On Apr 29, 2021, at 12:04 PM, Ross Kirsling via webkit-dev
> wrote:
>
> Yeah, I think it's important to clarify that nobody is "using
> non-Unified-Source building for their development", at least to my knowledge.
> Being broken by the shifting sands of unified sources is an everybody
On 2021-04-29 20:07, BJ Burg wrote:
> Given that there is some disagreement as to whether this is even a
> problem at all, perhaps we could try it out for a while. Diego, do you
> have the resources to set up an EWS bot in this configuration?
>
Yes, we have two workers ready for this new EWS
_
> From: Alex Christensen via webkit-dev
> Sent: Thursday, April 29, 2021 11:03 AM
> To: Darin Adler
> Cc: webkit-dev@lists.webkit.org
> Subject: Re: [webkit-dev] New EWS Non-Unified builder
>
> I don’t see the goal as “keep non-Unified-Source building” but r
an try and spare some cycles helping out with CMake Mac to get the build
in shape :)
Cheers,
—Adrian
> -Original Message-
> From: Alex Christensen via webkit-dev
> Sent: Thursday, April 29, 2021 8:16 AM
> To: dpino
> Cc: webkit-dev@lists.webkit.org
> Subject: Re: [webkit-
problem", which is
ultimately an everybody problem).
Ross
From: Alex Christensen via webkit-dev
Sent: Thursday, April 29, 2021 11:03 AM
To: Darin Adler
Cc: webkit-dev@lists.webkit.org
Subject: Re: [webkit-dev] New EWS Non-Unified builder
I don’t see the goal
I'm in favor of a non-Unified EWS builder. It seems it would largely prevent
the current situation where I have to add random headers to make my patch
build, usually after the patch has been reviewed and revised. This "surprise,
someone forgot a header" situation has no effect on our production
I don’t see the goal as “keep non-Unified-Source building” but rather “prevent
unrelated build fixes when we add another file later”. Right now when we add a
new file we often have to sprinkle includes, declarations, and other build
fixes in files unrelated to the current change. If we had a
Given the issue is that there are people that are using non-Unified-Source
building for their development, the best fix is to add post-commit and EWS
builders for one of those platforms. I do not support the idea of adding an
additional builder just to “keep non-Unified-Source building” if no
Hi,
Do we have a post-commit non-unified builder? Starting with EWS wouldn't seem
like a workable plan to me, as breakages would creep in anyway, and it's really
hard to notice and isolate those from EWS results alone.
Giving all WebKit developers the responsibility to support more build
: [webkit-dev] New EWS Non-Unified builder
I’d be excited to have this. Those build failures have been bothering me ever
since we started using unified builds. We would have a way to see more
problems in our code that are currently hidden.
> On Apr 28, 2021, at 11:45 PM, dpino via webkit-dev
>
I’d be excited to have this. Those build failures have been bothering me ever
since we started using unified builds. We would have a way to see more
problems in our code that are currently hidden.
> On Apr 28, 2021, at 11:45 PM, dpino via webkit-dev
> wrote:
>
> Hi everyone,
>
> In Igalia
23 matches
Mail list logo
