Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

> 17 нояб. 2017 г., в 23:02, youenn fablet написал(а): > > Tests are available at https://w3c-test.org which > makes it easy to share through any tool supporting hyperlinks. > A webarchive can also be made so that it is easy to share and probably edit

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

On 28/11/2017 16:24, Philip Jägenstedt wrote: > > To do the upstreaming from WebKit first would get around this problem, > and is something I could see us doing. If a Chromium developer > upstreamed tests from WebKit and got review from a WebKit reviewer, I > think we would rubberstamp the

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

On Tue, Nov 28, 2017 at 3:37 PM Ryosuke Niwa wrote: > On Mon, Nov 27, 2017 at 5:58 PM, Philip Jägenstedt > wrote: > >> (From Nov 24, I used the wrong email, resending for the archives.) >> >> On Sat, Nov 18, 2017 at 8:02 AM, youenn fablet

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

On Mon, Nov 27, 2017 at 5:58 PM, Philip Jägenstedt wrote: > (From Nov 24, I used the wrong email, resending for the archives.) > > On Sat, Nov 18, 2017 at 8:02 AM, youenn fablet wrote: > > Thanks for taking the time to share this additional information. >

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

(From Nov 24, I used the wrong email, resending for the archives.) On Sat, Nov 18, 2017 at 8:02 AM, youenn fablet wrote: > Thanks for taking the time to share this additional information. > I think this is helpful to make progress. > Please see inline for some more comments

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

On Fri, Nov 24, 2017 at 9:09 AM, Frédéric WANG wrote: > Right, running all the tests is nice. But sometimes I personally feel > guilty to have to execute everything on EWS for example to retrieve > results for macOS/iOS (when I did not have access to a mac) or to fix >

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

On 17/11/2017 17:23, Maciej Stachowiak wrote: > I should also note that pulling in the test suite won't automatically > get the bugs fixed or prioritized, or even filed in the bug tracker > necessarily.eratwerATWeRTWAerATWertwAerer Sure. However, I believe in general having more people importing

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

On Fri, Nov 17, 2017 at 5:23 PM, Maciej Stachowiak wrote: > > >> On Nov 17, 2017, at 7:53 AM, Frédéric WANG wrote: >> >> On 17/11/2017 16:26, Maciej Stachowiak wrote: >>> WebKit has a lot of tests that were regression tests for a specific >>> bug fix, not as

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

I filed https://github.com/w3c/web-platform-tests/issues/8391 for the WPT server performances issues. As of upstreaming the tests, would the following solve identified issues and keep the upstream process lightweight enough? - Meta tag each upstreamed test to identify this is an upstreamed version

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

Thanks for taking the time to share this additional information. I think this is helpful to make progress. Please see inline for some more comments related to the points you are bringing to the table. Stepping back from the WPT server specific issue, being optimistic and assuming that we are able

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

(re-sending from a correct address) > 17 нояб. 2017 г., в 9:18, youenn fablet > написал(а): > > Chris recently noticed that some heavily used files (testharness*) were > cacheable through Apache but not WPT. > This is now fixed and should improve

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

> On Nov 17, 2017, at 9:18 AM, youenn fablet wrote: > > Chris recently noticed that some heavily used files (testharness*) were > cacheable through Apache but not WPT. Wasn’t me. Alexey reported this via Description

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

>From my experience, the people behind WPT are quite responsive to WebKit community. Here are two examples: Chris recently noticed that some heavily used files (testharness*) were cacheable through Apache but not WPT. This is now fixed and should improve WPT performances. In January, was discussed

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

> On Nov 17, 2017, at 7:53 AM, Frédéric WANG wrote: > > On 17/11/2017 16:26, Maciej Stachowiak wrote: >> WebKit has a lot of tests that were regression tests for a specific >> bug fix, not as conformance tests (though they might b useful for that >> too). In such cases, the

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

Hi Danyao, I'm afraid that I don't yet have proper breakdown of this, but this is from some quick grepping in WebKit: - 3200k *-expected.html outside of LayoutTests/imported, that might work as reftests. - 60k files that aren't called *-expected.*, again outside of

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

On 17/11/2017 16:26, Maciej Stachowiak wrote: > WebKit has a lot of tests that were regression tests for a specific > bug fix, not as conformance tests (though they might b useful for that > too). In such cases, the association with the bugs.webkit.org bug is > more important than the spec URL.

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

> On Nov 17, 2017, at 7:05 AM, Frédéric WANG wrote: > > Hi Philip, > > We (at Igalia) are strong supporters of WPT tests and we've appreciated a lot > the effort made by Youenn and others to make them possible in WebKit. They > are very important for interoperability and

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

17.11.2017, 18:19, "Maciej Stachowiak" : >>  On Nov 17, 2017, at 7:15 AM, Konstantin Tokarev wrote: >> >>  16.11.2017, 20:10, "Alexey Proskuryakov" : >>>  Migrating WebKit tests seems undesirable to me, as that would make us lose >>> all

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

On Thu, Nov 16, 2017 at 11:10 AM, Alexey Proskuryakov wrote: Regression tests are taking an excessive amount of time to run for us (more than 1.5 hours in a debug build), a very large proportion of which is WPT. I do not think that the strategy of adopting WPT tests is

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

> On Nov 17, 2017, at 7:15 AM, Konstantin Tokarev wrote: > > > > 16.11.2017, 20:10, "Alexey Proskuryakov" : >> Migrating WebKit tests seems undesirable to me, as that would make us lose >> all their modification history. As mentioned before, WPT tests are

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

16.11.2017, 20:10, "Alexey Proskuryakov" : > Migrating WebKit tests seems undesirable to me, as that would make us lose > all their modification history. As mentioned before, WPT tests are inherently > getting less attention in CI support, largely because of unclear benefit

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

Hi Philip, We (at Igalia) are strong supporters of WPT tests and we've appreciated a lot the effort made by Youenn and others to make them possible in WebKit. They are very important for interoperability and make life much easier for developers working on different WebKit ports and different Web

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

Migrating WebKit tests seems undesirable to me, as that would make us lose all their modification history. As mentioned before, WPT tests are inherently getting less attention in CI support, largely because of unclear benefit when there isn't any history for why the particular test was added.

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

Hi Philip, Ali and I would be willing to help this wherever we can. It seems to us that there may be a few different classes of tests that require varying degree of effort to migrate. Do you have any estimates on how many tests fall into each category, maybe based on your analysis of Blink