Re: [webkit-dev] webkit-patch requests

2010-05-19 Thread Adam Barth
On Wed, May 19, 2010 at 10:27 AM, Darin Adler da...@apple.com wrote: Not sure where to put these. A while ago people were talking about changes needed to webkit-patch. Here are some of the basics for me for one command, webkit-patch upload. When I use webkit-patch upload to create a patch in

Re: [webkit-dev] webkit-patch requests

2010-05-19 Thread Darin Adler
On May 19, 2010, at 10:52 AM, Adam Barth wrote: Thanks for the feedback. Webkit-patch already respects the EDITOR environment variable. It should be a simple change to support the CHANGE_LOG_EDIT_APPLICATION environment variable also. The function that needs to change is:

Re: [webkit-dev] webkit-patch requests

2010-05-19 Thread Adam Barth
On Wed, May 19, 2010 at 11:04 AM, Darin Adler da...@apple.com wrote: On May 19, 2010, at 10:52 AM, Adam Barth wrote: Thanks for the feedback. Webkit-patch already respects the EDITOR environment variable. It should be a simple change to support the CHANGE_LOG_EDIT_APPLICATION environment

Re: [webkit-dev] webkit-patch requests

2010-05-19 Thread Maciej Stachowiak
On May 19, 2010, at 11:04 AM, Darin Adler wrote: On May 19, 2010, at 10:52 AM, Adam Barth wrote: Thanks for the feedback. Webkit-patch already respects the EDITOR environment variable. It should be a simple change to support the CHANGE_LOG_EDIT_APPLICATION environment variable also. The

Re: [webkit-dev] webkit-patch requests

2010-05-19 Thread Timothy Hatcher
The xed --wait is much better, since it waits for the files to be closed, not for Xcode to quit. (And quitting Xcode is pretty disruptive if you have projects open.) On May 19, 2010, at 1:08 PM, Maciej Stachowiak wrote: There’s also a tool called xed that I could probably use as an EDITOR.