Ah, we got a discussion :-)
Summarizing advantages: Aurelien sees the config file and the
more fine grained phapi logging, Andreas the console logging
and I an established design pattern.
And the basic con: That this is a big change, not an
incremental path. After reading Dave's article I
Alec leamas a écrit :
Ah, we got a discussion :-)
Yes :-)
Summarizing advantages: Aurelien sees the config file and the
more fine grained phapi logging, Andreas the console logging
and I an established design pattern.
I don't understand what you mean with console logging being an
Painful? Not really :-) As I said, earlier: you should not
apologize for doing our job. And at the moment you are taking a
code review personally, you are in deep trouble. I certainly
don't :-)
With this said, it's really hard for me to see an incremental
path leading from today's logging
Hi,
Alec leamas wrote:
With this said, it's really hard for me to see an incremental
path leading from today's logging system to something which
works along the lines I think we need. After all, it's kind of
a refactoring, and such things can't really be done in that
many steps. I
Alec leamas a écrit :
With this said, it's really hard for me to see an incremental
path leading from today's logging system to something which
works along the lines I think we need. After all, it's kind of
a refactoring, and such things can't really be done in that
many steps. I *have*
Alec leamas a écrit :
With this said, it's really hard for me to see an incremental
path leading from today's logging system to something which
works along the lines I think we need. After all, it's kind of
a refactoring, and such things can't really be done in that
many steps. I *have*
Alec leamas a écrit :
With this said, it's really hard for me to see an incremental
path leading from today's logging system to something which
works along the lines I think we need. After all, it's kind of
a refactoring, and such things can't really be done in that
many steps. I *have*
Aurélien Gâteau wrote:
I see two advantages to your work:
- It's now possible to configure the logging from a configuration file.
- You can configure phapi logging in a more fine grained way.
What I don't see is why these changes couldn't have been implemented
without rewriting everything.
