Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
On Tue, Feb 26, 2008 at 10:19:46PM +0100, Ralf Schlatterbeck wrote:
I'm getting the feeling that my whole advanced config stuff isn't
working, (the dialog *is* working but it seems the values there aren't
used by wengo) any idea if this could be the case? That would explain
that sip.chat.without.presence and sip.p2p... isn't working for me.
I've looked into the code with this suspicion in mind:
Chat without presence:
- sip.chat.without.presence name in xml file
- SIP_CHAT_WITHOUT_PRESENCE name of string in config, only used in
wengophone/src/model/config/Config.{cpp,h}
- getSipChatWhithouPresence used in Config.{cpp,h} and in main.cpp,
there it does a
setSipOptions(sip.chat.whithout.presence
(Note the additional h in whithout !)
(shouldn't that have _ instead of . ?)
- grepping through the whole tree I've found no instances beyond Config
and main where this is actually used.
Maybe this *is* missing the implementation? Should I make my earlier
patch configurable with this variable?
- Patch at the end of this mail corrects spelling:
getSipChatWhithouPresence - getSipChatWithoutPresence
sip.chat.whithout.presence - sip.chat.without.presence
without any change in functionality -- chat without presence is still
not working.
P2P:
- sip.p2p.presence name in xml file
- SIP_P2P_PRESENCE name of string in config, only used in
Config.{cpp,h}
- The name SIP_P2P_PRESENCE is also used in an environment-query in
libs/sipwrapper/src/phapi/PhApiWrapper.cpp
- getSipP2pPresence used in Config.{cpp,h} and in main.cpp,
there it does a
setSipOptions(sip.p2p_presence
(Note the mix of _ and . !)
- libs/sipwrapper/src/phapi/PhApiWrapper.cpp uses:
- sipOptions.sip_p2p_presence
- the environment-variable SIP_P2P_PRESENCE which sets
sipOptions.sip_p2p_presence
- PhApiWrapper::setSipOptions looks at an option sip.p2p_presence
and seems to set sipOptions.sip_p2p_presence accordingly
- I have tried to set environment-variable SIP_P2P_PRESENCE to 1 with no
change in functionality.
- then I've instrumented the code and it shows
sipOptions.sip_p2p_presence to be 1.
Note that this time while I had wengo running I had a pop-up that asked
me to authorize presence info for a remote (unknown) party. So there
seems some support of p2p presence working. I'll now re-test with
several clients.
Patch:
diff -r b37d3c8650e8 wengophone/src/model/config/Config.cpp
--- a/wengophone/src/model/config/Config.cppTue Feb 26 18:23:02 2008 +0100
+++ b/wengophone/src/model/config/Config.cppWed Feb 27 09:50:07 2008 +0100
@@ -530,7 +530,7 @@ bool Config::getSipP2pPresence() const {
return getBooleanKeyValue(SIP_P2P_PRESENCE);
}
-bool Config::getSipChatWhithouPresence() const {
+bool Config::getSipChatWithoutPresence() const {
return getBooleanKeyValue(SIP_CHAT_WITHOUT_PRESENCE);
}
diff -r b37d3c8650e8 wengophone/src/model/config/Config.h
--- a/wengophone/src/model/config/Config.h Tue Feb 26 18:23:02 2008 +0100
+++ b/wengophone/src/model/config/Config.h Wed Feb 27 09:50:15 2008 +0100
@@ -293,7 +293,7 @@ public:
bool getSipP2pPresence() const;
static const std::string SIP_CHAT_WITHOUT_PRESENCE;
- bool getSipChatWhithouPresence() const;
+ bool getSipChatWithoutPresence() const;
/** @} */
/**
diff -r b37d3c8650e8 wengophone/src/presentation/main.cpp
--- a/wengophone/src/presentation/main.cpp Tue Feb 26 18:23:02 2008 +0100
+++ b/wengophone/src/presentation/main.cpp Wed Feb 27 09:49:39 2008 +0100
@@ -288,10 +288,10 @@ int main(int argc, char * argv[]) {
else
w-setSipOptions(sip.p2p_presence, false);
- if(config.getSipChatWhithouPresence())
- w-setSipOptions(sip.chat.whithout.presence, true);
- else
- w-setSipOptions(sip.chat.whithout.presence, false);
+ if(config.getSipChatWithoutPresence())
+ w-setSipOptions(sip.chat.without.presence, true);
+ else
+ w-setSipOptions(sip.chat.without.presence, false);
if(config.getSipUseTypingState())
w-setSipOptions(sip.use_typing_state, true);
Ralf
--
Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16
Open Source Consulting Fax: +43/2243/26465-23
Reichergasse 131www: http://www.runtux.com
A-3411 Weidling email: [EMAIL PROTECTED]
osAlliance member email: [EMAIL PROTECTED]
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
On Wed, Feb 27, 2008 at 10:36:16AM +0100, Ralf Schlatterbeck wrote: Note that this time while I had wengo running I had a pop-up that asked me to authorize presence info for a remote (unknown) party. So there seems some support of p2p presence working. I'll now re-test with several clients. I've just tested: Laptop Desktop voip_testuser voip_testuser01 I'm seeing presence status of the Laptop/voip_testuser on the Desktop, on the Laptop I had to answer a popup to allow presence. The other direction doesn't seem to work. Propagation of Presence-Status changes is sometimes very slow (more than five minutes that the peer doesn't recognize a status change). I had to repeatedly answer the same popups concerning presence status: - Would be nice if the phone remembers my decision (for the session) even nicer would be if this decision can be made persistent - Maybe we want to allow presence to be shared if the peer is in my contactlist, so no popup would occur in this case? - A default setting that I don't want to share presence beyong my contacts would also be nice. I'll now retest with Darshaka Pathirana, maybe the unidirectional phenomenon is caused by the fact that both clients are behind the same nat firewall (although I'm using Linux kernel sip connection tracking in the firewall). Ralf -- Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16 Open Source Consulting Fax: +43/2243/26465-23 Reichergasse 131www: http://www.runtux.com A-3411 Weidling email: [EMAIL PROTECTED] osAlliance member email: [EMAIL PROTECTED] ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
Ralf Schlatterbeck wrote:
On Tue, Feb 26, 2008 at 10:19:46PM +0100, Ralf Schlatterbeck wrote:
I'm getting the feeling that my whole advanced config stuff isn't
working, (the dialog *is* working but it seems the values there aren't
used by wengo) any idea if this could be the case? That would explain
that sip.chat.without.presence and sip.p2p... isn't working for me.
I've looked into the code with this suspicion in mind:
Chat without presence:
- sip.chat.without.presence name in xml file
- SIP_CHAT_WITHOUT_PRESENCE name of string in config, only used in
wengophone/src/model/config/Config.{cpp,h}
- getSipChatWhithouPresence used in Config.{cpp,h} and in main.cpp,
there it does a
setSipOptions(sip.chat.whithout.presence
(Note the additional h in whithout !)
(shouldn't that have _ instead of . ?)
- grepping through the whole tree I've found no instances beyond Config
and main where this is actually used.
Maybe this *is* missing the implementation? Should I make my earlier
patch configurable with this variable?
- Patch at the end of this mail corrects spelling:
getSipChatWhithouPresence - getSipChatWithoutPresence
sip.chat.whithout.presence - sip.chat.without.presence
without any change in functionality -- chat without presence is still
not working.
P2P:
- sip.p2p.presence name in xml file
- SIP_P2P_PRESENCE name of string in config, only used in
Config.{cpp,h}
- The name SIP_P2P_PRESENCE is also used in an environment-query in
libs/sipwrapper/src/phapi/PhApiWrapper.cpp
- getSipP2pPresence used in Config.{cpp,h} and in main.cpp,
there it does a
setSipOptions(sip.p2p_presence
(Note the mix of _ and . !)
- libs/sipwrapper/src/phapi/PhApiWrapper.cpp uses:
- sipOptions.sip_p2p_presence
- the environment-variable SIP_P2P_PRESENCE which sets
sipOptions.sip_p2p_presence
- PhApiWrapper::setSipOptions looks at an option sip.p2p_presence
and seems to set sipOptions.sip_p2p_presence accordingly
- I have tried to set environment-variable SIP_P2P_PRESENCE to 1 with no
change in functionality.
- then I've instrumented the code and it shows
sipOptions.sip_p2p_presence to be 1.
Note that this time while I had wengo running I had a pop-up that asked
me to authorize presence info for a remote (unknown) party. So there
seems some support of p2p presence working. I'll now re-test with
several clients.
Patch:
diff -r b37d3c8650e8 wengophone/src/model/config/Config.cpp
--- a/wengophone/src/model/config/Config.cppTue Feb 26 18:23:02 2008 +0100
+++ b/wengophone/src/model/config/Config.cppWed Feb 27 09:50:07 2008 +0100
@@ -530,7 +530,7 @@ bool Config::getSipP2pPresence() const {
return getBooleanKeyValue(SIP_P2P_PRESENCE);
}
-bool Config::getSipChatWhithouPresence() const {
+bool Config::getSipChatWithoutPresence() const {
return getBooleanKeyValue(SIP_CHAT_WITHOUT_PRESENCE);
}
diff -r b37d3c8650e8 wengophone/src/model/config/Config.h
--- a/wengophone/src/model/config/Config.h Tue Feb 26 18:23:02 2008 +0100
+++ b/wengophone/src/model/config/Config.h Wed Feb 27 09:50:15 2008 +0100
@@ -293,7 +293,7 @@ public:
bool getSipP2pPresence() const;
static const std::string SIP_CHAT_WITHOUT_PRESENCE;
- bool getSipChatWhithouPresence() const;
+ bool getSipChatWithoutPresence() const;
/** @} */
/**
diff -r b37d3c8650e8 wengophone/src/presentation/main.cpp
--- a/wengophone/src/presentation/main.cpp Tue Feb 26 18:23:02 2008 +0100
+++ b/wengophone/src/presentation/main.cpp Wed Feb 27 09:49:39 2008 +0100
@@ -288,10 +288,10 @@ int main(int argc, char * argv[]) {
else
w-setSipOptions(sip.p2p_presence, false);
- if(config.getSipChatWhithouPresence())
- w-setSipOptions(sip.chat.whithout.presence, true);
- else
- w-setSipOptions(sip.chat.whithout.presence, false);
+ if(config.getSipChatWithoutPresence())
+ w-setSipOptions(sip.chat.without.presence, true);
+ else
+ w-setSipOptions(sip.chat.without.presence, false);
if(config.getSipUseTypingState())
w-setSipOptions(sip.use_typing_state, true);
Ralf
Ralf,
I've integrated your patch and the code to actually USE
getSipChatWithoutPresence
in model/contactlitst/ContactProfile.cpp
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
Ralf Schlatterbeck wrote:
On Fri, Feb 22, 2008 at 06:17:57PM +0100, Vadim Lebedev wrote:
Ralf we did a lot of fixes to presence stuff
Please try latest version
Hmm, I've just compiled tested without much further news:
- When turning on p2p presence, it still doesn't work for our
infrastructure
- ekiga.net is still not using presence at all (no matter if p2p is
turned on or off) although this used to work
I'd like to revert to an older version (maybe to the one when you moved
to hg) -- can you give me a short intro how I can revert to the start of
the hg version of the 2.2 branch, then I re-test ekiga.net to make sure
they didn't change anything that makes presence fail.
you can do hg update -r 0 command to get intial version of repository
which should be the same
wengophone_2.2 on SVN
- I had to patch src/presentation/main.cpp, otherwise it errors out when
compiling, seems that getSipChatWhithouPresence isn't defined (looks
like a typo, but searching for getSipChat didn't find anything either):
diff -r a58d652beefd wengophone/src/presentation/main.cpp
--- a/wengophone/src/presentation/main.cpp Fri Feb 22 18:13:12 2008 +0100
+++ b/wengophone/src/presentation/main.cpp Tue Feb 26 08:38:59 2008 +0100
@@ -288,10 +288,10 @@ int main(int argc, char * argv[]) {
else
w-setSipOptions(sip.p2p_presence, false);
- if(config.getSipChatWhithouPresence())
+ //if(config.getSipChatWhithouPresence())
w-setSipOptions(sip.chat.whithout.presence, true);
- else
- w-setSipOptions(sip.chat.whithout.presence, false);
+ //else
+ //w-setSipOptions(sip.chat.whithout.presence, false);
if(config.getSipUseTypingState())
w-setSipOptions(sip.use_typing_state, true);
Thanks, i'll fix it...
We need a build bot to detect this kind of problems promptly
Ralf
Vadim
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
Vadim Lebedev wrote: you can do hg update -r 0 command to get intial version of repository which should be the same wengophone_2.2 on SVN Does hg have a bisect function? I haven't found somthing like git-bisect. -- andreas signature.asc Description: OpenPGP digital signature ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
On Tue, Feb 26, 2008 at 12:48:23PM +0100, Vadim Lebedev wrote: Ralf Schlatterbeck wrote: I'd like to revert to an older version (maybe to the one when you moved to hg) -- can you give me a short intro how I can revert to the start of the hg version of the 2.2 branch, then I re-test ekiga.net to make sure they didn't change anything that makes presence fail. you can do hg update -r 0 command to get intial version of repository which should be the same wengophone_2.2 on SVN Doesn't work for me -- -r option is unrecognized for update and for pull it says: abort: pull -r doesn't work for remote repositories yet but hg revert -r 0 seemed to do the trick, is this the right thing to do? Compiling r0 just now... Ralf -- Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16 Open Source Consulting Fax: +43/2243/26465-23 Reichergasse 131www: http://www.runtux.com A-3411 Weidling email: [EMAIL PROTECTED] osAlliance member email: [EMAIL PROTECTED] ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
Andreas Schneider wrote: Vadim Lebedev wrote: you can do hg update -r 0 command to get intial version of repository which should be the same wengophone_2.2 on SVN Does hg have a bisect function? I haven't found somthing like git-bisect. -- andreas Yes http://www.selenic.com/mercurial/wiki/index.cgi/BisectExtension Vadim ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
Ralf Schlatterbeck wrote: On Tue, Feb 26, 2008 at 12:48:23PM +0100, Vadim Lebedev wrote: Ralf Schlatterbeck wrote: I'd like to revert to an older version (maybe to the one when you moved to hg) -- can you give me a short intro how I can revert to the start of the hg version of the 2.2 branch, then I re-test ekiga.net to make sure they didn't change anything that makes presence fail. you can do hg update -r 0 command to get intial version of repository which should be the same wengophone_2.2 on SVN Doesn't work for me -- -r option is unrecognized for update and for pull it says: abort: pull -r doesn't work for remote repositories yet but hg revert -r 0 seemed to do the trick, is this the right thing to do? Compiling r0 just now... Ralf No revert is the wrong thing... Maybe hg udpate 0 (without -r) ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
On Tue, Feb 26, 2008 at 02:48:04PM +0100, Vadim Lebedev wrote:
No revert is the wrong thing...
Maybe hg udpate 0
Ok that did it -- revert seems to do the same but deletes local changes.
I've built r0 and still don't get presence with ekiga.net. So either
they changed something or I'm missing something (and, yes, I've enabled
SIMPLE in the config dialog). So this doesn't seem to be a regression in
later versions. The fact remainst that I'm still not able to get p2p
presence working (tried both, ekiga.net and the phone provider we're
testing with).
With the following patch I'm able to chat via ekiga.net although
wengophone thinks my party (myself :-) isn't connected (you'll want to
remove my debug output and tie the behaviour of hasIM to a config
option) the idea of the patch is to make getPreferred always return the
best contact it finds, even if the peer is offline:
diff -r d4660b5e36fb wengophone/src/model/contactlist/ContactProfile.cpp
--- a/wengophone/src/model/contactlist/ContactProfile.cpp Mon Feb 18
15:44:08 2008 +0100
+++ b/wengophone/src/model/contactlist/ContactProfile.cpp Mon Feb 11
13:14:58 2008 +0100
@@ -136,6 +136,7 @@ void ContactProfile::setGroupId(const st
}
bool ContactProfile::hasIM() const {
+return true;
return (getPresenceState() != EnumPresenceState::PresenceStateOffline
getPresenceState() != EnumPresenceState::PresenceStateUnknown
getPresenceState() !=
EnumPresenceState::PresenceStateUnavailable);
@@ -218,9 +219,9 @@ IMContact * ContactProfile::getPreferred
const int offlineScore =
getStateScore(EnumPresenceState::PresenceStateOffline);
IMContact * bestIMContact = 0;
- int bestIMContactScore = 0;
+ int bestIMContactScore = -1;
IMContact * bestWengoContact = 0;
- int bestWengoContactScore = 0;
+ int bestWengoContactScore = -1;
// Find best IM contact and best Wengo contact
IMContactSet::const_iterator
@@ -231,9 +232,11 @@ IMContact * ContactProfile::getPreferred
EnumPresenceState::PresenceState state = it-getPresenceState();
int contactScore = getStateScore(state);
+# if 0
if (contactScore = offlineScore) {
continue;
}
+# endif
IMContact* contact = const_castIMContact*( (*it) );
@@ -248,6 +251,7 @@ IMContact * ContactProfile::getPreferred
bestIMContactScore = contactScore;
}
}
+LOG_WARN(Iterating...%d %d %d, contactScore, offlineScore,
bestIMContactScore);
}
// Get score of _preferredIMContact, if any
@@ -255,7 +259,7 @@ IMContact * ContactProfile::getPreferred
if (_preferredIMContact) {
preferredIMContactScore =
getStateScore(_preferredIMContact-getPresenceState());
} else {
- preferredIMContactScore = 0;
+ preferredIMContactScore = -1;
}
// Choose the best one
Ralf
--
Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16
Open Source Consulting Fax: +43/2243/26465-23
Reichergasse 131www: http://www.runtux.com
A-3411 Weidling email: [EMAIL PROTECTED]
osAlliance member email: [EMAIL PROTECTED]
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
Ralf Schlatterbeck wrote:
On Tue, Feb 26, 2008 at 02:48:04PM +0100, Vadim Lebedev wrote:
No revert is the wrong thing...
Maybe hg udpate 0
Ok that did it -- revert seems to do the same but deletes local changes.
I've built r0 and still don't get presence with ekiga.net. So either
they changed something or I'm missing something (and, yes, I've enabled
SIMPLE in the config dialog). So this doesn't seem to be a regression in
later versions. The fact remainst that I'm still not able to get p2p
presence working (tried both, ekiga.net and the phone provider we're
testing with).
With the following patch I'm able to chat via ekiga.net although
wengophone thinks my party (myself :-) isn't connected (you'll want to
remove my debug output and tie the behaviour of hasIM to a config
option) the idea of the patch is to make getPreferred always return the
best contact it finds, even if the peer is offline:
Ah... This is EXACTLY what this ghatWithoutPrsence stuff is
Activate Chat without PRESENCE mechanics functionning
Vadim
diff -r d4660b5e36fb wengophone/src/model/contactlist/ContactProfile.cpp
--- a/wengophone/src/model/contactlist/ContactProfile.cpp Mon Feb 18
15:44:08 2008 +0100
+++ b/wengophone/src/model/contactlist/ContactProfile.cpp Mon Feb 11
13:14:58 2008 +0100
@@ -136,6 +136,7 @@ void ContactProfile::setGroupId(const st
}
bool ContactProfile::hasIM() const {
+return true;
return (getPresenceState() != EnumPresenceState::PresenceStateOffline
getPresenceState() != EnumPresenceState::PresenceStateUnknown
getPresenceState() != EnumPresenceState::PresenceStateUnavailable);
@@ -218,9 +219,9 @@ IMContact * ContactProfile::getPreferred
const int offlineScore =
getStateScore(EnumPresenceState::PresenceStateOffline);
IMContact * bestIMContact = 0;
- int bestIMContactScore = 0;
+ int bestIMContactScore = -1;
IMContact * bestWengoContact = 0;
- int bestWengoContactScore = 0;
+ int bestWengoContactScore = -1;
// Find best IM contact and best Wengo contact
IMContactSet::const_iterator
@@ -231,9 +232,11 @@ IMContact * ContactProfile::getPreferred
EnumPresenceState::PresenceState state = it-getPresenceState();
int contactScore = getStateScore(state);
+# if 0
if (contactScore = offlineScore) {
continue;
}
+# endif
IMContact* contact = const_castIMContact*( (*it) );
@@ -248,6 +251,7 @@ IMContact * ContactProfile::getPreferred
bestIMContactScore = contactScore;
}
}
+LOG_WARN(Iterating...%d %d %d, contactScore, offlineScore,
bestIMContactScore);
}
// Get score of _preferredIMContact, if any
@@ -255,7 +259,7 @@ IMContact * ContactProfile::getPreferred
if (_preferredIMContact) {
preferredIMContactScore =
getStateScore(_preferredIMContact-getPresenceState());
} else {
- preferredIMContactScore = 0;
+ preferredIMContactScore = -1;
}
// Choose the best one
Ralf
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
On Tue, Feb 26, 2008 at 03:36:50PM +0100, Vadim Lebedev wrote: With the following patch I'm able to chat via ekiga.net although wengophone thinks my party (myself :-) isn't connected (you'll want to remove my debug output and tie the behaviour of hasIM to a config option) the idea of the patch is to make getPreferred always return the best contact it finds, even if the peer is offline: Ah... This is EXACTLY what this ghatWithoutPrsence stuff is Activate Chat without PRESENCE mechanics functionning Hmm, I didn't have any conflicts on update, did you already commit that chat-code (seems it wasn't fully implemented as indicated in my last patch where I had to remove that config-option). I'm happy to test your changes... Ralf -- Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16 Open Source Consulting Fax: +43/2243/26465-23 Reichergasse 131www: http://www.runtux.com A-3411 Weidling email: [EMAIL PROTECTED] osAlliance member email: [EMAIL PROTECTED] ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
Vadim Lebedev wrote:
Ralf Schlatterbeck wrote:
On Tue, Feb 26, 2008 at 02:48:04PM +0100, Vadim Lebedev wrote:
No revert is the wrong thing...
Maybe hg udpate 0
Ok that did it -- revert seems to do the same but deletes local changes.
I've built r0 and still don't get presence with ekiga.net. So either
they changed something or I'm missing something (and, yes, I've enabled
SIMPLE in the config dialog). So this doesn't seem to be a regression in
later versions. The fact remainst that I'm still not able to get p2p
presence working (tried both, ekiga.net and the phone provider we're
testing with).
With the following patch I'm able to chat via ekiga.net although
wengophone thinks my party (myself :-) isn't connected (you'll want to
remove my debug output and tie the behaviour of hasIM to a config
option) the idea of the patch is to make getPreferred always return the
best contact it finds, even if the peer is offline:
Ah... This is EXACTLY what this ghatWithoutPrsence stuff is
Activate Chat without PRESENCE mechanics functionning
Vadim
diff -r d4660b5e36fb wengophone/src/model/contactlist/ContactProfile.cpp
--- a/wengophone/src/model/contactlist/ContactProfile.cpp Mon Feb 18
15:44:08 2008 +0100
+++ b/wengophone/src/model/contactlist/ContactProfile.cpp Mon Feb 11
13:14:58 2008 +0100
@@ -136,6 +136,7 @@ void ContactProfile::setGroupId(const st
}
bool ContactProfile::hasIM() const {
+return true;
return (getPresenceState() != EnumPresenceState::PresenceStateOffline
getPresenceState() != EnumPresenceState::PresenceStateUnknown
getPresenceState() != EnumPresenceState::PresenceStateUnavailable);
@@ -218,9 +219,9 @@ IMContact * ContactProfile::getPreferred
const int offlineScore =
getStateScore(EnumPresenceState::PresenceStateOffline);
IMContact * bestIMContact = 0;
- int bestIMContactScore = 0;
+ int bestIMContactScore = -1;
IMContact * bestWengoContact = 0;
- int bestWengoContactScore = 0;
+ int bestWengoContactScore = -1;
// Find best IM contact and best Wengo contact
IMContactSet::const_iterator
@@ -231,9 +232,11 @@ IMContact * ContactProfile::getPreferred
EnumPresenceState::PresenceState state = it-getPresenceState();
int contactScore = getStateScore(state);
+# if 0
if (contactScore = offlineScore) {
continue;
}
+# endif
IMContact* contact = const_castIMContact*( (*it) );
@@ -248,6 +251,7 @@ IMContact * ContactProfile::getPreferred
bestIMContactScore = contactScore;
}
}
+LOG_WARN(Iterating...%d %d %d, contactScore, offlineScore,
bestIMContactScore);
}
// Get score of _preferredIMContact, if any
@@ -255,7 +259,7 @@ IMContact * ContactProfile::getPreferred
if (_preferredIMContact) {
preferredIMContactScore =
getStateScore(_preferredIMContact-getPresenceState());
} else {
- preferredIMContactScore = 0;
+ preferredIMContactScore = -1;
}
// Choose the best one
Ralf
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
I've just commit fix to syntax error you mentionned before.
Try the latest version whule activaiting sip.chat.without.prsenece
advanced config option
Vadim
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
Ralf Schlatterbeck wrote: On Tue, Feb 26, 2008 at 03:36:50PM +0100, Vadim Lebedev wrote: With the following patch I'm able to chat via ekiga.net although wengophone thinks my party (myself :-) isn't connected (you'll want to remove my debug output and tie the behaviour of hasIM to a config option) the idea of the patch is to make getPreferred always return the best contact it finds, even if the peer is offline: Ah... This is EXACTLY what this ghatWithoutPrsence stuff is Activate Chat without PRESENCE mechanics functionning Hmm, I didn't have any conflicts on update, did you already commit that chat-code (seems it wasn't fully implemented as indicated in my last patch where I had to remove that config-option). I'm happy to test your changes... Ralf I've committed 10 mins ago... I had not chance to test with ekiga but we have similar problem with another platform and we fixed it by adding sip.chat.without.presence advanced config option At some moment in the history of dev wengophone IM ceased to function without PRESENCE functioning. IMO This was already present in SVN version Thanks Vadim ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
On Tue, Feb 26, 2008 at 03:41:03PM +0100, Vadim Lebedev wrote: Vadim Lebedev wrote: I've just commit fix to syntax error you mentionned before. Try the latest version whule activaiting sip.chat.without.prsenece advanced config option Compiles but throws an exception: debug/wengophone (fatal) 15:57:02 [Common] /nobackup/checkout/wengophone-2.2/libs/owutil/settings/src/Settings.cpp:163 boost::any Settings::getAny(const std::string) const: key 'sip.chat.whithout.presence' does not exist (fatal) 15:57:02 [Common] /nobackup/checkout/wengophone-2.2/libs/owutil/settings/src/Settings.cpp:147 bool Settings::getBooleanKeyValue(const std::string) const: key 'sip.chat.whithout.presence' is not a boolean terminate called after throwing an instance of 'boost::bad_any_cast' what(): boost::bad_any_cast: failed conversion using boost::any_cast zsh: abort debug/wengophone After manually adding sip.chat.whithout.presencebool1/bool/sip.chat.whithout.presence to ~/.wengophone/config.xml the client starts but chat is greyed out. And I'm missing patches to src/model/contactlist/ContactProfile.cpp (thats where changes to the presence/chat behaviour would be, right?) this file is unchanged since r0 of the hg repo. Ralf -- Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16 Open Source Consulting Fax: +43/2243/26465-23 Reichergasse 131www: http://www.runtux.com A-3411 Weidling email: [EMAIL PROTECTED] osAlliance member email: [EMAIL PROTECTED] ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
On Tue, Feb 26, 2008 at 06:38:21PM +0100, Vadim Lebedev wrote: Ralf, I've fixed the spelling error (it should be *sip.chat.without.presence*) and added the the item into config.xml Ah, didn't notice the spelling error, sorry And here it appears in advanced config as item nr 72 Works for me now too. But the config option does nothing. Note that I don't have presence (config option for p2p presence still doesn't work) so wengo thinks I don't have presence at all (not just that my party is offline). With my earlier patch I can use the chat button while with the setting of sip.chat.without.presence I can't. I'm getting the feeling that my whole advanced config stuff isn't working, (the dialog *is* working but it seems the values there aren't used by wengo) any idea if this could be the case? That would explain that sip.chat.without.presence and sip.p2p... isn't working for me. Ralf -- Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16 Open Source Consulting Fax: +43/2243/26465-23 Reichergasse 131www: http://www.runtux.com A-3411 Weidling email: [EMAIL PROTECTED] osAlliance member email: [EMAIL PROTECTED] ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
On Fri, Feb 22, 2008 at 06:17:57PM +0100, Vadim Lebedev wrote:
Ralf we did a lot of fixes to presence stuff
Please try latest version
Hmm, I've just compiled tested without much further news:
- When turning on p2p presence, it still doesn't work for our
infrastructure
- ekiga.net is still not using presence at all (no matter if p2p is
turned on or off) although this used to work
I'd like to revert to an older version (maybe to the one when you moved
to hg) -- can you give me a short intro how I can revert to the start of
the hg version of the 2.2 branch, then I re-test ekiga.net to make sure
they didn't change anything that makes presence fail.
- I had to patch src/presentation/main.cpp, otherwise it errors out when
compiling, seems that getSipChatWhithouPresence isn't defined (looks
like a typo, but searching for getSipChat didn't find anything either):
diff -r a58d652beefd wengophone/src/presentation/main.cpp
--- a/wengophone/src/presentation/main.cpp Fri Feb 22 18:13:12 2008 +0100
+++ b/wengophone/src/presentation/main.cpp Tue Feb 26 08:38:59 2008 +0100
@@ -288,10 +288,10 @@ int main(int argc, char * argv[]) {
else
w-setSipOptions(sip.p2p_presence, false);
- if(config.getSipChatWhithouPresence())
+ //if(config.getSipChatWhithouPresence())
w-setSipOptions(sip.chat.whithout.presence, true);
- else
- w-setSipOptions(sip.chat.whithout.presence, false);
+ //else
+ //w-setSipOptions(sip.chat.whithout.presence, false);
if(config.getSipUseTypingState())
w-setSipOptions(sip.use_typing_state, true);
Ralf
--
Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16
Open Source Consulting Fax: +43/2243/26465-23
Reichergasse 131www: http://www.runtux.com
A-3411 Weidling email: [EMAIL PROTECTED]
osAlliance member email: [EMAIL PROTECTED]
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
On Fri, Feb 15, 2008 at 05:52:36PM +0100, Vadim Lebedev wrote: Folks, I've commited on 2.2 G722 codec support and P2P presence support. To acitivate P2P presnece in set sip.p2P_presence to TRUE in advanced config dialog It is not really well tested but seems to work Hi Vadim, I've just updated my HG checkout and rebuilt. With the following results. - Built against hg clone from http://repo.mbdsys.com/openwengo/wengophone-2.2 - The build reports: -- Found Mercurial (hg): /usr/bin/hg -- OS: Linux-2.6.20.1-p4 -- Processor: unknown -- Compiler: /usr/bin/gcc-3.4 -- Build type: Debug -- Build tool: /usr/bin/make -- Build directory: /home/ralf/checkout/wengophone-2.2/build/debug -- svn revision: d4660b5e36fb -- Time: 20080219145309 (Hmm, shouldn't that be hg revision?) - I'm *not* seeing a sip.p2P_presence in the (advanced) config dialog and nothing in ~/.wengophone/profiles/[EMAIL PROTECTED]/userprofile.xml - Normal server-presence which used to work with a [EMAIL PROTECTED] stopped working -- I was at least seeing myself as present and could verify that a colleague was visible when logged in with earlier versions of wengophone 2.2 -- ekiga doesn't seem to fully implement presence, I was only seeing green or grey status, no red/orange etc. but now I'm only seeing the icon that indicates that no presence info is available (pink with an orange dot at the top) - I'm getting several of the following debug messages with both sip providers (the one the only support p2p and against ekiga.net): (warn) 16:43:26 [PhApi] : osip: /home/ralf/checkout/wengophone-2.2/wifo/libosip2/src/osip2/osip_dialog.c:355: Remote UA is not compliant: missing a tag in response! (warn) 16:43:26 [PhApi] : osip: /home/ralf/checkout/wengophone-2.2/wifo/libosip2/src/osip2/osip_dialog.c:401: Remote UA is not compliant: missing a contact in response! (warn) 16:43:26 [PhApi] : osip: /home/ralf/checkout/wengophone-2.2/wifo/libosip2/src/osip2/osip_dialog.c:97: missing a contact in response! Ralf -- Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16 Open Source Consulting Fax: +43/2243/26465-23 Reichergasse 131www: http://www.runtux.com A-3411 Weidling email: [EMAIL PROTECTED] osAlliance member email: [EMAIL PROTECTED] ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
Ralf Schlatterbeck wrote: On Fri, Feb 15, 2008 at 05:52:36PM +0100, Vadim Lebedev wrote: Folks, I've commited on 2.2 G722 codec support and P2P presence support. To acitivate P2P presnece in set sip.p2P_presence to TRUE in advanced config dialog It is not really well tested but seems to work Hi Vadim, I've just updated my HG checkout and rebuilt. With the following results. - Built against hg clone from http://repo.mbdsys.com/openwengo/wengophone-2.2 - The build reports: -- Found Mercurial (hg): /usr/bin/hg -- OS: Linux-2.6.20.1-p4 -- Processor: unknown -- Compiler: /usr/bin/gcc-3.4 -- Build type: Debug -- Build tool: /usr/bin/make -- Build directory: /home/ralf/checkout/wengophone-2.2/build/debug -- svn revision: d4660b5e36fb -- Time: 20080219145309 (Hmm, shouldn't that be hg revision?) - I'm *not* seeing a sip.p2P_presence in the (advanced) config dialog and nothing in ~/.wengophone/profiles/[EMAIL PROTECTED]/userprofile.xml - Normal server-presence which used to work with a [EMAIL PROTECTED] stopped working -- I was at least seeing myself as present and could verify that a colleague was visible when logged in with earlier versions of wengophone 2.2 -- ekiga doesn't seem to fully implement presence, I was only seeing green or grey status, no red/orange etc. but now I'm only seeing the icon that indicates that no presence info is available (pink with an orange dot at the top) - I'm getting several of the following debug messages with both sip providers (the one the only support p2p and against ekiga.net): (warn) 16:43:26 [PhApi] : osip: /home/ralf/checkout/wengophone-2.2/wifo/libosip2/src/osip2/osip_dialog.c:355: Remote UA is not compliant: missing a tag in response! (warn) 16:43:26 [PhApi] : osip: /home/ralf/checkout/wengophone-2.2/wifo/libosip2/src/osip2/osip_dialog.c:401: Remote UA is not compliant: missing a contact in response! (warn) 16:43:26 [PhApi] : osip: /home/ralf/checkout/wengophone-2.2/wifo/libosip2/src/osip2/osip_dialog.c:97: missing a contact in response! Ralf Ralf, Thanks for the info... I never paid attention to the warnings from osip_dialog.c i'll look into it... The item in advanced dialog is called sip.p2p.prsence and is FALSE by default it is stored (if modified) ~/.wengophone/config.xml I'll look into the standrd presence regression Thanks Vadim ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
Vadim Lebedev wrote: Ralf Schlatterbeck wrote: On Fri, Feb 15, 2008 at 05:52:36PM +0100, Vadim Lebedev wrote: Folks, I've commited on 2.2 G722 codec support and P2P presence support. To acitivate P2P presnece in set sip.p2P_presence to TRUE in advanced config dialog It is not really well tested but seems to work Hi Vadim, I've just updated my HG checkout and rebuilt. With the following results. - Built against hg clone from http://repo.mbdsys.com/openwengo/wengophone-2.2 - The build reports: -- Found Mercurial (hg): /usr/bin/hg -- OS: Linux-2.6.20.1-p4 -- Processor: unknown -- Compiler: /usr/bin/gcc-3.4 -- Build type: Debug -- Build tool: /usr/bin/make -- Build directory: /home/ralf/checkout/wengophone-2.2/build/debug -- svn revision: d4660b5e36fb -- Time: 20080219145309 (Hmm, shouldn't that be hg revision?) - I'm *not* seeing a sip.p2P_presence in the (advanced) config dialog and nothing in ~/.wengophone/profiles/[EMAIL PROTECTED]/userprofile.xml - Normal server-presence which used to work with a [EMAIL PROTECTED] stopped working -- I was at least seeing myself as present and could verify that a colleague was visible when logged in with earlier versions of wengophone 2.2 -- ekiga doesn't seem to fully implement presence, I was only seeing green or grey status, no red/orange etc. but now I'm only seeing the icon that indicates that no presence info is available (pink with an orange dot at the top) - I'm getting several of the following debug messages with both sip providers (the one the only support p2p and against ekiga.net): (warn) 16:43:26 [PhApi] : osip: /home/ralf/checkout/wengophone-2.2/wifo/libosip2/src/osip2/osip_dialog.c:355: Remote UA is not compliant: missing a tag in response! (warn) 16:43:26 [PhApi] : osip: /home/ralf/checkout/wengophone-2.2/wifo/libosip2/src/osip2/osip_dialog.c:401: Remote UA is not compliant: missing a contact in response! (warn) 16:43:26 [PhApi] : osip: /home/ralf/checkout/wengophone-2.2/wifo/libosip2/src/osip2/osip_dialog.c:97: missing a contact in response! Ralf Ralf, Thanks for the info... I never paid attention to the warnings from osip_dialog.c i'll look into it... The item in advanced dialog is called sip.p2p.prsence and is FALSE by default it is stored (if modified) ~/.wengophone/config.xml I'll look into the standrd presence regression Well i've looked into it... I suppose you compare to wengophone 2.1, right? First of all these warning messages can be ignored they seem to be caused by stricter version of libosip Second the presence between two wengophone in standard mode (using PUBLISH works) I also know that P2P mode works (partially) in against our client's SIP server. The big problem is that wengophone implementation of presence is done in VERY strange way: for example the status is transmitted using note tag in the PIDF. And when the this tag contains a non-standard string it is considered as an alias change. I think all this stuff requires serious rewamping... Any volunteers? Thanks Vadim ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
Hi Vadim, thanks for looking into this. Any reason why your response didn't go to the mailinglist (my post had a CC)? OK if I also bounce my answer to the list? On Tue, Feb 19, 2008 at 06:53:28PM +0100, Vadim Lebedev wrote: - I'm *not* seeing a sip.p2P_presence in the (advanced) config dialog and nothing in ~/.wengophone/profiles/[EMAIL PROTECTED]/userprofile.xml The item in advanced dialog is called sip.p2p.prsence and is FALSE by default it is stored (if modified) ~/.wengophone/config.xml Ah. I was looking under the advanced-tab in the Log On/Log Off Dialog in the Wengo menu when selecting Modify. And I guess this should really be moved there -- the setting is probably different for each SIP Profile (it is in our test-cases). I've enabled it now and seeing in the config.xml: sip.p2p.presencebool1/bool/sip.p2p.presence But I'm still not seeing presence info. Thats what I get as debug output: (warn) 19:59:02 [PhApi] : osip: /nobackup/checkout/wengophone-2.2/wifo/libosip2/src/osip2/osip_dialog.c:355: Remote UA is not compliant: missing a tag in response! (warn) 19:59:02 [PhApi] : osip: /nobackup/checkout/wengophone-2.2/wifo/libosip2/src/osip2/osip_dialog.c:401: Remote UA is not compliant: missing a contact in response! (warn) 19:59:02 [PhApi] : osip: /nobackup/checkout/wengophone-2.2/wifo/libosip2/src/osip2/osip_dialog.c:97: missing a contact in response! I'm still getting the pink/orange icon that indicates that no presence info is available (I'm not sure about the status of my contacts but I guess I should see at least a grey bubble?). Ekiga.net is still not working when enabling p2p presence. Ralf -- Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16 Open Source Consulting Fax: +43/2243/26465-23 Reichergasse 131www: http://www.runtux.com A-3411 Weidling email: [EMAIL PROTECTED] osAlliance member email: [EMAIL PROTECTED] ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
On Tue, Feb 19, 2008 at 08:54:34PM +0100, Vadim Lebedev wrote: Vadim Lebedev wrote: Thanks for the info... I never paid attention to the warnings from osip_dialog.c i'll look into it... The item in advanced dialog is called sip.p2p.prsence and is FALSE by default it is stored (if modified) ~/.wengophone/config.xml I'll look into the standrd presence regression Well i've looked into it... I suppose you compare to wengophone 2.1, right? No, I was comparing to the last 2.2 version before moving the repository to HG First of all these warning messages can be ignored they seem to be caused by stricter version of libosip OK, this was just a guess that these messages have something to do with missing presence info. Second the presence between two wengophone in standard mode (using PUBLISH works) I also know that P2P mode works (partially) in against our client's SIP server. With the old version (2.2 before move to HG) I got grey bubbles for my contact @ekiga.net and a green bubble if I added myself as a contact. In addition I tested with a colleague against an older version of 2.2 and also saw him. I only saw grey or green, no red or orange stati. With the new version I'm getting the ping/orange/grey icon that indicates that no presence is available. I'm getting the same for a mobile phone provider SIP infrastructure that should support p2p presence (with p2p enabled in the advanced config). But I did some local modifications -- I'll revert these an re-test. I'll keep you updated. Ralf -- Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16 Open Source Consulting Fax: +43/2243/26465-23 Reichergasse 131www: http://www.runtux.com A-3411 Weidling email: [EMAIL PROTECTED] osAlliance member email: [EMAIL PROTECTED] ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
Ralf Schlatterbeck wrote: On Tue, Feb 19, 2008 at 10:18:56PM +0100, Ralf Schlatterbeck wrote: With the old version (2.2 before move to HG) I got grey bubbles for my contact @ekiga.net and a green bubble if I added myself as a contact. In addition I tested with a colleague against an older version of 2.2 and also saw him. I only saw grey or green, no red or orange stati. With the new version I'm getting the ping/orange/grey icon that indicates that no presence is available. But I did some local modifications -- I'll revert these an re-test. I'll keep you updated. I've just reverted my local changes and rebuilt/retested with the same results. When restarting wengo (but *not* when only logging off/on) I'm seeing these additional messages (several of them): (error) 22:25:39 [PhApi] : osip: /nobackup/checkout/wengophone-2.2/wifo/eXosip/src/eXosip.c:3513: eXosip: No subscribe dialog here? (error) 22:25:40 [PhApi] : osip: /nobackup/checkout/wengophone-2.2/wifo/eXosip/src/udp.c:2524: no matching SIP account found Ralf Ralf, Can you send me wireshark trace of this? Thanks Vadim ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] G772 and P2P SIP/SIMPLE
On Tue, Feb 19, 2008 at 10:18:56PM +0100, Ralf Schlatterbeck wrote: With the old version (2.2 before move to HG) I got grey bubbles for my contact @ekiga.net and a green bubble if I added myself as a contact. In addition I tested with a colleague against an older version of 2.2 and also saw him. I only saw grey or green, no red or orange stati. With the new version I'm getting the ping/orange/grey icon that indicates that no presence is available. But I did some local modifications -- I'll revert these an re-test. I'll keep you updated. I've just reverted my local changes and rebuilt/retested with the same results. When restarting wengo (but *not* when only logging off/on) I'm seeing these additional messages (several of them): (error) 22:25:39 [PhApi] : osip: /nobackup/checkout/wengophone-2.2/wifo/eXosip/src/eXosip.c:3513: eXosip: No subscribe dialog here? (error) 22:25:40 [PhApi] : osip: /nobackup/checkout/wengophone-2.2/wifo/eXosip/src/udp.c:2524: no matching SIP account found Ralf -- Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16 Open Source Consulting Fax: +43/2243/26465-23 Reichergasse 131www: http://www.runtux.com A-3411 Weidling email: [EMAIL PROTECTED] osAlliance member email: [EMAIL PROTECTED] ___ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
