Zitat von Micah Cowan [EMAIL PROTECTED]:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Micah Cowan wrote:
Jochen Roderburg wrote:
Unfortunately, however, a new regression crept in:
In the case timestamping=on, content-disposition=off, no local file
present it
does now no HEAD
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
Zitat von Micah Cowan [EMAIL PROTECTED]:
It's hard to be confident I'm not introducing more issues, with the
state of http.c being what it is. So please beat on it! :)
This time it survived the beating ;-)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Micah Cowan wrote:
Jochen Roderburg wrote:
Unfortunately, however, a new regression crept in:
In the case timestamping=on, content-disposition=off, no local file present
it
does now no HEAD (correctly), but two (!!) GETS and transfers the file
Zitat von Micah Cowan [EMAIL PROTECTED]:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
Zitat von Micah Cowan [EMAIL PROTECTED]:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
Yes, this one is still open, and the other one that
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
Unfortunately, however, a new regression crept in:
In the case timestamping=on, content-disposition=off, no local file present it
does now no HEAD (correctly), but two (!!) GETS and transfers the file two
times.
Ha!
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
Zitat von Micah Cowan [EMAIL PROTECTED]:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
Yes, this one is still open, and the other one that wget -c always starts
at 0
again.
Do you mean the
Zitat von Micah Cowan [EMAIL PROTECTED]:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
And now, for a change, a case, that works now (better) ;-)
This is an example where a HEAD request gets a 500 Error response.
Wget default options again, but
Zitat von Micah Cowan [EMAIL PROTECTED]:
The problem you pointed out that causes the failure to properly
timestamp when HEADs aren't issued seems, to my reading, to be simply
regressable for the fix. Mauro's fixes don't look as if they depend upon
that line being there, but I'm waiting for
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
Zitat von Micah Cowan [EMAIL PROTECTED]:
The problem you pointed out that causes the failure to properly
timestamp when HEADs aren't issued seems, to my reading, to be simply
regressable for the fix. Mauro's fixes don't
Zitat von Micah Cowan [EMAIL PROTECTED]:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
Yes, this one is still open, and the other one that wget -c always starts
at 0
again.
Do you mean the (local 0) thing? That should have been fixed in
674cc935f7c8
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
Zitat von Micah Cowan [EMAIL PROTECTED]:
Jochen Roderburg wrote:
Yes, this one is still open, and the other one that wget -c always starts
at 0
again.
Do you mean the (local 0) thing? That should have been fixed in
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
And now, for a change, a case, that works now (better) ;-)
This is an example where a HEAD request gets a 500 Error response.
Wget default options again, but contentdisposition=yes to force a HEAD.
Zitat von Micah Cowan [EMAIL PROTECTED]:
And the only other code I found which parses the remote date is in the part
which handles the logic around the timestamping option. In older versions
this
was a conditional block starting with if (!got_head) ... , now it starts
with
if
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
Zitat von Micah Cowan [EMAIL PROTECTED]:
Hm... that change came from the Content-Disposition fixes. I'll investigate.
OK, but I hope I am still allowed to help a little with the investigation ;-)
Oh, I'm always
Zitat von Micah Cowan [EMAIL PROTECTED]:
Btw, continued downloads (wget -c) are also
broken now in this case (probably for the same reason).
Really? I've been using this Wget version for a bit, and haven't noticed
this problem. Could you give an invocation that produces this problem?
Zitat von Micah Cowan [EMAIL PROTECTED]:
Zitat von Jochen Roderburg [EMAIL PROTECTED]:
So it looks now to me, that the new error (local timestamp not set to
remote)
only occurs in the cases when no HEAD is used.
This (new) piece of code in http.c (line 2666 ff.) looks very suspicious
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
Zitat von Micah Cowan [EMAIL PROTECTED]:
Zitat von Jochen Roderburg [EMAIL PROTECTED]:
So it looks now to me, that the new error (local timestamp not set to
remote)
only occurs in the cases when no HEAD is used.
This
Zitat von Jochen Roderburg [EMAIL PROTECTED]:
So it looks now to me, that the new error (local timestamp not set to remote)
only occurs in the cases when no HEAD is used.
This (new) piece of code in http.c (line 2666 ff.) looks very suspicious to me,
especially the time_came_from_head bit:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
Zitat von Jochen Roderburg [EMAIL PROTECTED]:
So it looks now to me, that the new error (local timestamp not set to remote)
only occurs in the cases when no HEAD is used.
This (new) piece of code in http.c (line 2666
Zitat von Micah Cowan [EMAIL PROTECTED]:
Hm, that should not be. It should definitely set the timestamp if it
gets downloaded... I'll investigate.
OOC, was there a specific resource you tested against (just in case I
have difficulty reproducing)?
Not a very specific one, just used our
And now, for a change, a case, that works now (better) ;-)
This is an example where a HEAD request gets a 500 Error response.
Wget default options again, but contentdisposition=yes to force a HEAD.
wget.111-svn-0709 --debug -e contentdisposition = yes
And now, finally, the ultimate real-life test with proxy-cache, timestamping and
contentdisposition, where HEAD and GET have different timestamps.
And this is perfectly correct now !
So it looks now to me, that the new error (local timestamp not set to remote)
only occurs in the cases when
Zitat von Micah Cowan [EMAIL PROTECTED]:
I've just merged a bunch of things into the current trunk, including
Mauro's latest changes related to when HEAD is sent (concerning which he
recently sent an email). Please feel free to beat on it, and report any
bugs here!
Ah, finally something to
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
I did only a few first tests now, because the basic test already had a
problem:
With default options the local timestamps are not set at all.
Options: no spider, no -O, no content-disposition:
no timestamping, no
24 matches
Mail list logo
