Re: [Wicket-user] constructors and on attach 2

2006-09-16 Thread Martijn Dashorst
Use new BookmarkableLink(MyPage.class); On 9/16/06, Scott Lusebrink [EMAIL PROTECTED] wrote: here is a sample of what i was doing, ( i don't have my code infront of me but i'll try to be close) new BookmarkableLink(new MyPage()) class MyPage public MyPage() { List options

Re: [Wicket-user] constructors and on attach 2

2006-09-16 Thread Igor Vaynberg
On 9/16/06, Scott Lusebrink [EMAIL PROTECTED] wrote: here is a sample of what i was doing, ( i don't have my code infront of me but i'll try to be close) new BookmarkableLink(new MyPage())new BookmarkableLink(MyPage.class); class MyPage public MyPage() {IModel choiceModel=new

Re: [Wicket-user] constructors and on attach

2006-09-16 Thread Johan Compagner
PageLink also has constructors for a Class.A bookmarkable page link is what it says it creates a bookmarkable link But maybe you don't want that at allthen you can use a PageLink and the PageLink class with the IPageLink param i the constructor is an easy think for lazy creating pages but directly

Re: [Wicket-user] constructors and on attach

2006-09-16 Thread Eelco Hillenius
At the very least, I'd be +100 for removing the constructor with the Page. The only thing that constructor does is encourage bad practice. Eelco On 9/16/06, Johan Compagner [EMAIL PROTECTED] wrote: PageLink also has constructors for a Class. A bookmarkable page link is what it says it creates

Re: [Wicket-user] constructors and on attach

2006-09-16 Thread Martijn Dashorst
It does one thing and one thing good: create a link to an already existing page. We use it quite often in our apps. I'm +1(00) for the constructor to stay. Read the docs and understand what you're doing. If we were to remove everything that 'encourages' bad practice we wouldn't have a framework

Re: [Wicket-user] constructors and on attach

2006-09-16 Thread Eelco Hillenius
On 9/16/06, Martijn Dashorst [EMAIL PROTECTED] wrote: It does one thing and one thing good: create a link to an already existing page. We use it quite often in our apps. I'm +1(00) for the constructor to stay. For what are you using it? Hopefully only for things like linking back to a page you

Re: [Wicket-user] constructors and on attach

2006-09-15 Thread Eelco Hillenius
On 9/15/06, Scott Lusebrink [EMAIL PROTECTED] wrote: I need a place where i can initialize a page, get data from the database and set the models of my components. I assume I'm going to need the data before i set the models. The models and the actual data they link to are different things.

Re: [Wicket-user] constructors and on attach

2006-09-15 Thread Igor Vaynberg
Why would you even create the page while you're actually linking toit? E.g, when you do ( 2.0 code):because he wants to link to a page, the obvious component is PageLink and it takes a Page instance in its contructor - so its the most obvious way to link to a page for a noob. you guys keep

Re: [Wicket-user] constructors and on attach

2006-09-15 Thread Eelco Hillenius
because he wants to link to a page, the obvious component is PageLink and it takes a Page instance in its contructor - so its the most obvious way to link to a page for a noob. Erm. Maybe. I didn't get that from his email. you guys keep outvoting me on removing that constructor, but its