Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread Johan Compagner
we could call validate() instead of convert()but i don't know we we want that at that time. Because it is not really a submit...(thats why it shouldn't really go into the model by default anyway)And for this case required test is not really needed. And validators for a DropDownSelect (not form vali

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread Igor Vaynberg
stillwhere is the validation?-IgorOn 8/30/06, Johan Compagner <[EMAIL PROTECTED]> wrote: if we can break a little bit more we could do something like this: public final void onSelectionChanged()    {        convert();        if(onSelectionChanged(getConvertedObject()))   {           updateM

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread landtuna
Eelco Hillenius wrote: > Could you please add a feature request, so that we can > change it when we agree for 2.0 and 1.3? Added as Request ID 1549588. -- Jim Hunziker -- View this message in context: http://www.nabble.com/DropDownChoice%27s-onSelectionChanged-called-too-late-tf2186138.html#

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread Johan Compagner
who? me?Why do you think you know me that well!On 8/30/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: johan was just being a smartass :)-Igor On 8/30/06, Gwyn Evans < [EMAIL PROTECTED]> wrote: Hmm, not /quite/ yet, I think - Check the thread on wicket-dev beforecommiting anything new (as opposed to b

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread Johan Compagner
if we can break a little bit more we could do something like this:public final void onSelectionChanged()    {        convert();        if(onSelectionChanged(getConvertedObject()))   {           updateModel();     }    } On 8/30/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote: Could you please

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread Eelco Hillenius
Could you please add a feature request, so that we can change it when we agree for 2.0 and 1.3? To my knowledge, the model always has been updated from the start. And I think that is good, though it would be better if it was optional (but not manual). Eelco On 8/30/06, landtuna <[EMAIL PROTECTE

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread Igor Vaynberg
johan was just being a smartass :)-IgorOn 8/30/06, Gwyn Evans <[EMAIL PROTECTED]> wrote: Hmm, not /quite/ yet, I think - Check the thread on wicket-dev beforecommiting anything new (as opposed to bug-fixes) to 1.x./GwynOn 30/08/06, Johan Compagner <[EMAIL PROTECTED]> wrote:> 1.3 is wicket-1.x he?

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread landtuna
Thanks for looking into this. Here's my ugly hack to get around the problem: DropDownChoice elevationSelect = new DropDownChoice("elevationSelect") { private float oldElevation = 0.0f; public List getChoices() { return ((HwddcState) parent.getModelObject()).getEleva

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread Gwyn Evans
Hmm, not /quite/ yet, I think - Check the thread on wicket-dev before commiting anything new (as opposed to bug-fixes) to 1.x. /Gwyn On 30/08/06, Johan Compagner <[EMAIL PROTECTED]> wrote: > 1.3 is wicket-1.x he? ;) -- Download Wicket 1.2.2 now! - http://wicketframework.org ---

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread Johan Compagner
1.3 is wicket-1.x he? ;)On 8/30/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: maybe, whatever you decide to do it will have to wait for 1.3 because it will break behavior-Igor On 8/30/06, Johan Compagner < [EMAIL PROTECTED]> wrote: i think you need some sleep yes ... On 8/30/06, Igor Vaynberg < [EM

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread Igor Vaynberg
maybe, whatever you decide to do it will have to wait for 1.3 because it will break behavior-IgorOn 8/30/06, Johan Compagner < [EMAIL PROTECTED]> wrote:i think you need some sleep yes ... On 8/30/06, Igor Vaynberg < [EMAIL PROTECTED]> wrote: i remember users asking the opposite a while ago - why do

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread Johan Compagner
i think you need some sleep yes ...On 8/30/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: i remember users asking the opposite a while ago - why doesnt my model update in onselectionchanged() and we had to tell them to call validate/updatemodel themselves... maybe im mixing something up-Igor On 8/30/

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread Igor Vaynberg
i remember users asking the opposite a while ago - why doesnt my model update in onselectionchanged() and we had to tell them to call validate/updatemodel themselves...maybe im mixing something up-Igor On 8/30/06, Johan Compagner <[EMAIL PROTECTED]> wrote: only with the "current" code (the seperate

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread Johan Compagner
only with the "current" code (the seperated convertValue()) it is possible to kill the updateModel() codebecause before that we needed the updateModel() because that did the conversion...But now that is handled differently we could also kill the updateModel() call. johanOn 8/30/06, Johan Compagner

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread Johan Compagner
we do that already a long time, maybe even from the beginning.johanOn 8/30/06, Igor Vaynberg < [EMAIL PROTECTED]> wrote:that updatemodel() call is a recentchange isnt it - i thought we didnt do that. who put that there? -IgorOn 8/30/06, Johan Compagner < [EMAIL PROTECTED]> wrote: Currently in all

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread Igor Vaynberg
that updatemodel() call is a recentchange isnt it - i thought we didnt do that. who put that there?-IgorOn 8/30/06, Johan Compagner < [EMAIL PROTECTED]> wrote:Currently in all those things we do update the model. When you don't want that or want the old value. You could override convertValue() the

Re: [Wicket-user] DropDownChoice's onSelectionChanged called too late

2006-08-30 Thread Johan Compagner
Currently in all those things we do update the model. When you don't want that or want the old value. You could override convertValue() then you are just before the model update.We could change this behaviour if needed somehow now we do this:     public final void onSelectionChanged()    {        c