I think skipped should be ignored in the UI, but the AI should be able to know
whether a program has been skipped a lot recently, because that means that a
new building is not needed.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613
Your team
The proposal to merge lp:~widelands-dev/widelands/ai_productionsites_statistics
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613
--
Your team Widela
transient failure on travis
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_productionsites_statistics.
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 5025. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/535462295.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613
Have done some playtesting 4 AI players on full moon.
found no obvious anomalies.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613
Your team Widelands Developers is subscribed to branch
For AI this is the best I believe...
--
https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_productionsites_statistics.
ok you are right especially for the AI cause the AI might want to build another
idle building then.
However we should perhaps have different rating for failed and skipped. If you
like we could deliver only half of the duration time to the update fuctionality
in case we skipped so it will fall
Low utilization can mean one of two shortage of inputs or that the output is
not needed. So by my opinion, skipped programs should be included in
statistics...
Because utilization close to 100 while the building being idle most of time can
confuse players in believing that new building is
OK, comments implemented.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_productionsites_statistics.
___
Mailing
by the way I now see another option.
- this change plus exposing the new crude Statistics to the UI ;-)
--
https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613
Your team Widelands Developers is subscribed to branch
Review: Approve
Got the concept. I think we should have this after you perhaps might fix the
small nits from the below diff comments
Diff comments:
> === modified file 'src/logic/map_objects/tribes/productionsite.cc'
> --- src/logic/map_objects/tribes/productionsite.cc2019-05-18 11:58:43
Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe
to review the proposed merge of
lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~wideland
An
>additional building is only reasonable if the current buildings are supplied
>properly.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613
Your team Widelands Developers is requested to review the proposed merge of
lp:~wi
, and expose official statistics to AI and retrain
--
https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands
team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
to review the proposed merge of
lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net
to review the proposed merge of
lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net
://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands.
___
Mailing list: https
to review the proposed merge of
lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands
%.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands
Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe
p:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.l
the proposed merge of
lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
ntire_duration - duration;
> + crude_percent_ = (crude_percent_ * old_duration + produced * duration *
> 1) / entire_duration;
> + assert(crude_percent_ <= 1); //be sure we do not go above 100 %
> + }
> +
> } // namespace Widelands
--
https://code.l
/widelands/ai_productionsites_statistics/+merge/367613
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands.
___
Mailing list: https://launchpad.net
ays.
> + crude_percent_ = (crude_percent_ * old_duration + produced * duration *
> 1) / entire_duration;
> + assert(crude_percent_ <= 1); //be sure we do not go above 100 %
> + }
> +
> } // namespace Widelands
--
https://code.l
are in, so I'd rather not add new code that we'll
then need to remove anyway.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands
/_widelands_dev_widelands_ai_productionsites_statistics-4801.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_productionsites_statistics/+merge/367613
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands
accurate than what is in
code now...
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai_productionsites_statistics into lp:widelands.
=== modified file 'src/logic/map_objects/tribes/productionsite.cc'
--- src/logic/map_objects/tribes
31 matches
Mail list logo
