The proposal to merge lp:~widelands-dev/widelands/bug1186906 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug1186906/+merge/177204
--
https://code.launchpad.net/~widelands-dev/widelands/bug11869
Review: Approve
Beautiful implementation! Merged.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1186906/+merge/177204
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1186906.
___
Mailing list: https://
Yes I thought about that but didn't have the courage to implement right away.
But thinking of it again, it might only be a signal in Map_Object that is
connected in the message class. It would be possible to renew the connection
quite easily upon loading, and to reset the serial field when the o
Review: Needs Fixing
--
https://code.launchpad.net/~widelands-dev/widelands/bug1186906/+merge/177204
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1186906.
___
Mailing list: https://launchpad.net/~widelands-dev
Okay, the code lgtm. What I do not like is that the messages are only archived
when the message window is opened. E.g.: if you have no messages and a quarry
runs out of stone. You burn this quarry - after this you open the message
window (which is marked as having new messages), but you see none
great that you figured it out. Loading indeed reassigns object serials - this
is the only way to get back no longer used serials. That is why we use the
magic with the map object loader and saver.
This seems like a nice change - I will review asap.
--
https://code.launchpad.net/~widelands-dev/
I figured it out - by saving the file_index given by the map object saver,
objects serial are loaded correctly through the map object loader. Works great
:)
--
https://code.launchpad.net/~widelands-dev/widelands/bug1186906/+merge/177204
Your team Widelands Developers is requested to review the p
And I realized that - as i feared - the serial are re-attributed during
loading. So, is there a way to handle this or shouldn't the serial field be
saved?
imo it doesn't matter much if they are not saved. Maybe we should go through
all messages once more before saving.
--
https://code.launchpad
I also thought about removing the position field, since we could get the
position through the object serial, but then i thought it might be useful to
know to which building - even if now destroyed - archived messages were linked.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1186906/
cghislai has proposed merging lp:~widelands-dev/widelands/bug1186906 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1186906 in widelands: "Remove entries from the message list that have
become obsolete"
https://bugs.launchpad.net/widelands/+bu
10 matches
Mail list logo
