Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/translation_stats into lp:widelands

[kaputtnik]

My version of translate-toolkit is 2.2.5-1.

Pulled your changes but no change:

$:> python2 utils/update_translation_stats.py   
 
Fetching translation stats .
ERROR: Invalid line in pocount output:
/home/kaputtnik/Quellcode/widelands-repo/translation_stats/po/map_the_green_plateau.wmf/la.po
 source words: total: 438  | 438t   0f  0u  | 100.0%t   0.0%f   
0.0%u

I have tried to print the line showing escape sequences by adjusting line 106 
like "...line.encode('string_escape'))" and the result is:

$:> python2 utils/update_translation_stats.py 
Fetching translation stats .
ERROR: Invalid line in pocount output:
\x1b[95m/home/kaputtnik/Quellcode/widelands-repo/translation_stats/po/map_the_green_plateau.wmf/la.po\x1b[0m
 source words: total: 438\t| 
\x1b[92m438\x1b[0mt\t\x1b[93m0\x1b[0mf\t\x1b[91m0\x1b[0mu\t| 
\x1b[92m100.0%\x1b[0mt\t\x1b[93m0.0%\x1b[0mf\t\x1b[91m0.0%\x1b[0mu

So tabs are there plus escape sequences showing colored output.
-- 
https://code.launchpad.net/~widelands-dev/widelands/translation_stats/+merge/332029
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/translation_stats.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/read_changelog_utf8 into lp:widelands-website

[kaputtnik]

Testet also encyclopedia and documentation: All works fine.

Merged and deployed.
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/read_changelog_utf8/+merge/332990
Your team Widelands Developers is subscribed to branch lp:widelands-website.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/read_changelog_utf8 into lp:widelands-website

[kaputtnik]

Thanks :-)

I guess encoding failures for the encyclopedia and the documentation may rise 
up when wlmap_map_object_info (encyclopedia) or extract_rst.py (documentation) 
ran.

Will try to test it, before merging this :-)
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/read_changelog_utf8/+merge/332990
Your team Widelands Developers is subscribed to branch lp:widelands-website.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/media_cleanup into lp:widelands-website

[kaputtnik]

Regarding the TODO: The file pybb/inlines/post.html is currently not used. So 
for this cleanup-branch it may had to be removed. I decided to leave it and use 
it in future, for template inheritance: 
https://docs.djangoproject.com/en/1.8/ref/templates/language/#template-inheritance

Regarding lowercase: I decided to use only lowercase filenames for all images 
(like for all files) to have a consistent naming schema.

Thanks for the review :-)
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/media_cleanup/+merge/333088
Your team Widelands Developers is subscribed to branch lp:widelands-website.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/read_changelog_utf8 into lp:widelands-website

[noreply]

The proposal to merge lp:~widelands-dev/widelands-website/read_changelog_utf8 
into lp:widelands-website has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/read_changelog_utf8/+merge/332990
-- 
Your team Widelands Developers is subscribed to branch lp:widelands-website.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1728006 into lp:widelands

[TiborB]

Good catch:) Removed...
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1728006/+merge/333094
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1728006 into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/media_cleanup into lp:widelands-website

[kaputtnik]

Merged and deployed.
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/media_cleanup/+merge/333088
Your team Widelands Developers is subscribed to branch lp:widelands-website.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/media_cleanup into lp:widelands-website

[noreply]

The proposal to merge lp:~widelands-dev/widelands-website/media_cleanup into 
lp:widelands-website has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/media_cleanup/+merge/333088
-- 
Your team Widelands Developers is subscribed to branch lp:widelands-website.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_variables_rework into lp:widelands

[TiborB]

I am going to use [] in my next branch I have in my head. And also current 
iterators can be reworked to [] if I was in a mood :)

I looked at the deque issue. First, all those deques are "iterated" - a member 
is moved from one side to another, but yes, on some of them also "remove in the 
middle" is done. When I look at biggest ones, it looks like:

std::deque buildable_fields:  rotating
std::deque mineable_fields:rotating
std::deque unusable_fields:   rotating

So these are only front/back manipulated

std::deque flags:  rotating, remove in the middle
std::deque roads:  rotating, remove in the middle
std::deque new_flags:  rotating, remove in the middle

Yes, here some removing in the middle is done. But rotating is regular (every X 
seconds Y members are rotated). Removing from the middle is as needed (e.g. 
teritory dissapears so roads and flags are gone)

So this is not such conclusive as you think... 

I saw some benchmarks comparing various operations on vector, list and deque 
and deque was not that bad at all and usually significantly faster than list
-- 
https://code.launchpad.net/~widelands-dev/widelands/ai_variables_rework/+merge/333041
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/ai_variables_rework into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_small_requests into lp:widelands

[TiborB]

I removed the variable altogether. I am bit surprised that it is not needed

What testing do you mean?
-- 
https://code.launchpad.net/~widelands-dev/widelands/ai_small_requests/+merge/332519
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/ai_small_requests.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/read_changelog_utf8 into lp:widelands-website

[kaputtnik]

Oh, and i had a look at the encoding of the database tables and columns 
(possibly again). It's all utf8 :-)
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/read_changelog_utf8/+merge/332990
Your team Widelands Developers is subscribed to branch lp:widelands-website.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_variables_rework into lp:widelands

[GunChleoc]

Are you using the []? If not, the bonus doesn't gain you anything ;)

What I'm looking at is the performance loss when deleting elements from the 
queue, because you're not using it as a queue - queues are there so you can 
push and pop, so deleting is much more efficient with lists. Please have a look 
if you really need to do all that iteration over the container just to delete 
an element - the iteration might actually lose you what you are trying to gain 
here.
-- 
https://code.launchpad.net/~widelands-dev/widelands/ai_variables_rework/+merge/333041
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/ai_variables_rework into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1728006 into lp:widelands

[GunChleoc]

You should get rid of kPureProducer. Looks good to me otherwise. Not tested yet.

Diff comments:

> === modified file 'src/ai/ai_help_structs.h'
> --- src/ai/ai_help_structs.h  2017-09-29 16:10:25 +
> +++ src/ai/ai_help_structs.h  2017-11-01 20:33:48 +
> @@ -78,6 +78,8 @@
>   kUpgradeExtends,
>   kLogRefiner,
>   kIronMine,
> + kPureProducer,

kPureProducer is not used anywhere, you can delete it.

> + kSupportingProducer,
>  };
>  
>  enum class AiType : uint8_t { kVeryWeak, kWeak, kNormal };
> 
> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc   2017-09-29 16:10:25 +
> +++ src/ai/defaultai.cc   2017-11-01 20:33:48 +
> @@ -698,6 +698,15 @@
>   bo.positions.push_back(temp_position.first);
>   }
>  
> + // If this is a producer, does it act also as supporter?
> + if (!bo.outputs.empty()) {
> + if (bo.production_hints.empty()) {
> + 
> bo.set_is(BuildingAttribute::kPureProducer);
> + } else {
> + 
> bo.set_is(BuildingAttribute::kSupportingProducer);
> + }
> + }
> +

if (!bo.outputs.empty() && !bo.production_hints.empty()) {
bo.set_is(BuildingAttribute::kSupportingProducer);
}

Then get rid of the pure producer - you're not using it anywhere.

>   iron_ore_id = tribe_->ironore();
>  
>   if (bo.type == BuildingObserver::Type::kMine) {


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1728006/+merge/333094
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1728006 into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_small_requests into lp:widelands

[GunChleoc]

Review: Approve

Code LGTM, just 1 tiny nit. Does this still need testing for the seafaring 
buildings?

Diff comments:

> 
> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc   2017-09-29 16:10:25 +
> +++ src/ai/defaultai.cc   2017-10-19 19:37:15 +
> @@ -4291,7 +4302,8 @@
>  // dismantle
>  BuildingNecessity DefaultAI::check_building_necessity(BuildingObserver& bo,
>const PerfEvaluation 
> purpose,
> -  const uint32_t 
> gametime) {
> +  const uint32_t 
> gametime,
> +  const bool 
> seafaring_map) {

Call this seafaring_economy for consistency

>  
>   bo.primary_priority = 0;
>  


-- 
https://code.launchpad.net/~widelands-dev/widelands/ai_small_requests/+merge/332519
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/ai_small_requests.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/read_changelog_utf8 into lp:widelands-website

[GunChleoc]

Review: Approve

We might get some in the documentation and the encyclopedia as well? Basically, 
anything that uses Widelands as a backend.

Code LGTM, ship it :)
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/read_changelog_utf8/+merge/332990
Your team Widelands Developers is subscribed to branch lp:widelands-website.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1728006 into lp:widelands

[GunChleoc]

The proposal to merge lp:~widelands-dev/widelands/bug-1728006 into lp:widelands 
has been updated.

Commit Message changed to:

Add support for productionsites that are also supporting site to the AI.

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1728006/+merge/333094
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1728006 into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-uuid into lp:widelands

[GunChleoc]

Looks mostly OK - I have added some nits.

We should test to make sure that 2 Widelands instances can be run from the same 
computer and join the same game. I need to figure out how to run a metaserver.

Diff comments:

> 
> === modified file 'src/network/internet_gaming.cc'
> --- src/network/internet_gaming.cc2017-08-16 04:31:56 +
> +++ src/network/internet_gaming.cc2017-10-14 06:58:24 +
> @@ -416,19 +405,24 @@
>   if (state_ == CONNECTING) {
>   if (cmd == IGPCMD_LOGIN) {
>   // Clients request to login was granted
> - clientname_ = packet.string();
> + std::string assigned_name = packet.string();
> + if (clientname_ != assigned_name) {
> + format_and_add_chat("", "", true,
> + (boost::format(
> + _("You logged in as '%s' since 
> your requested name is already in use or reserved."))

You have been logged in...

> + % assigned_name).str());
> + }
> + clientname_ = assigned_name;
>   clientrights_ = packet.string();
> + if (clientrights_ == INTERNET_CLIENT_UNREGISTERED) {
> + // Might happen that we log in with less rights 
> than we wanted to.
> + // Happens when we are already logged in with 
> another client.
> + reg_ = false;
> + }
>   state_ = LOBBY;
>   log("InternetGaming: Client %s logged in.\n", 
> clientname_.c_str());
>   return;
>  
> - } else if (cmd == IGPCMD_RELOGIN) {
> - // Clients request to relogin was granted
> - state_ = LOBBY;
> - log("InternetGaming: Client %s relogged in.\n", 
> clientname_.c_str());
> - format_and_add_chat("", "", true, _("Successfully 
> reconnected to the metaserver!"));
> - return;
> -
>   } else if (cmd == IGPCMD_ERROR) {
>   std::string errortype = packet.string();
>   if (errortype != "LOGIN" && errortype != "RELOGIN") {
> @@ -451,9 +445,8 @@
>  cmd.c_str());
>   }
>   }
> -
>   try {
> - if (cmd == IGPCMD_LOGIN || cmd == IGPCMD_RELOGIN) {
> + if (cmd == IGPCMD_LOGIN) {// || cmd == IGPCMD_RELOGIN) {

Remove commented out code

>   // Login specific commands but not in CONNECTING 
> state...
>   log("InternetGaming: Received %s cmd although client is 
> not in CONNECTING state.\n",
>   cmd.c_str());
> @@ -766,6 +759,10 @@
>  
>  /// ChatProvider: sends a message via the metaserver.
>  void InternetGaming::send(const std::string& msg) {
> + // TODO(Notabilis): Messages can get lost when we are temporarily 
> disconnected from the metaserver,
> + // even when we reconnect again. "Answered" messages like 
> IGPCMD_GAME_CONNECT are resend but chat

resend -> resent

> + // messages are not. Resend them after some time when we did not 
> received the matching IGPCMD_CHAT

received -> receive

> + // command from the server?
>   if (!logged_in()) {
>   format_and_add_chat(
>  "", "", true, _("Message could not be sent: You are not 
> connected to the metaserver!"));
> @@ -777,6 +774,7 @@
>  
>   if (msg.size() && *msg.begin() == '@') {
>   // Format a personal message
> + // TODO(Notabilis): msg should be trimmed before checking for 
> the space character

You can do that right now with boost::trim. Include 
 for that.

>   std::string::size_type const space = msg.find(' ');
>   if (space >= msg.size() - 1) {
>   format_and_add_chat(
> @@ -834,6 +832,7 @@
>   SendPacket m;
>   m.string(IGPCMD_ANNOUNCEMENT);
>   m.string(arg);
> + // NOCOM(Notabilis): This looks like a bug to me

Can you be a bit more specific? We shouldn't have NOCOM stuff in trunk.

>   net->send(s);
>   return;
>   } else
> 
> === modified file 'src/network/internet_gaming.h'
> --- src/network/internet_gaming.h 2017-07-01 08:22:54 +
> +++ src/network/internet_gaming.h 2017-10-14 06:58:24 +
> @@ -57,10 +57,12 @@
>   void reset();
>  
>   // Login and logout
> + // pwd should contain either the password for a registered account or 
> the UUID otherwise
>   void initialize_connection();
>   bool login(const std::string& nick,
>  const std::string& pwd,
>  bool registered,
> +  

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/dynamic_tribe_loading into lp:widelands

[bunnybot]

Continuous integration builds have changed state:

Travis build 2739. State: failed. Details: 
https://travis-ci.org/widelands/widelands/builds/296435108.
Appveyor build 2551. State: failed. Details: 
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_dynamic_tribe_loading-2551.
-- 
https://code.launchpad.net/~widelands-dev/widelands/dynamic_tribe_loading/+merge/329198
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/dynamic_tribe_loading.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1687100-reveal_fields into lp:widelands

[bunnybot]

Continuous integration builds have changed state:

Travis build 2731. State: passed. Details: 
https://travis-ci.org/widelands/widelands/builds/295910371.
Appveyor build 2543. State: failed. Details: 
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1687100_reveal_fields-2543.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1687100-reveal_fields/+merge/323721
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1687100-reveal_fields.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1727673 into lp:widelands

[GunChleoc]

I tested with a game I created myself, by building an expedition port on my own 
island and quickly connecting a road to a nearby warehouse. Two Lagoons is a 
good map for that.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1727673/+merge/332945
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1727673 into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/dynamic_tribe_loading into lp:widelands

[GunChleoc]

Making the Lua code prettier does not work - it will give me a crash with 
unknown function.

Diff comments:

> === modified file 'data/tribes/init.lua'
> --- data/tribes/init.lua  2017-02-12 09:10:57 +
> +++ data/tribes/init.lua  2017-09-03 11:19:20 +
> @@ -11,12 +11,33 @@
>  --
>  -- Basic load order (first wares, then immovables etc.) is important,
>  -- because checks will be made in C++.
> --- Also, enhanced/upgraded units need to come before their basic units.
>  --
>  
>  tribes = wl.Tribes()
>  include "scripting/mapobjects.lua"
>  
> +-- Load all init.lua files in the given table of directory names
> +function load_directories(directories)
> +   -- Helper function to check for file name endings
> +   function string.ends(haystack, needle)
> +  return needle == '' or string.sub(haystack, -string.len(needle)) == 
> needle
> +   end
> +
> +   while #directories > 0 do
> +  local filepath = directories[1]
> +  table.remove(directories, 1)

I tried and it gave me a nice big crash with unknown function.

> +  if path.is_directory(filepath) then
> + for idx, listed_path in ipairs(path.list_directory(filepath)) do
> +if path.is_directory(listed_path) then
> +   table.insert(directories, listed_path)
> +elseif string.ends(listed_path , "init.lua") then
> +   include(listed_path)
> +end
> + end
> +  end
> +   end
> +end
> +
>  print("┏━ Running Lua for tribes:")
>  
>  print_loading_message("┗━ took", function()


-- 
https://code.launchpad.net/~widelands-dev/widelands/dynamic_tribe_loading/+merge/329198
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/dynamic_tribe_loading.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

[GunChleoc]

Can you switch on the alpha site again?
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605
Your team Widelands Developers is subscribed to branch lp:widelands-website.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

[kaputtnik]

Its already running.
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605
Your team Widelands Developers is subscribed to branch lp:widelands-website.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/media_cleanup into lp:widelands-website

[GunChleoc]

Review: Approve

I don't get the "TODO (Franku): use" comment on the bottom. Id the change in 
LOGO_FILE = 'logo_alpha.png' intentional?

LGTM otherwise :)
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/media_cleanup/+merge/333088
Your team Widelands Developers is subscribed to branch lp:widelands-website.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1728006 into lp:widelands

[bunnybot]

Continuous integration builds have changed state:

Travis build 2740. State: passed. Details: 
https://travis-ci.org/widelands/widelands/builds/296462194.
Appveyor build 2552. State: failed. Details: 
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1728006-2552.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1728006/+merge/333094
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1728006 into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp