My version of translate-toolkit is 2.2.5-1.
Pulled your changes but no change:
$:> python2 utils/update_translation_stats.py
Fetching translation stats .
ERROR: Invalid line in pocount output:
Testet also encyclopedia and documentation: All works fine.
Merged and deployed.
--
https://code.launchpad.net/~widelands-dev/widelands-website/read_changelog_utf8/+merge/332990
Your team Widelands Developers is subscribed to branch lp:widelands-website.
Thanks :-)
I guess encoding failures for the encyclopedia and the documentation may rise
up when wlmap_map_object_info (encyclopedia) or extract_rst.py (documentation)
ran.
Will try to test it, before merging this :-)
--
Regarding the TODO: The file pybb/inlines/post.html is currently not used. So
for this cleanup-branch it may had to be removed. I decided to leave it and use
it in future, for template inheritance:
https://docs.djangoproject.com/en/1.8/ref/templates/language/#template-inheritance
Regarding
The proposal to merge lp:~widelands-dev/widelands-website/read_changelog_utf8
into lp:widelands-website has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/read_changelog_utf8/+merge/332990
--
Your team
Good catch:) Removed...
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1728006/+merge/333094
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1728006 into lp:widelands.
___
Mailing
Merged and deployed.
--
https://code.launchpad.net/~widelands-dev/widelands-website/media_cleanup/+merge/333088
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to
The proposal to merge lp:~widelands-dev/widelands-website/media_cleanup into
lp:widelands-website has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/media_cleanup/+merge/333088
--
Your team Widelands
I am going to use [] in my next branch I have in my head. And also current
iterators can be reworked to [] if I was in a mood :)
I looked at the deque issue. First, all those deques are "iterated" - a member
is moved from one side to another, but yes, on some of them also "remove in the
I removed the variable altogether. I am bit surprised that it is not needed
What testing do you mean?
--
https://code.launchpad.net/~widelands-dev/widelands/ai_small_requests/+merge/332519
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_small_requests.
Oh, and i had a look at the encoding of the database tables and columns
(possibly again). It's all utf8 :-)
--
https://code.launchpad.net/~widelands-dev/widelands-website/read_changelog_utf8/+merge/332990
Your team Widelands Developers is subscribed to branch lp:widelands-website.
Are you using the []? If not, the bonus doesn't gain you anything ;)
What I'm looking at is the performance loss when deleting elements from the
queue, because you're not using it as a queue - queues are there so you can
push and pop, so deleting is much more efficient with lists. Please have a
You should get rid of kPureProducer. Looks good to me otherwise. Not tested yet.
Diff comments:
> === modified file 'src/ai/ai_help_structs.h'
> --- src/ai/ai_help_structs.h 2017-09-29 16:10:25 +
> +++ src/ai/ai_help_structs.h 2017-11-01 20:33:48 +
> @@ -78,6 +78,8 @@
>
Review: Approve
Code LGTM, just 1 tiny nit. Does this still need testing for the seafaring
buildings?
Diff comments:
>
> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc 2017-09-29 16:10:25 +
> +++ src/ai/defaultai.cc 2017-10-19 19:37:15 +
> @@ -4291,7
Review: Approve
We might get some in the documentation and the encyclopedia as well? Basically,
anything that uses Widelands as a backend.
Code LGTM, ship it :)
--
https://code.launchpad.net/~widelands-dev/widelands-website/read_changelog_utf8/+merge/332990
Your team Widelands Developers is
The proposal to merge lp:~widelands-dev/widelands/bug-1728006 into lp:widelands
has been updated.
Commit Message changed to:
Add support for productionsites that are also supporting site to the AI.
For more details, see:
Looks mostly OK - I have added some nits.
We should test to make sure that 2 Widelands instances can be run from the same
computer and join the same game. I need to figure out how to run a metaserver.
Diff comments:
>
> === modified file 'src/network/internet_gaming.cc'
> ---
Continuous integration builds have changed state:
Travis build 2739. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/296435108.
Appveyor build 2551. State: failed. Details:
Continuous integration builds have changed state:
Travis build 2731. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/295910371.
Appveyor build 2543. State: failed. Details:
I tested with a game I created myself, by building an expedition port on my own
island and quickly connecting a road to a nearby warehouse. Two Lagoons is a
good map for that.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1727673/+merge/332945
Your team Widelands Developers is
Making the Lua code prettier does not work - it will give me a crash with
unknown function.
Diff comments:
> === modified file 'data/tribes/init.lua'
> --- data/tribes/init.lua 2017-02-12 09:10:57 +
> +++ data/tribes/init.lua 2017-09-03 11:19:20 +
> @@ -11,12 +11,33 @@
> --
>
Can you switch on the alpha site again?
--
https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list:
Its already running.
--
https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list:
Review: Approve
I don't get the "TODO (Franku): use" comment on the bottom. Id the change in
LOGO_FILE = 'logo_alpha.png' intentional?
LGTM otherwise :)
--
https://code.launchpad.net/~widelands-dev/widelands-website/media_cleanup/+merge/333088
Your team Widelands Developers is subscribed to
Continuous integration builds have changed state:
Travis build 2740. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/296462194.
Appveyor build 2552. State: failed. Details:
25 matches
Mail list logo
