Hans Joachim Desserud has proposed merging lp:~hjd/widelands/typos-n-stuff into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Fixed some small typos.
--
https://code.launchpad.net/~hjd/widelands/typos-n-stuff/+merge/37342
Your team Widelands Developers is requested
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/bug582905 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
The initial fix for this problem added the ability to build a fisher's hut.
This patch will additionally add a fisher to the HQ, and edite
The proposal to merge lp:~hjd/widelands/bug582905 into lp:widelands has been
updated.
Description changed to:
The initial fix for this problem (bug 582905) added the ability to build a
fisher's hut.
This patch will additionally add a fisher to the HQ, and edited the map a bit
so there is fish
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/bug682405 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
#682405 Some variables are not translatable
https://bugs.launchpad.net/bugs/682405
Note:this is more of a request for feedback
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/atlantean-miller
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/atlantean-miller/+merge/45998
The current description of the Atlantean
> Oh, I forgot: please test this branch before we merge it to trunk. We should
> get linux and windows testing at the very least.
Linux testing (Ubuntu 10.10 + Arch):
The list of locales is shown.
Selecting System language works.
Switching from one locale to another works. However, selecting a lan
>I can confirm, that it works with Ubuntu (except for the selection of
>uninstalled languages, but this >should be no problem).
I'd preferably like to see this fixed before the branch is merged, as it is a
somewhat strange regression. Out of curiosity I checked Wesnoth earlier today,
and I was a
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/bug717749 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
#717749 Fire tongs are the tool(s) of the smelter
https://bugs.launchpad.net/bugs/717749
For more details, see:
https
Everything seems to be working as expected on Arch (and Ubuntu as well): a long
list of languages is shown, switching to installed/not installed language
works, changing the config-file works.
Thanks for fixing languages without installed locale!
I wonder if bug 642853 and bug 642854 should be
Hans Joachim Desserud has proposed merging
lp:~hjd/widelands/remove-unused-variables into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/remove-unused-variables/+merge/50468
Removed a few unused variables
FWIW, here's the warnings:
/home/user/widelands/src/ai/defaultai.cc: In member function ‘bool
DefaultAI::check_mines(int32_t)’:
/home/user/widelands/src/ai/defaultai.cc:1794: warning: unused variable ‘en_bo’
/home/user/widelands/src/scripting/lua_game.cc: In member function ‘int
LuaGame::L_Player
Hans Joachim Desserud has proposed merging lp:~hjd/widelands-website/valid-css
into lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands-website/valid-css/+merge/53853
Fixes some errors in the .css
Hans Joachim Desserud has proposed merging
lp:~hjd/widelands/fix-partly-translatable-sentences into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #73 in widelands: "Two sentences in game tips are only partly
translatable&quo
The proposal to merge lp:~hjd/widelands/fix-partly-translatable-sentences into
lp:widelands has been updated.
Description changed to:
Wraps two sentences in quotation marks in order to mark the entire sentence,
not just parts of it as translatable. For details, see bug 73.
I only uploaded
Committed some more changes, which I just hadn't pushed. There's still 20
warnings left, which I haven't taken a closer look at yet...
--
https://code.launchpad.net/~hjd/widelands-website/valid-css/+merge/53853
Your team Widelands Developers is requested to review the proposed merge of
lp:~hjd/w
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/ware-data into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/ware-data/+merge/63462
The two strings
https://translations.launchpad.net
Hans Joachim Desserud has proposed merging
lp:~hjd/widelands/metalworks-text-bug-734409 into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #734409 in widelands: "Metalworks enhancements i Barbarian tutorial 3
should be rephrased&quo
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/chat-focus into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #795457 in widelands: "The chat window should receive focus automatically"
https://bugs.launchpad.net/widelands/+
Hans Joachim Desserud has proposed merging
lp:~hjd/widelands/savegame-focus-bug-565406 into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #565406 in widelands: "place cursor inside filename field after CTRL+S"
https://bugs.launchpad.net
Hans Joachim Desserud has proposed merging lp:~hjd/widelands-website/break into
lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands-website/break/+merge/69881
Changed to in two places (items under
Hans Joachim Desserud has proposed merging
lp:~hjd/widelands/adding-barriers-bug-787508 into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/adding-barriers-bug-787508/+merge/70653
When strongholds were
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/capital-Random
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #722757 in widelands: "Play as a random tribe"
https://bugs.launchpad.net/widelands/+bug/722757
Bug
(closing this review since the branch has already been merged to keep it from
showing up in the list of active reviews)
--
https://code.launchpad.net/~nomeata/widelands/buttons/+merge/81338
Your team Widelands Developers is requested to review the proposed merge of
lp:~nomeata/widelands/buttons
The proposal to merge lp:~nomeata/widelands/buttons into lp:widelands has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~nomeata/widelands/buttons/+merge/81338
--
https://code.launchpad.net/~nomeata/widelands/buttons/+merge/81338
Your team Wi
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/typo-promises into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/typo-promises/+merge/83526
Fixed a typo.
--
https://code.launchpad.net/~hjd
Hans Joachim Desserud has proposed merging lp:~hjd/widelands-website/bug892235
into lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #892235 in Widelands Website: "dependencies for buiding the website
locally is not complete&quo
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/bug899161 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #899161 in widelands: "missing whitespace require translating the almost
same map description multiple times&quo
Hans Joachim Desserud has proposed merging lp:~hjd/widelands-website/irc-help
into lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands-website/irc-help/+merge/85227
Adds a few tips for people who are
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/button-order into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #902765 in widelands: "Show buttons in the bottom toolbar in the same
order, also for spectators&quo
Hi, thanks for finding/fixing all these typos :)
I'm curious, do you have some specific strategy for finding them, or are you
simply going through the translatable strings on
https://translations.launchpad.net/widelands?
--
https://code.launchpad.net/~alocritani/widelands/translations_typos/+me
Hans Joachim Desserud has proposed merging lp:~hjd/widelands-website/bzr-branch
into lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands-website/bzr-branch/+merge/89541
--
https://code.launchpad.net
I am not sure how feasible this is, so feel free to ignore my comment.
That said, it would be nice if a test suite was added at the same time
as the reimplementation so that we could make sure it was working and
spot regressions. From remember from previous discussion, the current
test coverage is
As I said, I wasn't sure how easy it would be. It just seemed like a
nice opportunity to add tests to one of the important components. Like
SirVer mentioned, I imagined something like running a local server and
seeing if that responds in the expected way would be the easist way.
(Mocking [1] might
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/minor-python-fix
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/minor-python-fix/+merge/91578
Removes an unreachable line in the
Oh, I see various commits create a lot of noise in the view below. Please see
http://bazaar.launchpad.net/~hjd/widelands/help-strings-consistent/revision/6336
instead.
--
https://code.launchpad.net/~hjd/widelands/help-strings-consistent/+merge/99205
Your team Widelands Developers is requested to
Hans Joachim Desserud has proposed merging
lp:~hjd/widelands/help-strings-consistent into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/help-strings-consistent/+merge/99376
Hello. While looking at the
The more I think about this, the 80k+ lines patch seems wrong. Therefore I have
created a merge proposal against trunk instead
(https://code.launchpad.net/~hjd/widelands/help-strings-consistent/+merge/99376)
which if merged, can be merged from trunk to this branch in the future.
I'm sorry about
The proposal to merge lp:~hjd/widelands/help-strings-consistent into
lp:~widelands-dev/widelands/help_content has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~hjd/widelands/help-strings-consistent/+merge/99205
--
https://code.launchpad.ne
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/optimizations into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/optimizations/+merge/101116
I ran utils/create_cppcheck_report and saw it
Ok, thanks. :) I've pushed some more changes now. Some comments:
If we have a check as part of the stylechecker for this, then I think someone
should check whether that still works and is run.
How can logic/building.cc:686 ever be called when the if has the same check as
the while loop above?
>There is a break statement in the while loop which will terminate the
loop. So this is valid.
Oh, right. I have to admit I only skimmed this section.
--
https://code.launchpad.net/~hjd/widelands/optimizations/+merge/101116
Your team Widelands Developers is requested to review the proposed merge
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/assert into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #986611 in widelands: "Issues reported by cppcheck"
https://bugs.launchpad.net/widelands/+bug/986611
For more de
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/sentence into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/sentence/+merge/103341
Fix minor typos and use of capital letters.
Waited until
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/fun-typo into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/fun-typo/+merge/104018
Changed Smugglers description to have fun with lower case
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/cppcheck-report
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/cppcheck-report/+merge/104020
Various improvements to the
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/checkbox-light
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #986534 in widelands: "Improve in-game checkboxes"
https://bugs.launchpad.net/widelands/+bug/986534
For mo
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/more-empty-fixes
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #986611 in widelands: "Issues reported by cppcheck"
https://bugs.launchpad.net/widelands/+bug/986611
For mo
Hans Joachim Desserud has proposed merging
lp:~hjd/widelands-website/updated-installation-instructions into
lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands-website/updated-installation-instructions
Hans Joachim Desserud has proposed merging
lp:~hjd/widelands-website/simplified-installation-instructions into
lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands-website/simplified-installation
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/class-rendertarget
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/class-rendertarget/+merge/141518
Consistently refer to RenderTarget as a
Hans Joachim Desserud has proposed merging
lp:~hjd/widelands/compilation-warnings into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1033615 in widelands: "Consider checking for more warnings when
compiling Widelands with WL_EXTRAWARNINGS&quo
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/recruited-typo
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/recruited-typo/+merge/142011
Spotted this typo on the loading screen. Could
Nice to see someone tackling the remaining warnings. :)
I leave reviewing the code to someone better suited for the task, but here's a
few comments:
Could you elaborate a bit more on the warnings which are silenced? For minizip
and similar I fully understand since we don't want to diverge from
Awesome.
> only done where no code change was desirable (..) or possible
Fair enough. I won't really expect anyone to track down and fix issues
triggered by third party software.
>Here is a thread from the original author, Jonathan Wakely,
Nice. Based on the attribution link, it did seem like
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/class-FileSystem
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #913369 in widelands: "Warnings at compile-time (clang/llvm)"
https://bugs.launchpad.net/widelands/+bug/9
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/main-menu-year
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/main-menu-year/+merge/142918
--
https://code.launchpad.net/~hjd/widelands
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/warnings into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1033615 in widelands: "Consider checking for more warnings when
compiling Widelands with WL_EXTRAWARNINGS&quo
Yes, they will be used by default, of course assuming the compiler supports
them.
For instance, take the string "-Wlogical-op -Wsync-nand -Wtrampolines". If you
check this against a compiler which doesn't support -Wlogical-op, the check
will fail so none of the options are added. This happens e
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/class-building
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/class-building/+merge/148830
A single instance referring to Building as a
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/more-warnings into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1033615 in widelands: "Consider checking for more warnings when
compiling Widelands"
https://bugs.lau
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/scan-build-script
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/scan-build-script/+merge/173948
Adds a script to run scan-build static
Hans Joachim Desserud has proposed merging
lp:~hjd/widelands/scan-build-script-paths into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/scan-build-script-paths/+merge/174606
After thinking about the talk
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/bug1095022 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1095022 in widelands: "Division by zero in ui_basic/slider.cc"
https://bugs.launchpad.net/widelands/+bug/1095022
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/bug1201330 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1201330 in widelands: "Dangerous variable-length array (VLA) declaration
in map_generator.cc"
https://bugs.lau
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/scan-build-cmake
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/scan-build-cmake/+merge/175269
Yesterday I learnt that it is sufficient to
The proposal to merge lp:~hjd/widelands/scan-build-cmake into lp:widelands has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~hjd/widelands/scan-build-cmake/+merge/175269
--
https://code.launchpad.net/~hjd/widelands/scan-build-cmake/+merge/17
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/prodsite-null into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/prodsite-null/+merge/175538
Found by scan-build. I believe this should fix
Any estimate which compiler versions this change would require at a minimum?
I realize that a) we can't support ancient releases forever and b) a new
release will mainly be packaged in development versions where newer compilers
will be available anyways. Still, we have things like the PPA for s
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/string-fixes into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/string-fixes/+merge/175595
Fixes and improvements for various strings. See
>This should compile nicely in GCC 4.3 I think
>we could get by with GCC 4.5 for a while
Hm, so if it fails to build with GCC 4.6, would you consider that a bug?
Because currently it fails to build at Ubuntu 12.04*. Depending on how hard it
is to fix, I think it would be nice to be able to build
> Could you try again and change c++11
> in the cmake file to read c++0x?
Tried that and it works. Or at least I assume it does; the original error went
away, and the majority of the code compiled without complaints until I ran into
bug 1203121. I'll recheck once that is fixed, but I think that
> Tried that and it works. Or at least I assume it does; the original error went
> away, and the majority of the code compiled without complaints until I ran
> into bug 1203121. I'll recheck once that is fixed, but I think that took care
> of the major issue in this branch.
Update: after manually
Now that bug 1203121 has been fixed, I tried to merge this again, based on
latest trunk. Results:
Builds on Ubuntu 10.04 with GCC 4.4. Just for fun, I tried to install clang2.7
and see what happened, but it didn't even seem to have a clang++ binary?
Anyways, Ubuntu 12.04:
It builds fine with GCC
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/nullptr into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1203492 in widelands: "Fail to build in Ubuntu 10.04 LTS"
https://bugs.launchpad.net/widelands/+bug/1203492
For mo
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/more-stringfixes
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #933747 in widelands: "Text refers to bug #1951113"
https://bugs.launchpad.net/widelands/+bug/933747
For mo
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/menus into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/menus/+merge/177922
Changed various strings a bit.
* Remove 'menu' from th
I saw some strings from this had made their way into the translation templates
when the catalogues were updated. Was that unintential or because this is right
around the corner? Just curious.
--
https://code.launchpad.net/~widelands-dev/widelands/game_end_summary/+merge/176000
Your team Wideland
I'm really happy to see this proposal. I agree there has been too many
regressions lately and I definitely agree an automated test suite will help us
discover and fix these faster. I haven't really looked much at the tests
themselves, but it is really easy and straight-forward to run them at lea
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/cppcheck-fixes
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/cppcheck-fixes/+merge/179580
Fix a couple of issues found by cppcheck
Hans Joachim Desserud has proposed merging
lp:~widelands-dev/widelands/reworked-readme into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1203474 in widelands: "Ingame README needs review"
https://bugs.launchpad.net/widelands/+bug/12
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/unused-variable
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/unused-variable/+merge/180685
Removed an unused variable, since the
Hans Joachim Desserud has proposed merging
lp:~widelands-dev/widelands/new-maps-descriptions into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/new-maps-descriptions/+merge/180688
Various
Removed commas as requested. That sentence is rather long and I would like to
split it up, but I haven't come up with any good alternatives.
Have a nice vacation :)
--
https://code.launchpad.net/~widelands-dev/widelands/new-maps-descriptions/+merge/180688
Your team Widelands Developers is subsc
>Noone forces you to have all in the paragraph translated.
Thanks for the tip. :)
>-- TODO: Btw, looks like neither spaces, tabs nor \t provides whitespace.
>This is a bug in the old renderer.
I thought we were using the new one for campaign dialogs now?
I've now converted the format of the gener
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/noise into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1128024 in widelands: "Some way to silence most of the output"
https://bugs.launchpad.net/widelands/+bug/1128024
Hans Joachim Desserud has proposed merging
lp:~hjd/widelands/readme-daily-builds into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/readme-daily-builds/+merge/195514
The readme mentions nightly builds
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/cppcheck-issues
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #986611 in widelands: "Issues reported by cppcheck"
https://bugs.launchpad.net/widelands/+bug/986611
For mo
Hi, thanks for your work on this. :)
I haven't looked closely at this, but it seems to have fixed the VICTORY/NEW
OBJECTIVES headlines in campaing texts. I think this branch perhaps should be
linked up to bug 835559 (maybe it's even fixed most of the issues), could you
take a look at that?
>-
Hans Joachim Desserud has proposed merging
lp:~hjd/widelands/debian-remove-boost-signals into
lp:~widelands-dev/widelands/debian.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/debian-remove-boost-signals/+merge/200734
>Not sure if this is accurate. Boost signals2 is required to build widelands,
>but it is headers only - i.e. it does not need to be linked in.
Well, for some reason I failed to write down the longer explanation, so that's
understandable. :)
At first I was confused when I saw it was removed from
I just merged it now, so we'll see when the next automatic build is rolled out.
And if something bad happens, it should in any case be trivial to revert.
--
https://code.launchpad.net/~hjd/widelands/debian-remove-boost-signals/+merge/200734
Your team Widelands Developers is subscribed to branch
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/debian-b18rc1 into
lp:~widelands-dev/widelands/debian.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/debian-b18rc1/+merge/207529
This review basically
Nasenbaer: No problem. I figured that might be the case :) I also agree with
your points, so no, I wouldn't have pushed it to the main repo.
SirVer: I spoke with the Debian maintainer (emptty) on IRC yesterday and he
seemed happy with the changes. In fact, modified versions of commit 11 and 12
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/minifixes into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/minifixes/+merge/207803
Various minor fixes, now that code freeze is over
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/debian-b18 into
lp:~widelands-dev/widelands/debian.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/debian-b18/+merge/208464
Merged with the Debian packaging
> again, I have no domain knowledge, so take my opinion with a grain of salt
I understand. :)
I don't know if we have any contributors which can properly review these
changes. I try to do a light review by looking over the changes when I sync
from upstream revisions, but I'm no expert on this e
Try to ping emptty on IRC. He'll likely be able to answer (and maybe even add
the patch upstream). :)
--
https://code.launchpad.net/~qcumber-some/widelands/bug1287241/+merge/209091
Your team Widelands Developers is requested to review the proposed merge of
lp:~qcumber-some/widelands/bug1287241 i
Hans Joachim Desserud has proposed merging
lp:~hjd/widelands/debian-disable-patch into lp:~widelands-dev/widelands/debian.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/debian-disable-patch/+merge/210030
A fix for bug
Ayay capt'n!
I considered pushing this straight to the branch, but I wanted to at least flag
what had happened. Also, when I looked at disabling the daily builds (no need
to run them if they would only fail), they had run a mere hour ago which I
reckoned meant I had a day to get the fix in befo
Hans Joachim Desserud has proposed merging
lp:~widelands-dev/widelands/fix-strings into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fix-strings/+merge/210465
Various stringfixes, and tweaking
1 - 100 of 310 matches
Mail list logo
