Klaus Halfmann has proposed merging
lp:~klaus-halfmann/widelands/feature-NoClangWarn into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~klaus-halfmann/widelands/feature-NoClangWarn/+merge/283521
Added -Wno
Klaus Halfmann has proposed merging
lp:~klaus-halfmann/widelands/bug-1395278-ui_fsmenu into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~klaus-halfmann/widelands/bug-1395278-ui_fsmenu/+merge/284339
Migration from m_
Hello SirVer:
Id like to move the 0.5 * line_width invariant in tesselate_line_strip out of
the loop.
(I tend to optimize all the code I see)
--
Hasi50
> Am 05.02.2016 um 20:19 schrieb SirVer :
>
> If you want to play around a little bit more, go for it. I will not code
> anymore tonight, so
WL crashed on me after I tried to open a games and iternet game I save some
versions ago,
Ill try a new game tomorrow unless this should work?
--
https://code.launchpad.net/~widelands-dev/widelands/beautiful_correct_lines/+merge/284517
Your team Widelands Developers is subscribed to branch
lp:~w
Review: Approve testing
Revied the code and plyed for quit a while,
all fine for me
--
https://code.launchpad.net/~widelands-dev/widelands/beautiful_correct_lines/+merge/284517
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/beautiful_correct_lines.
__
Review: Approve code / compile
Compiles for me,
Manual Review in launchapd was fine,
will play on this branch for some time now.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-base-economy/+merge/285289
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/
Klaus Halfmann has proposed merging
lp:~widelands-dev/widelands/bug-1395278-scripting into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-scripting/+merge/285909
* Switch from m_ to
Hello GunChleoc, I cared for the copyright.
For the type of the player_num / player_index we shoud use the type you
suggested, of course.
But this is
a) out of scope of the original bug.
b) I have no Idea what, especially in LUA, might break.-
We should delegate this to some other ticket.
BTW:
Hmm, clang tell me:
/Users/klaus/develop/widelands-repo/bug-1395278-network/src/io/filesystem/zip_filesystem.cc:549:56:
warning: format specifies type 'wchar_t *' but the argument has type
'const value_type *' (aka 'const char *') [-Wformat]
throw wexception("Failed
Hello Kaputtnick:
I just review that code, you wrote:
> Is there something specific to look at?
I think we should do tests in the „real world“ with different FPS seconds and a
real
Network jitter. SirVers approach feels correct to me, but I am not sure is this
may have adverse effects, as the g
Hello SirVer:
Id propose a small change, mostly comments only
=== modified file 'src/ui_basic/panel.cc'
--- src/ui_basic/panel.cc 2016-02-13 19:17:06 +
+++ src/ui_basic/panel.cc 2016-02-14 11:20:39 +
@@ -148,9 +148,10 @@
// Panel-specific startup code. This might call
A test with TinoM palying on Impact with an AI, failed, going to reprodcu this
--
https://code.launchpad.net/~widelands-dev/widelands/lock_game_logic/+merge/285980
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/lock_game_logic.
Klaus Halfmann has proposed merging
lp:~widelands-dev/widelands/bug-1395278-network into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-network/+merge/285990
Make member variables
Mhh, you canged the semantics:
* now: on Error you do not update anything.
* old: on Error list whre made empty (to indicate the error)
I will play a round with trunk to find how it looks like and then compare wiht
this branch.
--
https://code.launchpad.net/~widelands-dev/widelands/network-memo
Review: Approve
I playes some Atlanters in "the last" bastion without any Hickups,
execpt that the trees so not grow that good in comparioson to r18?
Lets merge this...
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-logic1/+merge/286178
Your team Widelands Developers is subsc
Review: Approve compile / code read
See only harmless renamings here,
will play some games now, but this will take some time
Diff comments:
>
> === modified file 'src/logic/game.cc'
> --- src/logic/game.cc 2016-02-07 07:16:24 +
> +++ src/logic/game.cc 2016-02-16 14:25:27 +
> @@ -1024,4
Pulling the network cable and then trying to go along the internet game gave me:
InternetGaming: reached a timeout for an awaited answer of the metaserver!
InternetGaming: Connecting to the metaserver.
Warning: Verbindungsproblem
Widelands konnte sich nicht zum Metaserver verbinden.
Assertion fai
Review: Approve compile / test
Compiles, did some test with Gun, which foound bug #1542821 but this is the
same in trunk.
Maybe some lists will stay in some other state now, but as of the networking
error there
is no consistent state anyway.
OTOH we get rid of some memory leaks.
Diff comments
Klaus Halfmann has proposed merging
lp:~widelands-dev/widelands/bug-1395278-logic2 into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1395278 in widelands: "Consolidate naming of member variables"
https://bugs.launchpad.net/widelands/+b
Played this for seom 40 Minutes now, had no Problems whatsoever
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-logic2/+merge/287687
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1395278-logic2 into lp:widelands.
__
Klaus Halfmann has proposed merging
lp:~widelands-dev/widelands/bug-1395278-logic3 into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1395278 in widelands: "Consolidate naming of member variables"
https://bugs.launchpad.net/widelands/+b
Played perhas 30 Minutes had no
issues except an annyoing attacking AI :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-logic3/+merge/287827
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1395278-logic3 into lp:wi
Klaus Halfmann has proposed merging
lp:~widelands-dev/widelands/bug-1395278-game_io into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1395278 in widelands: "Consolidate naming of member variables"
https://bugs.launchpad.net/widelands/+b
Review: Approve
Code looks good, still want to play a bit with the Ports on
my https://wl.widelands.org/maps/fjord-ilands2/ map.
And some refactoring toward clean code is always good :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1191556-cancel-expedition/+merge/288375
Your team
Review: Approve
Played this with a lot of Ports and about > 6 Expeditions for some 3 hours.
I found a Problem with the network lobby (crash if Computer went offline
during the game) but that cannot be related to this code.
Compiled it again, but found it is alreday in trunk.
I will stick to rev
See my inline comment.
Diff comments:
> === modified file 'src/logic/map_objects/tribes/dismantlesite.cc'
> --- src/logic/map_objects/tribes/dismantlesite.cc 2016-02-18 18:27:52
> +
> +++ src/logic/map_objects/tribes/dismantlesite.cc 2016-03-13 09:28:07
> +
> @@ -93,7 +94,8 @@
>
Review: Approve
Found only renamings, execpt for one improvement,
fine for me.
Will now play some Artifact hunting for completeness...
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-map_io/+merge/288859
Your team Widelands Developers is subscribed to branch
lp:~widelands-de
The crash happens when you return to the internetlobby, when the computer was
offline meanwhile.
Looks like on of the Nullpointers in the Netowk code hit us. Still it did not
happen yesterday.
I may have to provoke it a bit harder, perhaps.
--
https://code.launchpad.net/~widelands-dev/widelands/
Review: Approve
Found only renamings that are fine with me.
Copiled this and played it a while, found no anomalies.
Diff comments:
> === modified file 'src/io/filesystem/layered_filesystem.cc'
> --- src/io/filesystem/layered_filesystem.cc 2016-02-18 18:27:52 +
> +++ src/io/filesystem/layer
Played this for a while now, found no anomalies.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-editor/+merge/289494
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1395278-editor.
___
Mailing
Review: Approve
Found only intended renamings or improvements,
Added some comments about minor things.
New for me are warnings like:
[ 44%] Building CXX object
src/logic/CMakeFiles/logic.dir/map_objects/tribes/requirements.cc.o
.../bug-1395278-editor/src/logic/map_objects/tribes/requirements.cc:
Ill try to reproduce #1553699 whit this perhaps today ...
--
https://code.launchpad.net/~widelands-dev/widelands/watchwindow-fixes/+merge/289573
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/watchwindow-fixes.
___
M
I am still missing some comments about the basic
workings of this (very sepcial) window. and I have some questions:
* why is uint8_t as index, a plain unsigned int would not make a difference?
* why is there no visual response when adding the last view fails?
I cannot reproduce #1553699 directly
Review: Approve test / compile
Bug #1553699? is fixed with this branch,
just reproduced this on bzr7903[trunk],
and found it fixed it here in bzr7904[watchwindow-fixes]
@Miroslav Remák: thanks for fixing this.
--
https://code.launchpad.net/~widelands-dev/widelands/watchwindow-fixes/+merge/2895
Found a crash after playing archipelago for quite a while,
the game crashed when I quit, but I had not time to check yesterday.
But that should not be related to this branch, I think.
--
https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704
Your team Widelands Developers i
Mhh, I found #1562332 again, but this is yet another other Issue, can someone
elese reproduce this?
--
https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/revised_maps.
Archipelago works for Atlanters, so it should work for pretty every tribe.
Ill try another Map the next days. One of the three AIs
was able to develop at least a bit. You will need horses (ochsen, donkeys)
in the long term however
--
https://code.launchpad.net/~widelands-dev/widelands/revised_map
Review: Approve playing
OK, I tried (got tired) of the nile, I think we should merrge this
now. Next time we should do this for single maps only.
I check some code, but not all, as I have no Idea what to check for.
So lets get his merged so we can check for single problems/bugs later.
If there a
Klaus Halfmann has proposed merging lp:~widelands-dev/widelands/bug-1562332
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1562332 in widelands: "Crash in
FullscreenMenuInternetLobby::fill_client_list"
https://bugs.launchpad.net
Review: Approve compile, review
Looks good to me, with Apple clang I get a lot less warnings.
You removed on break; that looks incorrect, but I am but sure,
see diff comments.
I prepared some changes that would remove some implicit float -> double
warnings, too.
Not sure if I should commit these
Expect a commit in some minutes
Diff comments:
>
> === modified file 'src/ai/ai_help_structs.h'
> --- src/ai/ai_help_structs.h 2016-03-12 20:06:24 +
> +++ src/ai/ai_help_structs.h 2016-04-02 16:49:56 +
> @@ -351,8 +350,8 @@
> uint16_t mines_percent; // % of res it can mine
>
Hello Gun: changes look good to me,
Compiles on OSX without any new Issues.
Will try to play this on trunk today.
(Thanks for playing the Triangle :-)
--
https://code.launchpad.net/~widelands-dev/widelands/travis-clang-warnings/+merge/290697
Your team Widelands Developers is subscribed to branc
I got a crash in
0 widelands 0x00010d0cfa40
FullscreenMenuInternetLobby::fill_client_list(std::__1::vector > const*) + 2336 (vector:641)
1 widelands 0x00010d0cf0e2 FullscreenMenuInternetLobby::think() + 146
(internet_lobby.cc:182)
but this is the same on trunk.
@SirVer I will re
Uhm, the fix for bug-1562332 was somehow reverted, I will add it in this branch
again
--
https://code.launchpad.net/~widelands-dev/widelands/travis-clang-warnings/+merge/290697
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/travis-clang-warnings.
Ready for merge, any objections?
SirVer, can you appove?
--
https://code.launchpad.net/~widelands-dev/widelands/travis-clang-warnings/+merge/290697
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/travis-clang-warnings.
_
Hello Gun, what shall we do with this branch?
the code looks ok, as far as I could check.
As this branch is far away from trunk. we should either merge it
or give it up.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1548932-editor-save-zip/+merge/287036
Your team Widelands Developers
Review: Approve
OK, found only the expected renamings.
OK, Compiles on OSX
I have seen no actual code changes -> Approve
--
https://code.launchpad.net/~widelands-dev/widelands/rename_editor_files/+merge/291093
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/r
perhaps to fast: /
Got a Crash in creating a radom Map 80x80 for 3 players in
Widelands::Map::get_starting_pos(unsigned char) const + 130 (map.h:205)
editor_tool_set_starting_pos_callback(Widelands::TCoords
const&,
--
https://code.launchpad.net/~widelands-dev/widelands/rename_editor_files/+merg
Ah, here is the assertion:
WARNING: Player 1 has no starting position - illegal coordinates (29508, 22202).
WARNING: Player 2 has no starting position - illegal coordinates (-1, -1).
WARNING: Player 1 has no starting position - illegal coordinates (29508, 22202).
WARNING: Player 2 has no starting
Mhh, looks like _setting_ the playerpos succeed but nrplayers is inconsistant,
mmh.
Should be unrelated to this branch.
--
https://code.launchpad.net/~widelands-dev/widelands/rename_editor_files/+merge/291093
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/rena
Looks like you know more about python than I do,
lets check this ...
--
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/python3 into lp:widelands.
___
OK, thas as far as I came, too but now I get
$ ./regression_test.py -b ./widelands
...
File "./regression_test.py", line 103, in run_widelands
stdout_file.write(line)
TypeError: must be str, not bytes
I used
print(line, flush=True)
for
stdout_file.write(line)
stdout_file.flush()
but
Mhh, even using python 2.7 does not work, it just gets stuck in the splasg
screeen?
Was there some change in the Lua Binding?
--
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev
On OSX (with macports) I have 'lua @5.3.1_2 (lang)'. hope this helps
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1543001-eris/+merge/291294
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1543001-eris into lp:widelands.
_
Review: Approve review / test / compile
$ ./regression_test.py -b ./widelands ; ## thats Python 3.4.4
Ran 32 tests in 1018.389s
$ python2.7 ./regression_test.py -b ./widelands
...
Ran 32 tests in 616.502s
Works but Python 3.4.4 was much slower.
Well I used this first so all files where cached
Review: Approve review/compile
Moste of the code is correct, we mave some "Upgrades" form 8bit to 32bit,
that where broken before but got unnoticed, but now they will become visible.
Please check my inline comments
Id really like to have some coverage tool that checks that this code is actually
t
Review: Needs Information
* When setting some options I get:
[] Section [global], key 'depth' not used (did you spell the name correctly?)
[] Section [global], key 'ui_font' not used (did you spell the name correctly?)
[] Section [global], key 'speed_of_new_game' not used (did you spell the name
Review: Needs Fixing regression test
OK, here is the Backtrace,
I think Appvoyer found something similar.
Widelands::EditorGameBase::create_immovable(Widelands::Coords, unsigned char,
Widelands::MapObjectDescr::OwnerType) + 160 (editor_game_base.cc:360)
Widelands::Worker::run_geologist_find(Wide
Review: Approve review/compile/regression testst, playing
OK, all fine now.
I played a savegame for perhaps 15 Minutes, looked all fine
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1545243-plnum-lua/+merge/291481
Your team Widelands Developers is subscribed to branch
lp:~widelands
Review: Approve compile, regressiontest.py +/-
Having more tests is always good and the code looks OK for me.
test-ngettext klaus$ ./regression_test.py -b ./widelands
OTOH Miroslav question is valid, where or when do we need to show someting like
"You have 3.145972 Item(plurals) in you Inventory
Natural Languages normally have no idea about floating point numbers. But they
can use fractions (will be ready in half a minute, can be done in a quarte of
an hour). Some progress messages use phrases like "less then 5 seconds
remaining" or "estimating 20 min for the Installation".
So we shoul
Review: Approve review, compile, test
Fixes the bug and improves variable names, fine.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1560085-save-suggested-teams-display/+merge/291852
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1560085-save
Review: Approve compile / regression / review / check f1-help
Fine for me.
--
https://code.launchpad.net/~widelands-dev/widelands/test-ngettext/+merge/291587
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/test-ngettext.
___
Uhm, to late, already branched it.
/me will try to read first, next time :-)
--
https://code.launchpad.net/~widelands-dev/widelands/fh1_multiline_textarea/+merge/292033
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/fh1_multiline_textarea i
Klaus Halfmann has proposed merging
lp:~widelands-dev/widelands/bug_1571009_work_area_radius into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1571009 in widelands: "Work area radius: 45xxx in bzr7962[trunk]"
https://bugs.lau
Thanks for the hints
Diff comments:
>
> === modified file 'src/scripting/lua_map.cc'
> --- src/scripting/lua_map.cc 2016-04-11 06:45:29 +
> +++ src/scripting/lua_map.cc 2016-04-16 12:42:55 +
> @@ -1871,10 +1871,16 @@
> /* RST
> .. attribute:: workarea_radius
>
> -
hope I fixed the codecheck issues now.
--
https://code.launchpad.net/~widelands-dev/widelands/bug_1571009_work_area_radius/+merge/292066
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug_1571009_work_area_radius into lp:widelands.
___
Whats the Problem with Appveyor?
I did not find the Problem.
Did the build take to long?
Did I cancel it?
--
https://code.launchpad.net/~widelands-dev/widelands/bug_1571009_work_area_radius/+merge/292066
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug_15710
Review: Approve compiled, tested, code review
That was easy, I still do not find my way around in that Internet code.
Thx for fixing this one.
Showing the version was _very_ good idea, too
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1542821-internet-exceptions/+merge/292698
Your
Review: Resubmit
Hello Gun, I reviewd that comment in workarea_info.h again.
Its just that I do not fully understand the usage of that map, yet.
So if you know what stings are used, please add them.
As of the implementation of std:map this will be correct, I guess.
But it usually is a abd idea to
Review: Approve compile, codereview, manual test
Had two computer players play while I watched and saved two times.
When trying to load the game I saw a minimap (terrain only).
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1228811-observer-minimap/+merge/292716
Your team Widelands De
Review: Needs Information codereview, compile
I now get some (new?) clang warning, see inline comments.
Shall I commit the change?
Diff comments:
> === modified file 'src/logic/queue_cmd_factory.cc'
> --- src/logic/queue_cmd_factory.cc2016-01-18 05:12:51 +
> +++ src/logic/queue_cmd_facto
Review: Approve
OK, for me with _my_ change, but gcc may complain again?
--
https://code.launchpad.net/~widelands-dev/widelands/gcc531/+merge/293478
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/gcc531.
___
Mailing
Review: Approve compile, test, code review
Testprotocol -- Testing this was not that easy ...
* bzr7981[bug-1302593-result-screen]
* Playing "Impact" with "Autocrat" as Barbarian versus (no AI)
* Imperial and Atlanters
* Saved as "Test1" before defeating Imperial
* Saved as "Test2" before defeat
Review: Approve compile, play
This was an easy one :-)
--
https://code.launchpad.net/~widelands-dev/widelands/fix_tut1_destroy_quarries/+merge/294699
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_tut1_destroy_quarries.
___
A small nit: After the "you have lost message" I get a last status message,
thats OK.
But it claims "The Game will end in ." instead of perhaps "The games is
finished",
oder "The Game will end in 0 minutes" or even "The game was finished 1 Minute
ago".
It may be ok (for the statistic as well)
Mhh, I am missing some Gold Points in the calcualtions.
every team has som 12 extra point at the beginning that do not sum up.
Is there some resource calculated, but not reported?
I found https://wl.widelands.org/wiki/GameHelpSinglePlayer/
and there Gold is mentioned as well, as every Player sta
About the gold: it does _not_ appear in the status message, thats the bug.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1418154-collectors-teams/+merge/294702
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1418154-collecto
Review: Approve compile, test, codereviw
Ok, statistics are fine now too,
you may still include the gold in the
status message (e.g. I increased my Gold Production
an gained some 100 points this way)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1418154-collectors-teams/+merge/29470
kaputtnik: waht you need is a, so called, headless mode.
Either SDL can provide this (No idea how o do this, thiugh).
Or you can set um some X-Server thats works on some local
Bitmaps, which may be sufficent for your case.
Perhpas it is not needed so set up any graphics fo this case,
but the code
Review: Approve code review, compile, test
Works for me.
The effect may still be void as the trees may have grown again after the port
was placed. (WHich would be some nic tactic to stop a port by some enemy).
--
https://code.launchpad.net/~widelands-dev/widelands/port-clearance/+merge/295236
Review: Approve compile, code review, test
Loogs good for me, played the originl desync now for > 30 minutes on two
network computers.
Will try to do more testing tomorrow
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1581828/+merge/297668
Your team Widelands Developers is subscribe
Review: Approve compile, test, code review
Looks good to me,
compiled and opend all the tables I coud think of and sorted them.
Found no crashes or Anomalies
gcc 5 in travis just needed to long?
Appveyor debug x64: could not read symbols: Memory exhausted.
These are no real Code Problems, can w
Review: Needs Information compile, plase
Uhhm, when testing this I got:
terrain: Terrain 'summer_meadow1' exists in map, not in world!
After loading any saved file. Can we merge in some fix for this?
--
https://code.launchpad.net/~widelands-dev/widelands/seafaring-final-objective/+merge/301060
Review: Needs Information compile, play, codereview
OK, I merged with trunk, which allowed me to load the saved game again.
I now was able to play the tutorial (nice one) till the end, but
the last objective still remains. As of the code I cannot see
how this should happen. Must I start the tutori
Review: Approve compile, play
OK, finally it works.
Now please tell me why that simple code change did this trick.
Can I merge this wia launchpad now, or must someone else do this?
--
https://code.launchpad.net/~widelands-dev/widelands/seafaring-final-objective/+merge/301060
Your team Widelands
Testing on OSX:
* removed .widelands folder
* :bug-1588063$ ./widelands --editor
* Created some random map and saved it
* found ./widelands/maps/My_Maps, OK
* Copied some selfmade map into ./widelands/maps
ls -R maps
Crossriver.wmf My_Maps
maps/My_Maps:
Test1608558.wmf
* I can open Crossriver.w
Review: Approve compile, review, test
OK, Tested some "evil" charaters. On OSX '`´&$()[]{} are allowed while |/":*
are not (incomplete).
Maybe we should filter these as well, to avoid Filenames with bad effects on
the Commandline?
OTOH the average user will not not use such characters, will he/
Code llooks +/- equal for all tribes, lets do some testing.
--
https://code.launchpad.net/~7010622-q/widelands/topple-production-logic-2/+merge/301477
Your team Widelands Developers is requested to review the proposed merge of
lp:~7010622-q/widelands/topple-production-logic-2 into lp:widelands.
I actually did the same (but less sophisticated) for the Raspi
https://wl.widelands.org/forum/topic/2031/
but with some different flags, mmh.
What can I do to test this? (other then waiting for appveyor)
--
https://code.launchpad.net/~widelands-dev/widelands/appveyor_linking_memory/+merge/302275
Review: Approve compile, test
Compiled snd started the "Green Plataue" was not able to choose any player.
(For debugging it wouldbe nice to choose other player via some hidden feature,
perhaps)
--
https://code.launchpad.net/~widelands-dev/widelands/scenario_slots/+merge/304149
Your team Widelan
Review: Approve code review
That code change is straight foreward,
but will some new translations once it is merged. Correct?
I will compile this and then try it in English and German
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1618597/+merge/304464
Your team Widelands Developers
... will need som new translations ...
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1618597/+merge/304464
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1618597.
___
Mailing list: https://launchpad.
Review: Approve test, compile
Works as expected, all German text but the fixed string is in English,
please point me to the translation once this was merged.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1618597/+merge/304464
Your team Widelands Developers is subscribed to branch
lp
Going to test this now (fetched the branch yesterday)
The Code change seems reasonable.
I will check for showstoppers, playability in general.
I personally do not care much about this ordering, well.
Ill start with Atlanters, and play some bigger maps perhaps.
(And check for the Terriotial Lord..
Please wait until this could be tested on OSX.
No idea how the Mapping of the Alt key workds with SDL on OSX yet.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1616661_messagebox_hotkeys/+merge/305381
Your team Widelands Developers is requested to review the proposed merge of
lp:~wi
Review: Approve compile, test
I played Atlanters, Imperial and Barbarian now without a noticabale difference.
lets get this in:
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1618547-wares-queue-order/+merge/304766
Your team Widelands Developers is subscribed to b
OK, about to fetch this, but its a bit late for today ...
--
https://code.launchpad.net/~widelands-dev/widelands/local_functions/+merge/305415
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/local_functions.
___
Maili
Review: Approve compile test
That fixed #1617576 for me, Launchpad does not show me the sources yet,
so Ill try to check the code later.
--
https://code.launchpad.net/~widelands-dev/widelands/local_functions/+merge/305415
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev
Review: Needs Fixing compile, test
This Drodown is missing a feature found in all normal GUIs:
when you click outside the dropdown it will NOT collapse,
allowing the user to click somewhere else.
This implementation will do nothing in this case.
So if I forgot that the Dropdown is open and clic
1 - 100 of 636 matches
Mail list logo
