Review: Approve
test on win32:
- code compiles
- wl finds existing .widelands dir in %Userhome%
- wl creates .widelands if it does not exist
--
https://code.launchpad.net/~nha/widelands/filesystem/+merge/25802
Your team Widelands Developers is requested to review the proposed merge of
lp:~nha/wid
Tino has proposed merging lp:~jarih/widelands/fix-windows-gzz-host into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
#554290 Windows client cannot open a new multiplayer room in the online lobby
https://bugs.launchpad.net/bugs/554290
Allows also
Tino has proposed merging lp:~widelands-dev/widelands/fixbug-669380 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
#669380 win32 binary file is missing wl-icon
https://bugs.launchpad.net/bugs/669380
Don't include the win32 icon to the libra
Review: Needs Fixing win32
I've just tested the branch on win32 (gcc):
Before i started WL, i removed my WL config file.
Widelands starts in German.
The language list in Options shows 2 entries:
- (checked) Verwende Systemsprache, ("Try system language", the german strings
seems somehow truncated
On windows the language list doesn't get populated, it only contains system
default and english, bot options are hardcoded in options.cc line 290ff.
I've tried to debug the way the list should be generated from the files in the
locales dir, but i didn't get it to work.
It seems "g_fs->FindFiles(
Tino has proposed merging lp:~widelands-dev/widelands/win32_glew into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/win32_glew/+merge/50529
The latest OpenGL related changes to Widelands do
Tino has proposed merging lp:~tino79/widelands/gettext018 into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~tino79/widelands/gettext018/+merge/83220
After switching to gettext-0.18 i was no longer able to compile
Updated the branch. Works fine for me with gettext-0.18 and win32.
Does it break on other platforms or with older gettext versions?
--
https://code.launchpad.net/~tino79/widelands/gettext018/+merge/83220
Your team Widelands Developers is requested to review the proposed merge of
lp:~tino79/widel
Ok, next try:
Just change the def for MSVC to WIN32 to be set on both msvc and mingw on
windows.
Works for me and shouldn't break anything...
--
https://code.launchpad.net/~widelands-dev/widelands/gettext018/+merge/83220
Your team Widelands Developers is requested to review the proposed merge of
You have been requested to review the proposed merge of
lp:~hjd/widelands/typo-promises into lp:widelands.
For more details, see:
https://code.launchpad.net/~hjd/widelands/typo-promises/+merge/83526
Fixed a typo.
--
https://code.launchpad.net/~hjd/widelands/typo-promises/+merge/83526
Your team
Review: Approve
--
https://code.launchpad.net/~hjd/widelands/typo-promises/+merge/83526
Your team Widelands Developers is requested to review the proposed merge of
lp:~hjd/widelands/typo-promises into lp:widelands.
___
Mailing list: https://launchpad
I can at least confirm that it compiles fine on win32 and doesn't seem to break
anything...
--
https://code.launchpad.net/~aber/widelands/static/+merge/87053
Your team Widelands Developers is requested to review the proposed merge of
lp:~aber/widelands/static into lp:widelands.
I like it very much, loading times are and feel much reduced on windows.
I've uploaded a win32 build with these changes:
http://widelands.8-schuss.de/Widelands-bzr6373-nomusic-ondemandload-win32.exe
--
https://code.launchpad.net/~qcumber-some/widelands/animations/+merge/104138
Your team Widelands
Tino has proposed merging lp:~tino79/widelands/using_sdl_net_init into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~tino79/widelands/using_sdl_net_init/+merge/141519
On windows you'll have to init winsock befor
It works fine on windows, just noticed:
- If i deactivate OpenGL in the Advanced Options menu->Apply->Apply ->
Widelands quits, not stderr.txt
- If i active OpenGL via Options menu => Back to main menu, but no fonts, only
white bars. I can quit widelands and then the updated config gets written.
Sorry, you are right. The same problem occurs with a trunk build.
I am pretty sure it worked at some point before.
--
https://code.launchpad.net/~nha/widelands/opengl/+merge/147207
Your team Widelands Developers is requested to review the proposed merge of
lp:~nha/widelands/opengl into lp:widelan
Does it compile on win32? => Yes
Does it run on win32? => Yes
Does it show any performance regressions on win32? => No
I am really sorry I can't appreciate better what you have done here. Can't wait
to see this with Nicolai's OpenGL changes and fixes in combined action...
--
https://code.launchp
Review: Needs Fixing
Ok, got it to compile with mingw, but it does not work on windows:
Widelands starts fine but as soon as i click to proceed to the main menu
Widelands just closes.
No output into stderr.txt and stdout.txt just ends after the graphics
initialization part
--
https://code.launc
It seems like a SIGTRAP error as described here:
http://stackoverflow.com/questions/1621059/breakpoints-out-of-nowhere-when-debugging-with-gdb-inside-ntdll
So with "handle SIGTRAP nostop" widelands continues to the main menu.
I can't find the code point in widelands where this happens, will try
Ok, the cuplrit seems to be the truncating in helper.cc::random_string()
buffer[nlen] = '\0';
Afterwards the SIGTRAP occurs at some point when boost tries to delete the
buffer.
I've committed a small change which fixes the code at least for my system.
Perhaps using boost:UUID could replace t
Review: Approve
Ok, i can't trigger any more crashes now, seems to work perfectly.
--
https://code.launchpad.net/~widelands-dev/widelands/graphic_resetting/+merge/159985
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/graphic_resetting.
___
A first quick test: It does not compile on mingw32 with gcc 4.7.2.
At the beginning, gcc fails to find an include (mman.h) in basic_fileread.h:
#ifdef WIN32
#else
#include
#endif
I am completely lost why, because:
- it does not differ from trunk
- it is the else case => should not be
Sorry, it still does not compile with c++0x:
http://pastebin.com/rVV2vvnh
According to http://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html "c++0x"
is deprecated.
I also tried "c++03" :(.
--
https://code.launchpad.net/~widelands-dev/widelands/cxx11/+merge/175455
Your team Widelands Devel
Review: Approve
Ok, i'll give up. I've pushed a simple change wich allows compile this on
mingw-win32.
Longer explanation:
With "std=c++11" mingw also implies strict ANSI mode. This disallows the usage
of certain POSIX functions:
- putenv()
- strdup()
- strcasecmp()
- ...
As I understand we wo
Tino has proposed merging lp:~tino79/widelands/fixbug1204226 into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1204226 in widelands: "FTBFS on Ubuntu 13.04 (use of deleted function
‘void std::unique_ptr<_Tp [], _Dp>::reset(_Up
Review: Approve
Did some updates on windows related stuff and i updated the COPYING file
--
https://code.launchpad.net/~widelands-dev/widelands/bug994712/+merge/176747
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug994712.
_
Tino has proposed merging lp:~widelands-dev/widelands/missing_include_win32
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/missing_include_win32/+merge/186245
Ok, the latest code does only
Tino has proposed merging lp:~widelands-dev/widelands/fix_bug_1232679 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1232679 in widelands: "Construction costs tooltip - Iron icon displaced"
https://bugs.launchpad.net/widelands/+b
Tino has proposed merging lp:~widelands-dev/widelands/fix_bug_1251914 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1251914 in widelands: "soldier stuck in battle animation loop"
https://bugs.launchpad.net/widelands/+bug/1251914
Tino has proposed merging lp:~widelands-dev/widelands/remove_signals into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/remove_signals/+merge/200501
I am proposing to merge this branch before
Tino has proposed merging lp:~widelands-dev/widelands/fix_bug_1271080 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1271080 in widelands: "Deletion of replay files on win32"
https://bugs.launchpad.net/widelands/+bug/1271080
For mo
Tino has proposed merging lp:~tino79/widelands-metaserver/ircbridge into
lp:widelands-metaserver.
Requested reviews:
SirVer (sirver)
For more details, see:
https://code.launchpad.net/~tino79/widelands-metaserver/ircbridge/+merge/203277
A first draft of a irce bridge. Lets the metaserver
Thanks for the comments, of course i only wanted a review, not a merge in the
current state.
This are my first steps with go, so i am just glad that it works at all ;).
- i will add tests
- the irc library handles disconnects itself, and because of the use of a
callback function for irc->lobby i
Ok, channels are in place.
Next up are tests, but first i need to understand go tests. The current tests
starts dozens of server instances in a few seconds, i need to use only one irc
bridge instance for all tests or have to implement my own tests with active irc
bridge.
--
https://code.launchp
The current state is:
- it is working, communication between ircbridge and metaserver via nonblocking
channels
- tests are working, result ok
- no tests regarding the ircbridge itself or communication implemented
I am a bit busy atm, i think i won't have time to implement further test before
nex
Tino has proposed merging lp:~widelands-dev/widelands/handle_tab into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1232392 in widelands: "Allow tabbing in forms"
https://bugs.launchpad.net/widelands/+bug/1232392
For more details,
You are right, i've put back that case distinction.
--
https://code.launchpad.net/~widelands-dev/widelands/handle_tab/+merge/209406
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/handle_tab.
___
Mailing list: https:/
Tino has proposed merging lp:~widelands-dev/widelands/tooltips_fixes into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/tooltips_fixes/+merge/211326
- Allow setting a tooltip for table column
Review: Approve
Ah, ok, I am just going to merge it ;). Trunk is is really evolving atm...
--
https://code.launchpad.net/~widelands-dev/widelands/tooltips_fixes/+merge/211326
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/tooltips_fixes.
_
Review: Resubmit
Ok, perhaps we can merge now?
I does work(tm), only the testcase i've drafted seems to do nothing?
--
https://code.launchpad.net/~widelands-dev/widelands-metaserver/ircbridge/+merge/203277
Your team Widelands Developers is subscribed to branch lp:widelands-metaserver.
__
Tino has proposed merging lp:~widelands-dev/widelands/scriptconsole into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/scriptconsole/+merge/214439
Allow setting the window title for
Review: Resubmit
Refactoring done.
--
https://code.launchpad.net/~widelands-dev/widelands/scriptconsole/+merge/214439
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/scriptconsole.
___
Mailing list: https://launchpad
Hm, that was the wrong review type ^^
--
https://code.launchpad.net/~widelands-dev/widelands/scriptconsole/+merge/214439
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/scriptconsole.
___
Mailing list: https://launchp
I've created a wikipage and a blueprint for further discussion of the
IRCBridge: https://wl.widelands.org/wiki/IrcBridgeImprovements/
Please add comments, request and suggestions. I will try to improve the
handling of the bridge on both client and server side.
--
https://code.launchpad.net/~wid
Review: Approve
Does compile fine on windows and as far as i can see (small sample size), the
distribution of tribes is random.
--
https://code.launchpad.net/~widelands-dev/widelands/fix-random-tribe/+merge/214451
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/wideland
Review: Approve
Sounds good to me ;).
Compiles on win32, will merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1304638-firstfix/+merge/215932
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1304638-firstfix.
I cannot get it to compile, log: http://pastebin.com/g9gquneJ
I am suspecting this could be the solution, but i didn't find a way to include
this into cmake and get rid of the error:
https://svn.boost.org/trac/boost/ticket/9240
--
https://code.launchpad.net/~widelands-dev/widelands/cmake-rework
It does still only compile, but not link on windows.
Output "ninja widelands" : http://pastebin.com/saRVAhHi
Output "ninja" :http://pastebin.com/UhnNmyzj
I've taken the full command and tried to change the linking order in different
ways, but this only changes the linking errors.
--
https://cod
Review: Approve
Nice, it does work now on win32/mingw!
--
https://code.launchpad.net/~widelands-dev/widelands/cmake-reworked/+merge/222455
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/cmake-reworked.
___
Mailing l
Tino has proposed merging lp:~widelands-dev/widelands/test_for_bug1332856 into
lp:~qcumber-some/widelands/bug1332856.
Requested reviews:
Jens Beyer (qcumber-some)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/test_for_bug1332856/+merge/224048
completes the
Review: Needs Fixing
Still shows a box character under Map:->Players:
Tested with "Crossing the horizon"
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1293158/+merge/221434
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1293158.
_
Tino has proposed merging lp:~widelands-dev/widelands/silence_Wpedantic into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/silence_Wpedantic/+merge/224179
Removes all extra ';'
Review: Approve
Ok, i've put Albert's values into the branch.
Not sure if we should test these first or merge the branch and tweak later...
--
https://code.launchpad.net/~widelands-dev/widelands/terrain_affinity/+merge/224045
Your team Widelands Developers is subscribed to branch
lp:~widelands-d
Hey,
it looks better. I've made a small change and now i've only a few errors left,
some of where black pixels are generated (255,555,255) and white expected
(0,0,0).
But still some deviations are so big, that kMax[Alpha|Clr]Distance doesn't make
sense.
Logoutput:
2/4 Testing: test_richtext_
Review: Approve
Compiles, linkes, tests, runs!
*Thumbs up*
--
https://code.launchpad.net/~widelands-dev/widelands/richtext_testing/+merge/225733
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/richtext_testing.
___
M
Review: Approve
LGTM.
I've compiled the code and did a quick check of some new tooltip texts of
buildings
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1348795/+merge/228430
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1348795.
___
Review: Approve
Thumbs up from the dark sideerr, windows side ;)
--
https://code.launchpad.net/~widelands-dev/widelands/glsl/+merge/240363
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/glsl.
___
Mailing list: h
Review: Needs Fixing
Ok, it does not work on windows, even with my "fixes" in
https://code.launchpad.net/~widelands-dev/widelands/glsl1_win32.
Two issues:
- cmake does find OpenGL and defines OPENGL_FOUND,OPENGL_gl_LIBRARY and
OPENGL_glu_LIBRARY but not OPENGL_INCLUDE_DIR and OPENGL_LIBRARIES
-
Review: Approve
Yep, it is working fine now!
Feel free to implement another solution. I am afraid i can't help with the
code, but i can always do builds...
--
https://code.launchpad.net/~widelands-dev/widelands/glsl1/+merge/241179
Your team Widelands Developers is subscribed to branch
lp:~wide
Again: It does compile with mingw and a quick visual check revealed no
graphical errors on my system.
--
https://code.launchpad.net/~widelands-dev/widelands/move_road_texture_out_of_graphics/+merge/242627
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-d
Review: Approve
Windows approves: Does build and toggling fullscreen with "f" works.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_some_resizing_bugs/+merge/242593
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_some_resizing_bugs.
___
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/move_road_texture_out_of_graphics/+merge/242627
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_some_resizing_bugs.
___
Mailing list: https:
Review: Needs Fixing
It does only compile with an additional include, see diff comment.
(Just trying to diff comment the first time ;) )
Diff comments:
> === modified file 'src/editor/editorinteractive.cc'
> --- src/editor/editorinteractive.cc 2014-11-23 14:34:38 +
> +++ src/editor/editori
Switching to fullscreen is now blazing fast, nice!
800x600 window -> 1920x1200
But:
- F11 does only produce black pngs, both in window and fullscreen mode
- The Debug overlay "Position" moves correctly to the down right edge in
fullscreen
- The gamspeed overlay and the chat don't move
--
https:/
Tino has proposed merging lp:~tino79/widelands/fix_screenshots into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1397301 in widelands: "Screenshots black"
https://bugs.launchpad.net/widelands/+bug/1397301
For more details,
Tino has proposed merging lp:~widelands-dev/widelands/fix_screenshots into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1397301 in widelands: "Screenshots black"
https://bugs.launchpad.net/widelands/+bug/1397301
For more details,
The proposal to merge lp:~widelands-dev/widelands/fix_screenshots into
lp:widelands has been updated.
Description changed to:
Ok, next try.
Perhaps someone with more c++ knowledge could check/implement:
- the if/else condition in those 2 nested for clauses for every pixel is not
nice
- can we m
Review: Approve
LGoWin ;)
--
https://code.launchpad.net/~widelands-dev/widelands/move_mapview_children/+merge/243233
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/move_mapview_children.
___
Mailing list: https://la
Review: Needs Fixing
On windows:
The menu stays big/small on toggeling fullscreen/window.
The moment you enter a submenu or go back the new menu is layouted correctly.
--
https://code.launchpad.net/~widelands-dev/widelands/f_for_fullscreen/+merge/243227
Your team Widelands Developers is subscri
Review: Approve
Does work well on win.
I am for merging and getting rid of the old MinGW Makfile completely. It does
miss all SDL2 related changes and CMake+Ninja|Make work fine on windows.
--
https://code.launchpad.net/~widelands-dev/widelands/remove_cached_resizing/+merge/243584
Your team Wid
It does compile and work on win32, small fix only needed atm for a release
build:
format.cc, function get_halign() does only contain an assert, a return
statement is missing.
--
https://code.launchpad.net/~widelands-dev/widelands/fh1/+merge/177228
Your team Widelands Developers is subscribed to
It does compile on win32.
But i can't test the disabling of sound if libogg is missing, because it seems
on my system libogg is statically linked into libvorbis and libvorbisfile.
If i remove both libvorbis dlls widelands does not start at all.
--
https://code.launchpad.net/~widelands-dev/widelan
Review: Approve
Works very well on windows.
--
https://code.launchpad.net/~widelands-dev/widelands/move_drawing_out/+merge/243944
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/remove_in_memory_image.
___
Mailing li
Tino has proposed merging lp:~widelands-dev/widelands/refactor_editor_start
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1390794 in widelands: "Remove the "New Map"/"Load map" menu when
launching the editor"
Tino has proposed merging lp:~widelands-dev/widelands/rolling_autosave into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1407948 in widelands: "More autosave files would help debugging"
https://bugs.launchpad.net/widelands/+bug/1407948
I agree with removing to GUI part.
Regarding other comments:
- 1-10 vs 0-9: this specifies how many files to use, because this is
independent from autosave intervall at all, at least one is necessary
(wl_autosave_0.wgf). You would not want to set this to 0, instead set autsave
interval to never.
Review: Resubmit
Ok, hopefully addressed all comments and suggestions.
--
https://code.launchpad.net/~widelands-dev/widelands/rolling_autosave/+merge/246061
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/rolling_autosave.
_
Review: Approve
Hm, current trunk does not show the campvis file on my system?
But beside this everything is fine with this request on windows...
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1412242/+merge/247404
Your team Widelands Developers is subscribed to branch
lp:~widelands
Review: Approve
Windows compile ok.
--
https://code.launchpad.net/~widelands-dev/widelands/remove_hosting_limitation/+merge/247221
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/remove_hosting_limitation.
___
Mailin
I am not sure if this is related:
https://github.com/boostorg/signals2/pull/8/files
When i was updating my build environment a few days ago i had to apply this
patch to boost 1.5.7 to make it work with widelands.
--
https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271
Y
Review: Approve
Works fine here!
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1459529/+merge/260632
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1459529.
___
Mailing list: https://launchpad.net/~
Tino has proposed merging
lp:~widelands-dev/widelands/editor-remove-invalid-resources_fix into
lp:~janosch-peters/widelands/editor-remove-invalid-resources.
Requested reviews:
Janosch Peters (janosch-peters)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/editor
Review: Approve
Looks good to me and bunnybot ;).
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/options_window/+merge/280355
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/options_window.
_
Tino has proposed merging lp:~widelands-dev/widelands/appveyor into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/appveyor/+merge/281473
Please do not merge as for now.
I want only bunnybot to
On windows the only glitch i can see are the road textures.
Switching from/to fullscreen, menues, everything else seems fine!
--
https://code.launchpad.net/~widelands-dev/widelands/render_queue/+merge/250524
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/render
Review: Approve
LGTM.
I cannot really quantify the performance gain, but i did not find any
regression.
--
https://code.launchpad.net/~widelands-dev/widelands/request_supply_opt/+merge/280193
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/request_supply_opt.
Review: Approve
Some minor issues with axis, ticks and graphs in the statistics window:
https://imgur.com/nkf8VCn
--
https://code.launchpad.net/~widelands-dev/widelands/render_queue/+merge/250524
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/render_queue.
_
Tino has proposed merging lp:~widelands-dev/widelands/appveyor into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/appveyor/+merge/281599
Provide a build script for appveyor, the "travis ci
Ok, no static linking at all for now.
Locally i am able to do a complete static widelands.exe, will have to figure
this out for appveyor later.
--
https://code.launchpad.net/~widelands-dev/widelands/appveyor/+merge/281599
Your team Widelands Developers is requested to review the proposed merge o
Review: Approve
Ok, it works now including building a windows setup.
I am going to merge because there are no changes to other than windows related
things.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/appveyor/+merge/281599
Your team Widelands Developers is subscribed
Tino has proposed merging lp:~widelands-dev/widelands/fix_windows_delete_dir
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fix_windows_delete_dir/+merge/282114
Testing the
Review: Approve
Compiles and runs fine on windows. I would really like to see this land in
trunk as soon as possible.
--
https://code.launchpad.net/~widelands-dev/widelands/use_image_cache/+merge/282106
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/full_text
The proposal to merge lp:~widelands-dev/widelands/fix_windows_delete_dir into
lp:widelands has been updated.
Commit Message changed to:
Check return value of RemoveDirectory() and throw error if delete fails
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fix_windows_
The proposal to merge lp:~widelands-dev/widelands/fix_windows_delete_dir into
lp:widelands has been updated.
Commit Message changed to:
- Check return value of RemoveDirectory() and throw error if delete fails
- Use CreateDirectory() on windows instead of mkdir
For more details, see:
https://co
Review: Resubmit
Ok, one more change. I'll wait for the travis bot to make sure i did not break
anything on *nix and will merge then.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_windows_delete_dir/+merge/282114
Your team Widelands Developers is subscribed to branch
lp:~widelands-
Review: Needs Fixing
Currently the images in campaigns are not cached.
Starting any campaign mission fails.
--
https://code.launchpad.net/~widelands-dev/widelands/use_image_cache/+merge/282106
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/full_texture_atlas.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/fix_windows_delete_dir/+merge/282114
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_windows_delete_dir.
___
Mailing list: https://launchpad.n
I cannot detect any visual regressions.
Still getting one "libpng warning: iCCP: known incorrect sRGB profile" on exit.
Any hint how to find the corresponding image?
--
https://code.launchpad.net/~widelands-dev/widelands/png_alternative_method/+merge/282856
Your team Widelands Developers is reques
Review: Approve
No, sorry.
As a test, I've run "pngcrush -ow -rem allb -reduce" (compiled with gcc 5.3.0
and libpng 1.6.20) once more over all files does not change anything.
BZR then only shows changes on the three files kaputtnik comitted last, but
there is no visual difference.
Still 1-4 occu
Both optipng and pngcrush were not able to "fix" (remove the unknown profile)
all images.
AdvaneCOMP was able to: http://www.advancemame.it/doc-advdef.html
Now with this branch I get no warning messages from libPNG any longer.
--
https://code.launchpad.net/~widelands-dev/widelands/png_alternativ
1 - 100 of 196 matches
Mail list logo
