https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
Helder mybugs.m...@gmail.com changed:
What|Removed |Added
Blocks||4714
Depends
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
Chad H. innocentkil...@gmail.com changed:
What|Removed |Added
Version|1.15.1 |1.15.x
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #25 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-06-01
17:10:54 UTC ---
The point is, we don't want to truncate it at all on the server side. It
should prohibit you from entering enough characters to be truncated on the
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #23 from Arod Shatil arod.sha...@gmail.com 2010-05-31 19:16:22
UTC ---
(In reply to comment #22)
this means that if len *is* 250 (or 249 for that matter) the script will
allow
you to add one more character, which can be 2 or
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #24 from Bawolff bawolff...@gmail.com 2010-06-01 02:42:48 UTC ---
Technically it will truncate it at 250, then add ... to the end then return
the original if its shorter or equal to the truncated string, so in english at
least
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #21 from Arod Shatil arod.sha...@gmail.com 2010-05-30 17:16:22
UTC ---
(In reply to comment #20)
Fixed in r66913
unfortunately this fix has an off-by-one bug:
+if (len 250) {
+if (e.preventDefault)
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #22 from Platonides platoni...@gmail.com 2010-05-30 20:18:41 UTC
---
this means that if len *is* 250 (or 249 for that matter) the script will allow
you to add one more character, which can be 2 or 3 extra bytes
which will still
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
Bawolff bawolff...@gmail.com changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #19 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-05-26
00:07:06 UTC ---
Sorry for the long delay. It looks okay to me at a glance, although I haven't
tested it. If you've tested that it doesn't break things in IE, go
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #18 from Arod Shatil arod.sha...@gmail.com 2010-05-09 15:10:33
UTC ---
intermediate report:
the patch seems to work as advertised, with no ill effects so far.
tested with FF, IE, (8 only - i do not have access to older versions :(
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #15 from Arod Shatil arod.sha...@gmail.com 2010-05-06 08:13:20
UTC ---
nice.
one small nitpick, though:
i find it aesthetically displeasing that in the three different points the
function checkSummary returns, three different
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #16 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-05-06
15:21:36 UTC ---
Thanks for the patch! I'm currently in the middle of finals, but should be
able to try this out in a week or two.
--
Configure bugmail:
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #17 from Bawolff bawolff...@gmail.com 2010-05-06 21:33:20 UTC ---
(In reply to comment #15)
nice.
one small nitpick, though:
i find it aesthetically displeasing that in the three different points the
function checkSummary
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
Bawolff bawolff...@gmail.com changed:
What|Removed |Added
Attachment #7258|0 |1
is obsolete|
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
Bawolff bawolff...@gmail.com changed:
What|Removed |Added
CC||bawolff...@gmail.com
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #8 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-04-01
19:51:39 UTC ---
If some browsers interpret maxlength as code points and some as half the number
of UTF-16 bytes, that's not a big issue, because it only affects
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #9 from Bawolff bawolff...@gmail.com 2010-04-01 21:08:16 UTC ---
Created an attachment (id=7256)
-- (https://bugzilla.wikimedia.org/attachment.cgi?id=7256)
patch that uses js to give better limit for summary field
Ok, here's a
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #10 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-04-01
23:01:34 UTC ---
Looks good at a glance. Can't test it right now, will do so later.
Preliminary comments:
+document.getElementById('wpSave').focus();
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
Bawolff bawolff...@gmail.com changed:
What|Removed |Added
Attachment #7256|0 |1
is obsolete|
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #12 from Arod Shatil arod.sha...@gmail.com 2010-04-02 02:04:53
UTC ---
nitpick:
len = text.replace(/[^\u-\u007F]/g, '').length +
text.replace(/[^\u0080-\u07FF\uD800-\uDFFF]/g, '').length*2 +
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #1 from Arod Shatil asha...@ezecastlesoftware.com 2010-03-26
18:49:02 UTC ---
and of course, the existing situation, where users enter edit summaries and
(sometimes) sweat to make them fit the 200-characters limit just to see them
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
Aryeh Gregor simetrical+wikib...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #3 from Arod Shatil asha...@ezecastlesoftware.com 2010-03-26
19:11:38 UTC ---
i disagree.
first, it is *very* straightforward to change one tinyblob to blob and you know
it. it only costs one extra byte per revision - hardly
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #4 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-03-26
19:20:29 UTC ---
(In reply to comment #3)
first, it is *very* straightforward to change one tinyblob to blob and you
know
it. it only costs one extra byte per
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
Roan Kattouw roan.katt...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #6 from Aryeh Gregor simetrical+wikib...@gmail.com 2010-03-26
19:31:20 UTC ---
The ALTER TABLE is a nonissue. There are procedures in place to do that,
although it's a pain and it might take a while if that was the only issue.
26 matches
Mail list logo
