[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Maarten Dammers maar...@mdammers.nl changed: What|Removed |Added Keywords|tracking| --- Comment #65 from Maarten Dammers maar...@mdammers.nl --- See also https://meta.wikimedia.org/wiki/Requests_for_comment/Global_file_deletion_review -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins (tracking)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #63 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 162546 merged by jenkins-bot: Add viewdeletedfile userright for global deleted image review https://gerrit.wikimedia.org/r/162546 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins (tracking)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #62 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 162546 had a related patch set uploaded by Legoktm: Add viewdeletedfile userright for global deleted image review https://gerrit.wikimedia.org/r/162546 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins (tracking)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #61 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 154868 merged by jenkins-bot: SpecialUndelete: Check permissions on a per-page basis https://gerrit.wikimedia.org/r/154868 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins (tracking)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins (tracking)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #59 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 154868 had a related patch set uploaded by Legoktm: SpecialUndelete: Check permissions on a per-page basis https://gerrit.wikimedia.org/r/154868 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins (tracking)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801
--- Comment #60 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
I think restructuring the entire permissions system would be nice, but I doubt
anyone is planning to do that for the next few years.
So I think bawolff's comment 41 is the best and easiest way to move forward. I
uploaded a patch which changes Special:Undelete to check per-page restrictions,
allowing us to set per-namespace restrictions in the wmf-config:
$wgHooks['TitleQuickPermissions'][] = function ( Title $title, User $user,
$action, $errors, $doExpensiveQueries, $short ) {
return ( !in_array( $action, array( 'deletedhistory', 'deletedtext' ) ) ||
!$title-inNamespaces( NS_FILE, NS_FILE_TALK ) || !$user-isAllowed(
'globalimagereview' ) );
};
Then we just create a global group that has the globalimagereview userright.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins (tracking)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|High|Normal --- Comment #58 from Andre Klapper aklap...@wikimedia.org --- Lowering priority, as bug 29780 and bug 29781 need to get fixed first. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins (tracking)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Krinkle krinklem...@gmail.com changed: What|Removed |Added Keywords|shellpolicy |tracking Blocks||2007 Summary|Global deleted image review |Global deleted image review |(global File-namespace |for Commons admins |deletedtext permission) for |(tracking) |Commons admins | --- Comment #57 from Krinkle krinklem...@gmail.com 2012-08-25 15:04:06 UTC --- Removing shellpolicy again. This is not in need of further clarification. The proposal was very clear and straight forward about how the implementation was to be done (deletedtext in the file namespace, globally). Yes, once done it will probably be implementable by stewards. This is just a tracking bug because it is a major thing that needs software to be written. The actual resolution of it probably doesn't require wmf-config changes. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins (tracking)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Nemo_bis federicol...@tiscali.it changed: What|Removed |Added Component|Site configuration |General/Unknown -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Krinkle krinklem...@gmail.com changed: What|Removed |Added Keywords|bugsmash, crosswiki | CC||benap...@gmail.com, ||wikimedia.b...@snowolf.eu Component|General/Unknown |Site configuration Product|MediaWiki |Wikimedia Summary|Global deleted image review |Global deleted image review |for Commons admins (allow |for Commons admins |per-namespace granting of | |deletedtext permission) | --- Comment #49 from Krinkle krinklem...@gmail.com 2012-08-24 14:44:51 UTC --- (In reply to comment #48) I'll create a global group on my wiki and test this. I'll be back with answers. Don't bother. That will work just fine. We create that kind of global groups all the time. Moving this bug back to the Wikimedia product, because this is just a request for configuration, not MediaWiki software implementation. The implementation of features that make this possible are already tracked and set as blockers for this bug: * bug 29780 * bug 29781 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #46 from Tomasz W. Kozłowski odder.w...@gmail.com 2012-08-21 15:25:43 UTC --- It's /just/ four years since the bug was reported, and a community consensus was granted. Are there any updates on the status of this bug? Is it ever going to be fixed? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins (allow per-namespace granting of deletedtext permission)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Nemo_bis federicol...@tiscali.it changed: What|Removed |Added CC||federicol...@tiscali.it Summary|Global deleted image review |Global deleted image review |for Commons admins |for Commons admins (allow ||per-namespace granting of ||deletedtext permission) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins (allow per-namespace granting of deletedtext permission)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Nemo_bis federicol...@tiscali.it changed: What|Removed |Added Component|General/Unknown |General/Unknown Product|Wikimedia |MediaWiki -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins (allow per-namespace granting of deletedtext permission)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #47 from Nemo_bis federicol...@tiscali.it 2012-08-21 15:58:31 UTC --- (In reply to comment #46) It's /just/ four years since the bug was reported, and a community consensus was granted. Are there any updates on the status of this bug? Is it ever going to be fixed? I suspect that, however difficult it may be, it's actually easier to get consensus for a global group with deletedtext permission on all namespaces than to get this bug fixed. If there was consensus for that, stewards could easily create the group and add any Commons admin who needed it. Beware, this is not the place to discuss it, you have to change [[m:Global deleted image review]] (and get it approved). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins (allow per-namespace granting of deletedtext permission)
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #48 from matanya matanya.mo...@gmail.com 2012-08-21 16:03:46 UTC --- I'll create a global group on my wiki and test this. I'll be back with answers. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 matanya matanya.mo...@gmail.com changed: What|Removed |Added Keywords|patch, patch-need-review| CC||matanya.mo...@gmail.com -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Krinkle krinklem...@gmail.com changed: What|Removed |Added Attachment #6580|0 |1 is obsolete|| --- Comment #44 from Krinkle krinklem...@gmail.com 2012-04-12 15:06:21 UTC --- Comment on attachment 6580 -- https://bugzilla.wikimedia.org/attachment.cgi?id=6580 Patch for Special:Undelete built against trunk (fixed) marking patch obsolete as it no longer applies cleanly to trunk and is meant for bug 29780. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Krinkle krinklem...@gmail.com changed: What|Removed |Added Attachment #8772|0 |1 is obsolete|| --- Comment #45 from Krinkle krinklem...@gmail.com 2012-04-12 15:06:25 UTC --- Comment on attachment 8772 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8772 Per namespace permissions for User.php marking patch obsolete as it no longer applies cleanly to trunk and is meant for bug 29780. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Bugmeister Bot mhershber...@wikimedia.org changed: What|Removed |Added Priority|Highest |High CC|garba...@seznam.cz | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Jan Kucera (Kozuch) garba...@seznam.cz changed: What|Removed |Added Priority|High|Highest CC||garba...@seznam.cz --- Comment #44 from Jan Kucera (Kozuch) garba...@seznam.cz 2011-12-30 15:45:16 UTC --- Because of votes rasing importance/priority according to following scheme: 15+ votes - highest 5-15 votes - high Community must have a voice within development. Regards, Kozuch http://en.wikipedia.org/wiki/User:Kozuch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords||need-review CC||suma...@panix.com -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #43 from Bryan Tong Minh bryan.tongm...@gmail.com 2011-07-11 19:11:37 UTC --- Created attachment 8772 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8772 Per namespace permissions for User.php Patch that adds support for per namespace permissions in User.php. Next step would be to patch User::isAllowed() and Title::getUserPermissionsErrors(). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #42 from Krinkle krinklem...@gmail.com 2011-07-08 21:54:41 UTC --- (In reply to comment #41) The Title-class currently has permission-related functions, how usable are they for this bug ? The userCan hook already gets passed a title. One could just simply make an extension using that hook. A really hacky implementation could be done in about ten minutes. (userCan hook that just checks local group membership at commons This bug (or rather part of it, we should split it) requests to: 1) Have the ability to set permissions per namespace 2) Have the globally 3) Set some in NS_FILE for commons admins. This last part could either be cross-wiki read, or as a global group. I don't think having to manually add as global group is that big a deal though. Could be done by a wiki bot, that's all very minor details. The problem is having these permissions work and being able to set them from LocalSettings and for global groups. When I referred to the usefulness related to this bug I meant point 1 and 2. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Krinkle krinklem...@gmail.com changed: What|Removed |Added Depends on||29780 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Krinkle krinklem...@gmail.com changed: What|Removed |Added Depends on||29781 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Krinkle krinklem...@gmail.com changed: What|Removed |Added Keywords||bugsmash, triage Priority|Low |High --- Comment #38 from Krinkle krinklem...@gmail.com 2011-07-04 20:33:09 UTC --- The backlogs in Commons are piling up as far back as 2004 with review of moves from other projects to Wikimedia Commons. Local wikis are refusing to delete images because the moves haven't been reviewed, if they would delete them (clean up), it is likely a Commons sysop may have to request temporary undeletion in order to review. This is taking hours/days/weeks for a single images, simply unworkable. with over 6 years of backlog and 3 years of waiting for an implementation I think it's time we get this under serious consideration and write out a road map of what needs to be done. An estimation at the very least because the work-arounds are killing at the very least and no where even near motivating or collaborative. Needed end-result: * There is a global user group which is allowed to view deleted files and their file-page history on all wmf-wikis. Technical aspects: * [x] Global groups * [_] Per namespace rights * [_] Per namespace rights support through global rights Making for triage, waiting for assignee and review of patch. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #39 from ChrisiPK chris...@gmail.com 2011-07-04 20:38:49 UTC --- Just a quick note, because you asked for patch review: That patch was more of a quick first attempt at hacking on my part, to give people an idea, where to put this. In the mean time, we also have Deleted Revisions, which would likely also need to be patched. That patch will definitely have to be re-written from scratch, as it was already insufficient at time of build and might now be useless, because the code base has changed. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #40 from Krinkle krinklem...@gmail.com 2011-07-04 20:39:31 UTC --- (In reply to comment #34) (In reply to comment #33) I would prefer this to have this dependant of a Title-userCan(), and having a way to set per namespace $wgGroupPermissions in a sane way. We are talking about global groups, so $wgGroupPermissions seems irrelevant. Your suggestion though would imply implementing per-namespace group permission support in CentralAuth. On an unrelated note a sane way for $wgGroupPermissions to support per-namespace permissions is to allow an array as argument, e.g. $wgGroupPermissions['sysop']['deletedhistory'] = array( NS_FILE = true ); In any case I think setting permissions per-namespace is the way to go, rather than creating per-namespace permissions. I agree. So the userright-key in the user-group array in $wgGroupPermissions is either boolean or an array of namespace-ids with booleans. So in the userCan function needs the option (or requirement) to specify a Title object. The Title-class currently has permission-related functions, how usable are they for this bug ? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #41 from Bawolff bawolff...@gmail.com 2011-07-04 21:43:40 UTC --- The Title-class currently has permission-related functions, how usable are they for this bug ? The userCan hook already gets passed a title. One could just simply make an extension using that hook. A really hacky implementation could be done in about ten minutes. (userCan hook that just checks local group membership at commons [hey we already do cross-db access for global usage], and lets people read if they are a sysop over there). Admittedly that'd be a bit hacky [Normally rights give people rights to do stuff, not group membership]. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #36 from Platonides platoni...@gmail.com 2011-03-16 22:42:36 UTC --- Only those in SpecialUndelete would need to be changed, but there are a number of them. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #35 from Krinkle krinklem...@gmail.com 2011-03-16 00:21:22 UTC --- *bump* Commons is getting fuller and fuller, more wikis moving to commons, more work. It's been 3 years since it was accepted through a global-vote on Meta. Bryan's suggestion appears to be a plausible solution. Altough I don't know a lot about the permissions and authentication in core and CentralAuth, it sounds like something that shouldn't be too hard. Whatever uses $wg*Permissions checks if either the value itself or the current namespace array item in that value is true. Can someone write a patch for this ? Do we need to update most/all usages of User-isAllowed / userCan() for addition/replacement with Title-userCan, or can it be implemented in there ? Even if you can't write a patch, adding some notes would be great so others can pick them up. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Normal |Highest CC||m...@everybody.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC|krinklem...@gmail.com | AssignedTo|gmaxw...@gmail.com |wikibugs-l@lists.wikimedia. ||org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #34 from Bryan Tong Minh bryan.tongm...@gmail.com 2010-07-09 17:33:47 UTC --- (In reply to comment #33) I would prefer this to have this dependant of a Title-userCan(), and having a way to set per namespace $wgGroupPermissions in a sane way. We are talking about global groups, so $wgGroupPermissions seems irrelevant. Your suggestion though would imply implementing per-namespace group permission support in CentralAuth. On an unrelated note a sane way for $wgGroupPermissions to support per-namespace permissions is to allow an array as argument, e.g. $wgGroupPermissions['sysop']['deletedhistory'] = array( NS_FILE = true ); In any case I think setting permissions per-namespace is the way to go, rather than creating per-namespace permissions. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #33 from Platonides platoni...@gmail.com 2010-05-01 11:33:01 UTC --- I would prefer this to have this dependant of a Title-userCan(), and having a way to set per namespace $wgGroupPermissions in a sane way. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #32 from Krinkle krinklem...@gmail.com 2010-05-01 03:24:01 UTC --- Ahm... it's been a while. I often find myself in situations to wait hours or days for an admin at a local wiki. What's the progress on this ? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 ChrisiPK chris...@gmail.com changed: What|Removed |Added Attachment #6576 is|0 |1 obsolete|| --- Comment #30 from ChrisiPK chris...@gmail.com 2009-09-24 16:23:22 UTC --- Created an attachment (id=6579) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6579) Patch for Special:Undelete built against trunk New patch, built against current trunk. This is considerably smaller because the trunk already has a variable mCanView, which basically does what I was doing with mAllowedView. Also note that this still does not provide the undel/view links for deleted revisions as I still have not found out where those are created. Regards! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 ChrisiPK chris...@gmail.com changed: What|Removed |Added Attachment #6579 is|0 |1 obsolete|| --- Comment #31 from ChrisiPK chris...@gmail.com 2009-09-24 18:56:16 UTC --- Created an attachment (id=6580) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6580) Patch for Special:Undelete built against trunk (fixed) Yet another patch (sorry for spamming you). This fixes a null pointer exception when accessing Special:Undelete without the undelete right and enables viewing of files. Note: This also enables viewing of files when user has the deletedcontent right - I assume this was intended anyway, right? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #29 from Brion Vibber br...@wikimedia.org 2009-09-23 20:14:37 UTC --- Couple quick notes... The patch doesn't apply cleanly against development trunk; lots of stuff has changed internally since 1.15, so this'll be a lot easier to get merged if it's rebuilt against trunk instead of a release branch. I also see some code duplication, copying portions of the UI output between the can-restore and can't-restore cases. This is easy to do the first time around, but makes code maintenance harder -- the copies can get out of sync easily, and generally just clutter the codebase. I would recommend merging the two cases together; just don't output the form fields when they won't be needed. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #27 from Platonides platoni...@gmail.com 2009-09-22 20:23:47 UTC --- 1. The patch is reversed. 2. Use unified diff when possible. 3. By removing 'deletedhistory', and the part of !$wgUser-isAllowed( 'deletedhistory' ) you're allowing everyone to see the deleted history. 4. Why are you removing the 1143,1155d1126 and 1195,1200d1165 chunks? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 ChrisiPK chris...@gmail.com changed: What|Removed |Added Attachment #6569 is|0 |1 obsolete|| --- Comment #28 from ChrisiPK chris...@gmail.com 2009-09-22 22:23:03 UTC --- Created an attachment (id=6576) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6576) Patch (unreversed, with unified diff) for Special:Undelete (In reply to comment #27) 1. The patch is reversed. 2. Use unified diff when possible. 3. By removing 'deletedhistory', and the part of !$wgUser-isAllowed( 'deletedhistory' ) you're allowing everyone to see the deleted history. 4. Why are you removing the 1143,1155d1126 and 1195,1200d1165 chunks? 1. Indeed it is, sorry about that. I still haven't completely mastered the diff tool. 2. I think I found the relevant option, the new patch should be unified. 3. As you already noted, the patch is reversed. I removed the need for the deletedhistory permission in SpecialPage.php as this prevents users from viewing the page unless they have this right (which not everyone with view-deleted-ns-# might). That is why I added a check in SpecialUndelete.php, see the new patch at @@ -625,6 +637,10 @@. 4. Once again, the patch is reversed, so I am not removing them, but adding them. They take care of the newly introduced variable mAllowedView, which determines whether you are allowed to view the revision (unlike mAllowed, which determines whether you are allowed to restore it). Best Regards and sorry for the double patch. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 ChrisiPK chris...@gmail.com changed: What|Removed |Added Attachment #5927 is|0 |1 obsolete|| --- Comment #26 from ChrisiPK chris...@gmail.com 2009-09-22 02:29:50 UTC --- Created an attachment (id=6569) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6569) Patch for Special:Undelete New patch for MediaWiki 1.15.1, now with the right view-deleted-ns-namespace number goes here. This makes the switches from the old patch obsolete and allows users to add the right for non-default namespaces. Please note: This is still only a patch for Special:Undelete. I still haven't found out where the view/undel links are added; pointers are appreciated. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #25 from Platonides platoni...@gmail.com 2009-08-30 12:46:32 UTC --- It seems to be already taken into account. Look at UndeleteForm::$mAllowed. If you don't have the undelete right, you can view the deleted page but the restore options aren't shown. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Rocket000 brad9...@gmail.com changed: What|Removed |Added CC||brad9...@gmail.com --- Comment #24 from Rocket000 brad9...@gmail.com 2009-08-29 08:46:39 UTC --- I think it will take some interface changes as well since access to Special:Undelete is needed to view anything, but that won't work if you don't have the rights to restore. At the very least the Restore revisions box (where you can add a comment when restoring) along with the checkboxes next to each revision needs to be hidden. The title of the page View and restore deleted pages would also have to change. And what about deletedhistory? (Don't really know the differences between them or why they're separate.) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Maarten Dammers maar...@mdammers.nl changed: What|Removed |Added CC||maar...@mdammers.nl --- Comment #23 from Maarten Dammers maar...@mdammers.nl 2009-07-19 21:52:32 UTC --- Any update on this one? Isn't this just the browsearchive right limited to ns 6 and maybe 7? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #20 from Abigor abi...@forgotten-beauty.com 2009-06-15 18:03:25 UTC --- Any update so far? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 ^demon innocentkil...@gmail.com changed: What|Removed |Added CC||innocentkil...@gmail.com --- Comment #21 from ^demon innocentkil...@gmail.com 2009-06-15 18:12:28 UTC --- (In reply to comment #18) I don't like that it created one permission per namespace, which then lead to those giantic switches. Yes, I can't possibly see something like that getting applied to trunk. What about $allowed = !$wgUser-isBlocked() $wgUser-isAllowed( viewdeletedns . MWNamespace::getSubject( $target-getNamespace() ) . andtalk ); ? You're still having to add all those rights, even if you're not switch()ing over them. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #18 from Platonides platoni...@gmail.com 2009-03-13 23:56:25 UTC --- I don't like that it created one permission per namespace, which then lead to those giantic switches. What about $allowed = !$wgUser-isBlocked() $wgUser-isAllowed( viewdeletedns . MWNamespace::getSubject( $target-getNamespace() ) . andtalk ); ? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Abigor abi...@forgotten-beauty.com changed: What|Removed |Added CC||abi...@forgotten-beauty.com --- Comment #16 from Abigor abi...@forgotten-beauty.com 2009-03-05 21:53:30 UTC --- Is there a progress update? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 Platonides platoni...@gmail.com changed: What|Removed |Added Keywords|patch | --- Comment #14 from Platonides platoni...@gmail.com 2008-12-30 23:42:49 UTC --- Where's that patch? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14801] Global deleted image review for Commons admins
https://bugzilla.wikimedia.org/show_bug.cgi?id=14801 --- Comment #15 from Mike.lifeguard mikelifegu...@fastmail.fm 2008-12-31 02:38:38 UTC --- (In reply to comment #14) Where's that patch? I guess it's trivial to just do it, but Brion wants it done /properly/ so we wait. Gmaxwell has promised to do it though. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
