https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #39 from Andre Klapper aklap...@wikimedia.org ---
Thanks everybody for your work on fixing this!
--
You are receiving this mail because:
You are on the CC list for the bug.
___
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #37 from Greg Grossmeier g...@wikimedia.org ---
Is this resolved now? The above patches are merged and I think all the issues
mentioned in the comments are addressed, no?
--
You are receiving this mail because:
You are on the CC
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:
What|Removed |Added
Status|PATCH_TO_REVIEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #31 from Mark A. Hershberger m...@everybody.org ---
Was just checking a fresh checkout of the extensions directory and it looks
like you didn't actually branch PhpTags (set branch to
Ib6e62863d6ec34e7ec696fe203d9fcf99ad7), or
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #32 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 144269 had a related patch set uploaded by MarkAHershberger:
remove IframePage, ValueView
https://gerrit.wikimedia.org/r/144269
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #33 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 144269 abandoned by MarkAHershberger:
remove IframePage, ValueView
Reason:
Wrong branch
https://gerrit.wikimedia.org/r/144269
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #34 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 144270 had a related patch set uploaded by Brian Wolff:
Set REL1_23 branch for .gitreview.
https://gerrit.wikimedia.org/r/144270
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #35 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 144270 merged by Legoktm:
Set REL1_23 branch for .gitreview.
https://gerrit.wikimedia.org/r/144270
--
You are receiving this mail because:
You are on the CC
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #36 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 144271 had a related patch set uploaded by Legoktm:
Remove IframePage and ValueView
https://gerrit.wikimedia.org/r/144271
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #15 from Mark A. Hershberger m...@everybody.org ---
(In reply to Greg Grossmeier from comment #11)
Is there a reason we didn't make the REL1_23 branch for these
remaining extensions at the same point in time as the 1.23 release?
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:
What|Removed |Added
Status|REOPENED
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #17 from Mark A. Hershberger m...@everybody.org ---
(In reply to Kunal Mehta (Legoktm) from comment #16)
This is ridiculous. I'm just going to fix it myself.
Thanks! Let me know if you need any gerrit approvals.
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #18 from Bawolff (Brian Wolff) bawolff...@gmail.com ---
Unfortunately, gerrit/git won't let me delete the bad branches. The easiest
thing to do would be to drop those REL1_23 branches that don't have their
own commits and
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #19 from Bawolff (Brian Wolff) bawolff...@gmail.com ---
(In reply to Bawolff (Brian Wolff) from comment #18)
Unfortunately, gerrit/git won't let me delete the bad branches. The easiest
thing to do would be to drop those
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #20 from Mark A. Hershberger m...@everybody.org ---
(In reply to Bawolff (Brian Wolff) from comment #19)
It's been pointed out to me that this is incorrect, and you can delete
branches from the gerrit interface. People with +2 on
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #21 from Mark A. Hershberger m...@everybody.org ---
Note that after deleting this in gerrit you have to (at least, I had to)
completely delete the git directory and check out a fresh copy for the change
to show up.
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:
What|Removed |Added
Status|ASSIGNED
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #23 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
Only Elastica updated the -extensions metarepo. Fixing that right now...
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #24 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 144055 had a related patch set uploaded by Legoktm:
Sync with updated REL1_23 branches in extensions
https://gerrit.wikimedia.org/r/144055
--
You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #25 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 144055 abandoned by Legoktm:
Sync with updated REL1_23 branches in extensions
Reason:
Erk, wrong branch.
https://gerrit.wikimedia.org/r/144055
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #26 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 144056 had a related patch set uploaded by Legoktm:
Sync with updated REL1_23 branches in extensions
https://gerrit.wikimedia.org/r/144056
--
You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #27 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 144056 merged by Legoktm:
Sync with updated REL1_23 branches in extensions
https://gerrit.wikimedia.org/r/144056
--
You are receiving this mail because:
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:
What|Removed |Added
Status|PATCH_TO_REVIEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #29 from Mark A. Hershberger m...@everybody.org ---
(In reply to Kunal Mehta (Legoktm) from comment #22)
(In reply to Mark A. Hershberger from comment #20)
Hrm... the gerrit interface. That would be why this didn't work:
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #30 from Mark A. Hershberger m...@everybody.org ---
Kunal,
Thanks for getting this done. I was busy with other work and traveling till
now and just sat down to take care of this now in case you hadn't had time.
I appreciate your
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #10 from Mark A. Hershberger m...@everybody.org ---
(In reply to Kunal Mehta (Legoktm) from comment #8)
Nope...you just made it worse. Now REL1_23 is pointing at master. Sigh.
I don't think this is worse. This is better.
The
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #11 from Greg Grossmeier g...@wikimedia.org ---
(In reply to Mark A. Hershberger from comment #10)
(In reply to Kunal Mehta (Legoktm) from comment #8)
Nope...you just made it worse. Now REL1_23 is pointing at master. Sigh.
I
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #12 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
(In reply to Mark A. Hershberger from comment #10)
(In reply to Kunal Mehta (Legoktm) from comment #8)
Nope...you just made it worse. Now REL1_23 is pointing at
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #13 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
(In reply to Greg Grossmeier from comment #11)
Just so I have this clear: this means that there are (potentially) commits
in the extensions listed in comment 2 that
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #14 from Bawolff (Brian Wolff) bawolff...@gmail.com ---
Just so I have this clear: this means that there are (potentially) commits
in the extensions listed in comment 2 that were made post 1.23's release and
thus might have
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
Mark A. Hershberger m...@everybody.org changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
Mark A. Hershberger m...@everybody.org changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:
What|Removed |Added
Status|RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #6 from Mark A. Hershberger m...@everybody.org ---
Thanks for pointing that difference out. I missed it. They're symptoms of the
same problem. Fixing both at the same time right now.
--
You are receiving this mail because:
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #7 from Mark A. Hershberger m...@everybody.org ---
I'm not so sure they're symptoms of the same problem any more. But I think
I've fixed these. Leaving open so you can tell me if I'm wrong.
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #8 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
Nope...you just made it worse. Now REL1_23 is pointing at master. Sigh.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #9 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
But in some cases it's a commit behind apparently like UrlShortener and
GlobalPreferences.
You also didn't update the REL1_23 branch of the meta mediawiki-extensions
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Priority|Unprioritized |High
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
--- Comment #1 from Greg Grossmeier g...@wikimedia.org ---
Is there a list of remaining extensions without REL1_23 branches?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:
What|Removed |Added
See Also|
https://bugzilla.wikimedia.org/show_bug.cgi?id=67270
Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:
What|Removed |Added
Severity|normal
43 matches
Mail list logo