[Bug 68556] [Regression] Disabled CodeEditor prevents toolbar functions to work
https://bugzilla.wikimedia.org/show_bug.cgi?id=68556 Michael M. listenle...@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68556] [Regression] Disabled CodeEditor prevents toolbar functions to work
https://bugzilla.wikimedia.org/show_bug.cgi?id=68556 --- Comment #5 from Derk-Jan Hartman hartman.w...@gmail.com --- Yuck... This is really all down to the fact that the textSelection api was once a part of the WikiEditor api. That separation was never really properly finished and that is why in the CodeEditor this api is now 'mixed' up with the WikiEditor api. Add to this that CodeEditor made it possible to enable and disable on the fly and you have one big mess... So this bug is because I failed to realize that the CodeEditor could be disabled in the same session and that this would 'break' the function mapping in: http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCodeEditor.git/ad908b2da64da4083e10e391153112978fb9df8f/modules%2Fjquery.codeEditor.js#L517 There we basically assign the 'textSelection' api functions into the WikiEditor api. The disabling works fine for the WikiEditor API functions, because they listen to the conditional in L508, but the textSelection APIs are no longer part of the wikiEditor api's and stuff start breaking. I'm thus going to reintroduce iframe check and then submit a new patch that does some very simple API registration to replace the textSelection API if a textfield/area wants to do that. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68556] [Regression] Disabled CodeEditor prevents toolbar functions to work
https://bugzilla.wikimedia.org/show_bug.cgi?id=68556 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68556] [Regression] Disabled CodeEditor prevents toolbar functions to work
https://bugzilla.wikimedia.org/show_bug.cgi?id=68556 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 150009 had a related patch set uploaded by TheDJ: jquery.textSelection: re-add iframe check due to regression https://gerrit.wikimedia.org/r/150009 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68556] [Regression] Disabled CodeEditor prevents toolbar functions to work
https://bugzilla.wikimedia.org/show_bug.cgi?id=68556 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 150009 merged by jenkins-bot: jquery.textSelection: re-add iframe check due to regression https://gerrit.wikimedia.org/r/150009 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68556] [Regression] Disabled CodeEditor prevents toolbar functions to work
https://bugzilla.wikimedia.org/show_bug.cgi?id=68556 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added CC||matma@gmail.com --- Comment #4 from Bartosz Dziewoński matma@gmail.com --- Was https://gerrit.wikimedia.org/r/#/c/149529/ a fix for this bug? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68556] [Regression] Disabled CodeEditor prevents toolbar functions to work
https://bugzilla.wikimedia.org/show_bug.cgi?id=68556 --- Comment #2 from Michael M. listenle...@gmail.com --- (In reply to Derk-Jan Hartman from comment #1) Are we sure that that is a regression ? Because if a take a peek at textSelection, it seems like it would have done that in the past as well.. Yes, I am sure. I have CodeEditor disabled, and use several user scripts that use the textSelection API, and they just broke yesterday. After a quick look: When you disable CodeEditor, context.$iframe is set to undefined [1], which previously was recognized by textSeclection as to use the default methods, while the mentioned change removed that check. So now the code always tries to call the methods provided by CodeEditor, but these fail when it is disabled. [1] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCodeEditor/56b9e4c350c122e105949b0faefa25f17253335b/modules%2Fjquery.codeEditor.js#L276 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68556] [Regression] Disabled CodeEditor prevents toolbar functions to work
https://bugzilla.wikimedia.org/show_bug.cgi?id=68556 Derk-Jan Hartman hartman.w...@gmail.com changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |hartman.w...@gmail.com |org | --- Comment #3 from Derk-Jan Hartman hartman.w...@gmail.com --- Bingo got it. Now to find a better way to fix this and more importantly.. document it... -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68556] [Regression] Disabled CodeEditor prevents toolbar functions to work
https://bugzilla.wikimedia.org/show_bug.cgi?id=68556 Helder he7...@gmail.com changed: What|Removed |Added Priority|Unprioritized |High CC||he7...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68556] [Regression] Disabled CodeEditor prevents toolbar functions to work
https://bugzilla.wikimedia.org/show_bug.cgi?id=68556 --- Comment #1 from Derk-Jan Hartman hartman.w...@gmail.com --- Are we sure that that is a regression ? Because if a take a peek at textSelection, it seems like it would have done that in the past as well.. Will have to investigate a bit. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
