[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 Daniel Friesen changed: What|Removed |Added Blocks||46807 Resolution|WORKSFORME |FIXED --- Comment #39 from Daniel Friesen --- This was fixed rather than just working so marking it as FIXED instead of WORKSFORME. Also adding bug 46807 to deal with the fact that the old hook and *ico keys are still around and don't support wgFooterIcons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 Quim Gil changed: What|Removed |Added Status|REOPENED|RESOLVED CC||q...@wikimedia.org Resolution|--- |WORKSFORME --- Comment #38 from Quim Gil --- (In reply to comment #0) > Would be nice if the function getPoweredBy could be changed to recive an > array > with picturepath, linkpath and alttext, so that someone can configure true > LocalSettings if there is anything displayed or if there are more buttons > shown. > > Extensions could also use this to show a button there. This is today provided by https://www.mediawiki.org/wiki/Manual:$wgFooterIcons Resolving as WORKSFORME. If this doesn't work in your website then please file a bug report specific to your case. Thank you! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 Michelle Lee Kosik changed: What|Removed |Added CC||kosi...@mail.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 Sumana Harihareswara changed: What|Removed |Added Keywords|need-review, patch | CC||suma...@panix.com --- Comment #37 from Sumana Harihareswara 2012-01-11 21:04:13 UTC --- Dasch, thank you for the patch. I'm removing the need-review and patch keywords since the MediaWiki codebase has changed so much since you submitted the patch that the patch no longer applies cleanly to Subversion trunk. If you're still interested in this issue, maybe you could come into the #mediawiki IRC channel and discuss the situation and possible approaches before revising. Thanks! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 Sumana Harihareswara changed: What|Removed |Added Attachment #7820|0 |1 is obsolete|| --- Comment #36 from Sumana Harihareswara 2012-01-11 21:02:42 UTC --- Comment on attachment 7820 --> https://bugzilla.wikimedia.org/attachment.cgi?id=7820 reworked new patch Marked as obsolete since patch no longer applies cleanly to Subversion trunk, per Rusty Burchfield's automated testing https://docs.google.com/spreadsheet/ccc?key=0Ah_71HHl7qa7dGtvSms3TGpHQU9NU2Y1VmNzUEUteWc -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 Sumana Harihareswara changed: What|Removed |Added Attachment #7806|0 |1 is obsolete|| --- Comment #35 from Sumana Harihareswara 2012-01-11 21:01:31 UTC --- Comment on attachment 7806 --> https://bugzilla.wikimedia.org/attachment.cgi?id=7806 Patch to add new SkinGetPoweredBy hook to getPoweredBy() Marked obsolete since patch has already been applied. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 --- Comment #34 from DaSch 2011-07-14 15:26:58 UTC --- And now again something was changed and my costum icon is not displayed anymore... what's happening here :o -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 --- Comment #33 from DaSch 2011-07-02 08:15:39 UTC --- Maybe you should take a look at the Skin I'm maintaining and what your Deprecation does to my code https://sourceforge.net/apps/trac/wecowi/browser/trunk/skins/Cavendish.php -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 Reedy changed: What|Removed |Added Keywords||need-review, patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 --- Comment #32 from Daniel Friesen 2011-07-01 20:35:06 UTC --- poweredbyico and copyrightico are deprecated. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463
--- Comment #31 from DaSch 2011-07-01 18:15:34 UTC ---
well, the implementation is buggy, the icons added by mediawiki and semantic
mediawiki show of with $this->html('poweredbyico') but the one added through
$wgFooterIcons does not show up
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 --- Comment #30 from Daniel Friesen 2011-07-01 12:34:43 UTC --- (In reply to comment #29) > Well, somehow we now ended up with a solution that is far away from what I > though of. Simply adding > > $wgFooterIcons['poweredby']['BinLayer'] = array ( > 'src' => "http://bl.wavecdn.de/lan/banner/de/88_31_1.gif";, > 'url' => "https://binlayer.com/ref-191183.html";, > 'alt' => "BinLayer"); > > to LocalSettings.php does not work and that was the intention. Like I see I > would have to create a Extension and using this Hook for adding an Icon. The > idea was that this could be used by users and developers, not only by > developers Erm, you might want to double check some stuff, that IS supposed to work. And my tests with stuff like that wave worked perfectly fine. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 DaSch changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #29 from DaSch 2011-07-01 11:35:44 UTC --- Well, somehow we now ended up with a solution that is far away from what I though of. Simply adding $wgFooterIcons['poweredby']['BinLayer'] = array ( 'src' => "http://bl.wavecdn.de/lan/banner/de/88_31_1.gif";, 'url' => "https://binlayer.com/ref-191183.html";, 'alt' => "BinLayer"); to LocalSettings.php does not work and that was the intention. Like I see I would have to create a Extension and using this Hook for adding an Icon. The idea was that this could be used by users and developers, not only by developers -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 --- Comment #28 from Daniel Friesen 2010-12-04 20:57:34 UTC --- I ended up dropping that part out of the footerlinks code and instead implementing $wgFooterIcons in r77741. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463
--- Comment #27 from Daniel Friesen
2010-12-04 18:13:47 UTC ---
I'm playing around with footerlinks right now a side effect of my tweaks would
actually allow for a SkinTemplateOutputPageBeforeExec hook to
$tpl->set('poweredbysmwico', '...'); and
$tpl->data["footerlinks"]["icons"]["right"][] = "poweredbysmwico"; to add
another icon. This flexibly also permits things on the left, and works nice in
vector.
Overcrowding in monobook also has a preference to allow the icons to be trimmed
back to just a normal 1 on each side.
Actually thinking about the SkinGetPoweredBy hook, it actually doesn't add any
special new functionality. Using SkinTemplateOutputPageBeforeExec you could
already use $tpl->set('poweredbyico', to replace the ico in the same way that
the new hook allows. It's a little redundant and doesn't add enough
flexibility.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 DaSch changed: What|Removed |Added Attachment #7817|0 |1 is obsolete|| --- Comment #26 from DaSch 2010-11-16 01:29:17 UTC --- Created attachment 7820 --> https://bugzilla.wikimedia.org/attachment.cgi?id=7820 reworked new patch rework with some fixes now even works with only a key and an url given -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 DaSch changed: What|Removed |Added Attachment #7816|0 |1 is obsolete|| --- Comment #25 from DaSch 2010-11-14 19:16:29 UTC --- Created attachment 7817 --> https://bugzilla.wikimedia.org/attachment.cgi?id=7817 For plain-links and image links This is an alternative that switches between image-links and plain-link by checking if an image is given or not. There is no HTML included so designers can really on the HTML that is returned. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 --- Comment #24 from DaSch 2010-11-14 19:03:31 UTC --- I think the best would be if there where 3 thinks in the array image, url, title If image and url are given, the image is shown, if no image is given then it would be a plain link with title as text -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 --- Comment #23 from Platonides 2010-11-14 18:57:55 UTC --- I like DaSch approach. It could be an array with either or image and url or html. I don't see a clean way to merge that with Modern approach of showing just text, though. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 --- Comment #22 from DaSch 2010-11-14 16:53:50 UTC --- well... but that's truely no enduser solution and it does not give a standarized output. With this hook you can and nearly anything to skin cause you give the full HTML. When somebody uses a different skin this may even lead to total page brake. That's not a nice easy to use solution. The idea is that every admin can add an icon just by putting in the url of the picture and a link. An that the output is that reliable that every skin designer can use the given format und fit it into the skin. In some skins this means that they are in one row in other skins this maybe in a colon. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463
--- Comment #21 from Raimond Spekking 2010-11-14
15:52:35 UTC ---
(In reply to comment #19)
> I'm really disapoinnted about what was made from my idea. My idea was to give
> the possibilty to add buttons through a variable so that it could also easily
> be done through configuration without any extension. With the hook implemented
> now it's just more complex. The point was that maybe somebody would also like
> to add a button for his hoster or something like this. I really do not
> understand why my simple solution was not applied but a hook was added that
> fast.
It's very easy now too. Please see what I added to LocalSettings.php of
Translatewiki:
$wgHooks['SkinGetPoweredBy'][] = 'efPoweredBy';
function efPoweredBy( &$text ) {
$text = "http://www.netcup.de/\";
title=\"Powered by netcup - Webspace and vServer\" target=\"_blank\">Powered by
netcup - Webspace and vServer";
return true;
}
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 --- Comment #20 from DaSch 2010-11-14 11:28:15 UTC --- Created attachment 7816 --> https://bugzilla.wikimedia.org/attachment.cgi?id=7816 alternative idea/patch Maybe it should be simple done this way. Then it would also be possible to add icons from other pages. Like this $wgPoweredBy['BinLayer'] = array ( 'image' => "http://bl.wavecdn.de/lan/banner/de/88_31_1.gif";, 'url' => "https://binlayer.com/ref-191183.html";); Just don't know now where to put the standard mediawiki button. Must be somewhere before local settings so it could be turned of and somewhere after Setup.php so that the skin path is already set -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 --- Comment #19 from DaSch 2010-11-14 10:54:07 UTC --- I'm really disapoinnted about what was made from my idea. My idea was to give the possibilty to add buttons through a variable so that it could also easily be done through configuration without any extension. With the hook implemented now it's just more complex. The point was that maybe somebody would also like to add a button for his hoster or something like this. I really do not understand why my simple solution was not applied but a hook was added that fast. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 --- Comment #18 from Daniel Friesen 2010-11-10 19:58:51 UTC --- (In reply to comment #17) > (In reply to comment #15) > > Just wondering, do we really want every extension adding buttons there? The > > average wiki (or wikipedia, which i geuss isn't that average) has something > > like 57 extensions installed. If each one added a button it'd get might > > crowded > > down there. On the other hand, I suppose (in the ideal world where extension > > authors show restraint) only extensions that significantly change mediawiki > > (like smw) would add a button. > > True, however I suppose its more for things like SMW, wiki farms and buttons > for hosting providers. For example: http://shoutwiki.com and Sourceforge > project web sites. True, though don't most of the people currently doing buttons for those in a custom way try to add new buttons rather than replace the MediaWiki powered by? Shouldn't we also try standardizing a newer button list (copyright, powered by, hosted by, extension powered [just for smw like large exts], etc...) which is supported by skins that have specifically coded support for it and can support more than just two buttons? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 Lewis Cawte changed: What|Removed |Added CC||lewisca...@hotmail.co.uk --- Comment #17 from Lewis Cawte 2010-11-10 19:48:01 UTC --- (In reply to comment #15) > Just wondering, do we really want every extension adding buttons there? The > average wiki (or wikipedia, which i geuss isn't that average) has something > like 57 extensions installed. If each one added a button it'd get might > crowded > down there. On the other hand, I suppose (in the ideal world where extension > authors show restraint) only extensions that significantly change mediawiki > (like smw) would add a button. True, however I suppose its more for things like SMW, wiki farms and buttons for hosting providers. For example: http://shoutwiki.com and Sourceforge project web sites. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 Raimond Spekking changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #16 from Raimond Spekking 2010-11-10 08:19:18 UTC --- Yaron's patch applied with r76434 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 --- Comment #15 from Bawolff 2010-11-09 18:01:23 UTC --- Just wondering, do we really want every extension adding buttons there? The average wiki (or wikipedia, which i geuss isn't that average) has something like 57 extensions installed. If each one added a button it'd get might crowded down there. On the other hand, I suppose (in the ideal world where extension authors show restraint) only extensions that significantly change mediawiki (like smw) would add a button. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 Yaron Koren changed: What|Removed |Added Attachment #7105|0 |1 is obsolete|| --- Comment #14 from Yaron Koren 2010-11-09 17:25:56 UTC --- Created attachment 7806 --> https://bugzilla.wikimedia.org/attachment.cgi?id=7806 Patch to add new SkinGetPoweredBy hook to getPoweredBy() Well, it looks like I no longer have commit access for MediaWiki, I guess as a result of separate permissions having been created for core and for the extensions. So attached is the code I wanted to check in, that I think solves this problem in a logical way, using a hook. Assuming this looks alright, it would be great if someone could check this in. Thanks, Yaron -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 Daniel Friesen changed: What|Removed |Added CC||mediawiki-b...@nadir-seen-f ||ire.com --- Comment #13 from Daniel Friesen 2010-11-09 08:27:41 UTC --- (In reply to comment #10) > (In reply to comment #8) > > why does it have to be relativ to $wgStylePath? > > Because the path to the skins is stored there. The user can change it. For > example, Wikipedia has $wgStylePath="http://bits.wikimedia.org/skins-1.5";; and > the icon is at > http://bits.wikimedia.org/skins-1.5/common/images/poweredby_mediawiki_88x31.png > > Your patch doesn't allow it. Moreover, it forces the user to have the wiki > installed in the root. It would also break for a wiki placed on > www.example.com/mediawiki/index.php. I really don't like the idea of this being required as relative to $wgStylePath. It should be absolute the same way $wgLogo, $wgFavicon, etc... all are. There are reasons to want to make this relative to the extensions resources, style path, or even the upload path, what it is relative to should NOT be dictated by the system. And the idea of using ../extensions/ or ../images/ is messed up, that's making assumptions about where the user's extensions and images may be. Upload paths, and more recently extension resource paths are customizable. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 --- Comment #12 from Platonides 2010-02-11 14:42:00 UTC --- That looks better. It's probably worth to also htmlspecialchars $key -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463
DaSch changed:
What|Removed |Added
Attachment #7104|0 |1
is obsolete||
--- Comment #11 from DaSch 2010-02-11 14:36:38 UTC ---
Created an attachment (id=7105)
--> (https://bugzilla.wikimedia.org/attachment.cgi?id=7105)
This way?
okay, but with setting the default value I have one problem, this should work
this way.
When I set
$wgPoweredBy['Semantic MediaWiki'] = array(
'image' => "../extensions/SemanticMediaWiki/skins/images/smw_button.png",
'url' => "http://semantic-mediawiki.org/";);
In LocalSettings I append it
When I set
$wgPoweredBy = array('Semantic MediaWiki' => array(
'image' => "../extensions/SemanticMediaWiki/skins/images/smw_button.png",
'url' => "http://semantic-mediawiki.org/";));
I will only see this one, so I think it should only be det in default settings
with the default value
So I put the default value in LocalSettings and put the StylePath into the
function again
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 --- Comment #10 from Platonides 2010-02-11 14:26:58 UTC --- (In reply to comment #8) > why does it have to be relativ to $wgStylePath? Because the path to the skins is stored there. The user can change it. For example, Wikipedia has $wgStylePath="http://bits.wikimedia.org/skins-1.5";; and the icon is at http://bits.wikimedia.org/skins-1.5/common/images/poweredby_mediawiki_88x31.png Your patch doesn't allow it. Moreover, it forces the user to have the wiki installed in the root. It would also break for a wiki placed on www.example.com/mediawiki/index.php. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463
--- Comment #9 from Chad H. 2010-02-11 14:14:49 UTC
---
(In reply to comment #8)
> why does it have to be relativ to $wgStylePath?
> I have
> $wgPoweredBy['Semantic MediaWiki'] = array
> ("/extensions/SemanticMediaWiki/skins/images/smw_button.png","http://semantic-mediawiki.org/";);
> in my config, for example
>
That's easily done with
'../extensions/SemanticMediaWiki/skins/images/smw_button.png'
> well with the parameters for clarity I don't know how to make the foreach I
> have no experiance in programming, so I will not provide more patches, take it
> or leave it
Instead of using [0] and [1] to get the values, you'd use ['url'] and
['image']. The foreach wouldn't change.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 Raimond Spekking changed: What|Removed |Added CC||raimond.spekk...@gmail.com -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463
--- Comment #8 from DaSch 2010-02-11 13:54:46 UTC ---
why does it have to be relativ to $wgStylePath?
I have
$wgPoweredBy['Semantic MediaWiki'] = array
("/extensions/SemanticMediaWiki/skins/images/smw_button.png","http://semantic-mediawiki.org/";);
in my config, for example
well with the parameters for clarity I don't know how to make the foreach I
have no experiance in programming, so I will not provide more patches, take it
or leave it
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 Chad H. changed: What|Removed |Added CC||innocentkil...@gmail.com --- Comment #7 from Chad H. 2010-02-11 13:47:33 UTC --- 1) $wgPoweredBy should be initialized as an empty array, then the default value for MediaWiki can be added. Also needs documentation. This should be done in DefaultSettings, not Setup. Rather than putting $wgStylePath in the image path, just start with 'common/images...' (and then use $wgStylePath when generating the URL). As long as it's clearly documented that $wgPoweredBy images are relative to $wgStylePath, this is fine. 2) Need a space after 'by' in the alt text. 3) I would suggest using named array keys for the URL and image parameters for clarity. Something like: array( 'url' => 'http://mediawiki.org', 'image' => 'common/images/poweredby_mediawiki_88x31.png' ) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 DaSch changed: What|Removed |Added Attachment #7100|0 |1 is obsolete|| --- Comment #6 from DaSch 2010-02-11 13:41:08 UTC --- Created an attachment (id=7104) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=7104) New Patch with value in Setup.php Okay, I move it from DefaultSetting.php to Setup.php and used StylePath -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 Platonides changed: What|Removed |Added CC||platoni...@gmail.com --- Comment #5 from Platonides 2010-02-11 13:30:25 UTC --- It completely must not. It should honor $wgStylePath (not expanded until Setup.php), not hardcode the wiki url. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 22463] Change getPoweredBy to be customizable
https://bugzilla.wikimedia.org/show_bug.cgi?id=22463 Bawolff changed: What|Removed |Added CC||bawolff...@gmail.com Component|General/Unknown |User interface Summary|Changed getPoweredBy to be |Change getPoweredBy to be |costumisable|customizable --- Comment #4 from Bawolff 2010-02-11 13:23:06 UTC --- The patch seems to hardcode $wgStylePath into the url for the image, which it probably shouldn't. changed component to user interface. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
