abian added a comment.
Update: I have finished formalizing this constraint as a part of my final degree project, and I will start implementing it at some point in the coming weeks so that this can be finished around May. I will keep you informed. :-)TASK
abian renamed this task from "[Task] Contemporary Constraint check" to "[Task] Contemporary constraint check".abian removed a project: Need-volunteer.abian updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONImplement a check on Wikidata for [[
Amire80 created this task.Amire80 added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, I18n.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONTo reproduce:
Set your language in Wikidata to English.
Go to an item that doesn't have a label in English (example query)
Instead of a
Amire80 created this task.Amire80 added projects: RTL, Wikidata Query UI.Herald added a subscriber: Aklapper.Herald added a project: I18n.
TASK DESCRIPTIONScreenshot:
F12969109: Screenshot-2018-2-2 Wikidata Query Service.png
Notice how the arrow at the top looks like two triangles.
In English
Smalyshev closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T178712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: gerritbot, Jarekt, Aklapper, Smalyshev, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113,
Smalyshev removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T178721EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Gehel, SmalyshevCc: Gehel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE,
Legoktm added a project: Test-Coverage.
TASK DETAILhttps://phabricator.wikimedia.org/T42656EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Liuxinyu970226, Aklapper, Danwe, Krinkle, Wikidata-bugs, Tobi_WMDE_SW, Denny, JeroenDeDauw, adrianheine,
Legoktm added a project: Test-Coverage.
TASK DETAILhttps://phabricator.wikimedia.org/T88435EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Liuxinyu970226, Zppix, Lydia_Pintscher, Aklapper, JanZerebecki, Lahi, Gq86, GoranSMilovanovic, QZanden,
Legoktm added a project: Test-Coverage.
TASK DETAILhttps://phabricator.wikimedia.org/T88434EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Ricordisamoa, Addshore, Legoktm, hashar, JanZerebecki, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden,
Legoktm added a project: Test-Coverage.
TASK DETAILhttps://phabricator.wikimedia.org/T185211EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: gerritbot, hashar, Addshore, Legoktm, greg, Aklapper, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Ladsgroup,
matej_suchanek added subscribers: Jan_Dittrich, daniel.matej_suchanek merged a task: T176404: Item merging should be possible without remembering Q-IDs.
TASK DETAILhttps://phabricator.wikimedia.org/T150204EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
matej_suchanek closed this task as a duplicate of T150204: Enable autocomplete for the textboxes on Special:MergeItems.
TASK DETAILhttps://phabricator.wikimedia.org/T176404EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: daniel,
Legoktm added a comment.
Compare the Wikibase ACL with a normal MediaWiki extension, e.g. https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/MassMessage,access - it really should look like the latter.
However, this only makes sense if nobody in no other extension Wikibase runs
eranroz added a comment.
The first question would be are wikidata sure they want wgIsArticle to be true on item pages?
I suppose this is correct, usually the main/content namespace is "wgIsArticle" (I dont know of any wiki site for which it is false in the main NS).
Possibly this warning can be
He7d3r added projects: _javascript_, Easy, Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T186356EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: He7d3rCc: Aklapper, He7d3r, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier,
gerritbot added a comment.
Change 406241 merged by jenkins-bot:
[wikidata/query/rdf@master] Support continuations in MWAPI
https://gerrit.wikimedia.org/r/406241TASK DETAILhttps://phabricator.wikimedia.org/T178712EMAIL
Esanders added a comment.
This appears on all wikidata item pages: https://www.wikidata.org/wiki/Q45554042
This is similar to T186174. VE is attempting to register itself because wgIsArticle is true, but then stops because the page doesn't have the correct UI components for article editing.
The
Smalyshev reopened this task as "Open".Smalyshev added a comment.
Reopening, still happens: https://integration.wikimedia.org/ci/job/wikidata-query-rdf-maven/238/consoleTASK DETAILhttps://phabricator.wikimedia.org/T178721EMAIL
matej_suchanek added a project: Commons.
TASK DETAILhttps://phabricator.wikimedia.org/T132665EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: El_Grafo, Aklapper, Steinsplitter, Tpt, Nemo_bis, JEumerus, Lahi, Gq86, Minilexikon,
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- to be continued…
Left to do:[ ] [constraint scope arguments](https://gerrit.wikimedia.org/r/407708)
- [ ] prior [refactoring](https://gerrit.wikimedia.org/r/407707)
- [ ] [constraint scope list
gerritbot added a comment.
Change 407709 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for constraint scope lists to ViolationMessage
https://gerrit.wikimedia.org/r/407709TASK
gerritbot added a comment.
Change 407710 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for language to ViolationMessage
https://gerrit.wikimedia.org/r/407710TASK
gerritbot added a comment.
Change 407708 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for constraint scopes to ViolationMessage
https://gerrit.wikimedia.org/r/407708TASK
gerritbot added a comment.
Change 407707 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Inject Config into ViolationMessageRenderer
https://gerrit.wikimedia.org/r/407707TASK
debt closed subtask T184083: Define the constraints of the new WDQS cluster as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T178492EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: debtCc: Daniel_Mietchen, BBlack, Lydia_Pintscher, Volans, mobrovac,
debt closed this task as "Resolved".debt added a comment.
TASK DETAILhttps://phabricator.wikimedia.org/T184083EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Gehel, debtCc: debt, EBernhardson, Lucas_Werkmeister_WMDE, Smalyshev, Gehel, Aklapper, Lahi,
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- add argument type “constraint scope” (incl. list)
- add argument type “language”, probably (corresponds to one param for autonym and one param for language code)...TASK
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- remove most of `ConstraintParameterRenderer`
- remove injected `ConstraintParameterRenderer` from checkers and helpers (at this point, it might be interesting to check the `git diff --stat 407387c
thiemowmde added a comment.
I'm bringing this up because this ticket is linked to the "derived labels" ticket T175030, but I do not think this ticket here will help in any way with that. Having a better LexemeIdFormatter will probably not help much when it comes to the search integration. And RDF
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- to be continued…
Left to do:
- add argument type “constraint scope”
- add argument type “language”, probably (corresponds to one param for autonym and one param for language code)
- {T185999}
-
Lucas_Werkmeister_WMDE added a comment.
I just realized that we also have the same problem in some code that’s already deployed on wikidata.org – the “text matches regex” cache can contain a serialized ConstraintParameterException, where “serialized” means “take the localized message and put it in
WMDE-leszek added a comment.
What the patches don't cover (possibly because of this tasks wording) are:
How to put derived Lexeme labels, descriptions, and "aliases" a.k.a. "secondary labels" (whatever that is on a Lexeme, maybe the Forms?) into wb_terms and search indexes?
Is an
Lucas_Werkmeister_WMDE closed this task as "Resolved".Lucas_Werkmeister_WMDE moved this task from Backlog to Done on the Wikidata-Sprint-2018-01-31 board.Lucas_Werkmeister_WMDE claimed this task.Lucas_Werkmeister_WMDE added a comment.
Should be fixed now, and it’s probably not worth backporting,
gerritbot added a comment.
Change 407657 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for FormatChecker
https://gerrit.wikimedia.org/r/407657TASK
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- [x] [extra test](https://gerrit.wikimedia.org/r/407044)
- [ ] [inline code arguments](https://gerrit.wikimedia.org/r/407653)
- [ ] `ViolationMessageRenderer` refactorings
gerritbot added a comment.
Change 407655 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Simplify ViolationMessageRenderer::renderArgument
https://gerrit.wikimedia.org/r/407655TASK
gerritbot added a comment.
Change 407656 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for multilingual text to ViolationMessage
https://gerrit.wikimedia.org/r/407656TASK
gerritbot added a comment.
Change 407654 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Make ViolationMessageRenderer::renderArgument return params
https://gerrit.wikimedia.org/r/407654TASK
gerritbot added a comment.
Change 407653 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for inline code to ViolationMessage
https://gerrit.wikimedia.org/r/407653TASK
thiemowmde added a comment.
In addition to a few more specific comments I left on the Gerrit patches, here is what I think about the different approaches:
LexemeIdHtmlFormatter
https://gerrit.wikimedia.org/r/406306 registers a formatter via the existing registry infrastructure Wikibase provides
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).
TASK DETAILhttps://phabricator.wikimedia.org/T175491EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, ReleaseTaggerBotCc: gerritbot, TerraCodes, aude,
Chicocvenancio edited projects, added Tools; removed Toolforge.
TASK DETAILhttps://phabricator.wikimedia.org/T146750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01, ChicocvenancioCc: Yaron_Koren, Tinaj1234, Slaporte, Aklapper, Lydia_Pintscher, hoo,
thiemowmde closed this task as "Resolved".thiemowmde updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...[x] Update custom test runner to work with php_codesniffer 3.x: https://github.com/wmde/WikibaseCodeSniffer/pull/16
[x] Review sniffs added in and update to
thiemowmde added subscribers: Lydia_Pintscher, aude, hoo, thiemowmde.thiemowmde added a comment.
From looking at the provided page I'm not able to understand the "mess".
I would like to argue for giving all people that already have +2 rights also the right to force-merge. This can be a helpful
gerritbot added a comment.
Change 407408 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add missing messages for Wikibase autocomments
https://gerrit.wikimedia.org/r/407408TASK DETAILhttps://phabricator.wikimedia.org/T175491EMAIL
thiemowmde closed this task as "Resolved".thiemowmde edited projects, added Wikidata-Sprint-2018-01-31; removed Patch-For-Review.thiemowmde claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T175491EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
D3r1ck01 removed a project: Africa-Wikimedia-Developers.
TASK DETAILhttps://phabricator.wikimedia.org/T146750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01Cc: Yaron_Koren, Tinaj1234, Slaporte, Aklapper, Lydia_Pintscher, hoo, 01tonythomas, Bene,
WMDE-leszek created this task.WMDE-leszek triaged this task as "High" priority.WMDE-leszek added projects: Lexicographical data, Wikidata, Wikidata-Sprint-2018-01-31.
TASK DESCRIPTIONWhen forms is added, the change should be visible when diffing relevant revisions of the lexeme.
When forms is
thiemowmde added subscribers: Lydia_Pintscher, thiemowmde, WMDE-leszek.thiemowmde added projects: MediaWiki-extensions-WikibaseRepository, Technical-Debt.thiemowmde added a comment.
I can not think of a good way that utilizes escaping to avoid this.
What we could do is to apply some validation to
thiemowmde added a comment.
From the discussion I had with @Lydia_Pintscher on Wednesday:
In our discussion we confirmed this: The user is able to edit as many grammatical features and representations as he wants the same time. One click on the save button should trigger one API request, and
Addshore added a comment.
So you can have a look at the log for everything (checkout the docker-compose logs command), a paste of those would help pin down what happened.
Although if you have already run 'down' then the containers have been removed and the logs won't exist any more.
When I then
WMDE-leszek renamed this task from "Introduce class for constraint violation messages" to "Introduce class for constraint violation messages (days: 1)".
TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
WMDE-leszek renamed this task from "Investigation: How to make it possible to format a Lexeme used in a statement (days: 3)" to "Investigation: How to make it possible to format a Lexeme used in a statement (days: 4)".
TASK DETAILhttps://phabricator.wikimedia.org/T185332EMAIL
WMDE-leszek renamed this task from "Set the edit summary when editing the representation and/or grammatical features of the form (days: 9)" to "Set the edit summary when editing the representation and/or grammatical features of the form (days: 10)".
TASK
WMDE-leszek renamed this task from "Make i18n keys in WikibaseLexeme consistent (days: 4)" to "Make i18n keys in WikibaseLexeme consistent (days: 5)".
TASK DETAILhttps://phabricator.wikimedia.org/T185761EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Mrjohncummings added a comment.
Would it be possible to add the name of the organisation producing or providing the data by stripping the URLs to just the root URLs and then 'official website (P856)' to get the name?TASK DETAILhttps://phabricator.wikimedia.org/T185308EMAIL
jhsoby added a comment.
Many wikis use Yair rand's WikidataInfo.js as a gadget, it's worth taking a look at that.TASK DETAILhttps://phabricator.wikimedia.org/T186218EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc: jhsoby, Lydia_Pintscher, Addshore,
jhsoby added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T186308EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc: jhsoby, Aklapper, eranroz, Lahi, Gq86, Necroarcano, Robinma, GoranSMilovanovic, QZanden, merbst, LawExplorer, Wess,
Legoktm added a comment.
See https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Generating_PHP_test_coverage_for_a_MediaWiki_extension for how to get this enabled for Wikibase. I believe this is currently blocked on the fact Wikibase is not following the standard directory layout of
WMDE-leszek added a comment.
Wow, what a mess. At this point I see no reason to allow force-pushing, V+2 etc. But will verify whether this is required, and for what reason with my more experienced colleagues.TASK DETAILhttps://phabricator.wikimedia.org/T183081EMAIL
Andrawaag added a comment.
I actually don't know when things went wrong. I launched all containers using docker compose. Upon initiation, seems to work. I then launched a bot to populate the wiki base instance. Which ran overnight to at around 180lk items. When I then tried to run some SPARQL
61 matches
Mail list logo
