gerritbot added a comment.
Change 442738 abandoned by Jdlrobson:
Limit wgMathEnableWikibaseDataType to wikidata
Reason:
Doesn't look like this will be needed anymore
https://gerrit.wikimedia.org/r/442738TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL
CCicalese_WMF reassigned this task from Tgr to daniel.CCicalese_WMF added a subscriber: Tgr.
TASK DETAILhttps://phabricator.wikimedia.org/T194048EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, CCicalese_WMFCc: Tgr, gerritbot, Aklapper, daniel,
Pablo-WMDE added a comment.
Unfortunately I could not come up with a completely different, more robust, approach of setting the value on the ComboBoxWidget.
I tried a couple of different ways of improving what was, making sure it is not the sheer speed at which the UI interactions are performed
CCicalese_WMF moved this task from MCR-SDC Storage Layer - phase 1 to MCR-SDC File Caption Support - phase 2 on the Multi-Content-Revisions board.CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2); removed Multi-Content-Revisions (MCR-SDC Storage
daniel added a comment.
@ArielGlenn I'm happy to be a co-author, I just can't invest much time into this right now. Thanks for taking care of this!TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlenn,
ArielGlenn added a comment.
@daniel I am about to steal a bunch of your preliminary work and comments in order to craft a workable proposal (see the link in the task description now); for this reason you are listed as a co-author of the RFC. If you would rather not, please say so and I'll just
ArielGlenn updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONThis is a placeholder ticket for an RFC about how the content of multiple slots should be represented in XML dumps.
Preliminary thoughtsDraft in progress (proposal section still empty) at:
Lydia_Pintscher added a comment.
Autonyms where possible. We do it in other places as well.TASK DETAILhttps://phabricator.wikimedia.org/T198202EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, Lydia_PintscherCc: Addshore, Lucas_Werkmeister_WMDE,
Lydia_Pintscher added a project: Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T155374EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, Lydia_PintscherCc: gerritbot, Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper,
Lydia_Pintscher added a project: Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T155418EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, Lydia_PintscherCc: gerritbot, Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper,
Lydia_Pintscher added a project: Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T155421EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, Lydia_PintscherCc: gerritbot, Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper,
Lydia_Pintscher added a project: Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T155420EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, Lydia_PintscherCc: gerritbot, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter, Gaboe420,
Lydia_Pintscher added a project: Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T155427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, Lydia_PintscherCc: gerritbot, Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper,
Lydia_Pintscher added a project: Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T155431EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, Lydia_PintscherCc: gerritbot, PokestarFan, Mbch331, Lydia_Pintscher, jhsoby, GerardM, Aklapper,
gerritbot added a comment.
Change 451327 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] NewLexemePage: lemma language in selenium test
https://gerrit.wikimedia.org/r/451327TASK
matej_suchanek assigned this task to jhsoby.
TASK DETAILhttps://phabricator.wikimedia.org/T155431EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, matej_suchanekCc: gerritbot, PokestarFan, Mbch331, Lydia_Pintscher, jhsoby, GerardM, Aklapper,
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T155418EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, gerritbotCc: gerritbot, Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter,
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T155427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, gerritbotCc: gerritbot, Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter,
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T155421EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, gerritbotCc: gerritbot, Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter,
gerritbot added a comment.
Change 451316 had a related patch set uploaded (by Matěj Suchánek; owner: Jon Harald Søby):
[mediawiki/extensions/Wikibase@master] Add monolingual language codes
https://gerrit.wikimedia.org/r/451316TASK DETAILhttps://phabricator.wikimedia.org/T155427EMAIL
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T155431EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, PokestarFan, Mbch331, Lydia_Pintscher, jhsoby, GerardM, Aklapper, Bugreporter, Gaboe420,
gerritbot added a comment.
Change 451316 had a related patch set uploaded (by Matěj Suchánek; owner: Jon Harald Søby):
[mediawiki/extensions/Wikibase@master] Add monolingual language codes
https://gerrit.wikimedia.org/r/451316TASK DETAILhttps://phabricator.wikimedia.org/T155374EMAIL
gerritbot added a comment.
Change 451316 had a related patch set uploaded (by Matěj Suchánek; owner: Jon Harald Søby):
[mediawiki/extensions/Wikibase@master] Add monolingual language codes
https://gerrit.wikimedia.org/r/451316TASK DETAILhttps://phabricator.wikimedia.org/T155418EMAIL
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T155374EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, gerritbotCc: gerritbot, Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter,
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T155420EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, gerritbotCc: gerritbot, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter, Gaboe420, Versusxo,
gerritbot added a comment.
Change 451316 had a related patch set uploaded (by Matěj Suchánek; owner: Jon Harald Søby):
[mediawiki/extensions/Wikibase@master] Add monolingual language codes
https://gerrit.wikimedia.org/r/451316TASK DETAILhttps://phabricator.wikimedia.org/T155431EMAIL
gerritbot added a comment.
Change 451316 had a related patch set uploaded (by Matěj Suchánek; owner: Jon Harald Søby):
[mediawiki/extensions/Wikibase@master] Add monolingual language codes
https://gerrit.wikimedia.org/r/451316TASK DETAILhttps://phabricator.wikimedia.org/T155420EMAIL
gerritbot added a comment.
Change 451316 had a related patch set uploaded (by Matěj Suchánek; owner: Jon Harald Søby):
[mediawiki/extensions/Wikibase@master] Add monolingual language codes
https://gerrit.wikimedia.org/r/451316TASK DETAILhttps://phabricator.wikimedia.org/T155421EMAIL
zeljkofilipin removed a project: User-zeljkofilipin.
TASK DETAILhttps://phabricator.wikimedia.org/T201337EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE, zeljkofilipinCc: Pablo-WMDE, hoo, gerritbot, Addshore, Mringgaard, Gaboe420, Versusxo,
Bugreporter added a comment.
In addition we should forwardly review all ISO 639 code (in batch). It is unmanageable if we need to create 7000 tasks to add every languages to Wikidata or a similar database.TASK DETAILhttps://phabricator.wikimedia.org/T201509EMAIL
Bugreporter added a comment.
Note "https://www.wikidata.org/wiki/Wikidata:Requests_for_comment/How_to_make_new_languages_enabled_on_Wikidata" says "to add a new label language, add it to MediaWiki"; this is because of they have negative effects. However I doubt how much negative effects it have
jhsoby closed this task as "Invalid".jhsoby added a comment.
I actually totally agree with that. The system needs a rethinking and reworking, so we should start a task for that instead (if there isn't one already?).TASK DETAILhttps://phabricator.wikimedia.org/T201509EMAIL
jhsoby claimed this task.jhsoby added a comment.
Ok from Langcom, patch submitted here.TASK DETAILhttps://phabricator.wikimedia.org/T155418EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc: Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby,
jhsoby claimed this task.jhsoby added a comment.
Ok from Langcom, patch submitted here.TASK DETAILhttps://phabricator.wikimedia.org/T155374EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc: Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby,
jhsoby claimed this task.jhsoby added a comment.
Ok from Langcom, patch submitted here.TASK DETAILhttps://phabricator.wikimedia.org/T155420EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc: Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter, Lahi,
jhsoby claimed this task.jhsoby added a comment.
Ok from Langcom, patch submitted here.TASK DETAILhttps://phabricator.wikimedia.org/T155421EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc: Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby,
Bugreporter added a comment.
Personally I think we should abolish this Wikidata-specific setting. We should just allow all languages in ULS (which will be the same as in https://github.com/wikimedia/language-data/blob/master/data/langdb.yaml) to be used in Wikidata (as monolingual language, label
jhsoby claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T155427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc: Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter, Lahi, Gq86, GoranSMilovanovic, QZanden,
jhsoby added a comment.
Ok from Langcom, patch submitted here.TASK DETAILhttps://phabricator.wikimedia.org/T155427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc: Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter, Lahi,
jhsoby added a comment.
Ok from Langcom, patch submitted here.TASK DETAILhttps://phabricator.wikimedia.org/T155431EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc: PokestarFan, Mbch331, Lydia_Pintscher, jhsoby, GerardM, Aklapper, Bugreporter, Lahi,
matej_suchanek closed this task as "Invalid".matej_suchanek added a comment.
It appears this was a mistake on my part.
Fine, that's better than mistake in the system. Please report again if you think there's a problem.TASK DETAILhttps://phabricator.wikimedia.org/T201275EMAIL
Daask added a comment.
It appears this was a mistake on my part.
The Wikipedia API shows echo-subscriptions-web-wikibase-action set to true. Wikipedia notifications preferences now shows the "Connection with Wikidata" option clearly checked. Unchecking the box just now changed
Nikki added a comment.
@Bluepossum Based on your edits, it seems like you are trying to add entries for words, like in Wiktionary. If so, you want to add lexemes not items (items represent concepts, not words). The page for adding new lexemes is https://www.wikidata.org/wiki/Special:NewLexeme.
Pablo-WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration5.
TASK DETAILhttps://phabricator.wikimedia.org/T201337EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Pablo-WMDE, hoo, gerritbot, Addshore, Mringgaard, Gaboe420,
Addshore reassigned this task from Addshore to Pablo-WMDE.Addshore added a subscriber: Pablo-WMDE.Addshore added a comment.
@Pablo-WMDE is taking this over now :)TASK DETAILhttps://phabricator.wikimedia.org/T201337EMAIL
Addshore added a subscriber: hoo.Addshore added a comment.
@hoo also just pointed out that if you enter "en" and wait for the dropdown selection to select English, but you happen to have your mouse over another value in the drop down list when you hit "Enter" rather than en / English be selected,
Daask updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...I have reviewed both [[ https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-echo | Wikipedia preferences ]] and Wikidata preferences, I have not activated the "Connection with Wikidata" option in either
jhsoby created this task.jhsoby added a project: Wikidata.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONWould it be possible to have a subproject of #wikidata here on Phabricator to keep track of the monolingual language code requests, instead of using the tracking task
Aleksey_WMDE added a comment.
Patch is merged - should be fixed.
I think we should wait, lets say, for a week and if nothing pops up close the ticket.TASK DETAILhttps://phabricator.wikimedia.org/T201453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
jhsoby added a comment.
I am sceptical of this one, as Zapotec is a language group, not an individual language. I'm therefore inclined to reject this.TASK DETAILhttps://phabricator.wikimedia.org/T155434EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc:
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).
TASK DETAILhttps://phabricator.wikimedia.org/T201453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDE, ReleaseTaggerBotCc: gerritbot, Addshore,
ReleaseTaggerBot edited projects, added MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)); removed MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).
TASK DETAILhttps://phabricator.wikimedia.org/T196882EMAIL
gerritbot added a comment.
Change 451298 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix SimpleCacheWithBagOStuff test flackiness
https://gerrit.wikimedia.org/r/451298TASK DETAILhttps://phabricator.wikimedia.org/T201453EMAIL
Nikki renamed this task from "Add monolingual language code hez (Hazaragi)" to "Add monolingual language code haz (Hazaragi)".
TASK DETAILhttps://phabricator.wikimedia.org/T155374EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NikkiCc: Mbch331, PokestarFan,
Addshore added a comment.
In PS5 of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/450970/ I added a bunch of screenshots to capture what happens
They can be found @ https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php70-docker/2788/ but as that will
gerritbot added a comment.
Change 442260 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Added CachingFallbackLabelDescriptionLookup
https://gerrit.wikimedia.org/r/442260TASK DETAILhttps://phabricator.wikimedia.org/T196882EMAIL
matej_suchanek edited projects, added Notifications, MediaWiki-User-preferences; removed Bug-Report, MediaWiki-Categories.matej_suchanek added a comment.Restricted Application added a project: Growth-Team.
I would expect the "Connection with Wikidata" option at English Wikipedia preferences to
hoo added a comment.
One question I just came across… what language shall we show the available languages in? Shall we use autonyms (native names)? What about languages that are not in CLDR?
We can either integrate these names into the API output (which is ok for autonyms, but maybe a little
gerritbot added a comment.
Change 451016 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Introduce SenseIdTextFormatter
https://gerrit.wikimedia.org/r/451016TASK DETAILhttps://phabricator.wikimedia.org/T196264EMAIL
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).
TASK DETAILhttps://phabricator.wikimedia.org/T201337EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, ReleaseTaggerBotCc: gerritbot, Addshore, Mringgaard,
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T201453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDE, gerritbotCc: gerritbot, Addshore, WMDE-leszek, Aleksey_WMDE, Krinkle, Aklapper, Gaboe420, Versusxo,
gerritbot added a comment.
Change 451298 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix SimpleCacheWithBagOStuff test flackiness
https://gerrit.wikimedia.org/r/451298TASK
zeljkofilipin added a project: User-zeljkofilipin.
TASK DETAILhttps://phabricator.wikimedia.org/T201337EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, zeljkofilipinCc: gerritbot, Addshore, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22,
Aleksey_WMDE added a comment.
Both solutions don't work for test when 0 is given as TTL. Special case is needed.TASK DETAILhttps://phabricator.wikimedia.org/T201453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Addshore, WMDE-leszek,
Addshore added a comment.
With the patches merged we now have a slightly more informative error:
https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php70-docker/2785/console
11:12:33 1) NewLexeme:Page for different lemma languages can create lexeme with language item not bearing
gerritbot added a comment.
Change 451275 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] selenium, new.js, fix assertion param order
https://gerrit.wikimedia.org/r/451275TASK DETAILhttps://phabricator.wikimedia.org/T201337EMAIL
Pablo-WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* Text and design on Special:MergeLexemes should be the same as on Special:MergeItems with s/Items/Lexemes. The text for the longer message should be "If you merge two Lexemes, all Lemmas, Statements, Forms and
Physikerwelt added a comment.
I am not sure if that's the way to go. Neither the Math extension depends on Wikibase nor the other way round. For the CI math depends on wikibase. This is good for WMF applications. However, for private wikis that use Math but not wikibase this is not optimal since
Lydia_Pintscher moved this task from ready to go to needs discussion or investigation on the Wikidata board.Lydia_Pintscher added a comment.
Still needs more discussion because we don't know what the solution could look like.TASK
Physikerwelt added a comment.
@WMDE-leszek thank you. Yes. My local wikibase copy was not up to date when I created the change (cf. Patch set 1).TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 450574 abandoned by Pablo Grass (WMDE):
DifferentEntities: add validator
Reason:
EntityId::equals() should do
https://gerrit.wikimedia.org/r/450574TASK DETAILhttps://phabricator.wikimedia.org/T198106EMAIL
Aleksey_WMDE added a comment.
Solution 2:
Add 1 to the result of time() and $date->getTimestamp(). In this case effective TTL will always be up to 1 second greater than the given one. In production it will not matter; Tests already sleep for 2 seconds when TTL is 1 second, which is always
hoo added a subscriber: Addshore.hoo added a comment.
Talking to @Addshore, we probably want to go for something along the lines of action="">.TASK DETAILhttps://phabricator.wikimedia.org/T198202EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Addshore,
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T201337EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: gerritbot, Addshore, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci,
gerritbot added a comment.
Change 451275 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] selenium, new.js, fix assertion param order
https://gerrit.wikimedia.org/r/451275TASK DETAILhttps://phabricator.wikimedia.org/T201337EMAIL
Aleksey_WMDE claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T201453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Addshore, WMDE-leszek, Aleksey_WMDE, Krinkle, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer,
Aleksey_WMDE added a comment.
The failure happened in code where we store a value with TTL 1s and next line try to get it back. The value was considered expired, so null was returned.
The failure, probably, happened because we use time() and $date->getTimestamp() which return integer values. So
Addshore added a comment.
In T201496#4487857, @WMDE-leszek wrote:
as mentioned in the description, this might not be immediately actionable, but will let @hashar decide on the order of things when he's back from his well deserved vacation.
I guess we want to try to finish T200508 before trying
Greta_Doci_WMDE added a project: Community-consensus-needed.
TASK DETAILhttps://phabricator.wikimedia.org/T155421EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Greta_Doci_WMDECc: Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter,
Greta_Doci_WMDE added a project: Community-consensus-needed.
TASK DETAILhttps://phabricator.wikimedia.org/T155427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Greta_Doci_WMDECc: Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter,
Greta_Doci_WMDE added a project: Community-consensus-needed.
TASK DETAILhttps://phabricator.wikimedia.org/T155374EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Greta_Doci_WMDECc: Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter,
Aklapper added projects: Continuous-Integration-Config, Wikidata.Aklapper removed subscribers: Continuous-Integration-Config, Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T201496EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc:
WMDE-leszek added a comment.
see T201496 about adjusting Wikibase CI to include Math extension somehowTASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Agabi10, gerritbot,
WMDE-leszek triaged this task as "Normal" priority.WMDE-leszek added a comment.
as mentioned in the description, this might not be immediately actionable, but will let @hashar decide on the order of things when he's back from his well deserved vacation.TASK
WMDE-leszek created this task.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONThere are some code paths in Wikibase that are only run when Math extension is enabled. Running tests with the extension enabled could spot some issues, see e.g. failure mentioned in
Jakob_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* This probably means `` is to be replaced with ``
* the HTML id: in `FormsView` line 105, `$this->templateFactory->render( 'wikibase-lexeme-form' ... )` should inject F1 instead of L1-F1
* the link fragment: in
zeljkofilipin added a comment.
In T200011#4487774, @WMDE-leszek wrote:
hardcoding the directory structure (and name) like done now is a bit evil.
Agreed. Even if you decide you don't care about running tests targeting beta cluster, hard-coding paths to files from another repository is a code
zeljkofilipin added a comment.
In T200011#4487750, @Addshore wrote:
The WikibaseLexeme extension can't function without the Wikibase extension loaded anyway, so the browser tests would never pass anyway.
The Jenkins job (running daily, targeting beta cluster) just clones a repository, runs npm
Addshore reopened subtask T201337: Quibble & WikibaseLexeme: selenium, TypeError: Cannot read property 'value' of undefined as "Open".
TASK DETAILhttps://phabricator.wikimedia.org/T201336EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore,
Addshore reopened this task as "Open".Addshore added a comment.
I ran 3 more check experimentals and 2 passed, 1 failed with the same error...
https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php70-docker/2780/console
hoo added a comment.
It seems that we do this differently for Monolingual texts atm: There this is handled via wikibase.WikibaseContentLanguages which is basically an access wrapper for mw.config.get( 'wgULSLanguages' ) (some languages supported by the backed are missing, though). This is being
Jakob_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* The use of the property id as HTML id attribute is hard-wired into the respective jquery ui widget (`view/resources/jquery/wikibase/jquery.wikibase.statementgroupview.js`) and the widget's value gets used
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).
TASK DETAILhttps://phabricator.wikimedia.org/T196264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, ReleaseTaggerBotCc: gerritbot,
WMDE-leszek added a comment.
However, I wonder how this could be merged without failing tests.
That's the very good point, and I was wondering the same. It seems that Wikibase quibble/phpunit jobs do not pull in Math extension, so that code path was never reached. Will try to get this fixed
gerritbot added a comment.
Change 451015 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make wikibase-sense datatype use entity ID values
https://gerrit.wikimedia.org/r/451015TASK DETAILhttps://phabricator.wikimedia.org/T196264EMAIL
Jakob_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* The use of the property id as HTML id attribute is hard-wired into the respective jquery ui widget (`view/resources/jquery/wikibase/jquery.wikibase.statementgroupview.js`) and the widget's value gets used
WMDE-leszek added a comment.
What you say @Addshore is all correct. But hardcoding the directory structure (and name) like done now is a bit evil.TASK DETAILhttps://phabricator.wikimedia.org/T200011EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Addshore triaged this task as "Low" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T200011EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, WMDE-leszek, zeljkofilipin, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden,
Addshore added a comment.
The WikibaseLexeme extension can't function without the Wikibase extension loaded anyway, so the browser tests would never pass anyway.
Are we sure we can't just keep this cross extension dependency for the modules?TASK
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- [ ] [format lemmas and glo](https://gerrit.wikimedia.org/r/451264)TASK DETAILhttps://phabricator.wikimedia.org/T196264EMAIL
1 - 100 of 134 matches
Mail list logo
