Tarrow added a subscriber: Lucas_Werkmeister_WMDE.Tarrow added a comment.
To try and figure out what needs doing @Lucas_Werkmeister_WMDE helpfully showed a way to dump the dependencies:
graph = 'digraph dependencies{\n';
for (module in mw.loader.moduleRegistry) { for (depended
Tarrow added a comment.
@Jakob_WMDE pointed out and I could reproduce that if running with chrome debug tools set to stop on caught exceptions there is a a notable one thrown on
extensions/Wikibase/view/resources/wikibase/view/ViewFactory.js#650:
because lexemeview is not found after looking
Tarrow claimed this task.Tarrow moved this task from incoming to in progress on the Wikidata board.Tarrow added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).
TASK DETAILhttps://phabricator.wikimedia.org/T204039WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL
Tarrow added a comment.
I can now replicate it and clearing local storage doesn't help meTASK DETAILhttps://phabricator.wikimedia.org/T204039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Jakob_WMDE, Nandana, Mringgaard, Lahi, Gq86
Tarrow created this task.Tarrow triaged this task as "High" priority.Tarrow added projects: Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Lexicographical data.Restricted Application removed a project: Patch-For-Review.
TASK DESCRIPTIONTASK D
Tarrow added a comment.
Looks like changes to just _javascript_ API's post weren't sufficient to catch some edits made to Lexemes:
e.g. Adding a representation to a formTASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
Tarrow created this task.Tarrow triaged this task as "High" priority.Tarrow added projects: Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review.Restricted Application removed a project: Patch-For-Review.
TASK DESCRIPTIONTASK DETAILhttps://phabricator.wik
Tarrow created this task.Tarrow triaged this task as "High" priority.Tarrow added projects: _javascript_, MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review.Restricted Application edited projects, added Wikidata; removed Patch-
Tarrow claimed this task.Tarrow moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
TASK DETAILhttps://phabricator.wikimedia.org/T124451WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps://phabricator.wikimedia.org
Tarrow added a comment.
https://www.wikidata.org/wiki/Special:EntityData/Q8743220.rdf also has some license data maybe we also need to look in other places if it doesn't change automagically.TASK DETAILhttps://phabricator.wikimedia.org/T205016EMAIL PREFERENCEShttps://phabricator.wikimedia.org
Tarrow added a comment.
Whoops, we passed like 'ships in the night' (or should that be 'at lunch'). There is a another patch that should make sure that whatever the globals are set we check that the Wiring will result in a service we can use (or a dummy one we'll ignore).TASK DETAILhttps
Tarrow added a comment.
The two services that are obviously switched in the service wiring based on globals are ResultSource and SparqlHelper. I've uploaded a patch to at least be sure that the various possible settings are tested.
I wonder if the solution may be to remove the logic from
Tarrow added a comment.
Apparently you removed themTASK DETAILhttps://phabricator.wikimedia.org/T204469EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Matthias_Geisler_WMDE, gerritbot, Smalyshev, Jonas, Ladsgroup, Lucas_Werkmeister_WMDE, Addshore
Tarrow removed Tarrow as the assignee of this task.Tarrow added a comment.
Unassigning because I didn't start this yet and it could make a great onboarding task!TASK DETAILhttps://phabricator.wikimedia.org/T207657EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
Tarrow added a comment.
It seems to be some artefact. See fix has worked here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/470592TASK DETAILhttps://phabricator.wikimedia.org/T208331EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc
Tarrow added a subscriber: hoo.Tarrow added a comment.
@hoo says
Pretty sure it was this change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/470071/4/includes/libs/rdbms/database/DatabaseSqlite.php
and provided a fix.
Testing it seems to result in a new failure https
Tarrow added a comment.
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/470592 is the revert test to wait forTASK DETAILhttps://phabricator.wikimedia.org/T208331EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Addshore, gerritbot
Tarrow added a comment.
A test commit working on CI to revert that chain successfully worked. Now to identify which was the breaking commit.TASK DETAILhttps://phabricator.wikimedia.org/T208331EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: gerritbot
Tarrow added a comment.
https://www.wikidata.org/w/api.php?action=""> is called and the response is:
{
"entities": {
"Q6607847": {
"pageid": 6434916,
"ns": 0,
"title": "Q6607847",
"lastre
Tarrow added a comment.
Looks like en was added in I191d172fdf6150e3010e4a50b0aab666c8195d67 with ticket T159316TASK DETAILhttps://phabricator.wikimedia.org/T208317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Addshore, Aklapper, Nandana
Tarrow added a comment.
Probably related to this change: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/470139TASK DETAILhttps://phabricator.wikimedia.org/T208124EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, ZioNicco
Tarrow added a comment.
Calling wb.sites.getSites() from an nowiki page only returns the pedias, whereas calling from wikidata we actually get all sites.TASK DETAILhttps://phabricator.wikimedia.org/T208077EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
Tarrow added a comment.
Some WMDE developers are taking a look at this but owing to the weekend and the Platform Evolution Summit we're a little thin on the ground tonight.TASK DETAILhttps://phabricator.wikimedia.org/T208074EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
Tarrow created this task.Tarrow added a project: Wikidata-Campsite.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONThere doesn't appear to be any tests relating to the CheckConstraintsRdf Action.
We should probably have
Tarrow created this task.Tarrow added projects: Wikidata-Campsite, Wikidata.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONCurrently this false everywhere by default except in production where it is true.
It would probably be good to now have it default to true
Tarrow added a comment.
It's not tested because the erroring codepath is only hit if WBQualityConstraintsCacheCheckConstraintsResults config option is set to trueTASK DETAILhttps://phabricator.wikimedia.org/T206205EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
Tarrow added a comment.
It appears to be that the Services tests are running both locally and on CI.
Looking through logstash/kibana it seems that all the errors are coming this sort of path:
#0 /srv/mediawiki/php-1.32.0-wmf.24/extensions/WikibaseQualityConstraints/src/ServiceWiring.php(249
Tarrow edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.Tarrow added a comment.
not sure why gerrit removed the iteration infinityTASK DETAILhttps://phabricator.wikimedia.org/T206205EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
Tarrow closed subtask T205063: Merge WikibaseQuality and WikibaseQualityConstraints as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T205064EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Aklapper, Addshore, Nandana, Nebulous
Tarrow closed subtask T205063: Merge WikibaseQuality and WikibaseQualityConstraints as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T205062EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: abian, Aklapper, Addshore, Nandana,
Tarrow moved this task from Backlog to DONE on the Wikibase-Quality board.Tarrow closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T205063WORKBOARDhttps://phabricator.wikimedia.org/project/board/989/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/sett
Tarrow added a comment.
docker run -it --rm -e "ZUUL_PROJECT=mediawiki/extensions/WikibaseQualityConstraints" -e "EXT_DEPENDENCIES=mediawiki/extensions/BetaFeatures\nmediawiki/extensions/Capiunto\nmediawiki/extensions/CentralAuth\nmediawiki/extensions/CirrusSearch\nmediawiki/
Tarrow added a comment.
Perhaps it could also be related to updates that ran while there were issues from: T206743 ?TASK DETAILhttps://phabricator.wikimedia.org/T207675EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, LucasWerkmeister
Tarrow added a comment.
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/466682/ made it through jenkins and I just +2dTASK DETAILhttps://phabricator.wikimedia.org/T206619EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JeroenDeDauw
Tarrow updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONWe should check for naming consistency in:
[] The repos name and Github Furniture
[] Any code in the repo
[] Any links to the repo from wikibase.org
[] Any links to the repo from wikiba.se
[] Any links from the wikibase
Tarrow created this task.Tarrow added projects: Wikidata, Wikibase-Containers, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONTASK DETAILhttps://phabricator.wikimedia.org/T207657EMAIL PREFERENCEShttps
Tarrow added a comment.
It appears that the SpecialConstraintReportTest failures I get locally do not occur on CI because WikibaseQuality is still being loaded and just the classes aren't missing. Made a new ticket for this at: T207655TASK DETAILhttps://phabricator.wikimedia.org/T206205EMAIL
Tarrow created this task.Tarrow triaged this task as "Normal" priority.Tarrow added projects: Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).Restricted Application added a subscriber: Aklapper.
TASK DESCRI
Tarrow added a comment.
That's interesting; so for you it's not like the gif I added? What happens? Does it correctly show and save the second code? Or just display and save the 1st?TASK DETAILhttps://phabricator.wikimedia.org/T207550EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings
Tarrow updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* Change the language code and **immediately** press enter...Actual result: Sense is saved using the original language code. The newly added sense is displayed using the second language code the user entered, so
Tarrow added a comment.
I can repeat this. I've added a screen cap for it on test.wikidata.org to the description.
Note: if you tab out of the language code box the feature works as expected. i.e. the new language is correctly displayed before and after refreshTASK DETAILhttps
Tarrow closed this task as "Resolved".Tarrow added a comment.
Great! I'll mark this as resolved.
@Magnus was the solution?:
I tried deleting data/data.jnl and it successfully recreated the data now including the correct URLs (not wikibase,svc).
If so it is also worth mentioning th
Tarrow reopened this task as "Open".Tarrow added a comment.
Looks like at least some of the HTML classes weren't changed over: see e.g. WikibaseQuality\Html\HtmlTableBuilder still present on extensions/WikibaseQualityConstraints/src/Specials/SpecialConstraintReport.php#38
This should
Tarrow reopened subtask T205063: Merge WikibaseQuality and WikibaseQualityConstraints as "Open".
TASK DETAILhttps://phabricator.wikimedia.org/T205062EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: abian, Aklapper, Addshore, Nandana,
Tarrow reopened subtask T205063: Merge WikibaseQuality and WikibaseQualityConstraints as "Open".
TASK DETAILhttps://phabricator.wikimedia.org/T205064EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Aklapper, Addshore, Nandana, Nebulous
Tarrow claimed this task.Tarrow added a comment.
Looks like other things may also not being being properly run:
Locally I get failures like this:
1) WikibaseQuality\ConstraintReport\Tests\Specials\SpecialConstraintReportTest::testExecute with data set "valid input - existing item" ('$
Tarrow closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T202646EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Addshore, gerritbot, Aklapper, Tarrow, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majestic
Tarrow claimed this task.Tarrow moved this task from To Do to Doing on the Wikidata-Campsite-Iteration-∞ board.
TASK DETAILhttps://phabricator.wikimedia.org/T204469WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
Tarrow added a comment.
I'm not super clear but was this being clobbered by the monkey patching which we're intending to disable when https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PropertySuggester/+/458187 mergesTASK DETAILhttps://phabricator.wikimedia.org/T207019EMAIL PREFERENCEShttps
Tarrow added a comment.
I just tried both test and wikidata.org and the patch works as expected for me. Perhaps it is some caching issue?TASK DETAILhttps://phabricator.wikimedia.org/T154869EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE
Tarrow added a comment.
I believe now that https://gerrit.wikimedia.org/r/459505 is merged we can go ahead.
Jonas' -2
We need to first teach the hook to evaluate ranking information, otherwise we have a running condition that randomly sorts suggestions.
is, I believe, satisfied by the above
Tarrow added a comment.
Looks like @Jonas is away (according to the calendar) so I guess a camper may need to take this overTASK DETAILhttps://phabricator.wikimedia.org/T207019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Jonas, gerritbot
Tarrow added a comment.
@Elfalem This should all be fixed now.TASK DETAILhttps://phabricator.wikimedia.org/T203528EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: gerritbot, Lucas_Werkmeister_WMDE, Tarrow, Addshore, Aklapper, Elfalem, CucyNoiD
Tarrow updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... [x] Wikibase composer.json could suggest that the PHP extension be installed?...TASK DETAILhttps://phabricator.wikimedia.org/T203528EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
Tarrow claimed this task.Tarrow moved this task from To Do to Doing on the Wikidata-Campsite-Iteration-∞ board.Tarrow added a comment.
Since @Jakob_WMDE is now hiking on Termbox I'll pick this up and take a look. If I hit a wall I'll page him :)TASK DETAILhttps://phabricator.wikimedia.org
Tarrow reassigned this task from Tarrow to johl.Tarrow added a comment.
I think @johl will be making an update to the PR addressing the issues on there soon! (today or tomorrow)TASK DETAILhttps://phabricator.wikimedia.org/T202406EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
Tarrow lowered the priority of this task from "Unbreak Now!" to "Normal".
TASK DETAILhttps://phabricator.wikimedia.org/T205330EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, TarrowCc: Lea_Lacroix_WMDE, Stashbot, gerritbot
Tarrow added a comment.
@Addshore:
the varnished cached pages would expire 14 days after the deployment that caused an issue, if they aren't purged for another reason before handTASK DETAILhttps://phabricator.wikimedia.org/T205330EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
Tarrow added a comment.
Ticket to remind us to tidy up: T205611TASK DETAILhttps://phabricator.wikimedia.org/T205330EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, TarrowCc: Lea_Lacroix_WMDE, Stashbot, gerritbot, Jakob_WMDE, Tarrow, TerraCodes
Tarrow created this task.Tarrow added projects: Wikidata-Campsite, Wikidata.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONRemove the fix for T205330
Once 22 days have expired from the 1.32.0-wmf.22 deploy we should remove from operations-mediawiki-config.
I.E. After 8pm
Tarrow added a comment.
We've now invalidated the cache for all pages in the parser cache before the train was deployed last week so it should now be fixed for logged in users. There is still a possibility that un-logged in users will see something stale from the Varnish cacheTASK DETAILhttps
Tarrow claimed this task.Tarrow moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration8 board.
TASK DETAILhttps://phabricator.wikimedia.org/T195829WORKBOARDhttps://phabricator.wikimedia.org/project/board/3608/EMAIL PREFERENCEShttps://phabricator.wikimedia.org
Tarrow added a comment.
This is another case of this HTML not being in sync with the JS; seems that we need a way to at least predict this and do the invalidation but ideally have it automatic.TASK DETAILhttps://phabricator.wikimedia.org/T205330EMAIL PREFERENCEShttps://phabricator.wikimedia.org
Tarrow added a comment.
I have my suspicions that this may be due to work done on: https://phabricator.wikimedia.org/T196226TASK DETAILhttps://phabricator.wikimedia.org/T205330EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, TerraCodes
Tarrow claimed this task.Tarrow added a comment.
I'll finish what I started but doing the composer.json tooTASK DETAILhttps://phabricator.wikimedia.org/T203528EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Lucas_Werkmeister_WMDE, Tarrow, Addshore
Tarrow added a comment.
Rebased and made PR at https://github.com/wmde/wikibase-docker-yml-gui/pull/33TASK DETAILhttps://phabricator.wikimedia.org/T202406EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, TarrowCc: Tarrow, johl, WMDE-leszek, Aklapper
Tarrow added a comment.
Just asked the man in person; looks like it is good to go. I'll make the PRTASK DETAILhttps://phabricator.wikimedia.org/T202406EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, TarrowCc: Tarrow, johl, WMDE-leszek, Aklapper
Tarrow added a comment.
https://github.com/wmde/wikibase-docker/pull/49 is a 2 line change to the docker filesTASK DETAILhttps://phabricator.wikimedia.org/T203528EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Lucas_Werkmeister_WMDE, Tarrow
Tarrow created this task.Tarrow added a project: Wikibase-Containers.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONLooks like this is an important part of the Rdf Dumper
This means the dumper fails with things like
Tarrow claimed this task.Tarrow added a project: Wikidata-Editor-Experience-Improvements-Iteration7.
TASK DETAILhttps://phabricator.wikimedia.org/T185481EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Addshore, Liuxinyu970226, Aklapper, Ladsgroup
Tarrow added a comment.
I would agree with thisTASK DETAILhttps://phabricator.wikimedia.org/T195828EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE, TarrowCc: Tarrow, Aklapper, Lucas_Werkmeister_WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic
Tarrow added a comment.
I wasn't able to replicate the problem. Seems @Jakob_WMDE managed to fix with clearing LocalStorageTASK DETAILhttps://phabricator.wikimedia.org/T204039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Jakob_WMDE
Tarrow claimed this task.Tarrow added a project: Wikidata-Editor-Experience-Improvements-Iteration7.
TASK DETAILhttps://phabricator.wikimedia.org/T194347EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Aklapper, Lucas_Werkmeister_WMDE, Tarrow
Tarrow created this task.Tarrow added projects: Federated-Wikibase-Workshops, User-Addshore, Wikidata.
TASK DESCRIPTIONCurrently it is not possible to create monolingual string datavalues longer than 400 chars.
This is currently not configurable. It seems to be set by ValidatorBuilders.php#298
Tarrow added a comment.
The failing browser test of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/458505 does seem to be a real problem:
Stack Trace from Special recent changes.
[c9365c8e6c9f4fb89869aeb5] /mediawiki/index.php?title=Special:RecentChanges TypeError from
Tarrow removed Tarrow as the assignee of this task.
TASK DETAILhttps://phabricator.wikimedia.org/T195315EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, gerritbot, Jakob_WMDE, Lydia_Pintscher, Aklapper, Pablo-WMDE, WMDE-leszek
Tarrow added a comment.
squashed and merged https://github.com/wmde/wikibase-docker-yml-gui/pull/26TASK DETAILhttps://phabricator.wikimedia.org/T201923EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, TarrowCc: Tarrow, Jonas, RazShuty, Aklapper
Tarrow created this task.Tarrow added a project: Wikibase-Quality-Constraints.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONFollowing the README I was unable to run the final set. The ImportConstraintStatements maint script
Tarrow created this task.Tarrow added projects: Wikibase-Containers, Wikidata-Campsite.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONBuilds are currently not passing because the linting is failing see: https://travis-ci.org
Tarrow claimed this task.Tarrow moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration5 board.
TASK DETAILhttps://phabricator.wikimedia.org/T195315WORKBOARDhttps://phabricator.wikimedia.org/project/board/3518/EMAIL PREFERENCEShttps://phabricator.wikimedia.org
Tarrow reassigned this task from Tarrow to Addshore.Tarrow added a comment.
I think the CT team should now be unblocked. I'm going back to my regular work.
Assigning to @Addshore to take overTASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org
Tarrow renamed this task from "Failures in LexemeDiffVisualizerIntegrationTest from " to "Hamcrest Failures in LexemeDiffVisualizerIntegrationTest".
TASK DETAILhttps://phabricator.wikimedia.org/T201141EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpref
Tarrow created this task.Tarrow added projects: Wikidata, Lexicographical data.
TASK DESCRIPTIONproblem with overriding propertyDataTypeLookup
1) Wikibase\Lexeme\Tests\MediaWiki\Diff\LexemeDiffVisualizerIntegrationTest::testAddedStatementsWithLexmesAsTargetDisplayLemma
Hamcrest\AssertionError
Tarrow added a comment.
More details about the newly failing senses tests: https://phabricator.wikimedia.org/T201137TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Ladsgroup, WMDE-leszek, Addshore
Tarrow added projects: Wikidata, Lexicographical data.
TASK DETAILhttps://phabricator.wikimedia.org/T201137EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Aklapper, Tarrow, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata
Tarrow added a comment.
Current plan is replicating tests in quibble but using non-temp tables.TASK DETAILhttps://phabricator.wikimedia.org/T201137EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Aklapper, Tarrow, Mringgaard, Lahi, Gq86
Tarrow closed this task as "Resolved".Tarrow added a comment.
Hopefully it works as planned for you now.TASK DETAILhttps://phabricator.wikimedia.org/T197666EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: LJ, Aklapper, Addshore, Tarrow, des
Tarrow added a comment.
Still looking. Not yet done much link cache investigation but have got the mysql general log out of my local quibble. It's not attached ( >70MB ) so anyone else who wants to dig through let me know.TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCESht
Tarrow added a comment.
Just tried @Addshore 's thought. It does fail! Looks like something is left over from phpunit or qunit. Now to track it downTASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc
Tarrow added a comment.
We have tried skipping the offending test in: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ContentTranslation/+/449447/
Unfortunately this just seems to move the failure to the next test along.
We've been progressively debugging but since we can't reproduce
Tarrow added a comment.
@hashar I think that is a red herring. Looks like it might be solved by https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/449436/ see: T200771TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
Tarrow created this task.Tarrow added projects: MediaWiki-extensions-OAuth, Wikibase-Containers.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONIt would be great if there were an API call that could be made to create (or propose
Tarrow added a comment.
I also tried running the suite locally (using the quibble docker images) and had success. Output can be seen here: P7403TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc
Tarrow added a comment.
The failed-save: The save has failed. error appear to us to be an error from the API not an interaction with the page.
We also note that it is the *first* test of the group and wonder if this is connected.TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
Tarrow created this task.Tarrow added projects: Wikidata, Wikidata-Editor-Experience-Improvements-Hike.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONTASK DETAILhttps://phabricator.wikimedia.org/T200774WORKBOARDhttps://phabricator.wikimedia.org/project/board/3489/EMAIL
Tarrow claimed this task.Tarrow added a comment.
@Pablo-WMDE @Jakob_WMDE and I are actively working on solving this.TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Addshore, gerritbot, matmarex
Tarrow added a comment.
@LJ Sorry for taking so long. There are settings that are needed for proposing OAuth consumers.
I think in your setup the wikibase-bundle image provided files have been overwritten but you can see them here: https://github.com/wmde/wikibase-docker/blob/master/wikibase/1.30
Tarrow added a comment.
I've uploaded a "strawman" patch to be clear what I'm suggesting and give a place to track the discussion.TASK DETAILhttps://phabricator.wikimedia.org/T200508EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc:
Tarrow updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONWhen a change happens in Wikibase that breaks something in Lexeme we don't know until it has already been mergedTASK DETAILhttps://phabricator.wikimedia.org/T200508EMAIL PREFERENCEShttps://phabricator.wikimedia.org
Tarrow created this task.Tarrow added a project: Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONWhen a change happens in Wikibase that break something in Lexeme we don't know until it has already been merged.
This is a problem because we could plausibly have a release cut
801 - 900 of 1077 matches
Mail list logo
