Lucas_Werkmeister_WMDE added a comment.
Just to clarify: the current situation in dumps and EntityData isn’t “no hashes”, it’s “qualifier hashes but not main snak hashes or reference hashes”. And we will lose the ability to make this distinction as soon as we switch to
Lydia_Pintscher added a comment.
Do we need them in the json dumps and Special:EntityData? If the answer is "unclear" then let's not do it until someone asks for it.TASK DETAILhttps://phabricator.wikimedia.org/T171607EMAIL
gerritbot added a comment.
Change 373859 abandoned by Lucas Werkmeister (WMDE):
Emit all snak hashes in API responses
Reason:
Already done in Ia143563ed1. (Merging this into current master produces an empty diff. That’s also why the tests succeeded – Leszek went through the trouble of fixing them
Lucas_Werkmeister_WMDE added a comment.
It might not even need to be configurable. (Daniel: “I’m okay with always including the hashes in API output, and output of Special:EntityData.”)
Perhaps it should be configurable after all, because otherwise the tests are going to become ugly.TASK
gerritbot added a comment.Herald added a subscriber: jeblad.
Change 373859 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Emit all snak hashes in API responses
https://gerrit.wikimedia.org/r/373859TASK
Lucas_Werkmeister_WMDE added a comment.
I have no idea how to implement this nicely for API modules. There should be an optional flag parameter to include hashes in the output of wbsetclaim and other modules, but the configuration of the serializers is buried in WikibaseRepo::getApiHelperFactory,
daniel added a comment.
In T171607#3478253, @Addshore wrote:
tldr, the only reason the options exist was to maintain the output format exactly as it was before refactoring.
Yay for bug-by-bug compatibility :)TASK DETAILhttps://phabricator.wikimedia.org/T171607EMAIL
daniel added a comment.
In T171607#3478233, @Lucas_Werkmeister_WMDE wrote:
As far as I can tell, we’ll need hashes in the output of wbeditentity if we want to have those hashes in the DOM (T171725). Or can the _javascript_ view calculate the hashes?
No, the frontend code should not do its own
Addshore added a comment.
So, this was part of the LARGE refactoring of the serialization stuff / removing lib serializers for those that remember that mess (it spans about 30 patches or something like that).
The options were introduced to keep the output in various areas of wikibase exactly the
daniel added a comment.
The following places currently construct statement serializers:
Scribunto_LuaWikibaseLibrary::newEntityAccessor()
WikibaseRepo::getApiHelperFactory()
SpecialEntityData::newDefaultRequestHandler()
DumpJson::execute()
All of them, set use the
daniel added a comment.
I guess this was just caused by confusion during refactoring. I'm looking into it now. A good point to start the investigation is SerializerFactory::newStatementSerializer().TASK DETAILhttps://phabricator.wikimedia.org/T171607EMAIL
11 matches
Mail list logo
