[Wikidata-bugs] [Maniphest] [Commented On] T254675: Rename WPBSkinBlacklist

gerritbot added a comment. Change 609141 **merged** by jenkins-bot: [mediawiki/extensions/WikidataPageBanner@master] Rename WPBSkinBlacklist and isSkinBlacklisted to WPBSkinDisabled and isSkinDisabled respectively https://gerrit.wikimedia.org/r/609141 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T254675: Rename WPBSkinBlacklist

gerritbot added a comment. Change 609490 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn): [operations/mediawiki-config@master] Rename WPBSkinBlacklist to WPBSkinDisabled https://gerrit.wikimedia.org/r/609490 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T254675: Rename WPBSkinBlacklist

Ammarpad added a comment. Yes, the issue started here. The task description inverted the logic. > Rename WPBSkinBlacklist to WPBSkinEnabled > Rename isSkinBlacklisted to isSkinEnabled You should however retain the logic in the patch. That's isSkinDisabled() for the method and

[Wikidata-bugs] [Maniphest] [Commented On] T254675: Rename WPBSkinBlacklist

Peter.ovchyn added a comment. @Jdlrobson I think the root of issue is in task description and naming. WPBSkinEnabled and isSkinEnabled is something totally opposite to WPBSkinBlacklist and isSkinBlacklisted. I'd rather offer to rename that to WPBSkinDisabled and isSkinDisabled? What do yo

[Wikidata-bugs] [Maniphest] [Commented On] T254675: Rename WPBSkinBlacklist

Reedy added a comment. In T254675#6274431 , @Peter.ovchyn wrote: > @Jdlrobson I renamed opt name and inverted logic accordingly. Is there any instruction on how to change mediawiki-config ? So with how your patch current is, it's

[Wikidata-bugs] [Maniphest] [Commented On] T254675: Rename WPBSkinBlacklist

Peter.ovchyn added a comment. @Jdlrobson I renamed opt name and inverted logic accordingly. Is there any instruction on how to change mediawiki-config ? TASK DETAIL https://phabricator.wikimedia.org/T254675 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T254675: Rename WPBSkinBlacklist

gerritbot added a comment. Change 609141 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn): [mediawiki/extensions/WikidataPageBanner@master] Rename WPBSkinBlacklist to WPBSkinEnabled and invert logic