[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

Arian_Bozorg closed this task as "Resolved". Arian_Bozorg moved this task from Product Verification to Done on the Wikidata Dev Team (Quality Tools "Sprint") board. Arian_Bozorg added a comment. Looks good, thank you :) TASK DETAIL https://phabricator.wikimedia.org/T245643 WORKBOARD

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

gerritbot added a comment. Change #1028440 **merged** by Hasan Akgün (WMDE): [wikidata/query/gui-deploy@production] Merging from d4bccb8d0dad75c806256bece3772f20214a6c7c https://gerrit.wikimedia.org/r/1028440 TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

gerritbot added a comment. Change #1028440 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder): [wikidata/query/gui-deploy@production] Merging from d4bccb8d0dad75c806256bece3772f20214a6c7c https://gerrit.wikimedia.org/r/1028440 TASK DETAIL

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

gerritbot added a comment. Change #1028432 **merged** by jenkins-bot: [wikidata/query/gui@master] Fix build error https://gerrit.wikimedia.org/r/1028432 TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

gerritbot added a comment. Change #1028432 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)): [wikidata/query/gui@master] Fix build error https://gerrit.wikimedia.org/r/1028432 TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

gerritbot added a comment. Change #1028384 **merged** by jenkins-bot: [wikidata/query/gui@master] Fix build error https://gerrit.wikimedia.org/r/1028384 TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

gerritbot added a comment. Change #1028384 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)): [wikidata/query/gui@master] Fix build error https://gerrit.wikimedia.org/r/1028384 TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

gerritbot added a comment. Change #1013058 **merged** by jenkins-bot: [wikidata/query/gui@master] Fix query cancellation bugs https://gerrit.wikimedia.org/r/1013058 TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

Sarai-WMDE added a comment. Thanks, @Michael! That's much appreciated  TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, Sarai-WMDE Cc: noarave, guergana.tzatchkova,

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

Michael added a comment. I wasn't aware of that modal to list the keyboard shortcuts either. And the shortcut `?` seems partially broken? It works when opening the query service UI freshly, but fails after running a query. I've created T360880: Shortcut Modal fails to open after running a

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

Sarai-WMDE added a comment. Thanks, @HasanAkgun_WMDE! Wasn't aware of the existence of that modal  Looking forward to taking a look at the changes  TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

Arian_Bozorg added a comment. Thanks Hasan, that's sounds good from me TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, Arian_Bozorg Cc: noarave, guergana.tzatchkova,

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

HasanAkgun_WMDE added a comment. @Arian_Bozorg I've fixed the sentence, but when I checked the vertical alignment I saw it's the same with "Running query" message as well. I couldn't find a proper solution for it, so if it's OK for you I think we can handle that one in a separate task.

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

gerritbot added a comment. Change 1013058 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)): [wikidata/query/gui@master] Fix query cancellation bugs https://gerrit.wikimedia.org/r/1013058 TASK DETAIL https://phabricator.wikimedia.org/T245643

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

Sarai-WMDE added a comment. Agreed, with the UI looking good and with the needed copy fix. I can't reproduce the message padding issues, though. Could it be related to font size or family? I detected some further adjustments needed to follow the original specs. Please let me know if

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

Arian_Bozorg moved this task from Product Verification to Backlog on the Wikidata Dev Team (Quality Tools "Sprint") board. Arian_Bozorg added a comment. Thanks Hasan, it's looking good :) Just a couple of small changes here: - can we adjust the copy so that it reads "The query was

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

HasanAkgun_WMDE added a comment. There's a cached version of i18n file and it isn't updated yet (I don't know why), so you can see messages like `wdqs-action-stop-query` that. They will disappear in a short time. @Arian_Bozorg TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

gerritbot added a comment. Change 1009481 **merged** by jenkins-bot: [wikidata/query/gui@master] Stop current query from running on Query Service https://gerrit.wikimedia.org/r/1009481 TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

gerritbot added a comment. Change 1007423 **abandoned** by Hasan Akgün (WMDE): [wikidata/query/gui@master] [WiP] Stop current query from running on Query Service Reason: cont. on somewhere else https://gerrit.wikimedia.org/r/1007423 TASK DETAIL

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

gerritbot added a comment. Change 1007423 **restored** by Hasan Akgün (WMDE): [wikidata/query/gui@master] [WiP] Stop current query from running on Query Service https://gerrit.wikimedia.org/r/1007423 TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

gerritbot added a comment. Change 1007423 **abandoned** by Guergana Tzatchkova: [wikidata/query/gui@master] [WiP] Stop current query from running on Query Service Reason: Abandoning this patch because issue has been solved in Change-Id:

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

gerritbot added a comment. Change 1009481 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)): [wikidata/query/gui@master] Cancel query ajax request https://gerrit.wikimedia.org/r/1009481 TASK DETAIL https://phabricator.wikimedia.org/T245643

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

HasanAkgun_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE Cc: noarave, guergana.tzatchkova, HasanAkgun_WMDE, dcausse, Gehel, Michael, Ainali,

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, gerritbot Cc: noarave, guergana.tzatchkova, HasanAkgun_WMDE, dcausse, Gehel,

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

gerritbot added a comment. Change 1007423 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova): [wikidata/query/gui@master] [WiP] Stop current query from running on Query Service https://gerrit.wikimedia.org/r/1007423 TASK DETAIL

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

guergana.tzatchkova claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: noarave, guergana.tzatchkova, HasanAkgun_WMDE, dcausse, Gehel, Michael, Ainali,

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

Arian_Bozorg moved this task from Unified QT Backlog to Quality Tools "Sprint" on the Wikidata Dev Team board. Arian_Bozorg edited projects, added Wikidata Dev Team (Quality Tools "Sprint"); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T245643 WORKBOARD

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running on Query Service

Arian_Bozorg renamed this task from "[SW] Stop current query from running" to "Stop current query from running on Query Service". Arian_Bozorg set the point value for this task to "8". TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: dcausse, Gehel, Michael, Ainali, Lydia_Pintscher, jhsoby, agray, Nikki, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Sarai-WMDE added a comment. Open question: Can we use Codex buttons to replace the current "Run" button and add the new "Stop" option? TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: dcausse, Gehel, Michael, Ainali, Lydia_Pintscher, jhsoby, agray, Nikki, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: dcausse, Gehel, Michael, Ainali, Lydia_Pintscher, jhsoby, agray, Nikki, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Sarai-WMDE attached a referenced file: F41734211: qs.gif. TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: dcausse, Gehel, Michael, Ainali, Lydia_Pintscher, jhsoby, agray, Nikki,

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: dcausse, Gehel, Michael, Ainali, Lydia_Pintscher, jhsoby, agray, Nikki, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Arian_Bozorg added a comment. That's great news Sarai! With the risk of overloading the server mitigated as Lydia said in her comment, let's move ahead with the design. I'll update the ticket accordingly TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Sarai-WMDE attached a referenced file: F41731801: qs.gif. TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: dcausse, Gehel, Michael, Ainali, Lydia_Pintscher, jhsoby, agray, Nikki,

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Lydia_Pintscher added subscribers: Gehel, dcausse. Lydia_Pintscher added a comment. In T245643#9495822 , @Sarai-WMDE wrote: > 2. Potential risks, concerns and improvements they would suggest in order to adjust the feature to their

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Sarai-WMDE added a comment. Sharing a sneak peek of the state of the current design iteration. There were three main adjustments applied to this new version: 1. The Run and Stop buttons are separated to prevent double clicks and improve accessibility (making all options detectable

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Sarai-WMDE added a comment. Posting a progress update on the design exploration. Att @Arian_Bozorg and @Lydia_Pintscher TL;DR: We need help validating whether the risk of overloading the WQS erver due to the implementation of the Run/Stop toggle solution is a serious one. We also need

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Sarai-WMDE added a comment. Call for feedback - Opening a more formal call for feedback in this comment, for anyone interested in helping us shape this solution  We'll share a quick feedback survey with the extended Wikidata community soon, but the opinions of

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Arian_Bozorg added a comment. Thanks so much for this Sarai, this all looks great to me. I think a keyboard shortcut like the one you suggested `ctrl+enter` would make sense here. To avoid a double click we could possibly have a delay between the run and stop button? Re: testing,

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Sarai-WMDE added a comment. Sharing an early version of the current design exploration. All feedback will be welcome and appreciated  The current suggested solution consists in **toggling the primary button in the Query Service to allow users to "run" and "stop" their queries**. The

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Arian_Bozorg added a comment. Re: the open questions I think changing the run button to a stop button one second after to prevent a double click could be a simple and elegant solution to this. And I think currently IPs can run multiple queries at once and the WMF already has safeguards

[Wikidata-bugs] [Maniphest] T245643: Stop current query from running

Arian_Bozorg renamed this task from "Start a new query when an existing one is running" to "Stop current query from running". Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245643 EMAIL PREFERENCES