[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

Lydia_Pintscher closed this task as "Resolved". Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board. Lydia_Pintscher added a comment. \o/ TASK DETAIL https://phabricator.wikimedia.org/T267733 WORKBOARD

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

Michael moved this task from Peer Review to Test (Verification) on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board. Michael added a comment. RTL seems fine in general. The currently existing issue with the "Add Condition"-Button is being worked on in T269438

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

Ladsgroup added a comment. In T267733#6662857 , @Michael wrote: > Ok, cool. > > - Should we create an extra ticket to consider using a different font for the heading for languages that use the Arabic script? Yeah. I think this

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

Michael added a comment. Ok, cool. - Should we create an extra ticket to consider using a different font for the heading for languages that use the Arabic script? - Does this need any more work now or is it enough to keep occasionally checking with RTL languages as we develop the app?

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

Ladsgroup moved this task from ❌ Blocked to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board. Ladsgroup added a comment. Looks okay to me so far: https://query-builder-test.toolforge.org/?uselang=fa TASK DETAIL https://phabricator.wikimedia.org/T267733

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

Lydia_Pintscher moved this task from Wikidata Query Builder - sprint 4 to Wikidata Query Builder - sprint 5 on the Wikidata Query Builder board. Lydia_Pintscher edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 5); removed Wikidata Query Builder ( Wikidata Query

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

Michael moved this task from Peer Review to ❌ Blocked on the Wikidata Query Builder ( Wikidata Query Builder - sprint 4) board. Michael added a comment. I'd say let's have another look at this when T267731 is merged. Then we can create the Persian

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

Ladsgroup added a comment. In T267733#6633196 , @guergana.tzatchkova wrote: > @Ladsgroup > Suggestions from Navigators Summit: > > - Did we check how Termbox's use of RTL? It uses RtlDetectLib which is nice but so far I

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

guergana.tzatchkova added a comment. @Ladsgroup Suggestions from Navigators Summit: - Did we check how Termbox's use of RTL? - Do not use CSS Janus. Let's use CSS logical properties. TASK DETAIL https://phabricator.wikimedia.org/T267733 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

Ladsgroup added a comment. In T267733#6629940 , @Michael wrote: >> - The result iframe is all in English and LTR, fixing it wouldn't be easy, I don't think we can use non-ASCII characters for variable names. > > Could you explain a

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

Michael added a comment. In T267733#6627887 , @Ladsgroup wrote: > Mostly it looks good but: > > - The fallback result when there's no label in Persian is RTL but it should be LTR Fixing that might be tricky. We could wrap all

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

Ladsgroup added a comment. So I changed everything to Persian and even uploaded it as a POC PR: https://github.com/wmde/query-builder/pull/64 Here's is my observations (they are not necessarily all RTL issues): F33917654: image.png

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

Ladsgroup claimed this task. Ladsgroup moved this task from To Do to Doing on the Wikidata Query Builder ( Wikidata Query Builder - sprint 4) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T267733 WORKBOARD

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder ( Wikidata Query Builder - sprint 4). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - Does changing the language to an RTL language cause RTL-specific bugs? - Do we need to use some