[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

Addshore closed this task as "Resolved". Addshore added a comment. Awesome refactoring of the test happened here too ! :) TASK DETAIL https://phabricator.wikimedia.org/T286209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

gerritbot added a comment. Change 703720 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add ClientNoBadUsageTest https://gerrit.wikimedia.org/r/703720 TASK DETAIL https://phabricator.wikimedia.org/T286209 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T286209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, Michael,

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

gerritbot added a comment. Change 703720 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Add ClientNoBadUsageTest https://gerrit.wikimedia.org/r/703720 TASK DETAIL

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T286209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Addshore, Ladsgroup, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12). TASK DETAIL https://phabricator.wikimedia.org/T286209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: Addshore, Ladsgroup,

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

gerritbot added a comment. Change 703588 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add RepoNoBadUsageTest https://gerrit.wikimedia.org/r/703588 TASK DETAIL https://phabricator.wikimedia.org/T286209 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

gerritbot added a comment. Change 703587 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Rewrite NoBadDependencyUsageTest as NoBadUsageTest https://gerrit.wikimedia.org/r/703587 TASK DETAIL https://phabricator.wikimedia.org/T286209 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

gerritbot added a comment. Change 703462 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Also strip line comments in NoBadDependencyUsageTest https://gerrit.wikimedia.org/r/703462 TASK DETAIL https://phabricator.wikimedia.org/T286209 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

gerritbot added a comment. Change 703460 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Test number of MW RDBMS references in lib/ https://gerrit.wikimedia.org/r/703460 TASK DETAIL https://phabricator.wikimedia.org/T286209 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

gerritbot added a comment. Change 703588 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] WIP: Add RepoNoBadUsageTest https://gerrit.wikimedia.org/r/703588 TASK DETAIL

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

gerritbot added a comment. Change 703587 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Rewrite NoBadDependencyUsageTest as NoBadUsageTest https://gerrit.wikimedia.org/r/703587 TASK DETAIL

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

gerritbot added a comment. Change 703462 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Also strip line comments in NoBadDependencyUsageTest https://gerrit.wikimedia.org/r/703462 TASK DETAIL

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T286209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, Michael,

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

gerritbot added a comment. Change 703460 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Test number of MW RDBMS references in lib/ https://gerrit.wikimedia.org/r/703460 TASK DETAIL

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

Lucas_Werkmeister_WMDE added a comment. Doesn’t look like there’s any existing PHPCS ruleset we could easily use. (mediawiki-codesniffer has several sniffs for forbidden or deprecated things, but they’re all hard-coded, not configurable. Slevomat coding standard has a forbidden classes

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T286209 WORKBOARD

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

Lucas_Werkmeister_WMDE added a subscriber: Addshore. Lucas_Werkmeister_WMDE added a comment. @Addshore had previously found phparch and phpat , two projects that are supposed to help you keep your architecture clean. Though

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

Ladsgroup added a comment. Where the test should reside? In Lib? I want to avoid that as lib should be dismantled. In Client and repo separately? then how are going to test lib? Maybe we shouldn't test lib in this regard at all. TASK DETAIL https://phabricator.wikimedia.org/T286209 EMAIL

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

Lucas_Werkmeister_WMDE added a comment. So what exactly do we want to prevent… - The `Wikimedia\Rdmbs\` namespace: this would be closest to the existing repo/client/lib usage test, but I’m pretty sure this isn’t feasible – there are several uses of other types in that namespace, notably

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

Michael created this task. Michael added projects: Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION This means we want something similar to the forbidden Client/Repo usage tests