[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

Volker_E removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DAbad, Volker_E Cc: SaraiSan, EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

ldelench_wmf closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DAbad, ldelench_wmf Cc: SaraiSan, EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 865151 **merged** by jenkins-bot: [mediawiki/core@master] Update Codex from v0.3.0 to v0.4.0 https://gerrit.wikimedia.org/r/865151 TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 865151 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner): [mediawiki/core@master] Update Codex from v0.3.0 to v0.4.0 https://gerrit.wikimedia.org/r/865151 TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

EUdoh-WMF reassigned this task from EUdoh-WMF to DAbad. TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DAbad, EUdoh-WMF Cc: SaraiSan, EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf,

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

AnneT moved this task from Design Sign-Off to QTE Sign-off on the Design-Systems-Team (Design-Systems-Sprint) board. AnneT reassigned this task from Volker_E to EUdoh-WMF. TASK DETAIL https://phabricator.wikimedia.org/T306932 WORKBOARD https://phabricator.wikimedia.org/project/board/5859/

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 850261 **merged** by jenkins-bot: [design/codex@main] Menu: Remove -1px margin-top from menu https://gerrit.wikimedia.org/r/850261 TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

Volker_E claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E Cc: SaraiSan, EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE, Michael,

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

Catrope moved this task from QTE Sign-off to Design Sign-Off on the Design-Systems-Team (Design-Systems-Sprint) board. Catrope reassigned this task from EUdoh-WMF to Volker_E. Catrope added a comment. Moving to Design Sign-Off and assigning to @Volker_E per the previous comment TASK DETAIL

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

ldelench_wmf reassigned this task from Volker_E to bmartinezcalvo. TASK DETAIL https://phabricator.wikimedia.org/T306932 WORKBOARD https://phabricator.wikimedia.org/project/board/5859/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

AnneT added a comment. @Volker_E can we move forward with this patch and accept that we will not make a similar change in OOUI, per the previous comments? TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

bmartinezcalvo added a comment. In T306932#8356470 , @AnneT wrote: > Could we accept such a slight divergence between Codex and OOUI? I would hate to hold back Codex because of the old system, and I'm not convinced that both versions

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

Sarai-WMDE added a comment. In T306932#8356470 , @AnneT wrote: > Could we accept such a slight divergence between Codex and OOUI? I would hate to hold back Codex because of the old system, and I'm not convinced that both versions must

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

AnneT added a comment. Could we accept such a slight divergence between Codex and OOUI? I would hate to hold back Codex because of the old system, and I'm not convinced that both versions must be completely in sync, especially when it comes to a single-pixel difference. TASK DETAIL

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

EUdoh-WMF added a comment. Hi Team, Thank you for the perspective and comments. @AnneT 's patch works just fine. The issues I stated are not occurring anymore, even the blue line I mentioned in point 1 appears to have been fixed! TASK DETAIL https://phabricator.wikimedia.org/T306932

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

Sarai-WMDE added a comment. Hey all. Regarding the removal of that //-1px// border-top. The change (which I still support) was suggested a while back (see original task, T307767 ): me and Alex

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

Volker_E added a comment. @bmartinezcalvo The reason for the -1px negative margin in past design decision in OOUI was to make sure the menu is overlaying the calling element, to also support the elevated layering with this visual detail (I vaguely remember some technical reason as well, but

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

AnneT added a comment. cc @Sarai-WMDE on the message above ^ if you have a second, could you please confirm if this is the correct style now, especially for TypeaheadSearch? I had thought there was supposed to be a -1px margin-top on the menu, but it seems like that's not indicated in the

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

AnneT added a comment. @EUdoh-WMF @bmartinezcalvo I've opened a patch that I think should resolve all of those things, although the bug that happens in Chrome at 175% zoom is still a bit of an issue. Check it out here .

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 850261 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich): [design/codex@main] Menu: Remove -1px margin-top from menu https://gerrit.wikimedia.org/r/850261 TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 849191 **merged** by jenkins-bot: [mediawiki/core@master] Update Codex from v0.2.1 to v0.2.2 https://gerrit.wikimedia.org/r/849191 TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 849191 had a related patch set uploaded (by VolkerE; author: VolkerE): [mediawiki/core@master] Update Codex from v0.2.1 to v0.2.2 https://gerrit.wikimedia.org/r/849191 TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

bmartinezcalvo added a comment. In T306932#8299386 , @EUdoh-WMF wrote: > @Catrope @SaraiSan > > 1.Chrome v106: At 175% zoom, there is a faint blue border at the top of the first menu item. > F35552654: image.png

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

EUdoh-WMF attached a referenced file: F35552677: image.png. TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EUdoh-WMF Cc: SaraiSan, EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf,

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

EUdoh-WMF added a comment. Chrome v106 1. At 175% zoom, there is a faint blue border at the top of the first menu item. F35552654: image.png 2. At 125% zoom and with a number of visible items as 1, there appears to be a bottom

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 838268 **merged** by jenkins-bot: [design/codex@main] docs: Add more scrolling demos and load-more docs https://gerrit.wikimedia.org/r/838268 TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 838268 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich): [design/codex@main] docs: Add more scrolling demos and load-more docs https://gerrit.wikimedia.org/r/838268 TASK DETAIL

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

karapayneWMDE removed a project: Wikidata Dev Team (Sprint-∞). TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EUdoh-WMF, karapayneWMDE Cc: EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf,

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

Sarai-WMDE moved this task from Design Sign-Off to QTE Sign-off on the Design-Systems-Team (Design-Systems-Sprint) board. Sarai-WMDE reassigned this task from Sarai-WMDE to EUdoh-WMF. TASK DETAIL https://phabricator.wikimedia.org/T306932 WORKBOARD

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

Sarai-WMDE added a comment. This task can be signed-off from a design perspective. Following the ACs, users of the Menu component can now define the number of visible items that the menu will display in context. Further options are available on scroll. As specified, the scroll position is

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 832271 **merged** by jenkins-bot: [design/codex@main] Add cypress browser test for Menu component scroll functionality https://gerrit.wikimedia.org/r/832271 TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 832271 had a related patch set uploaded (by Michael Große; author: Michael Große): [design/codex@main] Add cypress browser test for Menu component scroll functionality https://gerrit.wikimedia.org/r/832271 TASK DETAIL

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

AnneT updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE, AnneT Cc: EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE,

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

AnneT added a subscriber: EUdoh-WMF. AnneT added a comment. @Sarai-WMDE and @EUdoh-WMF, you can test this new functionality via the "menu with scroll enabled" demo on the docs site. No other demos

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 836241 **merged** by jenkins-bot: [design/codex@main] docs, Menu: Improve display of number input https://gerrit.wikimedia.org/r/836241 TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 833853 **merged** by jenkins-bot: [design/codex@main] docs, Menu: Separate menu scroll into its own demo https://gerrit.wikimedia.org/r/833853 TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

AnneT added a comment. In T306932#8256431 , @Sarai-WMDE wrote: > Tiniest nitpick about the demo, but the width of the input to enter the number of visible items should be increased, so it can take two digits: > On the other hand, it'd

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 836241 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich): [design/codex@main] docs, Menu: Increase width of number input https://gerrit.wikimedia.org/r/836241 TASK DETAIL https://phabricator.wikimedia.org/T306932

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

AnneT moved this task from Code Review to Design Sign-Off on the Design-Systems-Team (Design-Systems-Sprint) board. AnneT assigned this task to Sarai-WMDE. TASK DETAIL https://phabricator.wikimedia.org/T306932 WORKBOARD https://phabricator.wikimedia.org/project/board/5859/ EMAIL

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 831887 **merged** by jenkins-bot: [design/codex@main] Menu: Add configurable scroll behavior https://gerrit.wikimedia.org/r/831887 TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

Sarai-WMDE added a comment. Tiniest nitpick about the demo, but the width of the input to enter the number of visible items should be increased, so it can take two digits: F35531089: Screenshot 2022-09-23 at 20.39.29.png I think 2.5em

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 833853 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich): [design/codex@main] docs, Menu: Separate menu scroll into its own demo https://gerrit.wikimedia.org/r/833853 TASK DETAIL

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

AnneT moved this task from Ready for Design to In Development on the Design-Systems-Team (Design-Systems-Sprint) board. AnneT changed the task status from "Open" to "In Progress". TASK DETAIL https://phabricator.wikimedia.org/T306932 WORKBOARD

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

gerritbot added a comment. Change 833329 had a related patch set uploaded (by Noa wmde; author: Noa wmde): [design/codex@main] Lookup: Limit default number of visible menu items to 6 https://gerrit.wikimedia.org/r/833329 TASK DETAIL https://phabricator.wikimedia.org/T306932

[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE, Michael,