[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

Lucas_Werkmeister_WMDE moved this task from Product Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE removed ArthurTaylor as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T355059 WORKBOARD

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

Volker_E closed this task as "Resolved". Volker_E updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Volker_E Cc: ArthurTaylor, Manuel, CCiufo-WMF,

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

Volker_E assigned this task to ArthurTaylor. Volker_E removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Volker_E Cc: ArthurTaylor, Manuel,

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

gerritbot added a comment. Change #1017120 **merged** by jenkins-bot: [mediawiki/core@master] Update OOUI to v0.49.1 https://gerrit.wikimedia.org/r/1017120 TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: ArthurTaylor, Manuel, CCiufo-WMF, Lucas_Werkmeister_WMDE, Michael, Aklapper, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

gerritbot added a comment. Change #1017120 had a related patch set uploaded (by Catrope; author: Catrope): [mediawiki/core@master] Update OOUI to v1.2.34 https://gerrit.wikimedia.org/r/1017120 TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

CCiufo-WMF added a comment. In T355059#9684948 , @Lucas_Werkmeister_WMDE wrote: > Production will be fixed once T361490: Release OOUI v0.49.1 happens, I guess. It looks like it’s already

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

Lucas_Werkmeister_WMDE added a comment. Production will be fixed once T361490: Release OOUI v0.49.1 happens, I guess. It looks like it’s already scheduled, so I think we (#wikidata_dev_team

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

ArthurTaylor removed ArthurTaylor as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor Cc: ArthurTaylor, Manuel, CCiufo-WMF, Lucas_Werkmeister_WMDE, Michael,

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Maintenance_bot Cc: Manuel, CCiufo-WMF, Lucas_Werkmeister_WMDE, Michael,

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

gerritbot added a comment. Change #1010878 **merged** by jenkins-bot: [oojs/ui@master] WikimediaUI theme: Increase margin for PopupWidget label to account for close button https://gerrit.wikimedia.org/r/1010878 TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

CCiufo-WMF moved this task from Up Next to DST-Sprint-20 (2024-04-01 to 2024-04-12) on the Design-System-Team board. CCiufo-WMF edited projects, added Design-System-Team (DST-Sprint-20 (2024-04-01 to 2024-04-12)); removed Design-System-Team. TASK DETAIL

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

CCiufo-WMF moved this task from Following to Up Next on the Design-System-Team board. CCiufo-WMF added a comment. In T355059#9664551 , @ArthurTaylor wrote: > Hi @CCiufo-WMF , > > I prepared this patch

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

ArthurTaylor added a comment. Hi @CCiufo-WMF , I prepared this patch https://gerrit.wikimedia.org/r/1010878 to adjust the right margin on the pop-up label. Can you take a look and see if that's something you could imagine to include in ooui-js? TASK DETAIL

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.25; 2024-04-02). TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, ReleaseTaggerBot Cc: Manuel, CCiufo-WMF,

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

gerritbot added a comment. Change #1012671 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add extra padding to bottom of mul pop-up https://gerrit.wikimedia.org/r/1012671 TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

Sarai-WMDE added a comment. Perfect! Looking great. Thanks again for the fix! TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Sarai-WMDE Cc: Manuel, CCiufo-WMF,

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

ArthurTaylor added a comment. Okay. I added an extra bottom margin to the `oo-ui-fieldLayout-body` class, but only for the `wikibase-entityterms-languagelistview-mul-popup`. This makes the pop-up look balanced without requiring changes to OOUI - we get 8px from the bottom of the checkbox to

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

gerritbot added a comment. Change 1012671 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor): [mediawiki/extensions/Wikibase@master] Add extra padding to bottom of mul pop-up https://gerrit.wikimedia.org/r/1012671 TASK DETAIL

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

Sarai-WMDE added a comment. @ArthurTaylor thanks for the fix and for sharing the clear findings! That's totally right, the actual default margin of the OOUI popover is 5px. I would consider 8px to be more canonical, given that the base spacing unit of our systems (both OOUI and Codex) are

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

ArthurTaylor added a comment. I'm saying that I don't know where the expectation of the 8px margin comes from, except the OOUI demo pages. And the OOUI demo pages have "hacked" the margin in there rather than including it in the library. Should we try and reproduce the 8px margin despite

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

Manuel added a comment. You are saying that the problem only seems to be there (due to a non-cannonical context in our Test and Beta test environments), correct? In this case, we could use this opportunity to make test.wikidata.org more cannonical, right? Also looping in @Sarai-WMDE here.

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

ArthurTaylor added a comment. I've added a patch / proposed a fix for issue 1. Issue 2 I think is not a real problem with the OOUI styles. In the OOUI demo, the margin around the text is normally 5px: F42746355: ooui-popup-1.png In

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, gerritbot Cc: Manuel, CCiufo-WMF, Lucas_Werkmeister_WMDE, Michael, Aklapper, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

gerritbot added a comment. Change 1010878 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor): [oojs/ui@master] Increase right margin for Popup label to account for close button https://gerrit.wikimedia.org/r/1010878 TASK DETAIL

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

ArthurTaylor claimed this task. ArthurTaylor edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

CCiufo-WMF moved this task from Triaging to Following on the Design-System-Team board. CCiufo-WMF added a comment. Thanks! I'm going to move it to our tracking column for now, but if/when you need our help just follow up here. TASK DETAIL https://phabricator.wikimedia.org/T355059

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

Manuel added a comment. @CCiufo-WMF: Yes, I timeboxed the investigation for WMDE's Wikidata team. Once they're finished, we'll reach out to you with an update. TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

CCiufo-WMF added a subscriber: Manuel. CCiufo-WMF added a comment. @Manuel I see you triaged this task so checking to confirm that someone at WMDE plans on timeboxing an upstream fix to OOUI (which #dst can do a release for) or if

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

CCiufo-WMF changed the subtype of this task from "Task" to "Bug Report". TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: CCiufo-WMF Cc: Manuel, CCiufo-WMF, Lucas_Werkmeister_WMDE, Michael,

[Wikidata-bugs] [Maniphest] T355059: OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]

Manuel renamed this task from "OOUI Popover component padding fixes (timexboxed to 1 day for proposing fix via OOUI)" to "OOUI Popover component padding fixes [timexboxed to 1 day for proposing a fix via OOUI]". TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES