WMDE-leszek added a comment.
With https://gerrit.wikimedia.org/r/452915 merged the T201928 should no longer be triggering failures that were blocking ContrentTranslation. @Nikerabbit could you verify that this is the case (and at very least lower the priority of this task, although probably is
Jonas added a comment.
The problem is SPARQL.js tries to parse the query and then fails with the error when trying to resolve the prefix.
I am afraid we cannot do anything about it.
A workaround would be defining the prefix in the query or in the default prefixes ...TASK
jcrespo added a comment.
I still have no idea how this could happen (also these errors don't seem to be on mwlog1001?!).
Does dumpJson.php call any function that could force any check on all replicas to fail (and because it has old configuration, it fails on a depooled non-slow host?TASK
jcrespo added a comment.
Related: T135851 T164488#3530600 T162593#3175313 T162807#3882309 T163190#3246365 T160509#3110389TASK DETAILhttps://phabricator.wikimedia.org/T202032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarling, jcrespoCc: Aklapper,
WMDE-leszek added a comment.
Apologies for late response. If it is possible to fairly easy adjust mw vagrant and wikibase role, so that composer.local.json is utilized, that would be a preferred way from my perspective. That said, I have to admit that WMDE we've move away from vagrant, and would
Nikerabbit lowered the priority of this task from "Unbreak Now!" to "Needs Triage".Nikerabbit added a comment.
I haven't seen this blocking anymore.TASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE,
gerritbot added a comment.
Change 452677 merged by jenkins-bot:
[mediawiki/core@master] selenium: undo page
https://gerrit.wikimedia.org/r/452677TASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE,
gerritbot added a comment.
Change 447651 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Store real form/sense ID in BlankForm/BlankSense
https://gerrit.wikimedia.org/r/447651TASK DETAILhttps://phabricator.wikimedia.org/T200255EMAIL
daniel added a comment.
The MCR write-both mode, with its unique index on slot_revision_id, should at least prevent conflicting rows from being inserted, although this potentially comes at the cost of throwing an exception on every edit until someone manually advances the autoincrement value for
daniel reopened this task as "Open".daniel added a comment.
Re-opening, since we again have multiple archive rows with the same ar_rev_id on several wikis, see T202032.TASK DETAILhttps://phabricator.wikimedia.org/T193180EMAIL
daniel reopened subtask T193180: Clean up archive rows with duplicate revision IDs as "Open".
TASK DETAILhttps://phabricator.wikimedia.org/T183489EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: Abit, Jdforrester-WMF, Aklapper, aude,
daniel added a subtask: T193180: Clean up archive rows with duplicate revision IDs.
TASK DETAILhttps://phabricator.wikimedia.org/T202032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarling, danielCc: gerritbot, Aklapper, daniel, aude, Addshore, Anomie,
daniel added a parent task: T202032: Duplicate ar_rev_id values in several wikis.
TASK DETAILhttps://phabricator.wikimedia.org/T193180EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: Aklapper, gerritbot, greg, Stashbot, CCicalese_WMF, daniel,
daniel added a comment.
The patch I made should protect against the edge case that @jcrespo mentioned. Not sure that it's worth the overhead given how unlikely we are to hit that situation, but that can be discussed on the ticket.TASK DETAILhttps://phabricator.wikimedia.org/T202032EMAIL
daniel raised the priority of this task from "Normal" to "High".daniel added a comment.
Bumping to high, since this now blocks the completion of T183488.TASK DETAILhttps://phabricator.wikimedia.org/T193180EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 453118 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/Wikibase@master] Introduce LatestRevisionIdResult
https://gerrit.wikimedia.org/r/453118TASK
gerritbot added a comment.
Change 453118 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/Wikibase@master] Introduce LatestRevisionIdResult
https://gerrit.wikimedia.org/r/453118TASK
jcrespo added a comment.
In T183488#4506824, @daniel wrote:
We did pretty extensive testing of this on the test copies (db and db1112). We could have a script that does basic sanity checks, but I'm not sure what to test, beyond the trivial. All I can think of is:
all revision rows have an
gerritbot added a comment.
Change 453143 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] phpunit: clear in-memory caches between tests
https://gerrit.wikimedia.org/r/453143TASK
Greta_Doci_WMDE raised the priority of this task from "Normal" to "High".Greta_Doci_WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration5.
TASK DETAILhttps://phabricator.wikimedia.org/T201928EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Pamputt added a comment.
Another example F25017715: Capture d’écran_2018-08-16_14-57-15.png
One solution might be to add a horizontal slider in the central area.TASK DETAILhttps://phabricator.wikimedia.org/T201734EMAIL
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T202032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarling, gerritbotCc: gerritbot, Aklapper, daniel, aude, Addshore, Anomie, Abit, jcrespo, tstarling, Gaboe420,
gerritbot added a comment.
Change 453117 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Make sure we don't try to use a deleted rev ID.
https://gerrit.wikimedia.org/r/453117TASK DETAILhttps://phabricator.wikimedia.org/T202032EMAIL
jcrespo added a comment.
So the script will make sure to not miss any content, but doesn't assure it introduces extra one, or duplicates some, that is why I mention the usage of extra checks. Takes very little time (1 long running query per check) and validates the whole process. The same thing
gerritbot added a comment.
Change 450541 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use PageUpdater & RevisionStore in Wikibase
https://gerrit.wikimedia.org/r/450541TASK DETAILhttps://phabricator.wikimedia.org/T194729EMAIL
Anomie closed this task as "Declined".Anomie added a comment.
You can't sanely "create" a consumer without already being logged in, which rather defeats the purpose of using OAuth.
T165219 is one potential better proposal. Another would be to somehow figure out a way to safely deal with secret
Ramsey-WMF added subscribers: Fjalapeno, Abit, Lydia_Pintscher, Cparle, RazShuty, MarkTraceur, PDrouin-WMF, matthiasmullie.Ramsey-WMF added a comment.
Adding stakeholders to track progress of documentation and encouraging everyone to provide input and/or questions :)TASK
daniel added a comment.
I just realized, we already fixed duplicate ar_rev_id entries before... And then the problem re-appeared? That doesn't sound good.
I re-opened T193180: Clean up archive rows with duplicate revision IDs and made it a blocker for this task. @Anomie, can you look into
ReleaseTaggerBot edited projects, added MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).
TASK DETAILhttps://phabricator.wikimedia.org/T194729EMAIL
SandraF_WMF added a subscriber: Pigsonthewing.SandraF_WMF added a comment.
In T173346#4497764, @Jheald wrote:
A heads-up that "Wikipedia and IIIF" is the proposed subject for the IIIF community call this week -- see https://groups.google.com/forum/?hl=en#!topic/iiif-discuss/wy2uRl_ukJ0
The call
daniel added a comment.
@jcrespo Ooops, I updated my comment after you already answered, sorry.TASK DETAILhttps://phabricator.wikimedia.org/T183488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarling, danielCc: jcrespo, greg, tstarling, Stashbot, Abit,
Jakob_WMDE lowered the priority of this task from "High" to "Normal".Jakob_WMDE removed a project: Wikidata-Editor-Experience-Improvements-Iteration5.
TASK DETAILhttps://phabricator.wikimedia.org/T201928EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
jcrespo added a comment.
I mentioned this to Tim, and he said to better mention it to Brad (and Daniel?), that it would be nice to run a read-only process to check the consistency of the migration- it should take much less time than the writes and would avoid headaches given the issues with the
daniel added a comment.
Duplicates are prevented by the unique index on slot_revision_id/slot_role_id. Orphan slot rows are possible, just as orphan revision rows have been possible before.
We can run a query to detect those on some wikis as a spot check. If we find nothing, I don't think full
gerritbot added a comment.
Change 453147 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] phpunit: WikibaseRepo statics persist between tests
https://gerrit.wikimedia.org/r/453147TASK
Bugreporter created this task.Bugreporter added projects: Wikimedia-Site-requests, Wikidata.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONPer https://www.wikidata.org/wiki/Wikidata:Interface_administrators, please allow 1. bureaucrats to remove interface adminship; 2. Users
Addshore added a subtask: T202067: Use Quibble for WikibaseMediaInfo CI.
TASK DETAILhttps://phabricator.wikimedia.org/T202066EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer,
Anomie added a comment.
In T183488#4504507, @tstarling wrote:
So how do we end up trying to insert a row for revision 3003 twice?
max(rev_id) on this wiki is 3002, so the ar_rev_id certainly came from populateArchiveRevId.php, which allocated ar_rev_id values by inserting dummy rows into
Nikki created this task.Nikki added a project: Wikidata.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONThe degree symbol does not appear on all keyboards, including standard US and UK layouts, but the coordinate parser requires a degree symbol when using the DMS format. Users
Deskana removed a project: VisualEditor.Restricted Application added a project: VisualEditor.
TASK DETAILhttps://phabricator.wikimedia.org/T131661EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aude, DeskanaCc: He7d3r, MichaelSchoenitzer, Jsamwrites, Jklamo,
debt moved this task from Needs triage to Later on the Discovery-Search board.debt triaged this task as "Lowest" priority.debt added a comment.
Admins have 'deletion' search capability but it's limited to showing just the title of the deleted item (title of namespace), as that's all that is
daniel added a comment.
We'd then want to check in case any of the reassigned rows are the ones that populateContentTables.php had populated (versus being the rows that it errored out on). Or we could just blank the slots and content tables.
populateContentTables.php failed when hitting the first
gerritbot added a comment.
Change 453148 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/Wikibase@master] Use LatestRevisionIdResult in EntityRevisionLookup::getLatestRevisionId
https://gerrit.wikimedia.org/r/453148TASK
gerritbot added a comment.
Change 453148 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/Wikibase@master] Use LatestRevisionIdResult in EntityRevisionLookup::getLatestRevisionId
https://gerrit.wikimedia.org/r/453148TASK
Addshore added a project: User-Addshore.
TASK DETAILhttps://phabricator.wikimedia.org/T202066EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude,
Addshore added a parent task: T159708: Deploy WikibaseMediaInfo extension to production.
TASK DETAILhttps://phabricator.wikimedia.org/T202066EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Aklapper, Lahi, Gq86, GoranSMilovanovic,
Addshore added a subtask: T202066: Run WikibaseMediaInfo with Wikibase CI.
TASK DETAILhttps://phabricator.wikimedia.org/T159708EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Jdforrester-WMF, Addshore, Ricordisamoa, Aklapper, Lydia_Pintscher,
Anomie added a comment.
I think all the action is going to happen on T202032 rather than here. Once the underlying issue there is fixed, this task will be to just re-run the maintenance script.TASK DETAILhttps://phabricator.wikimedia.org/T193180EMAIL
gerritbot added a comment.
Change 453149 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use LatestRevisionIdResult in EntityRevisionLookup::getLatestRevisionId()
Deskana removed a project: VisualEditor.Restricted Application added a project: VisualEditor.
TASK DETAILhttps://phabricator.wikimedia.org/T148928EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Sophivorus, DeskanaCc: Mvolz, Daniel_Mietchen, Iniquity,
Krinkle closed this task as "Resolved".Krinkle removed projects: MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T201453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDE,
Rxy triaged this task as "Normal" priority.Rxy claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T202065EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: RxyCc: Aklapper, Bugreporter, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden,
Rxy added a project: User-Rxy.
TASK DETAILhttps://phabricator.wikimedia.org/T202065EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: RxyCc: Aklapper, Bugreporter, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, Zoranzoki21, LawExplorer, DatGuy,
Anomie added a comment.
In T202032#4505934, @tstarling wrote:
populateArchiveRevId.php allocated rev_id values by inserting a dummy row into the revision table and then deleting it in the same transaction. It's evident from the MariaDB documentation that this is unsafe in MariaDB 10.1. In fact
Addshore created this task.Addshore added projects: MediaWiki-extensions-WikibaseMediaInfo, Wikidata.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONSimilar to T200508.
In order for Wikibase to stop breaking WikibaseMediaInfo accidentally, the WikibaseMediaInfo tests should be
Anomie added a comment.
When hitting the first duplicate is the point. If rows A and B had the same ar_rev_id, the slots table would have been populated for A and then B would be the "first duplicate". If the deduplication decided to reassign A rather than B, we'd have the problem.
Offhand I
Denny added a comment.
That looks neat.TASK DETAILhttps://phabricator.wikimedia.org/T201000EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DennyCc: Denny, Lucas_Werkmeister_WMDE, RazShuty, WMDE-leszek, Addshore, Lydia_Pintscher, Mringgaard, Lahi, Gq86,
Jdlrobson moved this task from Needs Analysis to Tracking on the Readers-Web-Backlog board.Jdlrobson edited projects, added Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog.
TASK
Dzahn added a comment.
related: convert the "role(simplelamp)" which is used by more things:
https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/415510/
There was also "role(simplelap)" (without mysql) but that was used by only one project and has been converted:
Krinkle created this task.Krinkle added projects: Performance-Team, MediaWiki-extensions-WikibaseClient.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONTo generate the content and/or version of the mediawiki.jqueryMsg module,
Mvolz added a subscriber: Deskana.Mvolz added a comment.
@Deskana as you may have noticed, there's a rule that adds VisualEditor to every citoid task, including ones like this which have no relation to VE, even when you remove it it adds it back in- should we maybe consider removing the rule?TASK
gerritbot added a comment.
Change 448160 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] ApiComparePages: Update for MCR
https://gerrit.wikimedia.org/r/448160TASK DETAILhttps://phabricator.wikimedia.org/T200569EMAIL
Krinkle added a comment.
I'd recommend considering Message::text() instead of Message::parse(). This would disallow templates and parser functions, which aren't currently used in those messages.
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T174032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, gerritbotCc: Tgr, Fjalapeno, gerritbot, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22,
gerritbot added a comment.
Change 448160 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] ApiComparePages: Update for MCR
https://gerrit.wikimedia.org/r/448160TASK DETAILhttps://phabricator.wikimedia.org/T174032EMAIL
Dzahn triaged this task as "Low" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T202092EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DzahnCc: Aklapper, Dzahn, AndyTan, sietec, Davinaclare77, Qtn1293, Lahi, aborrero, Gq86, herron,
Dzahn created this task.Dzahn added projects: Operations, Puppet, Wikidata-Query-Service, cloud-services-team.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONWe want to deprecate the puppet apache module and completely replace
gerritbot added a comment.
Change 453190 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Add tests for article viewing
https://gerrit.wikimedia.org/r/453190TASK DETAILhttps://phabricator.wikimedia.org/T174035EMAIL
Sophivorus lowered the priority of this task from "High" to "Normal".Sophivorus removed projects: VisualEditor, Citoid.
TASK DETAILhttps://phabricator.wikimedia.org/T148928EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SophivorusCc: Deskana, Mvolz,
Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONTo generaWhen generating the startup response for a wiki, ResourceLoader needs to compute the content and/or version of the `mediawiki.jqueryMsg` module,. ResourceLoader This currently indirectlyvolves invoking the
Addshore added a project: User-Addshore.
TASK DETAILhttps://phabricator.wikimedia.org/T202097EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Aklapper, Krinkle, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei,
tstarling added a comment.
Current status: everything is done except enwiki and the T202032 wikis. enwiki has about another 49 hours to run.TASK DETAILhttps://phabricator.wikimedia.org/T183488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarlingCc:
Marshallsumter added a comment.
Regarding Wikipedia use "Draft ns is excluded since 2015 after the discussion at Wikidata:Project_chat/Archive/2014/05#What_do_do_with_Wikipedia:Draft_articles" on https://www.wikidata.org/wiki/Wikidata:Administrators%27_noticeboard#Changes_to_Wikidata_items
Legoktm added a comment.
In T110022#4502131, @Krinkle wrote:
This means we can be reasonably certain that we can always use the latest stable version of the library, with upstream support for any issues that may arise in either its public interface or compatibility with any of the PHP versions
daniel added a comment.
it would be nice to run a read-only process to check the consistency of the migration
We did pretty extensive testing of this on the test copies (db and db1112). We could have a script that does basic sanity checks, but I'm not sure what to test, beyond the trivial.
gerritbot added a comment.
Change 453140 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] Store: add ability to clean in-memory cache
https://gerrit.wikimedia.org/r/453140TASK
76 matches
Mail list logo
