[Wikidata-bugs] [Maniphest] T310255: PHPUnit failure in various extensions: Wikimedia\Rdbms\DBConnectionError: Cannot access the database: Access denied for user 'wikiuser'@'localhost' to database 'ce

2022-06-09 Thread gerritbot
gerritbot added a comment.


  Change 804283 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Change API tests from unit tests to 
integration tests
  
  https://gerrit.wikimedia.org/r/804283

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: matmarex, Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, 
kostajh, Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 
786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T297299: Ensure Team A gets notified if something breaks on Wikidata Analytics

2022-06-09 Thread ItamarWMDE
ItamarWMDE added a comment.


  Current status:
  
  - We replaced the email address to `wikidata-emerge...@wikimedia.de` in the 
crontabs responsible for running the analytics engines on `stat1005` and 
`stat1007`, and added it to corntabs where the email address was missing
  - We tested to see that the above email works, and it was confirmed
  - In addition, I also tested to see if the analytics machines are indeed 
sending emails to specified addresses from cron instructions, and they do indeed
  
  @GoranSMilovanovic please note that it actually is not necessary to add the 
`MAILTO=` line before each entry in the crontab, once seems to suffice
  
  @Manuel Other than that I don't think there is anything else we can try to 
ensure alerts are sent to the wikidata team in case of failures, and I would 
assume that adding the email address where it was missing should be the best we 
can do for now.

TASK DETAIL
  https://phabricator.wikimedia.org/T297299

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: ItamarWMDE, Lucas_Werkmeister_WMDE, Michael, Addshore, WMDE-leszek, Manuel, 
GoranSMilovanovic, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: PHPUnit failure in various extensions: Wikimedia\Rdbms\DBConnectionError: Cannot access the database: Access denied for user 'wikiuser'@'localhost' to database 'ce

2022-06-09 Thread Physikerwelt
Physikerwelt added a comment.


  Another change on the 1_38 release branch is still failing 
(https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/804102) however, 
this might be totally unrelated 
(https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php73-selenium-docker/19730/console)

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt
Cc: matmarex, Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, 
kostajh, Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 
786, Suran38, Biggs657, karapayneWMDE, Invadibot, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: PHPUnit failure in various extensions: Wikimedia\Rdbms\DBConnectionError: Cannot access the database: Access denied for user 'wikiuser'@'localhost' to database 'ce

2022-06-09 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: matmarex, Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, 
kostajh, Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 
786, Suran38, Biggs657, karapayneWMDE, Invadibot, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: PHPUnit failure in various extensions: Wikimedia\Rdbms\DBConnectionError: Cannot access the database: Access denied for user 'wikiuser'@'localhost' to database 'ce

2022-06-09 Thread Physikerwelt
Physikerwelt moved this task from Inbox to Doing on the Math board.
Physikerwelt added a comment.


  Thank you all for your help. Now the tests pass again and changes 
 can be 
merged. From a math perspective, the issue can be closed.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

WORKBOARD
  https://phabricator.wikimedia.org/project/board/130/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt
Cc: matmarex, Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, 
kostajh, Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 
786, Suran38, Biggs657, karapayneWMDE, Invadibot, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T306214: When adding statements, some items won't resolve to their labels after being selected, display QNumber instead.

2022-06-09 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).

TASK DETAIL
  https://phabricator.wikimedia.org/T306214

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: Lydia_Pintscher, Manuel, Nikki, Lucas_Werkmeister_WMDE, Aklapper, Moebeus, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Eihel, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Esc3300, LawExplorer, 
_jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T306214: When adding statements, some items won't resolve to their labels after being selected, display QNumber instead.

2022-06-09 Thread gerritbot
gerritbot added a comment.


  Change 784237 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Use new display part in entity 
selector some more
  
  https://gerrit.wikimedia.org/r/784237

TASK DETAIL
  https://phabricator.wikimedia.org/T306214

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lydia_Pintscher, Manuel, Nikki, Lucas_Werkmeister_WMDE, Aklapper, Moebeus, 
Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Eihel, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, Esc3300, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Agabi10, Neuronton, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T306214: When adding statements, some items won't resolve to their labels after being selected, display QNumber instead.

2022-06-09 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T306214

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: Lydia_Pintscher, Manuel, Nikki, Lucas_Werkmeister_WMDE, Aklapper, Moebeus, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Eihel, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Esc3300, LawExplorer, 
_jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331, 
Fernandobacasegua34, 786, Suran38, Biggs657, Juan90264, Alter-paule, Beast1978, 
Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, 
Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310134: Update error message on blur of Lookup where no item has been selected

2022-06-09 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.


  How about these?
  
  "Lexeme language needs to be a valid Item."
  "Spelling variant needs to be a valid language code."
  "Lexical category needs to be a valid Item."

TASK DETAIL
  https://phabricator.wikimedia.org/T310134

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: noarave, Lea_Lacroix_WMDE, Lydia_Pintscher, Erdinc_Ciftci_WMDE, ItamarWMDE, 
Lucas_Werkmeister_WMDE, guergana.tzatchkova, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread kostajh
kostajh added a comment.


  In T310255#7991664 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > In T310255#7991620 , 
@gerritbot wrote:
  >
  >> Change 804283 had a related patch set uploaded (by Lucas Werkmeister 
(WMDE); author: Lucas Werkmeister (WMDE)):
  >>
  >> [mediawiki/extensions/Wikibase@master] Change API tests from unit tests to 
integration tests
  >>
  >> https://gerrit.wikimedia.org/r/804283
  >
  > Ugh, this doesn’t work yet because there’s one more warning (and those also 
make gate-and-submit fail):
  >
  >   PHPUnit\Framework\WarningTestCase
  >⚠ Warning
  >  │
  >  │ The data provider specified for ApiStructureTest::testParameters is 
invalid.
  >  │ Wikimedia\Rdbms\DBConnectionError: Cannot access the database: 
Access denied for user 'wikiuser'@'localhost' to database 'centralauth' 
(localhost:/workspace/db/quibble-mysql-wc4x6073/socket)
  >  │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:1465
  >  │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:958
  >  │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:931
  >  │ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:65
  >  │ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:270
  >  │ 
/workspace/src/extensions/CentralAuth/includes/GlobalGroup/GlobalGroupLookup.php:56
  >  │ 
/workspace/src/extensions/CentralAuth/includes/Api/ApiQueryGlobalAllUsers.php:273
  >  │ /workspace/src/includes/api/ApiBase.php:1782
  >  │ /workspace/src/tests/phpunit/structure/ApiStructureTest.php:175
  >  │ phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
  >
  > This is a unit test in core… should it also be an integration test? It 
tests that the parameter definitions of API modules are valid, and in 
CentralAuth that requires accessing the database so that the defined groups can 
be used for the `group` and `excludegroup` params. (Presumably, other APIs do 
something similar for `tags` parameters, that just doesn’t produce an error 
because the `change_tag_def` table would exist in the real wiki.)
  
  If anyone is able to reproduce this error locally, please let me know. So far 
I haven't been able to, with the same set of extensions as CI.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T273627: Remove wmgExtraLanguageNames from Wikimedia production

2022-06-09 Thread hoo
hoo moved this task from Peer Review to Incoming on the Wikidata-Campsite (Team 
A Hearth ) board.
hoo added a comment.


  Moving this back to incoming (as this is not worked on right now)… not sure 
we even want this in the hearth currently.

TASK DETAIL
  https://phabricator.wikimedia.org/T273627

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5612/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo
Cc: hoo, Manuel, Nikki, Lucas_Werkmeister_WMDE, Aklapper, mrephabricator, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Nikerabbit
Nikerabbit added subscribers: ngkountas, Nikerabbit.
Nikerabbit added a comment.


  We also observed the ApiStructureTest failure for ContentTranslation.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikerabbit
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread kostajh
kostajh added a comment.


  In T310255#7991676 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > Wait, no. `ApiStructureTest` isn’t a unit test, it’s an integration test 
already, both by location (`tests/phpunit/structure/`) and type (`extends 
MediaWikiIntegrationTestCase`).
  >
  > But I guess the data providers are evaluated before the 
`onUnitTestsAfterDatabaseSetup()` hook runs 
  >
  > I’m actually not sure how this would’ve worked before.
  
  Something I observed before the vendor/bin/phpunit switch is that data 
providers with exceptions would silently fail, and thus the test wouldn't run 
at all. Is it possible that ApiStructureTest did not run in CI prior to T90875 
?
  
  In T310255#7991644 , 
@Lucas_Werkmeister_WMDE wrote:
  
  >> I think we’re now running anything that claims to be a unit test against 
the real database of the wiki
  >
  > Confirmed:
  >
  > name=tests/phpunit/unit/includes/LucasTest.php
  >  
  >   class LucasTest extends \PHPUnit\Framework\TestCase {
  >   
  > public function testDatabaseAccess(): void {
  > var_dump( wfGetDB( DB_PRIMARY )->selectRow(
  > 'recentchanges',
  > [ 'rc_title', 'rc_timestamp' ],
  > '',
  > __METHOD__,
  > [
  > 'LIMIT' => 1,
  > 'ORDER BY' => 'rc_timestamp DESC',
  > ]
  > ) );
  > }
  >   
  >   }
  >
  >
  >
  >   $ vendor/bin/phpunit tests/phpunit/unit/includes/LucasTest.php
  >   Using PHP 8.1.2
  >   PHPUnit 8.5.26 #StandWithUkraine
  >   
  >   LucasTest
  >☢ testDatabaseAccess
  >   /var/www/html/wiki1/tests/phpunit/unit/includes/LucasTest.php:12:
  >   class stdClass#876 (2) {
  > public $rc_title =>
  > string(21) "Page_with_1000_commas"
  > public $rc_timestamp =>
  > string(14) "20220604150204"
  >   }
  >
  > “Page with 1000 commas” is indeed the latest recentchanges entry on my 
local wiki, from 2022-06-04. This test is accessing the real wiki database. In 
my opinion, **this should never happen** – integration tests should have the 
test DB, and for unit tests, database access should fail.
  
  Unit (as opposed to integration) tests need to run with a separate bootstrap 
file. Can you test with `vendor/bin/phunit --bootstrap 
tests/phpunit/bootstrap.php tests/phpunit/unit/includes/LucasTest.php` ? That 
is what `composer phpunit:unit` is using.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot
gerritbot added a comment.


  Change 804305 had a related patch set uploaded (by Kosta Harlan; author: 
Kosta Harlan):
  
  [mediawiki/core@master] phpunit: Temporary revert entrypoint to phpunit.php
  
  https://gerrit.wikimedia.org/r/804305

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot
gerritbot added a comment.


  Change 804319 had a related patch set uploaded (by Kosta Harlan; author: 
Kosta Harlan):
  
  [mediawiki/core@master] DevelopmentSettings: Set CentralAuthDatabase to main 
DB name
  
  https://gerrit.wikimedia.org/r/804319

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T306789: AbuseFilter messages contain local hrefs even for links formed with interwiki prefix

2022-06-09 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  It looks like we’re making a client-side cross-wiki request from 
pi.wikipedia.org to www.wikidata.org, and the error in the response contains 
relative URLs (`https://phabricator.wikimedia.org/T306789

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Daimona, CX_Zoom, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Manuel, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, 94rain, Nandana, Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, 
LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot
gerritbot added a comment.


  Change 804283 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Change API tests from unit tests to 
integration tests
  
  https://gerrit.wikimedia.org/r/804283

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T305091: [TypeaheadSearch] Support lang and dir attributes for text nodes within MenuItem component

2022-06-09 Thread Sarai-WMDE
Sarai-WMDE added a parent task: T300625: Add MenuItem component to Codex and 
TypeaheadSearch component.

TASK DETAIL
  https://phabricator.wikimedia.org/T305091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: EUdoh-WMF, Ladsgroup, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, 
Mooeypoo, bmartinezcalvo, Sarai-WMDE, Aklapper, STH, AnneT, Michael, 
NHillard-WMF, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, DannyS712, Nandana, Lahi, Gq86, Xover, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T306789: AbuseFilter messages contain local hrefs even for links formed with interwiki prefix

2022-06-09 Thread Daimona
Daimona added a comment.


  I'm not familiar with wikidata, so I'm not sure what's really happening here. 
However, this does not seem to be caused by AbuseFilter itself: IIUC, a 
wikidata filter is being run on another wiki, but this is NOT happening via the 
AbuseFilter's own "global filters" feature. In fact, I think AF is being 
manually triggered by Wikibase (e.g. by running the EditFilterMergedContent 
hook). AF simply returns a Status object with the error messages, but it's up 
to the calling code to make sure that those messages are parsed correctly. As 
an aside, AF does not let you use a customized warning message for global 
filters, possibly because parsing it in the right context could be difficult.

TASK DETAIL
  https://phabricator.wikimedia.org/T306789

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, CX_Zoom, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Manuel, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, 94rain, Nandana, Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, 
LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310043: Update analytics-wmde-scripts for site_stats sharding

2022-06-09 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a subscriber: Manuel.
Lucas_Werkmeister_WMDE added a comment.


  Yup, to me that looks like the actual numbers went up regularly and we’ve now 
caught up with them again:
  
  F35221895: image.png 
  
  (It’s most obvious in the “total edits” graph, which should be a pretty 
straight diagonal line.)
  
  @Manuel do you want to confirm?

TASK DETAIL
  https://phabricator.wikimedia.org/T310043

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Manuel, Aklapper, tstarling, Ladsgroup, Krinkle, aaron, Marostegui, 
Addshore, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310043: Update analytics-wmde-scripts for site_stats sharding

2022-06-09 Thread Manuel
Manuel moved this task from Product Verification to Our work done on the 
Wikidata-Campsite (Team A Hearth ) board.
Manuel closed this task as "Resolved".
Manuel added a comment.


  I can confirm: Your explanation makes perfect sense. We seem to now have 
caught up with the actual numbers. The total edits for example now matches 
https://www.wikidata.org/wiki/Special:Statistics again.
  
  Thank you for handling this! \o/

TASK DETAIL
  https://phabricator.wikimedia.org/T310043

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5612/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Manuel
Cc: Manuel, Aklapper, tstarling, Ladsgroup, Krinkle, aaron, Marostegui, 
Addshore, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a project: MediaWiki-extensions-CentralAuth.
Lucas_Werkmeister_WMDE added a comment.


  Okay, I can reproduce the error with `wfLoadExtension( 'CentralAuth' );` in 
LocalSettings.
  
  If I add `$wgCentralAuthDatabase = $wgDBname;`, then the error message 
changes:
  
  > Failed asserting that exception of type "Wikimedia\Rdbms\DBQueryError" 
matches expected exception "ApiUsageException". Message was: "Error 1146: Table 
'wiki1.globaluser' doesn't exist
  
  (`wiki1` is my DB name.) And when I then run `php maintenance/mysql.php < 
extensions/CentralAuth/schema/mysql/tables-generated.sql`, then the tests pass:
  
$ vendor/bin/phpunit 
extensions/Wikibase/client/tests/phpunit/unit/includes/Api/ApiFormatReferenceTest.php
 
Using PHP 8.1.2
PHPUnit 8.5.26 #StandWithUkraine

Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest
 ✔ testAsDataBridgeForHtml
 ✔ testInvalidReferenceJson
 ✔ testInvalidReferenceSerialization

Time: 430 ms, Memory: 52.50 MB

OK (3 tests, 8 assertions)
  
  So it’s something about the way CentralAuth is set up that previously used to 
work in CI but now doesn’t.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Okay, CentralAuth sets up its database in 
`UnitTestsHookHandler::onUnitTestsAfterDatabaseSetup()`, but that hook is only 
run by `MediaWikiIntegrationTestCase::setupTestDB()`. `ApiFormatReferenceTest` 
and `QuerySearchEntitiesTest` are nominally unit tests, not integration tests, 
so the database doesn’t get set up, but then CentralAuth still runs as if it’s 
in an integration test.
  
  I think the correct solution here is to declare those tests as integration 
tests. Trying to run a whole API module as only a unit test feels like a fool’s 
errand to me, at least at the moment. Perhaps a few years down the line, 
MediaWiki will be disciplined enough about dependency injection that API 
modules won’t interact with global state or the real wiki configuration, but 
until then, this should have its own database.
  
  But this also highlights something that was brought up in the Gerrit 
discussion 
:
  
  > Per Kosta on IRC, there's a chance the speed up is itself suspicious and 
possibly indicating we missed something, e.g. some kind of protection layer or 
reset.
  
  I think that’s exactly what’s happening – these unit tests, and presumably 
many others like them, previously enjoyed the protection layer of having a 
separate database set up for them, and now they don’t. I think we’re now 
running anything that claims to be a unit test against the real database of the 
wiki, and if it happens to hit a code path that isn’t ready for unit tests, so 
to speak (like this CentralAuth hook), then who knows what happens. IMHO this 
needs to be fixed – I don’t think it was sufficiently communicated that all 
extension unit tests would now be less “sandboxed”, so to speak.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot
gerritbot added a comment.


  Change 804279 **abandoned** by Kosta Harlan:
  
  [mediawiki/extensions/Wikibase@master] ApiFormatReferenceTest: Temporarily 
disable testInvalidReferenceJson
  
  Reason:
  
  
  
  https://gerrit.wikimedia.org/r/804279

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread kostajh
kostajh added a comment.


  In T310255#7991592 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > Okay, CentralAuth sets up its database in 
`UnitTestsHookHandler::onUnitTestsAfterDatabaseSetup()`, but that hook is only 
run by `MediaWikiIntegrationTestCase::setupTestDB()`. `ApiFormatReferenceTest` 
and `QuerySearchEntitiesTest` are nominally unit tests, not integration tests, 
so the database doesn’t get set up, but then CentralAuth still runs as if it’s 
in an integration test.
  >
  > I think the correct solution here is to declare those tests as integration 
tests.
  
  +1, that makes sense to me.
  
  As for the general problem about separate unit/integration runs, `composer 
phpunit:unit` runs which uses a fairly restrictive bootstrap file. Any attempts 
to access the database there or MediaWiki services would fail, for example. 
That command looks for tests that are in the `tests/phpunit/unit` subdirectory.
  
  So, we need to update Quibble's PHPUnit commands to then ensure that 
`tests/phpunit/unit` is excluded from integration test runs. We could do that 
by applying `@group Unit` to each unit test class and then using `--exclude 
Unit` in Quibble. That's a lot of work, though. We could also have 
ExtensionTestSuite manually exclude any tests that are in `tests/phpunit/unit` 
subdirectory, but that wouldn't handle the test run that happens for core. 
Maybe it is most straightforward (but also another hack) to just remove the 
`tests/phpunit/unit` directory from each project after `composer phpunit:unit` 
runs.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  > I think we’re now running anything that claims to be a unit test against 
the real database of the wiki
  
  Confirmed:
  
  name=tests/phpunit/unit/includes/LucasTest.php
selectRow(
'recentchanges',
[ 'rc_title', 'rc_timestamp' ],
'',
__METHOD__,
[
'LIMIT' => 1,
'ORDER BY' => 'rc_timestamp DESC',
]
) );
}

}
  
  
  
$ vendor/bin/phpunit tests/phpunit/unit/includes/LucasTest.php
Using PHP 8.1.2
PHPUnit 8.5.26 #StandWithUkraine

LucasTest
 ☢ testDatabaseAccess
/var/www/html/wiki1/tests/phpunit/unit/includes/LucasTest.php:12:
class stdClass#876 (2) {
  public $rc_title =>
  string(21) "Page_with_1000_commas"
  public $rc_timestamp =>
  string(14) "20220604150204"
}
  
  “Page with 1000 commas” is indeed the latest recentchanges entry on my local 
wiki, from 2022-06-04. This test is accessing the real wiki database. In my 
opinion, this should never happen – integration tests should have the test DB, 
and for unit tests, database access should fail.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Prior to 7238dff532 
,
 that test produces the following error:
  
Premature access to service container [Called from wfGetDB in 
/var/www/html/wiki1/includes/GlobalFunctions.php at line 1945]

/var/www/html/wiki1/includes/debug/MWDebug.php:381
/var/www/html/wiki1/includes/debug/MWDebug.php:352
/var/www/html/wiki1/includes/GlobalFunctions.php:795
/var/www/html/wiki1/includes/MediaWikiServices.php:278
/var/www/html/wiki1/includes/GlobalFunctions.php:1945
/var/www/html/wiki1/tests/phpunit/unit/includes/LucasTest.php:6

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  In T310255#7991620 , 
@gerritbot wrote:
  
  > Change 804283 had a related patch set uploaded (by Lucas Werkmeister 
(WMDE); author: Lucas Werkmeister (WMDE)):
  >
  > [mediawiki/extensions/Wikibase@master] Change API tests from unit tests to 
integration tests
  >
  > https://gerrit.wikimedia.org/r/804283
  
  Ugh, this doesn’t work yet because there’s one more warning (and those also 
make gate-and-submit fail):
  
PHPUnit\Framework\WarningTestCase
 ⚠ Warning
   │
   │ The data provider specified for ApiStructureTest::testParameters is 
invalid.
   │ Wikimedia\Rdbms\DBConnectionError: Cannot access the database: Access 
denied for user 'wikiuser'@'localhost' to database 'centralauth' 
(localhost:/workspace/db/quibble-mysql-wc4x6073/socket)
   │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:1465
   │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:958
   │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:931
   │ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:65
   │ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:270
   │ 
/workspace/src/extensions/CentralAuth/includes/GlobalGroup/GlobalGroupLookup.php:56
   │ 
/workspace/src/extensions/CentralAuth/includes/Api/ApiQueryGlobalAllUsers.php:273
   │ /workspace/src/includes/api/ApiBase.php:1782
   │ /workspace/src/tests/phpunit/structure/ApiStructureTest.php:175
   │ phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
  
  This is a unit test in core… should it also be an integration test? It tests 
that the parameter definitions of API modules are valid, and in CentralAuth 
that requires accessing the database so that the defined groups can be used for 
the `group` and `excludegroup` params. (Presumably, other APIs do something 
similar for `tags` parameters, that just doesn’t produce an error because the 
`change_tag_def` table would exist in the real wiki.)

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Wait, no. `ApiStructureTest` isn’t a unit test, it’s an integration test 
already, both by location (`tests/phpunit/structure/`) and type (`extends 
MediaWikiIntegrationTestCase`).
  
  But I guess the data providers are evaluated before the 
`onUnitTestsAfterDatabaseSetup()` hook runs 
  
  I’m actually not sure how this would’ve worked before.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310252: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread kostajh
kostajh created this task.
kostajh added projects: ci-test-error (WMF-deployed Build Failure), 
MediaWiki-extensions-WikibaseClient.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Seen on GrowthExperiments builds, e.g. 
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/156996/console
  
Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest
11:30:30  ✘ testInvalidReferenceJson
11:30:30│
11:30:30│ Failed asserting that exception of type 
"Wikimedia\Rdbms\DBConnectionError" matches expected exception 
"ApiUsageException". Message was: "Cannot access the database: Access denied 
for user 'wikiuser'@'localhost' to database 'centralauth' 
(localhost:/workspace/db/quibble-mysql-0qcjx7do/socket)" at
11:30:30│ 
/workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:1465
11:30:30│ 
/workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:958
11:30:30│ 
/workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:931
11:30:30│ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:65
11:30:30│ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:649
11:30:30│ /workspace/src/includes/libs/rdbms/database/Database.php:4281
11:30:30│ 
/workspace/src/extensions/CentralAuth/includes/User/CentralAuthUser.php:640
11:30:30│ 
/workspace/src/includes/libs/objectcache/wancache/WANObjectCache.php:1692
11:30:30│ 
/workspace/src/includes/libs/objectcache/wancache/WANObjectCache.php:1520
11:30:30│ 
/workspace/src/extensions/CentralAuth/includes/User/CentralAuthUser.php:660
11:30:30│ 
/workspace/src/extensions/CentralAuth/includes/User/CentralAuthUser.php:465
11:30:30│ 
/workspace/src/extensions/CentralAuth/includes/User/CentralAuthUser.php:714
11:30:30│ 
/workspace/src/extensions/CentralAuth/includes/User/CentralAuthUser.php:807
11:30:30│ 
/workspace/src/extensions/CentralAuth/includes/CentralAuthHooks.php:568
11:30:30│ /workspace/src/includes/HookContainer/HookContainer.php:160
11:30:30│ /workspace/src/includes/HookContainer/HookRunner.php:1942
11:30:30│ /workspace/src/includes/block/BlockManager.php:179
11:30:30│ /workspace/src/includes/user/User.php:1436
11:30:30│ /workspace/src/includes/user/User.php:1752
11:30:30│ /workspace/src/includes/api/ApiBase.php:1285
11:30:30│ /workspace/src/includes/api/ApiBase.php:1528
11:30:30│ 
/workspace/src/extensions/Wikibase/client/includes/Api/ApiFormatReference.php:56
11:30:30│ 
/workspace/src/extensions/Wikibase/client/tests/phpunit/unit/includes/Api/ApiFormatReferenceTest.php:141
11:30:30│ 
phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
11:30:30│ .
11:30:30│
11:30:30│ 
phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97

TASK DETAIL
  https://phabricator.wikimedia.org/T310252

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: kostajh, Aklapper, Akuckartz, DannyS712, lucamauri, Wikidata-bugs, 
Jdforrester-WMF
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Math CI tests fail

2022-06-09 Thread kostajh
kostajh added a project: MediaWiki-extensions-WikibaseClient.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Akuckartz, DannyS712, lucamauri, Maosef, Debenben, Izno, 
thcipriani, Wikidata-bugs, fredw, Pkra, scfc, Jdforrester-WMF, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310252: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread kostajh
kostajh closed this task as a duplicate of T310255: Math CI tests fail.

TASK DETAIL
  https://phabricator.wikimedia.org/T310252

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: kostajh, Aklapper, Akuckartz, DannyS712, lucamauri, Wikidata-bugs, 
Jdforrester-WMF
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Maintenance_bot
Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, 
Lewizho99, Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Izno, thcipriani, Wikidata-bugs, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310252: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Maintenance_bot
Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T310252

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: kostajh, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, DannyS712, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310259: Add option to edit interlanguage links as an option on the language selector

2022-06-09 Thread Pginer-WMF
Pginer-WMF created this task.
Pginer-WMF added projects: UniversalLanguageSelector, Wikidata.

TASK DESCRIPTION
  With recent desktop improvements 
 the language 
selector is provided in a new place where some options are no longer available. 
In particular, users cannot easily edit interwiki links on Wikidata or find the 
translation tool.
  
  In response to this, the Language team has incorporated an extensible menu 
inside the language selector dialog to provide access to those options. 
  More details in T289840: Add "quick actions" menu to the current language 
selector 
  
  The options to translate the page and to access the language settings are 
already available. This ticket proposes to add the remaining "Edit language 
links". We expect the Wikidata team to be able to do this with support from the 
Language team. So feel free to share any questions.
  
  F32401021: more-options.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T310259

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pginer-WMF
Cc: Lydia_Pintscher, santhosh, olga, Aklapper, Theklan, ovasileva, Pginer-WMF, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, Amire80, 
Nikerabbit, Arrbee, KartikMistry, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T307869: Request for new search profile for Wikidata that boosts Items for languages

2022-06-09 Thread ItamarWMDE
ItamarWMDE added a project: User-ItamarWMDE.

TASK DETAIL
  https://phabricator.wikimedia.org/T307869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: ItamarWMDE, dcausse, Lucas_Werkmeister_WMDE, MPhamWMF, Aklapper, 
Lydia_Pintscher, Fernandobacasegua34, Astuthiodit_1, Nikospappas1312, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, 
Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Gryllida, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T298146: Spelling variant of the Lemma - Access documentation if spelling variant isn’t available

2022-06-09 Thread ItamarWMDE
ItamarWMDE removed a project: User-ItamarWMDE.

TASK DETAIL
  https://phabricator.wikimedia.org/T298146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Erdinc_Ciftci_WMDE, ItamarWMDE
Cc: ItamarWMDE, Sarai-WMDE, Michael, Erdinc_Ciftci_WMDE, Aklapper, 
Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, 786, Suran38, Biggs657, Lalamarie69, 
Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, DannyS712, CucyNoiD, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, 
Af420, Bsandipan, Maosef, Lewizho99, Maathavan, Debenben, Neuronton, Izno, 
thcipriani, Wikidata-bugs, fredw, Pkra, scfc, Jdforrester-WMF, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot
gerritbot added a comment.


  Change 804279 had a related patch set uploaded (by Kosta Harlan; author: 
Kosta Harlan):
  
  [mediawiki/extensions/Wikibase@master] ApiFormatReferenceTest: Temporarily 
disable testInvalidReferenceJson
  
  https://gerrit.wikimedia.org/r/804279

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Akuckartz, DannyS712, lucamauri, Maosef, Debenben, Izno, 
thcipriani, Wikidata-bugs, fredw, Pkra, scfc, Jdforrester-WMF, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T306789: AbuseFilter messages contain local hrefs even for links formed with interwiki prefix

2022-06-09 Thread Manuel
Manuel updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T306789

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: CX_Zoom, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Manuel, Aklapper, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T306789: AbuseFilter messages contain local hrefs even for links formed with interwiki prefix

2022-06-09 Thread Manuel
Manuel added a project: AbuseFilter.
Manuel added a comment.


  This looks like an issue in the AbuseFilter component. Maybe someone from the 
AbuseFilter team might be able to help?

TASK DETAIL
  https://phabricator.wikimedia.org/T306789

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: CX_Zoom, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Manuel, Aklapper, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
94rain, Nandana, Lahi, Gq86, Daimona, GoranSMilovanovic, ihojose, QZanden, 
LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T306789: AbuseFilter messages contain local hrefs even for links formed with interwiki prefix

2022-06-09 Thread Manuel
Manuel updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T306789

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: CX_Zoom, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Manuel, Aklapper, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread kostajh
kostajh renamed this task from "Math CI tests fail" to 
"Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson 
failure".
kostajh updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Akuckartz, DannyS712, lucamauri, Maosef, Debenben, Izno, 
thcipriani, Wikidata-bugs, fredw, Pkra, scfc, Jdforrester-WMF, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  I can’t reproduce this yet, `vendor/bin/phpunit 
extensions/Wikibase/client/tests/phpunit/unit/` works fine for me with latest 
MediaWiki core and Wikibase…

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, 
Lewizho99, Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Izno, thcipriani, Wikidata-bugs, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310259: Add option to edit interlanguage links as an option on the language selector

2022-06-09 Thread Theklan
Theklan added a comment.


  I think the ··· button doesn't suggest what you are going to find there, but 
an expanded list of languages. Also, when open, the button to close it is a 
left arrow. For consistency, there should be a right arrow instead of a menu 
(···) button. I also suggest the button to be in the upper side, and not in the 
lower side. Now the option to translate to other languages is in the upper 
side, above the interlanguage links. There seems more logical.

TASK DETAIL
  https://phabricator.wikimedia.org/T310259

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Theklan
Cc: Lydia_Pintscher, santhosh, olga, Aklapper, Theklan, ovasileva, Pginer-WMF, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, Amire80, 
Nikerabbit, Arrbee, KartikMistry, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T307869: Request for new search profile for Wikidata that boosts Items for languages

2022-06-09 Thread gerritbot
gerritbot added a comment.


  Change 804344 had a related patch set uploaded (by DCausse; author: DCausse):
  
  [mediawiki/extensions/Wikibase@master] EntitySearchHelper: pass a "profile 
context" to the engine
  
  https://gerrit.wikimedia.org/r/804344

TASK DETAIL
  https://phabricator.wikimedia.org/T307869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ItamarWMDE, dcausse, Lucas_Werkmeister_WMDE, MPhamWMF, Aklapper, 
Lydia_Pintscher, Fernandobacasegua34, Astuthiodit_1, Nikospappas1312, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, 
Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Gryllida, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T308654: Validate lemma length inline on input event

2022-06-09 Thread gerritbot
gerritbot added a comment.


  Change 803507 **merged** by jenkins-bot:
  
  [mediawiki/extensions/WikibaseLexeme@master] Lexidata: add maxLemmaLength to 
init parameter list
  
  https://gerrit.wikimedia.org/r/803507

TASK DETAIL
  https://phabricator.wikimedia.org/T308654

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, gerritbot
Cc: Lydia_Pintscher, Erdinc_Ciftci_WMDE, karapayneWMDE, ItamarWMDE, noarave, 
Michael, Lucas_Werkmeister_WMDE, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T308654: Validate lemma length inline on input event

2022-06-09 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.16; 
2022-06-13); removed MW-1.39-notes (1.39.0-wmf.14; 2022-05-30).

TASK DETAIL
  https://phabricator.wikimedia.org/T308654

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, ReleaseTaggerBot
Cc: Lydia_Pintscher, Erdinc_Ciftci_WMDE, karapayneWMDE, ItamarWMDE, noarave, 
Michael, Lucas_Werkmeister_WMDE, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Paste] P29605: More Entity IDs for T301104

2022-06-09 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


lucaswerkmeister-wmde@mwmaint1002:~$ mwscript 
extensions/Wikibase/repo/maintenance/dumpJson.php wikidatawiki --list-file 
moreids-T301104 --snippet 2>/dev/null > dump-nometadata-T301104
lucaswerkmeister-wmde@mwmaint1002:~$ mwscript 
extensions/Wikibase/repo/maintenance/dumpJson.php wikidatawiki --list-file 
moreids-T301104 --snippet --page-metadata 2>/dev/null > dump-metadata-T301104
lucaswerkmeister-wmde@mwmaint1002:~$ wc -c < dump-nometadata-T301104 
150784416
lucaswerkmeister-wmde@mwmaint1002:~$ wc -c < dump-metadata-T301104 
151574520
lucaswerkmeister-wmde@mwmaint1002:~$ gzip -9 < dump-nometadata-T301104 | wc 
-c
15622451
lucaswerkmeister-wmde@mwmaint1002:~$ gzip -9 < dump-metadata-T301104 | wc -c
15920738
lucaswerkmeister-wmde@mwmaint1002:~$ bzip2 < dump-nometadata-T301104 | wc -c
10541406
lucaswerkmeister-wmde@mwmaint1002:~$ bzip2 < dump-metadata-T301104 | wc -c
10722543

PASTE DETAIL
  https://phabricator.wikimedia.org/P29605

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310259: Add option to edit interlanguage links as an option on the language selector

2022-06-09 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.


  I have to agree with @Theklan. This does feel a bit too hidden for something 
so crucial for the connection between our projects.

TASK DETAIL
  https://phabricator.wikimedia.org/T310259

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, santhosh, olga, Aklapper, Theklan, ovasileva, Pginer-WMF, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, Amire80, 
Nikerabbit, Arrbee, KartikMistry, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread kostajh
kostajh added a comment.


  Let's see if https://gerrit.wikimedia.org/r/c/mediawiki/core/+/804319 and 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/804283 work, 
otherwise we should revert 
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/741970 (cc @Krinkle).

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread kostajh
kostajh added a comment.


  In T310255#7991842 , 
@kostajh wrote:
  
  > In T310255#7991676 , 
@Lucas_Werkmeister_WMDE wrote:
  >
  >> Wait, no. `ApiStructureTest` isn’t a unit test, it’s an integration test 
already, both by location (`tests/phpunit/structure/`) and type (`extends 
MediaWikiIntegrationTestCase`).
  >>
  >> But I guess the data providers are evaluated before the 
`onUnitTestsAfterDatabaseSetup()` hook runs 
  >>
  >> I’m actually not sure how this would’ve worked before.
  >
  > Something I observed before the vendor/bin/phpunit switch is that data 
providers with exceptions would silently fail, and thus the test wouldn't run 
at all. But that doesn't seem to be the case here.
  >
  > In T310255#7991644 , 
@Lucas_Werkmeister_WMDE wrote:
  >
  >>> I think we’re now running anything that claims to be a unit test against 
the real database of the wiki
  >>
  >> Confirmed:
  >>
  >> name=tests/phpunit/unit/includes/LucasTest.php
  >>   >   
  >>   class LucasTest extends \PHPUnit\Framework\TestCase {
  >>   
  >>public function testDatabaseAccess(): void {
  >>var_dump( wfGetDB( DB_PRIMARY )->selectRow(
  >>'recentchanges',
  >>[ 'rc_title', 'rc_timestamp' ],
  >>'',
  >>__METHOD__,
  >>[
  >>'LIMIT' => 1,
  >>'ORDER BY' => 'rc_timestamp DESC',
  >>]
  >>) );
  >>}
  >>   
  >>   }
  >>
  >>
  >>
  >>   $ vendor/bin/phpunit tests/phpunit/unit/includes/LucasTest.php
  >>   Using PHP 8.1.2
  >>   PHPUnit 8.5.26 #StandWithUkraine
  >>   
  >>   LucasTest
  >>☢ testDatabaseAccess
  >>   /var/www/html/wiki1/tests/phpunit/unit/includes/LucasTest.php:12:
  >>   class stdClass#876 (2) {
  >> public $rc_title =>
  >> string(21) "Page_with_1000_commas"
  >> public $rc_timestamp =>
  >> string(14) "20220604150204"
  >>   }
  >>
  >> “Page with 1000 commas” is indeed the latest recentchanges entry on my 
local wiki, from 2022-06-04. This test is accessing the real wiki database. In 
my opinion, **this should never happen** – integration tests should have the 
test DB, and for unit tests, database access should fail.
  >
  > Unit (as opposed to integration) tests need to run with a separate 
bootstrap file. Can you test with `vendor/bin/phunit --bootstrap 
tests/phpunit/bootstrap.php tests/phpunit/unit/includes/LucasTest.php` ? That 
is what `composer phpunit:unit` is using.
  
  @Lucas_Werkmeister_WMDE there's another test to fix as well, see 
https://integration.wikimedia.org/ci/job/wikibase-client-docker/28093/console:
  
13:03:46 INFO:quibble.commands:php tests/phpunit/phpunit.php --verbose 
--log-junit "$LOG_DIR/junit-wikibase-client.xml" --group Wikibase,WikibaseClient
13:03:46 Using PHP 7.3.33-1+0~2029.91+debian10~1.gbp618351
13:03:46 PHP Deprecated:  tests/phpunit/phpunit.php is deprecated and will 
be removed. Please use `composer phpunit` or `vendor/bin/phpunit` [Called from 
unknown in /workspace/src/tests/phpunit/phpunit.php at line 75] in 
/workspace/src/includes/debug/MWDebug.php on line 381
13:03:46 Deprecated: tests/phpunit/phpunit.php is deprecated and will be 
removed. Please use `composer phpunit` or `vendor/bin/phpunit` [Called from 
unknown in /workspace/src/tests/phpunit/phpunit.php at line 75] in 
/workspace/src/includes/debug/MWDebug.php on line 381
13:03:48 [e70351983cbb3759ca54c6bb] [no req]   Exception: entitySources 
must be configured for non-repo client wikis
13:03:48 Backtrace:
13:03:48 from 
/workspace/src/extensions/Wikibase/client/config/WikibaseClient.default.php(211)
13:03:48 #0 
/workspace/src/extensions/Wikibase/lib/includes/SettingsArray.php(68): 
Wikibase\Lib\WikibaseSettings::{closure}(Wikibase\Lib\SettingsArray)
13:03:48 #1 
/workspace/src/extensions/Wikibase/client/WikibaseClient.ServiceWiring.php(433):
 Wikibase\Lib\SettingsArray->getSetting(string)
13:03:48 #2 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(447): 
Wikimedia\Services\ServiceContainer->{closure}(MediaWiki\MediaWikiServices)
13:03:48 #3 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(416): 
Wikimedia\Services\ServiceContainer->createService(string)
13:03:48 #4 /workspace/src/includes/MediaWikiServices.php(295): 
Wikimedia\Services\ServiceContainer->getService(string)
13:03:48 #5 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(424): 
MediaWiki\MediaWikiServices->getService(string)
13:03:48 #6 
/workspace/src/extensions/Wikibase/client/includes/WikibaseClient.php(123): 
Wikimedia\Services\ServiceContainer->get(string)
13:03:48 #7 

[Wikidata-bugs] [Maniphest] T307869: Request for new search profile for Wikidata that boosts Items for languages

2022-06-09 Thread gerritbot
gerritbot added a comment.


  Change 801791 **abandoned** by DCausse:
  
  [mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Add new config 
options to tune Special:NewLexeme...
  
  Reason:
  
  moved to WikibaseCirrusSearch
  
  https://gerrit.wikimedia.org/r/801791

TASK DETAIL
  https://phabricator.wikimedia.org/T307869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ItamarWMDE, dcausse, Lucas_Werkmeister_WMDE, MPhamWMF, Aklapper, 
Lydia_Pintscher, Fernandobacasegua34, Astuthiodit_1, Nikospappas1312, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, 
Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Gryllida, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: PHPUnit failure in various extensions: Wikimedia\Rdbms\DBConnectionError: Cannot access the database: Access denied for user 'wikiuser'@'localhost' to database 'ce

2022-06-09 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE lowered the priority of this task from "Unbreak Now!" to 
"High".
Lucas_Werkmeister_WMDE added a comment.


  No longer UBN!; I’ll leave @kostajh to decide whether this task should be 
kept open or closed, since the revert isn’t a permanent solution.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: matmarex, Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, 
kostajh, Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 
786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T306789: AbuseFilter messages contain local hrefs even for links formed with interwiki prefix

2022-06-09 Thread Manuel
Manuel added a comment.


  Thank you for considering this @Daimona!

TASK DETAIL
  https://phabricator.wikimedia.org/T306789

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Daimona, CX_Zoom, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Manuel, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, 94rain, Nandana, Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, 
LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T297299: Ensure Team A gets notified if something breaks on Wikidata Analytics

2022-06-09 Thread ItamarWMDE
ItamarWMDE claimed this task.
Restricted Application added a project: User-ItamarWMDE.

TASK DETAIL
  https://phabricator.wikimedia.org/T297299

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: ItamarWMDE, Lucas_Werkmeister_WMDE, Michael, Addshore, WMDE-leszek, Manuel, 
GoranSMilovanovic, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot
gerritbot added a comment.


  Change 803918 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/core@master] Revert "phpunit: Default to vendor/bin/phpunit, 
remove suites.xml"
  
  https://gerrit.wikimedia.org/r/803918

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T238751: Only generate maxlag from pooled query service servers.

2022-06-09 Thread gerritbot
gerritbot added a comment.


  Change 552544 **restored** by Itamar Givon:
  
  [mediawiki/extensions/Wikidata.org@master] Only generate QS maxlag for pooled 
servers
  
  https://gerrit.wikimedia.org/r/552544

TASK DETAIL
  https://phabricator.wikimedia.org/T238751

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Joe, gerritbot
Cc: ItamarWMDE, akosiaris, Lydia_Pintscher, bking, karapayneWMDE, 
Lucas_Werkmeister_WMDE, Ladsgroup, Gehel, Jheald, Joe, Addshore, Aklapper, 
Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, Invadibot, 
Lalamarie69, MPhamWMF, LSobanski, maantietaja, Juan90264, Alter-paule, 
Beast1978, CBogen, Un1tY, Akuckartz, Hook696, PatsagornY, Kent7301, 
joker88john, CucyNoiD, Nandana, jijiki, Klaas_Z4us_V, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, EBjune, 
LawExplorer, Lewizho99, Maathavan, elukey, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot
gerritbot added a comment.


  Change 803918 **merged** by jenkins-bot:
  
  [mediawiki/core@master] Revert "phpunit: Default to vendor/bin/phpunit, 
remove suites.xml"
  
  https://gerrit.wikimedia.org/r/803918

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310255: PHPUnit failure in various extensions: Wikimedia\Rdbms\DBConnectionError: Cannot access the database: Access denied for user 'wikiuser'@'localhost' to database 'ce

2022-06-09 Thread matmarex
matmarex renamed this task from 
"Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson 
failure" to "PHPUnit failure in various extensions: 
Wikimedia\Rdbms\DBConnectionError: Cannot access the database: Access denied 
for user 'wikiuser'@'localhost' to database 'centralauth'".

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matmarex
Cc: matmarex, Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, 
kostajh, Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 
786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org