[Wikidata-bugs] [Maniphest] [Updated] T257096: Configure eslint for jsx files

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE removed a project: Story. TASK DETAIL https://phabricator.wikimedia.org/T257096 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplore

[Wikidata-bugs] [Maniphest] [Created] T257096: Configure eslint for jsx files

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Story, Wikidata - DS hike (Milestone 1 - Edit and Demo Tokens). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T257096 EMAIL PREFERENCES https://phabricat

[Wikidata-bugs] [Maniphest] [Commented On] T249039: Security Readiness Review For Wikidata Bridge

2020-07-03 Thread sbassett
sbassett added a comment. **Update:** Apologies, but this is going to have to wait until Monday 2020-07-06. TASK DETAIL https://phabricator.wikimedia.org/T249039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sbassett Cc: WMDE-leszek, sbassett,

[Wikidata-bugs] [Maniphest] [Edited] T254675: Rename WPBSkinBlacklist

2020-07-03 Thread Peter.ovchyn
Peter.ovchyn updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T254675 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Peter.ovchyn Cc: Ammarpad, Reedy, Aklapper, abi_, Amire80, Ladsgroup, Dinoguy1000, APerson, Isarra, MZMcB

[Wikidata-bugs] [Maniphest] [Commented On] T254675: Rename WPBSkinBlacklist

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609490 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn): [operations/mediawiki-config@master] Rename WPBSkinBlacklist to WPBSkinDisabled https://gerrit.wikimedia.org/r/609490 TASK DETAIL https://phabricator.wikimedia.org/T2546

[Wikidata-bugs] [Maniphest] [Commented On] T255885: Figure out what to do with uses of Repo classes in Lib and Client tests

2020-07-03 Thread Ladsgroup
Ladsgroup added a comment. In T255885#6277267 , @Lucas_Werkmeister_WMDE wrote: > If we say that this is a test which needs the WikibaseRepo extension to be installed, and that’s fine, but we want to avoid the direct coupling to the `Wik

[Wikidata-bugs] [Maniphest] [Commented On] T256391: Evaluate Puppeteer in EntitySchema

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609483 had a related patch set uploaded (by AlQaholic007; owner: AlQaholic007): [mediawiki/extensions/EntitySchema@master] WIP Puppeteer: SetEntitySchemaLabelDescriptionAliasesPage:Page should detect edit conflict on re-submission https://gerrit.wikim

[Wikidata-bugs] [Maniphest] [Commented On] T256391: Evaluate Puppeteer in EntitySchema

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609481 had a related patch set uploaded (by AlQaholic007; owner: AlQaholic007): [mediawiki/extensions/EntitySchema@master] WIP Puppeteer: SetEntitySchemaLabelDescriptionAliasesPage:Page should allow Schema edit in another language https://gerrit.wikim

[Wikidata-bugs] [Maniphest] [Commented On] T256391: Evaluate Puppeteer in EntitySchema

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609478 had a related patch set uploaded (by AlQaholic007; owner: AlQaholic007): [mediawiki/extensions/EntitySchema@master] WIP Puppeteer: SetEntitySchemaLabelDescriptionAliasesPage:Page should make it possible to edit identifying info https://gerrit.w

[Wikidata-bugs] [Maniphest] [Updated] T256252: Migrate wgWBClientDataTypes + wgWBClientSettings loading out of Client PHP entry point

2020-07-03 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T256252 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Ladsgroup, Aklapper, Lucas_Werkmeister_WMDE, darthmo

[Wikidata-bugs] [Maniphest] [Commented On] T256252: Migrate wgWBClientDataTypes + wgWBClientSettings loading out of Client PHP entry point

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 608663 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Don’t load $wgWBClientSettings in WikibaseClient.php https://gerrit.wikimedia.org/r/608663 TASK DETAIL https://phabricator.wikimedia.org/T256252 EMAIL PREFERENCES https://pha

[Wikidata-bugs] [Maniphest] [Commented On] T256391: Evaluate Puppeteer in EntitySchema

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609476 had a related patch set uploaded (by AlQaholic007; owner: AlQaholic007): [mediawiki/extensions/EntitySchema@master] WIP Puppeteer: SetEntitySchemaLabelDescriptionAliasesPage:Page should make it possible to get Schema identifying info https://ge

[Wikidata-bugs] [Maniphest] [Commented On] T256391: Evaluate Puppeteer in EntitySchema

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609474 had a related patch set uploaded (by AlQaholic007; owner: AlQaholic007): [mediawiki/extensions/EntitySchema@master] WIP Puppeteer: SetEntitySchemaLabelDescriptionAliasesPage:Page shows label, description aliases form and submit button https://g

[Wikidata-bugs] [Maniphest] [Commented On] T256391: Evaluate Puppeteer in EntitySchema

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609473 had a related patch set uploaded (by AlQaholic007; owner: AlQaholic007): [mediawiki/extensions/EntitySchema@master] WIP Puppeteer: SetEntitySchemaLabelDescriptionAliasesPage:Page request shows first form https://gerrit.wikimedia.org/r/609473 TA

[Wikidata-bugs] [Maniphest] [Changed Project Column] T255885: Figure out what to do with uses of Repo classes in Lib and Client tests

2020-07-03 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Peer Review to Verification on the Wikibase Extension Decoupling and Registration (Sprint 2) board. Lucas_Werkmeister_WMDE added a comment. Verification instructions: check that Travis CI builds are green again. TASK DETAIL https://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T255885: Figure out what to do with uses of Repo classes in Lib and Client tests

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609461 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Skip SqlChangeStoreTest in Client-only mode https://gerrit.wikimedia.org/r/609461 TASK DETAIL https://phabricator.wikimedia.org/T255885 EMAIL PREFERENCES https://phabricator.

[Wikidata-bugs] [Maniphest] [Commented On] T256391: Evaluate Puppeteer in EntitySchema

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609469 had a related patch set uploaded (by AlQaholic007; owner: AlQaholic007): [mediawiki/extensions/EntitySchema@master] WIP Puppeteer: Schema Edit Page properly limits input length https://gerrit.wikimedia.org/r/609469 TASK DETAIL https://phabric

[Wikidata-bugs] [Maniphest] [Updated] T256259: Migrate Client ChangesListLinesHandler hooks to extension JSON

2020-07-03 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T256259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow, Maintenance_bot Cc: Aklapper, ItamarWMDE, Lucas_Werkmeister_WMDE, darthmon_wmde, DannyS7

[Wikidata-bugs] [Maniphest] [Updated] T257034: Turn LibHooks into HookHandler

2020-07-03 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T257034 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Maintenance_bot Cc: Aklapper, Lucas_Werkmeister_WMDE, Hazizibinmahdi, darthmon_wmde,

[Wikidata-bugs] [Maniphest] [Updated] T257034: Turn LibHooks into HookHandler

2020-07-03 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07). TASK DETAIL https://phabricator.wikimedia.org/T257034 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, ReleaseTaggerBot Cc: Aklapper, Lucas_Werkmeister_WMDE, Alter-

[Wikidata-bugs] [Maniphest] [Updated] T255885: Figure out what to do with uses of Repo classes in Lib and Client tests

2020-07-03 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T255885 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Ladsgroup, Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1t

[Wikidata-bugs] [Maniphest] [Commented On] T256861: Create visalization for cursors

2020-07-03 Thread Sarai-WMDE
Sarai-WMDE added a comment. Oh wow!! Working great now! Thanks for the hack, Pablo :D TASK DETAIL https://phabricator.wikimedia.org/T256861 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE, Sarai-WMDE Cc: Pablo-WMDE, Aklapper, Sarai-WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T255885: Figure out what to do with uses of Repo classes in Lib and Client tests

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609461 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Skip SqlChangeStoreTest in Client-only mode https://gerrit.wikimedia.org/r/609461 TASK DETAIL https://phab

[Wikidata-bugs] [Maniphest] [Commented On] T256854: Create visalization for Size/Dimension

2020-07-03 Thread Sarai-WMDE
Sarai-WMDE added a comment. Viz pimping: 1. Divide the content in two sections/tables with their respective h2s in the following order: 1. Static sizes (from `dimension-static-size-0` to `dimension-static-size-3200`) 2. Heights and widths (A third section containing paddings

[Wikidata-bugs] [Maniphest] [Commented On] T256861: Create visalization for cursors

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. > The thing is that I don't see any behaviour at all Hacked something. Should now have more behavior than none. https://wmde.github.io/wikit/ TASK DETAIL https://phabricator.wikimedia.org/T256861 EMAIL PREFERENCES https://phabricator.wikimedia.org/setting

[Wikidata-bugs] [Maniphest] [Created] T257065: Differentiate between global and other tokens when displaying

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata - DS hike (Milestone 1 - Edit and Demo Tokens). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION There were comments like > The 2 global tokens (box-shadow-inset-thin, box-shadow-inset-thick) s

[Wikidata-bugs] [Maniphest] [Unblock] T256246: Migrate Client hooks to extension JSON

2020-07-03 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T256259: Migrate Client ChangesListLinesHandler hooks to extension JSON as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T256246 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Closed] T256259: Migrate Client ChangesListLinesHandler hooks to extension JSON

2020-07-03 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikibase Extension Decoupling and Registration (Sprint 2) board. TASK DETAIL https://phabricator.wikimedia.org/T256259 WORKBOARD https://phabricator.wikimedia.org/pro

[Wikidata-bugs] [Maniphest] [Commented On] T256391: Evaluate Puppeteer in EntitySchema

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609458 had a related patch set uploaded (by AlQaholic007; owner: AlQaholic007): [mediawiki/extensions/EntitySchema@master] WIP Puppeteer: Schema Edit Page detects an edit conflict on re-submission when user is allowed https://gerrit.wikimedia.org/r/609

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

2020-07-03 Thread Sarai-WMDE
Sarai-WMDE added a comment. Leaving here a couple of improvements: 1. Make the font size of the value column 14px. 2. It may make sense to use typeset here too (like in the rest of the font pages) rather than the blue background. If it does, then I would apply the following sizes to ea

[Wikidata-bugs] [Maniphest] [Commented On] T257034: Turn LibHooks into HookHandler

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609439 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Turn LibHooks into HookHandler https://gerrit.wikimedia.org/r/609439 TASK DETAIL https://phabricator.wikimedia.org/T257034 EMAIL PREFERENCES https://phabricator.wikimedia.org/

[Wikidata-bugs] [Maniphest] [Commented On] T256259: Migrate Client ChangesListLinesHandler hooks to extension JSON

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609408 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Refactor ChangesLinesListHandler https://gerrit.wikimedia.org/r/609408 TASK DETAIL https://phabricator.wikimedia.org/T256259 EMAIL PREFERENCES https://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] [Commented On] T256391: Evaluate Puppeteer in EntitySchema

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609453 had a related patch set uploaded (by AlQaholic007; owner: AlQaholic007): [mediawiki/extensions/EntitySchema@master] WIP Puppeteer: Schema Edit Page returns to view page on submit when user is allowed https://gerrit.wikimedia.org/r/609453 TASK D

[Wikidata-bugs] [Maniphest] [Commented On] T256856: Create visualization for width breakpoints

2020-07-03 Thread Sarai-WMDE
Sarai-WMDE added a comment. All good! TASK DETAIL https://phabricator.wikimedia.org/T256856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE, Sarai-WMDE Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, darthmon

[Wikidata-bugs] [Maniphest] [Commented On] T256858: Create visalization for shadows

2020-07-03 Thread Sarai-WMDE
Sarai-WMDE added a comment. Improvement suggestions: 1. The 2 global tokens (box-shadow-inset-thin, box-shadow-inset-thick) should go on top 2. The font size of the text in the duration value column () should be 14px. 3. The value text should be outside the specimen 4. The specime

[Wikidata-bugs] [Maniphest] [Commented On] T257057: Create visalization for borders

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. @Sarai-WMDE http://172.17.0.2:43149/?path=/docs/design-tokens-borders--page TASK DETAIL https://phabricator.wikimedia.org/T257057 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Sarai-WMDE, Jako

[Wikidata-bugs] [Maniphest] [Commented On] T256861: Create visalization for cursors

2020-07-03 Thread Sarai-WMDE
Sarai-WMDE added a comment. The thing is that I don't see any behaviour at all 🤷🏼‍♀️ Agree on creating a ticket if this is something we want since, yes, it hasn't been discussed. Addition: the font size of the text in the duration value column () should be 14px. TASK DETAIL https://ph

[Wikidata-bugs] [Maniphest] [Commented On] T256391: Evaluate Puppeteer in EntitySchema

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609448 had a related patch set uploaded (by AlQaholic007; owner: AlQaholic007): [mediawiki/extensions/EntitySchema@master] WIP Puppeteer: Schema Edit Page has a submit button when user is allowed https://gerrit.wikimedia.org/r/609448 TASK DETAIL htt

[Wikidata-bugs] [Maniphest] [Commented On] T256860: Create visalization for z-index (positioning)

2020-07-03 Thread Sarai-WMDE
Sarai-WMDE added a comment. All good! Same comment again, as in all pages: I expected that clicking the anchor emoji would update the URL, appending the anchor, but that is not happening (tried Chrome and Firefox). Maybe I misunderstood their function? TASK DETAIL https://phabricator.wikim

[Wikidata-bugs] [Maniphest] [Commented On] T256861: Create visalization for cursors

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. In T256861#6277339 , @Sarai-WMDE wrote: > Anchor links do not work on Chrome in any of the pages: the URL is not updated on click. FTR In the grand scheme of things this is interesting but the least of ou

[Wikidata-bugs] [Maniphest] [Commented On] T256861: Create visalization for cursors

2020-07-03 Thread Sarai-WMDE
Sarai-WMDE added a comment. Anchor links do not work on Chrome in any of the pages: the URL is not updated on click. TASK DETAIL https://phabricator.wikimedia.org/T256861 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE, Sarai-WMDE Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T253863: SetDescription/Label/Aliases special pages on commons specifies Item/Property in messages but can be used for MediaInfo

2020-07-03 Thread toan
toan added a comment. This could be supported by -> https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/608903 TASK DETAIL https://phabricator.wikimedia.org/T253863 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Addsh

[Wikidata-bugs] [Maniphest] [Commented On] T256854: Create visalization for Size/Dimension

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. @Sarai-WMDE https://wmde.github.io/wikit/?path=/docs/design-tokens-dimensions--page TASK DETAIL https://phabricator.wikimedia.org/T256854 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklap

[Wikidata-bugs] [Maniphest] [Commented On] T257057: Create visalization for borders

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. https://github.com/wmde/wikit/pull/51 TASK DETAIL https://phabricator.wikimedia.org/T257057 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, Pablo

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. @Sarai-WMDE https://wmde.github.io/wikit/?path=/docs/design-tokens-font-line-height--page TASK DETAIL https://phabricator.wikimedia.org/T256855 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T256391: Evaluate Puppeteer in EntitySchema

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609443 had a related patch set uploaded (by AlQaholic007; owner: AlQaholic007): [mediawiki/extensions/EntitySchema@master] WIP Puppeteer: Schema Edit Page has text area when user is allowed https://gerrit.wikimedia.org/r/609443 TASK DETAIL https://p

[Wikidata-bugs] [Maniphest] [Edited] T256024: Illustrate tokens

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T256024 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Tonina_Zhelyazkova_WMDE, Jakob_WMDE, Sarai-WMDE, Aklapper, Pablo-WMDE, darthmon_wmde, Nandan

[Wikidata-bugs] [Maniphest] [Created] T257057: Create visalization for borders

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata - DS hike (Milestone 1 - Edit and Demo Tokens). TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T257057 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo

[Wikidata-bugs] [Maniphest] [Commented On] T255885: Figure out what to do with uses of Repo classes in Lib and Client tests

2020-07-03 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. I looked a bit into LuaWikibaseIntegrationTest and I’m also unsure what to do with that. The test saves an example item to `WikibaseRepo`’s entity store, creates a test module, and then tests the result of parsing various bits of wikitext that invoke t

[Wikidata-bugs] [Maniphest] [Updated] T255885: Figure out what to do with uses of Repo classes in Lib and Client tests

2020-07-03 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T255885 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Ladsgroup, Aklapper, Lucas_Werkmeister_WMDE, Hazizibinmahdi, darthmon_wmde,

[Wikidata-bugs] [Maniphest] [Created] T257055: WDQS - Planning for disaster (significant failure of the project)

2020-07-03 Thread Gehel
Gehel created this task. Gehel added a project: Wikidata-Query-Service. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION We know that WDQS is getting close to the scaling limits. While we want to make WDQS scale, we need to

[Wikidata-bugs] [Maniphest] [Updated] T255885: Figure out what to do with uses of Repo classes in Lib and Client tests

2020-07-03 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07). TASK DETAIL https://phabricator.wikimedia.org/T255885 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ReleaseTaggerBot Cc: Ladsgroup, Aklapper, Lucas_Werkmeister_WMDE, Alter-

[Wikidata-bugs] [Maniphest] [Updated] T257034: Turn LibHooks into HookHandler

2020-07-03 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T257034 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, gerritbot Cc: Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1t

[Wikidata-bugs] [Maniphest] [Commented On] T257034: Turn LibHooks into HookHandler

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609439 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Turn LibHooks into HookHandler https://gerrit.wikimedia.org/r/609439 TASK DETAIL https://phabricator.wikimedia.org/T257034 EMAIL PREFERE

[Wikidata-bugs] [Maniphest] [Claimed] T257034: Turn LibHooks into HookHandler

2020-07-03 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from Backlog to Doing on the Wikibase Extension Decoupling and Registration (Sprint 2) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T257034 WORKBOARD https://phabricator.wik

[Wikidata-bugs] [Maniphest] [Unassigned] T255885: Figure out what to do with uses of Repo classes in Lib and Client tests

2020-07-03 Thread Ladsgroup
Ladsgroup moved this task from Peer Review to Backlog on the Wikibase Extension Decoupling and Registration (Sprint 2) board. Ladsgroup removed Ladsgroup as the assignee of this task. Ladsgroup added a comment. Still we need to something about LuaWikibaseIntegrationTest TASK DETAIL https://

[Wikidata-bugs] [Maniphest] [Commented On] T255885: Figure out what to do with uses of Repo classes in Lib and Client tests

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609271 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Move SqlChangeStore from repo to lib https://gerrit.wikimedia.org/r/609271 TASK DETAIL https://phabricator.wikimedia.org/T255885 EMAIL PREFERENCES https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Closed] T254686: Rename WikibaseRepo’s idBlacklist setting

2020-07-03 Thread LucasWerkmeister
LucasWerkmeister closed this task as "Resolved". LucasWerkmeister claimed this task. LucasWerkmeister added a comment. We ended up merging this without any formal deprecation period or announcement. TASK DETAIL https://phabricator.wikimedia.org/T254686 EMAIL PREFERENCES https://phabricat

[Wikidata-bugs] [Maniphest] [Created] T257045: [Epic] Better understanding of WDQS users and use cases

2020-07-03 Thread Gehel
Gehel created this task. Gehel added projects: Wikidata-Query-Service, Epic. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION To better understand how WDQS can be improved (particularly in terms of scaling) we need a better

[Wikidata-bugs] [Maniphest] [Commented On] T256856: Create visualization for width breakpoints

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. @Sarai-WMDE https://wmde.github.io/wikit/?path=/docs/design-tokens-break-points--page TASK DETAIL https://phabricator.wikimedia.org/T256856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Akl

[Wikidata-bugs] [Maniphest] [Commented On] T256858: Create visalization for shadows

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. @Sarai-WMDE https://wmde.github.io/wikit/?path=/docs/design-tokens-shadows--page TASK DETAIL https://phabricator.wikimedia.org/T256858 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_WMDE, Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T256391: Evaluate Puppeteer in EntitySchema

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609425 had a related patch set uploaded (by AlQaholic007; owner: AlQaholic007): [mediawiki/extensions/EntitySchema@master] WIP Puppeteer: Schema Viewing Page doesn't touch whitespace https://gerrit.wikimedia.org/r/609425 TASK DETAIL https://phabrica

[Wikidata-bugs] [Maniphest] [Commented On] T254675: Rename WPBSkinBlacklist

2020-07-03 Thread Ammarpad
Ammarpad added a comment. Yes, the issue started here. The task description inverted the logic. > Rename WPBSkinBlacklist to WPBSkinEnabled > Rename isSkinBlacklisted to isSkinEnabled You should however retain the logic in the patch. That's isSkinDisabled() for the method and WPBSk

[Wikidata-bugs] [Maniphest] [Commented On] T256858: Create visalization for shadows

2020-07-03 Thread Tonina_Zhelyazkova_WMDE
Tonina_Zhelyazkova_WMDE added a comment. https://github.com/wmde/wikit/pull/48 TASK DETAIL https://phabricator.wikimedia.org/T256858 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_WMDE Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jako

[Wikidata-bugs] [Maniphest] [Commented On] T256854: Create visalization for Size/Dimension

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. https://github.com/wmde/wikit/pull/47 TASK DETAIL https://phabricator.wikimedia.org/T256854 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova

[Wikidata-bugs] [Maniphest] [Claimed] T256854: Create visalization for Size/Dimension

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T256854 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, darthmon_wmde, Nandana, Lahi, Gq

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. https://github.com/wmde/wikit/pull/46 TASK DETAIL https://phabricator.wikimedia.org/T256855 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova

[Wikidata-bugs] [Maniphest] [Commented On] T256859: Create visalization for transitions (duration, property)

2020-07-03 Thread Sarai-WMDE
Sarai-WMDE added a comment. Thanks, @Pablo-WMDE! It would be great to improve the glitching issues (shrinking of the central column if the 100ms value cell is hovered from the bottom, and the twitching of the divs if they are hovered from the right). F31915677: Jul-03-2020 14-31-59.gif

[Wikidata-bugs] [Maniphest] [Claimed] T256855: Create visalization for line height

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T256855 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, darthmon_wmde, Nandana, Lahi, Gq

[Wikidata-bugs] [Maniphest] [Commented On] T256856: Create visualization for width breakpoints

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. https://github.com/wmde/wikit/pull/45 TASK DETAIL https://phabricator.wikimedia.org/T256856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova

[Wikidata-bugs] [Maniphest] [Claimed] T256856: Create visualization for width breakpoints

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T256856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, darthmon_wmde, Nandana, Lahi, Gq

[Wikidata-bugs] [Maniphest] [Reassigned] T240328: Slow indexing for wbsearchentities

2020-07-03 Thread Gehel
Gehel reassigned this task from Fnielsen to dcausse. Gehel added a comment. @dcausse could you have another look into this? Looking at job queue stats , the rate of the various Cirrus jobs seems stable, but I'm n

[Wikidata-bugs] [Maniphest] [Commented On] T256859: Create visalization for transitions (duration, property)

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. @Sarai-WMDE https://wmde.github.io/wikit/?path=/docs/design-tokens-transition--page TASK DETAIL https://phabricator.wikimedia.org/T256859 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklap

[Wikidata-bugs] [Maniphest] [Updated] T257002: Internal error on Special:Contributions in Wikidata

2020-07-03 Thread daniel
daniel added a comment. might be related to T253289: Remove USE INDEX usertext_timestamp and other references from code TASK DETAIL https://phabricator.wikimedia.org/T257002 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/ema

[Wikidata-bugs] [Maniphest] [Commented On] T256861: Create visalization for cursors

2020-07-03 Thread Sarai-WMDE
Sarai-WMDE added a comment. I didn't notice the URL changing right away, but it makes total sense 😅 Linking is extremely useful and I like the evolutionary approach. I had in mind suggesting adding an `#` symbol after a given token on hover (basically like in the OOUI demo page) if Storyboo

[Wikidata-bugs] [Maniphest] [Claimed] T256858: Create visalization for shadows

2020-07-03 Thread Tonina_Zhelyazkova_WMDE
Tonina_Zhelyazkova_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T256858 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_WMDE Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, darthm

[Wikidata-bugs] [Maniphest] [Created] T257034: Turn LibHooks into HookHandler

2020-07-03 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase Extension Decoupling and Registration (Sprint 2). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Per ADR #13 ,

[Wikidata-bugs] [Maniphest] [Updated] T256259: Migrate Client ChangesListLinesHandler hooks to extension JSON

2020-07-03 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T256259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow, gerritbot Cc: Aklapper, ItamarWMDE, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, Hook

[Wikidata-bugs] [Maniphest] [Commented On] T256259: Migrate Client ChangesListLinesHandler hooks to extension JSON

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609408 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/Wikibase@master] Refactor ChangesLinesListHandler https://gerrit.wikimedia.org/r/609408 TASK DETAIL https://phabricator.wikimedia.org/T256259 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T256391: Evaluate Puppeteer in EntitySchema

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609407 had a related patch set uploaded (by AlQaholic007; owner: AlQaholic007): [mediawiki/extensions/EntitySchema@master] WIP Puppeteer: Special:Version has the EntitySchema extension enabled https://gerrit.wikimedia.org/r/609407 TASK DETAIL https:

[Wikidata-bugs] [Maniphest] [Unblock] T256228: Convert WikibaseClient to use extension registration

2020-07-03 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T256238: Remove WB_VERSION, WBL_VERSION, WBC_VERSION constants as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T256228 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklap

[Wikidata-bugs] [Maniphest] [Closed] T256238: Remove WB_VERSION, WBL_VERSION, WBC_VERSION constants

2020-07-03 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Verification to Done on the Wikibase Extension Decoupling and Registration (Sprint 2) board. TASK DETAIL https://phabricator.wikimedia.org/T256238 WORKBOARD https://phabricator.wikimedia.org/pr

[Wikidata-bugs] [Maniphest] [Commented On] T256391: Evaluate Puppeteer in EntitySchema

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609405 had a related patch set uploaded (by AlQaholic007; owner: AlQaholic007): [mediawiki/extensions/EntitySchema@master] WIP Puppeteer: A sample test https://gerrit.wikimedia.org/r/609405 TASK DETAIL https://phabricator.wikimedia.org/T256391 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T256391: Evaluate Puppeteer in EntitySchema

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 609401 had a related patch set uploaded (by AlQaholic007; owner: AlQaholic007): [mediawiki/extensions/EntitySchema@master] WIP Puppeteer: Setup screenshots and video recording https://gerrit.wikimedia.org/r/609401 TASK DETAIL https://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T124758: [Story] Show all available languages in monolingual text value's suggester

2020-07-03 Thread gerritbot
gerritbot added a comment. Change 425785 **abandoned** by Thiemo Kreuz (WMDE): [mediawiki/extensions/Wikibase@master] [WIP] Expose additional monolingual languages to LanguageSelector Reason: https://gerrit.wikimedia.org/r/425785 TASK DETAIL https://phabricator.wikimedia.org/T12

[Wikidata-bugs] [Maniphest] [Commented On] T254675: Rename WPBSkinBlacklist

2020-07-03 Thread Peter.ovchyn
Peter.ovchyn added a comment. @Jdlrobson I think the root of issue is in task description and naming. WPBSkinEnabled and isSkinEnabled is something totally opposite to WPBSkinBlacklist and isSkinBlacklisted. I'd rather offer to rename that to WPBSkinDisabled and isSkinDisabled? What do yo th

[Wikidata-bugs] [Maniphest] [Commented On] T256860: Create visalization for z-index (positioning)

2020-07-03 Thread Pablo-WMDE
Pablo-WMDE added a comment. @Sarai-WMDE https://wmde.github.io/wikit/?path=/docs/design-tokens-z-index--page TASK DETAIL https://phabricator.wikimedia.org/T256860 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklapper