Michael claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T207657EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Addshore, Lydia_Pintscher, Aklapper, Tarrow, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, Abbe98
Michael added a comment.
Turns out the wikitext for the comment from the summary is directly in the database as wikitext. Thus is seems not savely possible to fix the old entries.
Screenshots are from system recreating the problem:
F27096357: Screenshot_2018-11-07 phpmyadmin mw localhost 8080 db
Michael added a comment.
It seems this is only a problem with historic entries. New ones are fine-ish: https://test.wikidata.org/w/index.php?title=Lexeme:L42="">TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/ema
Michael claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T203457EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Lucas_Werkmeister_WMDE, Addshore, KaMan, Micru, Liuxinyu970226, Lydia_Pintscher, Lea_Lacroix_WMDE, Nandana, Mringgaard
Michael added a comment.
So, after a lot of investigation I can basely confirm what is stated in the original description by @Jakob_WMDE(?):
EntityParserOutputGenerator line 244 loads wikibase.ui.entityViewInit
ViewLexemeAction concurrently loads wikibase.lexeme.lexemeview
This is also
Michael removed Michael as the assignee of this task.
TASK DETAILhttps://phabricator.wikimedia.org/T204039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Michael, Addshore, Lucas_Werkmeister_WMDE, Tarrow, Jakob_WMDE, Nandana, Mringgaard, Lahi, Gq86
Michael claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T186006EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Ladsgroup, Liuxinyu970226, Lea_Lacroix_WMDE, Nikki, Pablo-WMDE, matej_suchanek, Lydia_Pintscher, Aklapper, Mike_Peel
Michael added a comment.
matmarex: No, it does not, or at least: not yet. Your approach covers the problem we had with Object.assign(), so I would expect that they complement each other for the time being.TASK DETAILhttps://phabricator.wikimedia.org/T207169EMAIL PREFERENCEShttps
Michael updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...[x] Any code in the repo ==> [#34](https://github.com/wmde/wikibase-docker-compose-generator/pull/34)
[] Any links to the repo from wikibase.org...TASK DETAILhttps://phabricator.wikimedia.org/T207657EM
Michael added a comment.
Wikibase.org is apparently up for sale?TASK DETAILhttps://phabricator.wikimedia.org/T207657EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: WMDE-leszek, Addshore, Lydia_Pintscher, Aklapper, Tarrow, Nandana, Lahi, Gq86
Michael added a comment.
Changed copy mentioning blubber in the code in https://github.com/wmde/wikibase-docker-compose-generator/pull/34
Did not touch the variable and class names, but added a note to future developers encouraging them to do so if they work on them anyway
TASK DETAILhttps
Michael updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...[x] Any code in the repo...TASK DETAILhttps://phabricator.wikimedia.org/T207657EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: WMDE-leszek, Addshore, Lydia_Pintscher
Michael added a comment.
So, the conclusion is that wmf will upstream the changes to their wikimedia config soonish. This is tracked by issue #113 on GitHub. Once this patch has landed and is released we bump the version and should be done. There will be another phabricator ticket for this version
Michael added a comment.
There are apparently two options: eslint-plugin-ie11 and eslint-plugin-compat
However, eslint-plugin-ie11 seems to have only 4 rules and they don't cover the issue with Object.assign(). Also it seems to be rarely used and the last release was a year ago.
On the other hand
Michael added a comment.
I looked into this further. While eslint-plugin-compat is straightforward to integrate, it doesn't pick up the Object.assign() error, either. This is a known issue: #89 on GitHub.
Adding this plugin to our eslint setup might make sense nonetheless?TASK DETAILhttps
Michael added a comment.
Wikiba.se doesn't seem to mention Blubber or this tool at all. However, it might be useful to add it to the "community tools" section on the libraries subpage.TASK DETAILhttps://phabricator.wikimedia.org/T207657EMAIL PREFERENCEShttps://phabricator.wikimedia.or
Michael added a comment.
wikibase-docker doesn't seen to contain any reference to this repo.TASK DETAILhttps://phabricator.wikimedia.org/T207657EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: WMDE-leszek, Addshore, Lydia_Pintscher, Aklapper, Tarrow
Michael claimed this task.Michael updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONRelates T206644 and T206643Investigate with eslint plugins are available to check browser compatibility for IE 11. (Timeboxed to 2 hours)
If there is a clear winner, add it to eslint
Michael updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...[x] Any links from the wikibase-docker code/readme...TASK DETAILhttps://phabricator.wikimedia.org/T207657EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: WMDE-leszek
Michael claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden
Michael added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).
TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, Nandana
Michael claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T208918EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Lucas_Werkmeister_WMDE, Aklapper, Krinkle, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10
Michael claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T204039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Addshore, Lucas_Werkmeister_WMDE, Tarrow, Jakob_WMDE, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden
Michael added a comment.
ContemporaryChecker had the only call for \Wikibase\DataModel\Services\Lookup\EntityLookup::getEntity that wasn't guarded against a null result.TASK DETAILhttps://phabricator.wikimedia.org/T208918EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
Michael added a comment.
Results of the investigation so far:
The relevant pattern is in WikibaseLexeme/src/Domain/Model/FormId.php:
const PATTERN = '/^L[1-9]\d*-F[1-9]\d*\z/';
However, simply removing the first part of the pattern breaks \Wikibase\Lexeme\Domain\Model\LexemeSubEntityId
Michael claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T206164EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Tarrow, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden
Michael claimed this task.Restricted Application added a project: User-Michael.
TASK DETAILhttps://phabricator.wikimedia.org/T206416EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Addshore, Zoranzoki21, matej_suchanek, Nandana, Mringgaard, Lahi
Michael added a comment.
Just looked into this. That change is actually covered by qunit unittests. So I would assume that this change should be fine 樂TASK DETAILhttps://phabricator.wikimedia.org/T213975EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
Michael added a comment.
I guess only one of the changes, either 479194 or 479240, should move forward. Both seem to resolve the issue.TASK DETAILhttps://phabricator.wikimedia.org/T208924EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: gerritbot
Michael added a comment.
Now the change is live (see Q39259) and we can disable the workaround :)TASK DETAILhttps://phabricator.wikimedia.org/T186006EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: gerritbot, Ladsgroup, Lea_Lacroix_WMDE, Nikki
Michael claimed this task.Restricted Application added a project: User-Michael.
TASK DETAILhttps://phabricator.wikimedia.org/T29EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: WMDE-leszek, Aklapper, abian, Addshore, Nandana, Lahi, Gq86
Michael updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... [] TBAwbcreateclaim
[] wbcreateredirect
[] wbeditentity
[] TBCTASK DETAILhttps://phabricator.wikimedia.org/T29EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc
Michael created this task.Michael added projects: Wikidata-Campsite, Accessibility, User-Michael.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONThe thing that looks like a link, behaves like a button and is a that toggles
Michael added a comment.
@Lucas_Werkmeister_WMDE Interestingly, and independently from today's deployment, https://www.wikidata.org/wiki/Special:ConstraintReport/Q41 is broken o.OTASK DETAILhttps://phabricator.wikimedia.org/T209504EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
Michael updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...[x] wblinktitles...[x] wbladdform
[x] wbladdsense
[x] wbleditformelements
[x] wbleditsenseelements
[x] wblmergelexemes
[x] wblremoveform
[x] wblremovesense
TASK DETAILhttps://phabricator.wikimedia.org/T29EMAIL
Michael claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Aklapper, Michael, Nandana, Mh-3110, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, enigmaeth, rohitt
Michael removed Michael as the assignee of this task.Michael removed projects: Patch-For-Review, User-Michael.
TASK DETAILhttps://phabricator.wikimedia.org/T207749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Michael, rafidaslam, Lydia_Pintscher
Michael claimed this task.Restricted Application added a project: User-Michael.
TASK DETAILhttps://phabricator.wikimedia.org/T208924EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Anomie, Aklapper, Krinkle, revi, Nandana, Lahi, Gq86
Michael created this task.Michael added a project: Wikidata-Campsite.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONFor better or worse, External IDs constitute a large portion of the references used in Wikidata. We should have
Michael created this task.Michael added a project: Wikidata-Campsite.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONCurrently, we have a graph listing the number of reference snaks linking to wikimedia wikis in relation
Michael updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...{F27494840}
This ticket was created when working on T209399.TASK DETAILhttps://phabricator.wikimedia.org/T211681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc
Michael renamed this task from "Create Dashboard for External ID reference snaks" to "Create graph for External ID reference snaks".
TASK DETAILhttps://phabricator.wikimedia.org/T211678EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Michael added a subscriber: Addshore.Michael added a comment.
This is somewhat stalled until I'm (auto-)confirmed on meta.wikimedia.org. However, @Lydia_Pintscher already created the page for the new schema: https://meta.wikimedia.org/wiki/Schema:WikibaseTermboxInteraction and I will add
Michael created this task.Michael added a project: Wikidata-Campsite.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONWhen working on T29, I noticed that the API checks the validity of requests before it checks whether
Michael updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...[x] wbcreateclaim
[x] wbcreateredirect
[x] wbeditentity
[x] wbmergeitems
[x] wbremoveclaims
[x] wbremovequalifiers
[x] wbremovereferences
[x] wbsetaliases
[x] wbsetclaim
[x] wbsetclaimvalue
[x] wbsetdescription
[x
Michael added a parent task: T40968: Keyboard-navigability of the repo UI.
TASK DETAILhttps://phabricator.wikimedia.org/T211751EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Aklapper, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden
Michael added a subtask: T211751: Div to toggle termbox is unreachable with keyboard.
TASK DETAILhttps://phabricator.wikimedia.org/T40968EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Envlh, Charlie_WMDE, PokestarFan, Jan_Dittrich, Aklapper
Michael updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...[x] wbeditentity
[] wblinktitles
[x] wbmergeitems...[] wbleditsenseelements
[] wblinktitles
[] wblmergelexemes...TASK DETAILhttps://phabricator.wikimedia.org/T29EMAIL PREFERENCEShttps://phabricator.wikimedia.org
Michael updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONPart of T211038 but for the API modules
Api modules:**Wikibase api modules:**
[] wbcreateclaim
[] wbcreateredirect
[] wbeditentity
[] wbmergeitems
[] wbremoveclaims
[] wbremovequalifiers
[] wbremovereferences
Michael added a comment.
In T209504#4821248, @Lucas_Werkmeister_WMDE wrote:
New tracking has been deployed and added to Grafana (“PHP Type Check Entities” panel), so we should be able to see how much these numbers move up when we bump the limit.
I see now that this gives us only
Michael added a comment.
In T209504#4823419, @Lucas_Werkmeister_WMDE wrote:
However, what would be much more useful to know, would be the distribution of checks that exceeded that limit and were handled by SPARQL.
Well, that’s the “Type Check Runtimes” and “Type Check Distribution” panels… which
Michael added a comment.
@Greta_Doci_WMDE @Lydia_Pintscher
This is an example where long language names are already breaking the layout: https://www.wikidata.org/wiki/Lexeme:L3338#S1
Setting the width to 100px and removing max-width and min-width as mentioned above, fixes that problem
Michael changed the task status from "Open" to "Stalled".
TASK DETAILhttps://phabricator.wikimedia.org/T211015EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Addshore, gerritbot, Lydia_Pintscher, D3r1ck01, Aklapper, WMDE-leszek
Michael added a project: User-Michael.
TASK DETAILhttps://phabricator.wikimedia.org/T212282EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Addshore, Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic
Michael added a comment.
In T212282#4834025, @Addshore wrote:
[...]
But I also see:
2018-12-19T12:32:49 mw1252 WARNING Full constraint check on Q142 took longer than 55 second(s) (duration: 56.151183128357 seconds).
[...]
Are we logging this anywhere? Maybe the time these constraints checks
Michael added a comment.
In T209399#4824419, @Lucas_Werkmeister_WMDE wrote:
Do we need to do anything to get this change deployed or does it happen automatically?
Yes, we might need to build it and push it to another repo. The description says:
Description of T209399
As well as updating
Michael added a comment.
Yes, I think the next step should be deciding/defining the expected behavior in these situations. Does this API have documentation from which we could infer the expected behavior? Without knowing the use-cases and tools, having two type definitions in the request seems
Michael added a comment.
What is Needed to make MultipleRepositoryAwareWikibaseServices use an API?
Case Study: PropertyInfoLookup
Interface: \Wikibase\Lib\Store\PropertyInfoLookup
3 relevant implementations:
CachingPropertyInfoLookup
DispatchingPropertyInfoLookup
PropertyInfoTable
Only
Michael added a comment.
TASK DETAILhttps://phabricator.wikimedia.org/T186006EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: gerritbot, Ladsgroup, Lea_Lacroix_WMDE, Nikki, Pablo-WMDE, Lydia_Pintscher, Aklapper, Mike_Peel, Dinadineke, Nandana
Michael claimed this task.Restricted Application added a project: User-Michael.
TASK DETAILhttps://phabricator.wikimedia.org/T207749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: rafidaslam, Lydia_Pintscher, gerritbot, Aklapper, abian, Dinadineke
Michael added a comment.
In T209880#4800645, @Lucas_Werkmeister_WMDE wrote:
[...] Or is this a blacklist/whitelist on the target repo, so that e. g. Wikidata would refuse to be a foreign repo for Metapedia?
Yes, that was the usage I thought of. How do we handle badly configured instances
Michael added a comment.
Currently, we would only query one federated instance, because any entity type can only be provided by a single repository (the local one or a federated one). That will change in the future, but even then, I don’t think many installs will have more than two or three repos
Michael claimed this task.Restricted Application added a project: User-Michael.
TASK DETAILhttps://phabricator.wikimedia.org/T211015EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Lydia_Pintscher, D3r1ck01, Aklapper, WMDE-leszek, Lea_WMDE, Nandana
Michael claimed this task.Restricted Application added a project: User-Michael.
TASK DETAILhttps://phabricator.wikimedia.org/T210929EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Aklapper, Lucas_Werkmeister_WMDE, Michael, Daimona, Nandana
Michael claimed this task.Restricted Application added a project: User-Michael.
TASK DETAILhttps://phabricator.wikimedia.org/T179263EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Lucas_Werkmeister_WMDE, Olaf_Simons, gerritbot, Aklapper, Jonas
Michael added a comment.
I created the patch counting the clicks as described above. But I think, I need a more detailed introduction/tutorial or some pairing for working with graphite and selecting the correct metrics from Hadoop as stated in the description.TASK DETAILhttps
Michael added a comment.
Hey @Lea_Lacroix_WMDE,
that looks still like the workaround put in place by @Ladsgroup . When deployed, the references on protected pages should fold like on every other page as well. It doesn't look like this change is on the production or even test instance yet.TASK
Michael added a comment.
In T186006#4810230, @Lea_Lacroix_WMDE wrote:
Fancy \o/
Any idea when it's going to be deployed?
As I understand the tag on this task, the patch should be part of 1.33.0-wmf.8 and that should be live on all wikis on Thursday: https://phabricator.wikimedia.org/T206662
Michael added a comment.
In T186006#4810272, @Ladsgroup wrote:
Wikidata is in group1, meaning this will be live on Wednesday noonish if everything goes as expected. See https://wikitech.wikimedia.org/wiki/Deployments
Even better :)TASK DETAILhttps://phabricator.wikimedia.org/T186006EMAIL
Michael added a comment.
@Lucas_Werkmeister_WMDE
Good idea. Number of entities processed might be interesting. But also how the number of constraint checks per checked entity is distributed. Maybe we can calculate/track how some key aspects of the distribution change, e.g. median, third quartile
Michael added a comment.
TASK DETAILhttps://phabricator.wikimedia.org/T209504EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, MichaelCc: Stashbot, Agabi10, gerritbot, Michael, Lucas_Werkmeister_WMDE, Aklapper, CucyNoiD, Nandana
Michael added a comment.
It would be helpful to have a plot showing the distribution of the number of checks per request. Either as normal histogram or as CDF. Maybe a 3D plot to show this over time?TASK DETAILhttps://phabricator.wikimedia.org/T209504EMAIL PREFERENCEShttps
Michael claimed this task.Restricted Application added a project: User-Michael.
TASK DETAILhttps://phabricator.wikimedia.org/T209504EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Michael, Lucas_Werkmeister_WMDE, Aklapper, Nandana, Lahi, Gq86
Michael added a comment.
Side-note: I noticed that the language code and the gloss value are not perfectly vertically aligned. The gloss value has some vertical 1px padding that the language code is missing and that causes the slight misalignment.TASK DETAILhttps://phabricator.wikimedia.org
Michael added a comment.
This seems to be deployed to beta: https://wikidata.beta.wmflabs.org/wiki/Q503104
But not yet on test: https://test.wikidata.org/wiki/Q120085
Hence, I would assume that it is not live either. (check: https://www.wikidata.org/wiki/Q39259 )TASK DETAILhttps
Michael added a comment.
This is a problem with table layouting in IE11, Edge and some older Chrome versions.
From some preliminary testing on IE 11, it seems like adding an explicit width attribute to the first table cell (i.e. .wikibase-lexeme-sense-gloss-language) resolves that problem. However
Michael claimed this task.Restricted Application added a project: User-Michael.
TASK DETAILhttps://phabricator.wikimedia.org/T209880EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Lucas_Werkmeister_WMDE, WMDE-leszek, _jensen, johl, Aklapper
Michael claimed this task.Restricted Application added a project: User-Michael.
TASK DETAILhttps://phabricator.wikimedia.org/T207401EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Greta_Doci_WMDE, Michael, Lydia_Pintscher, Ladsgroup, Nikki, Nandana
Michael added a comment.
In T209368#4781099, @Lucas_Werkmeister_WMDE wrote:
[...] there are more data types than data value types. [...]
When do we need the "data value type"? Are there data types that could reasonably have multiple data value types?TASK DETAILhttps://phabricator.wik
Michael claimed this task.Restricted Application added a project: User-Michael.
TASK DETAILhttps://phabricator.wikimedia.org/T209932EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Jdforrester-WMF, Aklapper, Michael, Nandana, Mh-3110, Lahi, Gq86
Michael added a comment.
No, the config change should not be harmful, it might just no be as effective as "double the limit" might seem. This would be possible to tell from the distribution. But we should be able to deploy the change now and see whether it brings us from ~70% to ~80%
Michael created this task.Michael added projects: User-Michael, Wikidata-Campsite.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONWhen we updated the upstream wikimedia eslint config in T209932, we deactivated a lot of rules
Michael updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...**Acceptance criteria:**
- [ - [x] Wikibase extends `mediawiki/client`
- [x] WikibaseLexeme extends `mediawiki/client`
- [ - [x] WikibaseLexemeQualityConstraints extends `mediawiki/client`
- [ - [x
Michael added a comment.
The new release of the wikimedia config also disallows a number of jQuery methods. I didn't implement these changes in this ticket, but created T210744 to discuss and estimate them. This only affects Wikibase and WikibaseLexeme.TASK DETAILhttps://phabricator.wikimedia.org
Michael added projects: Technical-Debt, _javascript_.
TASK DETAILhttps://phabricator.wikimedia.org/T210744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Aklapper, Michael, Nandana, Mh-3110, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden
Michael added a comment.
Also a noticed that today a new version of wikimedia stylelint was released. Do we want to pull that version as well in a new ticket?TASK DETAILhttps://phabricator.wikimedia.org/T209932EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
Michael added a comment.Restricted Application added a project: User-Michael.
I discussed this with @Lucas_Werkmeister_WMDE and we came up with some open questions:
Currently the queries for the Wikimedias and the reference properties are the following:
wikimedias: https://query.wikidata.org
Michael created this task.Michael added projects: Wikidata, Wikidata-Campsite.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONThe IDs of senses are wrapping around after the -. The IDs of forms don't and that looks better:
F27318545: Screenshot_2018-11-27 Pluto.png
Screenshot
Michael added a comment.
Because it is somehow not added here by Gerrit:
The patch :
https://gerrit.wikimedia.org/r/c/analytics/wmde/toolkit-analyzer/+/475807TASK DETAILhttps://phabricator.wikimedia.org/T209399EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
Michael added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T209399EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Nikki, Addshore, Lucas_Werkmeister_WMDE, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo
Michael claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T209399EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Nikki, Addshore, Lucas_Werkmeister_WMDE, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen
Michael added a comment.
NB: apparently there are regressions both in the current openjdk release and the current surefire release that cause the following error message during the testing step in mvn package:
Error: Could not find or load main class org.apache.maven.surefire.booter.ForkedBooter
Michael updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONIn T207169 we added eslint-plugin-compat to our eslint config, but that didn't catch all IE11 incompatibilities. We also discovered that wikimedia was in the process of updating their eslint configuration to ensure
Michael added a subscriber: Lydia_Pintscher.Michael added a comment.
The upstream issue has been resolved, so we could now adjust our own eslint json. See https://github.com/wikimedia/eslint-config-wikimedia/issues/113
@Addshore @Lydia_PintscherTASK DETAILhttps://phabricator.wikimedia.org
Michael added a project: _javascript_.Michael updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONIn T207169 we added eslint-plugin-compat to our eslint config, but that didn't catch all IE11 incompatibilities. We also discovered that wikimedia was in the process of updating
Michael created this task.Michael added a project: Wikidata-Campsite.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONIn T207169 we added eslint-plugin-compat to our eslint config, but that didn't catch all IE11 incompatibilities
Michael moved this task from Ready to go to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.Michael edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T209922WORKBOARDhttps
Michael moved this task from Ready to go to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.Michael edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T209820WORKBOARDhttps
Michael moved this task from Ready to go to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.Michael edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T209931WORKBOARDhttps
Michael moved this task from Ready to go to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.Michael edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T199611WORKBOARDhttps
1 - 100 of 3519 matches
Mail list logo
