[Wikidata-bugs] [Maniphest] [Created] T237536: Wire up Permission Error Component in Error Component

2019-11-06 Thread Michael
Michael created this task. Michael added projects: Wikidata-Bridge, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - (This includes browser testing) TASK DETAIL https://phabricator.wikimedia.org/T237536 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Triaged] T232577: Wikidata Bridge random browser test failure “Errors-Init-Value-Switch shows the current targetValue” (Failed to wait for wikibase.client.data-bridge.app

2019-11-06 Thread Michael
Michael moved this task from tech things to Task overflow on the Wikidata-Bridge board. Michael triaged this task as "Normal" priority. Michael added a comment. Thank you for the links! I made Jenkins remember this log (thanks @Lucas_Werkmeister_WMDE for showing me how), and I'

[Wikidata-bugs] [Maniphest] [Claimed] T237023: Create references (section) component

2019-11-11 Thread Michael
Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-8 board. Michael claimed this task. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T237023 WORKBOARD https://phabricator.wikimedia.org/project/board/4341/ EMAIL

[Wikidata-bugs] [Maniphest] [Claimed] T237368: Track bridge opening performance

2019-11-15 Thread Michael
Michael claimed this task. Michael edited projects, added Wikidata-Bridge-Sprint-9, User-Michael; removed Wikidata-Bridge. TASK DETAIL https://phabricator.wikimedia.org/T237368 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Addshore

[Wikidata-bugs] [Maniphest] [Created] T238496: Links to edit Senses and Forms can't be reached with the keyboard

2019-11-17 Thread Michael
Michael created this task. Michael added projects: Accessibility, Wikidata, Lexicographical data. TASK DESCRIPTION The edit links for senses and form are not reachable by tabbing with the keyboard. See for example: https://wikidata.beta.wmflabs.org/wiki/Lexeme:L1 TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Created] T238533: Proper aria attributes when opening the bridge

2019-11-18 Thread Michael
Michael created this task. Michael added projects: Wikidata-Bridge, Accessibility, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION When a modal or dialog is opened, we need to tell screen readers about that. See: https://www.w3.org/TR/wai-aria-practices

[Wikidata-bugs] [Maniphest] [Claimed] T234060: Exhibit native behavior on key+click on bridge link

2019-11-18 Thread Michael
Michael claimed this task. Michael edited projects, added Wikidata-Bridge-Sprint-9; removed Wikidata-Bridge. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T234060 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Claimed] T237523: Create Interface for Service about user being allowed to edit entity

2019-11-18 Thread Michael
Michael claimed this task. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T237523 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Addshore, Aklapper, Michael, darthmon_wmde, DannyS712

[Wikidata-bugs] [Maniphest] [Claimed] T237524: Create Error vector in store root layer and enum of possible error reasons

2019-11-19 Thread Michael
Michael claimed this task. Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-9 board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T237524 WORKBOARD https://phabricator.wikimedia.org/project/board/4371/ EMAIL

[Wikidata-bugs] [Maniphest] [Unassigned] T237368: Track bridge opening performance

2019-11-20 Thread Michael
Michael removed Michael as the assignee of this task. Michael moved this task from Peer Review to To do on the Wikidata-Bridge-Sprint-10 board. Michael added a comment. Left todo: create the dashboards in grafana TASK DETAIL https://phabricator.wikimedia.org/T237368 WORKBOARD https

[Wikidata-bugs] [Maniphest] [Created] T238828: Show intended blockee in blocked message in wikidata bridge

2019-11-21 Thread Michael
Michael created this task. Michael added projects: Wikidata-Bridge, MediaWiki-User-management. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION As a user that finds themselves blocked, I want to know who is the intended

[Wikidata-bugs] [Maniphest] [Updated] T235154: show error when editor can't edit the statement because of permission errors on the repository

2019-11-21 Thread Michael
Michael added a comment. We discussed that the investigation (T237522 <https://phabricator.wikimedia.org/T237522>) uncovered that we currently cannot get the intended blockee from the mediawiki API. We decided that for now, we drop that requirement, i.e. that bullet point in the

[Wikidata-bugs] [Maniphest] [Updated] T238828: Show intended blockee in blocked message in wikidata bridge

2019-11-21 Thread Michael
Michael added a subtask: T58227: Provide original user name as "intended blockee" in case of autoblock. TASK DETAIL https://phabricator.wikimedia.org/T238828 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklappe

[Wikidata-bugs] [Maniphest] [Created] T238850: Enable other mediawiki extensions to add their own vue components for datatypes

2019-11-21 Thread Michael
Michael created this task. Michael added a project: Wikidata-Bridge. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Other extensions can add their own datatypes, like score, math or Lexeme. To be able to display or edit

[Wikidata-bugs] [Maniphest] [Created] T238910: MwTimeIsoParser.php: PHP Warning: preg_match(): Unknown modifier 'p'

2019-11-22 Thread Michael
Michael created this task. Michael added projects: Wikimedia-production-error, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Error - `MediaWiki version:` **`1.35.0-wmf.5`** name

[Wikidata-bugs] [Maniphest] [Claimed] T237527: Add notice component

2019-11-26 Thread Michael
Michael claimed this task. Michael added a subscriber: Matthias_Geisler_WMDE. Michael added a comment. Restricted Application added a project: User-Michael. In T237527#5693170 <https://phabricator.wikimedia.org/T237527#5693170>, @Lucas_Werkmeister_WMDE wrote: > Actually, let’s

[Wikidata-bugs] [Maniphest] [Unassigned] T237527: Add notice component

2019-11-26 Thread Michael
Michael removed Michael as the assignee of this task. Michael added a comment. In T237527#5693196 <https://phabricator.wikimedia.org/T237527#5693196>, @Michael wrote: > In T237527#5693170 <https://phabricator.wikimedia.org/T237527#5693170>, @Lucas_Werkmei

[Wikidata-bugs] [Maniphest] [Updated] T239267: Remove patch-move-page-namespace.sql from EntitySchema

2019-11-27 Thread Michael
Michael added a comment. Yes, that file was created in context of T213726: Register Schema: namespace <https://phabricator.wikimedia.org/T213726>. I don't think it is needed anymore. TASK DETAIL https://phabricator.wikimedia.org/T239267 EMAIL PREFEREN

[Wikidata-bugs] [Maniphest] [Commented On] T237527: Add notice component

2019-11-28 Thread Michael
Michael added a comment. @Charlie_WMDE @Sarai-WMDE: We adjusted the global styles of the Storybook so that it should be by default closer to the OOUI Demo page. Could you verify this component again? TASK DETAIL https://phabricator.wikimedia.org/T237527 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T238662: make edit based on fix/update choice

2019-11-28 Thread Michael
Michael added a comment. > We likely want to do the update flow in two edits to have useful edit summaries. Note: Then we cannot ensure that both edits succeed, which could leave the item in an incorrect state. TASK DETAIL https://phabricator.wikimedia.org/T238662 EMAIL PREFEREN

[Wikidata-bugs] [Maniphest] [Closed] T237513: implement loading bar timing in App

2019-11-29 Thread Michael
Michael moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-10 board. Michael closed this task as "Resolved". Michael added a comment. Storybook has been updated: https://tools-static.wmflabs.org/wikibase-databridge-storybook/?path=/story/initializing--default T

[Wikidata-bugs] [Maniphest] [Unblock] T232468: Illustrate loading

2019-11-29 Thread Michael
Michael closed subtask T237513: implement loading bar timing in App as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T232468 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Michael, Lydia_Pintscher, Charlie_WMDE

[Wikidata-bugs] [Maniphest] [Claimed] T249118: Implement the "reload" functionality

2020-04-01 Thread Michael
Michael claimed this task. Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-17 board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T249118 WORKBOARD https://phabricator.wikimedia.org/project/board/4663/ EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T249120: Add tracking of errors

2020-04-02 Thread Michael
Michael added a comment. In T249120#6022064 <https://phabricator.wikimedia.org/T249120#6022064>, @Lucas_Werkmeister_WMDE wrote: > I looked a bit more into the possible error types we have which don’t have more specific handlers, and I think

[Wikidata-bugs] [Maniphest] [Commented On] T249120: Add tracking of errors

2020-04-02 Thread Michael
Michael added a comment. In T249120#6022564 <https://phabricator.wikimedia.org/T249120#6022564>, @Lucas_Werkmeister_WMDE wrote: > But we aren’t throwing any actual `Error` objects. At the point where this task is supposed to happen – in `ErrorUnknown` – what we have is

[Wikidata-bugs] [Maniphest] [Commented On] T249120: Add tracking of errors

2020-04-02 Thread Michael
Michael added a comment. In T249120#6022743 <https://phabricator.wikimedia.org/T249120#6022743>, @Lucas_Werkmeister_WMDE wrote: > Well, it sounds to me like you’re asking for a complete overhaul of our error handling, and I didn’t really sign up for that… > I’ll upload wha

[Wikidata-bugs] [Maniphest] [Unassigned] T249118: Implement the "reload" functionality

2020-04-02 Thread Michael
Michael removed Michael as the assignee of this task. Michael removed a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T249118 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Michael, Aklapper, Pablo-WMDE, Oblanco79

[Wikidata-bugs] [Maniphest] [Commented On] T249120: Add tracking of errors

2020-04-02 Thread Michael
Michael added a comment. In T249120#6022937 <https://phabricator.wikimedia.org/T249120#6022937>, @Lucas_Werkmeister_WMDE wrote: > I also wonder if we shouldn’t maybe track all the error types in Graphite, not just the ones that end up in `ErrorUnknown` but also the ones that ha

[Wikidata-bugs] [Maniphest] [Claimed] T249122: Configure link to issue tracker

2020-04-02 Thread Michael
Michael claimed this task. Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-17 board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T249122 WORKBOARD https://phabricator.wikimedia.org/project/board/4663/ EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T249120: Add tracking of errors

2020-04-07 Thread Michael
Michael added a comment. Thanks @Pablo-WMDE for chiming in. It seems I have misunderstood the purpose of why we are adding this tracking to the generic error handler. Could you elaborate on the value that we are expecting from adding this tracking as described in //this task//? TASK DETAIL

[Wikidata-bugs] [Maniphest] [Claimed] T249713: Extract header out of App

2020-04-09 Thread Michael
Michael claimed this task. Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-18 board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T249713 WORKBOARD https://phabricator.wikimedia.org/project/board/4726/ EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T250181: test.wikidata.org - term store not updating

2020-04-14 Thread Michael
Michael added a comment. This may be due to a problem with "old"(?) cookies in Firefox. These are the ones with which the problem occurs. A Chromium browser opened in parallel shows the correct page { "GeoIP": "DE:BE:Berlin:52.50:13.37:v4",

[Wikidata-bugs] [Maniphest] [Commented On] T250181: test.wikidata.org - term store not updating

2020-04-16 Thread Michael
Michael added a comment. In T250181#6059323 <https://phabricator.wikimedia.org/T250181#6059323>, @Pablo-WMDE wrote: > I'm observing a behavior I perceive as intuitive for https://test.wikidata.org/w/index.php?title=Q187712&action=history > @Michael Agree? Yes

[Wikidata-bugs] [Maniphest] [Commented On] T249713: Extract header out of App

2020-04-22 Thread Michael
Michael added a comment. In T249713#6075931 <https://phabricator.wikimedia.org/T249713#6075931>, @Lucas_Werkmeister_WMDE wrote: > Anything left to do? > >> It’s not decided yet whether that component will directly use `ProcessDialogHeader`, or whether it will sw

[Wikidata-bugs] [Maniphest] [Claimed] T249715: Add capability to provoke generic save error to browser tests

2020-04-22 Thread Michael
Michael claimed this task. Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-18 board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T249715 WORKBOARD https://phabricator.wikimedia.org/project/board/4726/ EMAIL

[Wikidata-bugs] [Maniphest] [Changed Project Column] T249715: Add capability to provoke generic save error to browser tests

2020-04-22 Thread Michael
Michael moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-18 board. Michael added a comment. It turns out that webdriver+chrome can do this natively with: browser.setNetworkConditions( { latency: 0, throughput: 0, offline: true } ) See https://webdriver.io

[Wikidata-bugs] [Maniphest] [Claimed] T249718: Add more error information to store

2020-04-22 Thread Michael
Michael claimed this task. Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-18 board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T249718 WORKBOARD https://phabricator.wikimedia.org/project/board/4726/ EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T249715: Add capability to provoke generic save error to browser tests

2020-04-23 Thread Michael
Michael added a comment. In T249715#6079408 <https://phabricator.wikimedia.org/T249715#6079408>, @Pablo-WMDE wrote: > Hmm, I see a `canSave.js` patch landed. Was about to add such a test to the (new) errorHandling test, using network outage as the reason for the initial loadin

[Wikidata-bugs] [Maniphest] [Commented On] T249717: Wire up generic save error component in ErrorWrapper

2020-04-23 Thread Michael
Michael added a comment. In T249717#6079266 <https://phabricator.wikimedia.org/T249717#6079266>, @Lucas_Werkmeister_WMDE wrote: > The implementation for this might be interesting, I think. Currently, `ErrorWrapper` has a lot of getters in its own class, for processing the

[Wikidata-bugs] [Maniphest] [Updated] T203461: Have the focus on field when adding new element on Sense

2020-04-24 Thread Michael
Michael added a project: Accessibility. TASK DETAIL https://phabricator.wikimedia.org/T203461 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Michael Cc: Michael, Lucas_Werkmeister_WMDE, KaMan, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] [Closed] T249718: Add more error information to store

2020-04-27 Thread Michael
Michael moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-18 board. Michael closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T249718 WORKBOARD https://phabricator.wikimedia.org/project/board/4726/ EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] [Unblock] T248087: Step 1: Improved generic error screen: on save (impact: high)

2020-04-27 Thread Michael
Michael closed subtask T249718: Add more error information to store as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T248087 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Masumrezarock100, Aklapper,

[Wikidata-bugs] [Maniphest] [Claimed] T249719: Add “back” button to header when appropriate

2020-04-28 Thread Michael
Michael claimed this task. Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-18 board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T249719 WORKBOARD https://phabricator.wikimedia.org/project/board/4726/ EMAIL

[Wikidata-bugs] [Maniphest] [Claimed] T249720: Make “go back” buttons go back in the app

2020-04-28 Thread Michael
Michael claimed this task. Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-18 board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T249720 WORKBOARD https://phabricator.wikimedia.org/project/board/4726/ EMAIL

[Wikidata-bugs] [Maniphest] [Created] T251385: Modify ApiWritingRepository to allow for not asserting user

2020-04-29 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata-Bridge-Sprint-19. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Allow the store to tell the ApiWritingRepository that it should not assert the user. TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T246117: Visual fixes

2020-05-06 Thread Michael
Michael added a comment. > (its size is dependent of the label line-height. Maybe we could use the css 'lh' unit here to achieve that!) The `lh` unit is going to be pretty awesome! Unfortunately, it is still very experimental and not yet supported by browsers: https://cani

[Wikidata-bugs] [Maniphest] [Claimed] T251390: Teach store to recognize “assertuser failed” error type(s?)

2020-05-06 Thread Michael
Michael claimed this task. Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-19 board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T251390 WORKBOARD https://phabricator.wikimedia.org/project/board/4757/ EMAIL

[Wikidata-bugs] [Maniphest] [Claimed] T251393: Implement anonymous saving in store

2020-05-11 Thread Michael
Michael claimed this task. Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-19 board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T251393 WORKBOARD https://phabricator.wikimedia.org/project/board/4757/ EMAIL

[Wikidata-bugs] [Maniphest] [Claimed] T251396: Wire up "go back" button in header (mobile)

2020-05-11 Thread Michael
Michael claimed this task. Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-19 board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T251396 WORKBOARD https://phabricator.wikimedia.org/project/board/4757/ EMAIL

[Wikidata-bugs] [Maniphest] [Claimed] T252499: Purge page as soon as edit conflict is detected

2020-05-14 Thread Michael
Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-20 board. Michael claimed this task. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T252499 WORKBOARD https://phabricator.wikimedia.org/project/board/4778/ EMAIL

[Wikidata-bugs] [Maniphest] [Claimed] T252683: Track errors people encounter when using the Bridge

2020-05-18 Thread Michael
Michael claimed this task. Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-20 board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T252683 WORKBOARD https://phabricator.wikimedia.org/project/board/4778/ EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T252683: Track errors people encounter when using the Bridge

2020-05-20 Thread Michael
Michael added a comment. In T252683#6152427 <https://phabricator.wikimedia.org/T252683#6152427>, @Lucas_Werkmeister_WMDE wrote: > Changes are merged, I guess we still need to actually create the graph? I just did :) https://grafana-labs.wikimedia.org/d/00020/wik

[Wikidata-bugs] [Maniphest] [Updated] T248840: Don’t polyfill Promise in Bridge modules

2020-05-25 Thread Michael
Michael edited projects, added Technical Improvements; removed Wikidata-Bridge. Michael added a comment. @Lucas_Werkmeister_WMDE and I looked into this today and encountered some problems with getting this to work. While it is correct that the promise polyfill is included by default (vuejs

[Wikidata-bugs] [Maniphest] [Updated] T253966: sonar cloud + .vue files: 'import' and 'export' may appear only with 'sourceType: module'

2020-05-29 Thread Michael
Michael added a project: Code-Health. TASK DETAIL https://phabricator.wikimedia.org/T253966 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Pablo-WMDE, Demian, darthmon_wmde, Michael, Nandana, kostajh, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

2020-06-11 Thread Michael
Michael added a comment. In T249598#6074491 <https://phabricator.wikimedia.org/T249598#6074491>, @daniel wrote: > So, can we close this? The original core test still throws errors that seem related to Wikibase, but, OTOH, it is currently 1555 commits behind master. Could y

[Wikidata-bugs] [Maniphest] [Claimed] T255237: SkinAfterPortletHandlerTest: failing CI for non-English wikis

2020-06-12 Thread Michael
Michael claimed this task. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T255237 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: darthmon_wmde, RhinosF1, Liuxinyu970226, Addshore, WMDE

[Wikidata-bugs] [Maniphest] [Updated] T255237: SkinAfterPortletHandlerTest: failing CI for non-English wikis

2020-06-12 Thread Michael
Michael added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). TASK DETAIL https://phabricator.wikimedia.org/T255237 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: darthmon_wmde, RhinosF1, Liuxinyu970226, Addshore, WMDE

[Wikidata-bugs] [Maniphest] [Lowered Priority] T255237: SkinAfterPortletHandlerTest: failing CI for non-English wikis

2020-06-12 Thread Michael
Michael lowered the priority of this task from "Unbreak Now!" to "High". Michael moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Michael added a comment. Travis <https://travis-ci.org/git

[Wikidata-bugs] [Maniphest] [Created] T255410: Termbox SSR connection terminated very often

2020-06-15 Thread Michael
Michael created this task. Michael added projects: Wikidata-Termbox, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Starting last Wednesday, 2020-06-10, the number of connection failures with the Termbox SSR services seems to sharply rise to about 300 - 450 per

[Wikidata-bugs] [Maniphest] [Edited] T255410: Termbox SSR connection terminated very often

2020-06-15 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T255410 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Pablo-WMDE, Tarrow, Jakob_WMDE, Addshore, Aklapper, Michael, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T255410: Termbox SSR connection terminated very often

2020-06-15 Thread Michael
Michael added a comment. Seems to be caused by T254581: Move termbox to use TLS only <https://phabricator.wikimedia.org/T254581>. TASK DETAIL https://phabricator.wikimedia.org/T255410 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mich

[Wikidata-bugs] [Maniphest] [Created] T255426: Create Grafana tracking `wikibase.view.TermboxRemoteRenderer.requestError` and add alert

2020-06-15 Thread Michael
Michael created this task. Michael added projects: Wikidata-Termbox, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Termbox logs counts errors in `wikibase.view.TermboxRemoteRenderer.requestError`. The error in the parent ticket and its fix can be seen in that

[Wikidata-bugs] [Maniphest] [Retitled] T255426: Create Grafana tracking `wikibase.view.TermboxRemoteRenderer.requestError` and maybe add alert

2020-06-15 Thread Michael
Michael renamed this task from "Create Grafana tracking `wikibase.view.TermboxRemoteRenderer.requestError` and add alert" to "Create Grafana tracking `wikibase.view.TermboxRemoteRenderer.requestError` and maybe add alert". TASK DETAIL https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Updated] T255410: Termbox SSR connection terminated very often

2020-06-15 Thread Michael
Michael added a comment. The patch above (Ib7bfacf88 <https://gerrit.wikimedia.org/r/#/q/Ib7bfacf88eef436ed0f34a16e9d39eb0c053a44f>/02109a44 <https://gerrit.wikimedia.org/g/operations/puppet/+/02109a444a6ece2f480aee183dc02074d0f3734d>) seemingly resolved the original issue,

[Wikidata-bugs] [Maniphest] [Created] T255450: Understand Termbox SSR timouts better

2020-06-15 Thread Michael
Michael created this task. Michael added projects: Wikidata-Termbox, Wikidata, wikidata-tech-focus. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION As pointed out by `jayme` on #wikimedia-serviceops <https://wm-bot.wmflabs.org/browser/index.php?start=06%2F15%2F2020&

[Wikidata-bugs] [Maniphest] [Commented On] T255410: Termbox SSR connection terminated very often

2020-06-15 Thread Michael
Michael added a comment. In T255410#6224290 <https://phabricator.wikimedia.org/T255410#6224290>, @akosiaris wrote: > Logstash links are unfortunately not copy-pastable. Anyone clicking on those links will get a `Unable to completely restore the URL, be sure to use

[Wikidata-bugs] [Maniphest] [Commented On] T255410: Termbox SSR connection terminated very often

2020-06-15 Thread Michael
Michael added a comment. @akosiaris I edited my comment and it now has links that hopefully should work. There should be only a single event behind each of the searches linked there. Also, I added another follow-up task to understand those k8s timeouts themselves. TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Edited] T255187: Special:NewItem appears to have placeholder text heading "⧼Create a new Item⧽"

2020-06-16 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T255187 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender, Michael Cc: Ladsgroup, jhsoby, Umherirrender, Premeditated, Moebeus, Aklapper, Addshore

[Wikidata-bugs] [Maniphest] [Edited] T255187: Special:NewItem appears to have placeholder text heading "⧼Create a new Item⧽"

2020-06-16 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T255187 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender, Michael Cc: Ladsgroup, jhsoby, Umherirrender, Premeditated, Moebeus, Aklapper, Addshore

[Wikidata-bugs] [Maniphest] [Closed] T251876: wbsgetsuggestions RevisionedUnresolvedRedirectException logspam

2020-06-16 Thread Michael
Michael moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Michael closed this task as "Resolved". Michael added a comment. Last event for this in logstash was on 2020-06-09T16:33:53, see: https://logstash.wikimedi

[Wikidata-bugs] [Maniphest] [Unblock] T228293: RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job)

2020-06-16 Thread Michael
Michael closed subtask T251876: wbsgetsuggestions RevisionedUnresolvedRedirectException logspam as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T228293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: toan

[Wikidata-bugs] [Maniphest] [Unblock] T228293: RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job)

2020-06-16 Thread Michael
Michael closed subtask T251878: UpdateRepoOnMove RevisionedUnresolvedRedirectException logspam as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T228293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: toan, Addshore,

[Wikidata-bugs] [Maniphest] [Closed] T251878: UpdateRepoOnMove RevisionedUnresolvedRedirectException logspam

2020-06-16 Thread Michael
Michael moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Michael closed this task as "Resolved". Michael added a comment. As far as I can tell, this is fixed. Neither found it in logstash nor could reproduce the probl

[Wikidata-bugs] [Maniphest] [Created] T255566: Figure out why LexemeEditEntityTest::testGivenInvalidDataInClearRequest_errorIsReported is throwing an Exception/logging an error with AbuseFilter enable

2020-06-16 Thread Michael
Michael created this task. Michael added projects: wikidata-tech-focus, Technical-Debt. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION In an effort to resolve errors ending up in `mw-error.log` during a CI run in T249838

[Wikidata-bugs] [Maniphest] [Commented On] T255410: Termbox SSR connection terminated very often

2020-06-16 Thread Michael
Michael added a comment. In T255410#6227218 <https://phabricator.wikimedia.org/T255410#6227218>, @JMeybohm wrote: > @Michael thanks for writing this up! > > So, if it is safe to assume the MW -> termbox timeout is 3s I would suggest we configure the envoys acco

[Wikidata-bugs] [Maniphest] [Unblock] T228293: RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job)

2020-06-17 Thread Michael
Michael closed subtask T251880: Special:Search RevisionedUnresolvedRedirectException logspam as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T228293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: toan, Addshore,

[Wikidata-bugs] [Maniphest] [Closed] T251880: Special:Search RevisionedUnresolvedRedirectException logspam

2020-06-17 Thread Michael
Michael moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Michael closed this task as "Resolved". Michael added a comment. Didn't see this code path when I looked at those exceptions earlier. TASK

[Wikidata-bugs] [Maniphest] [Changed Project Column] T237248: Convert wdqs docker image to not run blazegraph as root

2020-06-17 Thread Michael
Michael moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Michael added a comment. Pull request merged, currently is being built by CI TASK DETAIL https://phabricator.wikimedia.org/T237248 WORKBOARD https

[Wikidata-bugs] [Maniphest] [Updated] T255437: Create Logstash Dashboard Tracking Termbox Errors

2020-06-17 Thread Michael
Michael added a project: Sustainability (Incident Prevention). TASK DETAIL https://phabricator.wikimedia.org/T255437 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Tarrow, darthmon_wmde, Nandana, Lahi, Gq86, Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Closed] T238496: Links to edit Senses and Forms can't be reached with the keyboard

2020-06-17 Thread Michael
Michael closed this task as "Invalid". Michael added a subscriber: Lucas_Werkmeister_WMDE. Michael added a comment. This has already been fixed at some point in the past. If I recall correctly, by @Lucas_Werkmeister_WMDE. TASK DETAIL https://phabricator.wikimedia.org/T238

[Wikidata-bugs] [Maniphest] [Updated] T255187: Special:NewItem appears to have placeholder text heading "⧼Create a new Item⧽"

2020-06-17 Thread Michael
Michael added subscribers: Lydia_Pintscher, Michael. Michael edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Patch-For-Review, Wikidata-Campsite. Michael added a comment. Seems to be fixed in production now @Lydia_Pintscher 🙂 TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Closed] T255505: Travis test failure FederatedPropertiesErrorTest::testOutputShouldGenerateMissingLabel

2020-06-19 Thread Michael
Michael closed this task as "Resolved". Michael added a comment. Master is now green again on Travis ✅ TASK DETAIL https://phabricator.wikimedia.org/T255505 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan, Michael Cc: WMDE-lesze

[Wikidata-bugs] [Maniphest] [Created] T255855: PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Avoiding infinite loop due to possibily undetectab

2020-06-19 Thread Michael
Michael created this task. Michael added projects: Wikimedia-production-error, Wikidata, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - `MediaWiki version:` **`1.35.0-wmf.37`** name=message PHP Warning: [data-update

[Wikidata-bugs] [Maniphest] [Edited] T255855: PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Avoiding infinite loop due to possibily undetectabl

2020-06-19 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T255855 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Ladsgroup, Addshore, Aklapper, Michael, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] [Triaged] T255855: PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Avoiding infinite loop due to possibily undetectab

2020-06-19 Thread Michael
Michael triaged this task as "Unbreak Now!" priority. Restricted Application added a subscriber: Liuxinyu970226. TASK DETAIL https://phabricator.wikimedia.org/T255855 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Liux

[Wikidata-bugs] [Maniphest] [Edited] T255855: PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Avoiding infinite loop due to possibily undetectabl

2020-06-19 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T255855 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Liuxinyu970226, Lucas_Werkmeister_WMDE, Ladsgroup, Addshore, Aklapper, Michael, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Lowered Priority] T255855: PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Avoiding infinite loop due to possibily u

2020-06-19 Thread Michael
Michael lowered the priority of this task from "Unbreak Now!" to "High". Michael added a comment. After debugging together with @Addshore, I'm lowering the priority for now as it doesn't seem to do permanent damage. It seems to go wrong somewhere in Repli

[Wikidata-bugs] [Maniphest] [Changed Project Column] T255855: PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Avoiding infinite loop due to possi

2020-06-19 Thread Michael
Michael moved this task from Incoming to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board. Michael edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T255855 WORKBOARD https

[Wikidata-bugs] [Maniphest] [Commented On] T255855: PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Avoiding infinite loop due to possibily undet

2020-06-22 Thread Michael
Michael added a comment. The errors reduced their frequency abruptly over the weekend, but are occasionally still happening: F31874325: image.png <https://phabricator.wikimedia.org/F31874325> TASK DETAIL https://phabricator.wikimedia.org/T255855 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T255855: PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Avoiding infinite loop due to possibily undet

2020-06-22 Thread Michael
Michael added a comment. We are currently speculating that these errors might be triggered by a batch of quickstatement edits adding labels to Chinese villages. Two candidates are: - https://www.wikidata.org/w/index.php?title=Q86019902&oldid=1211265991 - https://www.wikidata.o

[Wikidata-bugs] [Maniphest] [Closed] T250305: wmf-quibble-vendor-mysql-php72-docker failed on Special:EntityData

2020-06-22 Thread Michael
Michael moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Michael closed this task as "Resolved". Michael claimed this task. Michael added a comment. Restricted Application added a project: User-Michael. As far as I can

[Wikidata-bugs] [Maniphest] [Claimed] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-06-22 Thread Michael
Michael claimed this task. Michael moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T237164 WORKBOARD https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-06-22 Thread Michael
Michael added a comment. In T237164#6234226 <https://phabricator.wikimedia.org/T237164#6234226>, @Addshore wrote: > I think "Just copy the test code we need and ditch the library." Did that with the version currently in the HEAD of their master branch, but I'

[Wikidata-bugs] [Maniphest] [Changed Project Column] T250930: Wikibase receiving ⧼Lang⧽ from uselang parameter and using it everwhere

2020-06-22 Thread Michael
Michael moved this task from Incoming to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board. Michael edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T250930 WORKBOARD https

[Wikidata-bugs] [Maniphest] [Claimed] T250930: Wikibase receiving ⧼Lang⧽ from uselang parameter and using it everwhere

2020-06-22 Thread Michael
Michael claimed this task. Michael moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T250930 WORKBOARD https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Changed Status] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-06-22 Thread Michael
Michael moved this task from in progress to ready to go on the Wikidata board. Michael changed the task status from "Open" to "Stalled". Michael added a comment. The reasons that the tests break is because of patch ebe58f <https://gerrit.wikimedia.org/g/mediaw

[Wikidata-bugs] [Maniphest] [Updated] T250930: Wikibase receiving ⧼Lang⧽ from uselang parameter and using it everwhere

2020-06-22 Thread Michael
Michael added a comment. We can't fix it where I would like to fix it: name=RequestContext::getLanguage() // There are certain characters we don't allow in language code strings, // but by and large almost any v

[Wikidata-bugs] [Maniphest] [Claimed] T255998: Wikibase travis CI is failing, no such table: unittest_wbt_type foir sqlite

2020-06-23 Thread Michael
Michael claimed this task. Michael edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T255998 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Created] T256405: Investigate where and how \Wikibase\Lib\LanguageFallbackChain is used

2020-06-25 Thread Michael
Michael created this task. Michael added a project: wikidata-tech-focus. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION **Background**: In researching T250930: Wikibase receiving ⧼Lang⧽ from uselang parameter and using

[Wikidata-bugs] [Maniphest] [Created] T256407: Investigate where and with which keys FormatterOptions are used

2020-06-25 Thread Michael
Michael created this task. Michael added projects: wikidata-tech-focus, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION \ValueFormatters\FormatterOptions <https://github.com/DataValues/Interfaces/b

<    3   4   5   6   7   8   9   10   11   12   >