[Wikidata-bugs] [Maniphest] [Commented On] T87237: RFC: Possible redesign of the EntityTermsProvider interface

2015-01-23 Thread Snaterlicious
Snaterlicious added a subscriber: Snaterlicious. Snaterlicious added a comment. First off: Renaming in the UI has already happened. The reason behind that change was that, in the layout, the sub-component of a `Fingerprint` (label, description, aliases in one language) needs to be encapsulated

[Wikidata-bugs] [Maniphest] [Created] T87363: UI freezes when trying to save an entity reference that does not exist

2015-01-22 Thread Snaterlicious
Snaterlicious created this task. Snaterlicious added a subscriber: Snaterlicious. Snaterlicious added a project: MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Previously (version deployed on wikidata.org), it was not possible

[Wikidata-bugs] [Maniphest] [Updated] T86528: RFC: Unit Localization

2015-01-21 Thread Snaterlicious
Snaterlicious added a comment. Would be awesome to document the reasoning behind the agreements. So, instead of flexible entity types, there will be special properties? As that is a very fundamental decision, it should be evaluated properly as to other use cases (spontaneously, https

[Wikidata-bugs] [Maniphest] [Commented On] T40360: ui: ESC on autosuggestion for site/page selection will close the whole edit mode instead of just the suggestion dropdown

2015-01-20 Thread Snaterlicious
Snaterlicious added a comment. Works as expected by now, except for the siteselector selecting the first site when pressing ESC. Solved in https://gerrit.wikimedia.org/r/#/c/185976/. TASK DETAIL https://phabricator.wikimedia.org/T40360 REPLY HANDLER ACTIONS Reply to comment or attach

[Wikidata-bugs] [Maniphest] [Commented On] T86795: siteidtointerwiki gadget does not work on some pages

2015-01-20 Thread Snaterlicious
Snaterlicious added a comment. Unable to reproduce. Works for me on https://www.wikidata.org/wiki/Q16503 in Chrome, FF, IE. The gadget does not require a dependency on `jquery.wikibase.entityview`, just like the AuthorityControl gadget is not supposed to require that dependency. Either some

[Wikidata-bugs] [Maniphest] [Commented On] T87195: Autocomplete triggers new line for adding new sitelink

2015-01-20 Thread Snaterlicious
Snaterlicious added a comment. https://gerrit.wikimedia.org/r/#/c/185979/ TASK DETAIL https://phabricator.wikimedia.org/T87195 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T86895: Don't trigger statementviewchange when starting editing

2015-01-16 Thread Snaterlicious
Snaterlicious added a comment. https://gerrit.wikimedia.org/r/#/c/185411/ TASK DETAIL https://phabricator.wikimedia.org/T86895 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T85633: Adds a more prominent display of entity URIs

2015-01-16 Thread Snaterlicious
Snaterlicious added a comment. Just an idea: That could be a chance to fill the skin template native h1 class=firstHeading tag with meaningful information. TASK DETAIL https://phabricator.wikimedia.org/T85633 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Closed] T78273: MediaWiki dependence

2015-01-16 Thread Snaterlicious
Snaterlicious closed this task as Resolved. Snaterlicious claimed this task. Snaterlicious added a comment. Yes, done with https://github.com/wmde/WikibaseSerializationJavaScript/pull/6. TASK DETAIL https://phabricator.wikimedia.org/T78273 REPLY HANDLER ACTIONS Reply to comment or attach

[Wikidata-bugs] [Maniphest] [Reassigned] T78273: MediaWiki dependence

2015-01-16 Thread Snaterlicious
Snaterlicious reassigned this task from Snaterlicious to Wikidata-bugs. TASK DETAIL https://phabricator.wikimedia.org/T78273 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Reassigned] T75310: Stopping edit mode in full sitelinklistview removes the table head

2015-01-16 Thread Snaterlicious
Snaterlicious reassigned this task from Snaterlicious to Wikidata-bugs. Snaterlicious set Security to none. TASK DETAIL https://phabricator.wikimedia.org/T75310 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T86923: Entity selector should show the exact match as first result

2015-01-15 Thread Snaterlicious
Snaterlicious added a comment. Unable to reproduce (trying with uselang=nl on wikidata.org on that property name). Would be very surprised if that actually was a bug in the entityselector widget as there is no mechanism to change the order of the suggestions in any way. It might rather point

[Wikidata-bugs] [Maniphest] [Updated] T75360: save button not activated when changing order of statements

2015-01-15 Thread Snaterlicious
Snaterlicious added a comment. The move toolbar was removed as of https://phabricator.wikimedia.org/T58050 and is supposed to be re-implemented on top of https://phabricator.wikimedia.org/T74297. Of course, I would like to have move functionality back, but, in my opinion, there is no point

[Wikidata-bugs] [Maniphest] [Commented On] T86178: Mockup for indicating language fallbacks for labels of referenced entities

2015-01-15 Thread Snaterlicious
Snaterlicious added a comment. I had that in mind and, yes, there should be some concept covering all those cases. Regarding multilingual value: In my opinion, I could very well imagine that working just the same, as the label acts (and, basically, is), in fact, a multilingual value

[Wikidata-bugs] [Maniphest] [Commented On] T42657: Auto-generated documentation for JavaScript code based on already existing doxygen comments

2015-01-14 Thread Snaterlicious
Snaterlicious added a subscriber: Snaterlicious. Snaterlicious added a comment. Would be nice to get that ticket back on track as, by now, there is complete code documentation in place for the JS components / JS part of the components DataModel, API, Serialization, DataTypes, DataValues

[Wikidata-bugs] [Maniphest] [Updated] T75987: JavaScript Documentation: ValueView

2015-01-14 Thread Snaterlicious
Snaterlicious added a comment. The JavaScript code documentation of ValueView was updated extensively some time ago (by now) and is part of ValueView = 0.9.0. The remaining part is generating and deploying the actual documentation. Not sure whether that should be part of this ticket

[Wikidata-bugs] [Maniphest] [Updated] T75606: update documentation of js data model

2015-01-14 Thread Snaterlicious
Snaterlicious added a comment. The code documentation is in place. Maybe the task of generating and deploying the documentation should be tracked on https://phabricator.wikimedia.org/T42657. (see also https://phabricator.wikimedia.org/T75987) TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T86191: Give user indication how to influence preferred language selection

2015-01-14 Thread Snaterlicious
Snaterlicious added a comment. While that is a reasonable suggestion, adding any code to that feature is quite demotivating as it appears to be senseless effort... https://gerrit.wikimedia.org/r/#/c/184907/ I sincerely hope there is a way to replace that embarrassing mechanism. Can't we just

[Wikidata-bugs] [Maniphest] [Updated] T78277: [docs] Add documentation about events

2015-01-14 Thread Snaterlicious
Snaterlicious added a subscriber: Snaterlicious. Snaterlicious added a comment. Just noticed that bug. ValueView documentation has been updated via https://phabricator.wikimedia.org/T75987. As to the documentation (see `jquery.valueview.valueview.js`), there is no generic `change` event

[Wikidata-bugs] [Maniphest] [Commented On] T86178: Mockup for indicating language fallbacks for labels of referenced entities

2015-01-14 Thread Snaterlicious
Snaterlicious added a comment. Adding the language name in superscript was proposed already and we even had some mock-up way back. It would tie in with what we do with the calendar names as those are, in a way, some kind of language as well. It would be nice to be able to use the language name

[Wikidata-bugs] [Maniphest] [Commented On] T84913: remove table of content bar

2015-01-14 Thread Snaterlicious
Snaterlicious added a comment. What is the rest of the header design? Change is submitted already: https://gerrit.wikimedia.org/r/#/c/184629/ TASK DETAIL https://phabricator.wikimedia.org/T84913 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Commented On] T86191: Give user indication how to influence preferred language selection

2015-01-14 Thread Snaterlicious
Snaterlicious added a comment. Just wondering about the message content. As having a hint in non-JS is probably not that useful anyway, still, there would be at least two messages. One for logged-in users and one for users not logged in. To avoid being bashed for improper messages and since

[Wikidata-bugs] [Maniphest] [Commented On] T76849: Remove-toolbar not disabled during save

2015-01-14 Thread Snaterlicious
Snaterlicious added a comment. https://gerrit.wikimedia.org/r/#/c/183456/ TASK DETAIL https://phabricator.wikimedia.org/T76849 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T86191: Give user indication how to influence preferred language selection

2015-01-14 Thread Snaterlicious
Snaterlicious added a comment. OK, follow-up question: As the whole procedure of using Babel is kind of not how it should be, should that mechanism be implemented as a gadget on Wikidata, or should effort be put into implementing a dedicated Special page (that should be removed rather sooner

[Wikidata-bugs] [Maniphest] [Commented On] T86528: RFC: Unit Localization

2015-01-13 Thread Snaterlicious
Snaterlicious added a comment. I my opinion, specifically developing for Wikidata would be opening Pandora's box. We already have rather awkward Wikidata-specifics in the the code (Calendar types reference Wikidata items, for example) and, from my point of view, dealing with gadgets is already

[Wikidata-bugs] [Maniphest] [Commented On] T86528: RFC: Unit Localization

2015-01-12 Thread Snaterlicious
Snaterlicious added a comment. Just some thoughts on that: In my opinion, the full name should be defined by a property as well. Using the label would add an an assumption on top of the concept of label whose original purpose is nothing more than to identify an entity. Additionally

[Wikidata-bugs] [Maniphest] [Closed] T75749: languages mixed up in other languages box

2015-01-09 Thread Snaterlicious
Snaterlicious closed this task as Resolved. Snaterlicious added a subscriber: Snaterlicious. TASK DETAIL https://phabricator.wikimedia.org/T75749 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Closed] T75749: languages mixed up in other languages box

2015-01-09 Thread Snaterlicious
Snaterlicious closed this task as Resolved. Snaterlicious added a subscriber: Snaterlicious. TASK DETAIL https://phabricator.wikimedia.org/T75749 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Unblock] T75654: Redesign header

2015-01-08 Thread Snaterlicious
Snaterlicious closed blocking task T75655: Rename existing fingerprint* widgets as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T75654 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Closed] T75655: Rename existing fingerprint* widgets

2015-01-08 Thread Snaterlicious
Snaterlicious closed this task as Resolved. Snaterlicious claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T75655 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Changed CC] T86155: AuthorityControl gadget broken with Wikibase (Uncaught TypeError: undefined is not a function)

2015-01-08 Thread Snaterlicious
Snaterlicious added a subscriber: Snaterlicious. Snaterlicious added a comment. I suppose it was not possible in the past (probably before implementing the JS data model), but it would be better practice to retrieve the `Reference` objects from the Statement object, instead of gathering it from

[Wikidata-bugs] [Maniphest] [Commented On] T75653: Implement new Wikibase Skin

2014-12-16 Thread Snaterlicious
Snaterlicious added a comment. After some tossing and turning, I opt for not implementing a dedicated skin as long as there are no specific requirements. A dedicated skin (although it would just be an adaption of an existing skin without applying any complex patterns) increases complexity

[Wikidata-bugs] [Maniphest] [Changed CC] T76673: Placeholders like $1 that occur in descriptions are replaced by in other languages when shown in the other languages box.

2014-12-16 Thread Snaterlicious
Snaterlicious added a subscriber: Snaterlicious. Snaterlicious added a comment. https://gerrit.wikimedia.org/r/#/c/180150/ TASK DETAIL https://phabricator.wikimedia.org/T76673 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Wikidata-bugs] [Maniphest] [Commented On] T78469: JavaScript error in UnUnserializableValue

2014-12-16 Thread Snaterlicious
Snaterlicious added a comment. `SnakSerializer` submits the parameters in the order `type`, `value`, `error` while the `UnUnserializableValue` constructor assumes `value`, `type`, `error`. Started cleaning up in https://github.com/wmde/DataValuesJavascript/pull/58. The other issue is, of course

[Wikidata-bugs] [Maniphest] [Commented On] T68437: Autocompletion in linked page suggester missing

2014-12-16 Thread Snaterlicious
Snaterlicious added a comment. The pros and cons were discussed in older comments already... I am reluctant to retrigger the discussion. It boils down to the question is whether there should be a selector or a suggester. (While it makes sense for a selector to use hard auto-completion

[Wikidata-bugs] [Maniphest] [Commented On] T76215: find the right order for the elements in the sitelink section

2014-12-15 Thread Snaterlicious
Snaterlicious added a comment. Using CSS flexbox, the mock-up could just be adapted as is. However, due to the lack of compatibility, this options is disregarded. (Sensible) options from a technical perspective: - Leave the badges left to the page name: When toggling edit mode, the page name

[Wikidata-bugs] [Maniphest] [Commented On] T76215: find the right order for the elements in the sitelink section

2014-12-12 Thread Snaterlicious
Snaterlicious added a comment. As to the mock-up, the plan is to have the badges at the end of a line / after the page name input box in order to be able to prevent jitters when toggling edit mode. This, of course, if effective only if the space for the remove button is reflected by white

[Wikidata-bugs] [Maniphest] [Commented On] T78149: Prevent events from bubbling up the whole DOM unnecessarily

2014-12-10 Thread Snaterlicious
Snaterlicious added a comment. Widgets that aggregate other widgets should encapsulate their aggregated widgets' events using `event.stopPropagation()`. If parent components/widgets are to receive notification, these parent components should rely only on the events of their direct children

[Wikidata-bugs] [Maniphest] [Commented On] T75606: update documentation of js data model

2014-11-24 Thread Snaterlicious
Snaterlicious added a comment. This ticket needs some more specification. I am not sure about what the expected outcome should be as I do not see the need for the ticket to be blocked by the high-level documentation. The diagram embedded on https://github.com/wmde/WikibaseDataModelJavaScript

<    1   2