[Wikidata-bugs] [Maniphest] [Updated] T205459: Decide how SlotRoleHandlers can provide placeholders for missing slots

2018-11-20 Thread daniel
daniel added a subtask: T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles.. TASK DETAILhttps://phabricator.wikimedia.org/T205459EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, Aklapper, gerritbot, daniel

[Wikidata-bugs] [Maniphest] [Updated] T205459: Decide how SlotRoleHandlers can provide placeholders for missing slots

2018-11-20 Thread daniel
daniel added a comment. One solution would be to yield control over the layout to a PageTypeHandler (T209924), and control over content rendering to the SlotRoleHandler.TASK DETAILhttps://phabricator.wikimedia.org/T205459EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T205459: Decide how SlotRoleHandlers can provide placeholders for missing slots

2018-11-20 Thread daniel
daniel edited parent tasks, added: T205891: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block; removed: T200915: Allow SlotRoleHandlers to control page layout. TASK DETAILhttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Updated] T205891: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block

2018-11-20 Thread daniel
daniel added a subtask: T205459: Decide how SlotRoleHandlers can provide placeholders for missing slots. TASK DETAILhttps://phabricator.wikimedia.org/T205891EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: daniel, Agabi10, Cparle, Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles.

2018-11-20 Thread daniel
daniel removed a subtask: T205444: Provide a way of having a meaningful slot header. TASK DETAILhttps://phabricator.wikimedia.org/T194046EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper, daniel, CucyNoiD, Nandana, NebulousIris

[Wikidata-bugs] [Maniphest] [Updated] T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles.

2018-11-20 Thread daniel
daniel added a parent task: T205444: Provide a way of having a meaningful slot header. TASK DETAILhttps://phabricator.wikimedia.org/T194046EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper, daniel, CucyNoiD, Nandana, NebulousIris

[Wikidata-bugs] [Maniphest] [Updated] T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles.

2018-11-20 Thread daniel
daniel removed a subtask: T205459: Decide how SlotRoleHandlers can provide placeholders for missing slots. TASK DETAILhttps://phabricator.wikimedia.org/T194046EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper, daniel, CucyNoiD

[Wikidata-bugs] [Maniphest] [Updated] T205459: Decide how SlotRoleHandlers can provide placeholders for missing slots

2018-11-20 Thread daniel
daniel edited parent tasks, added: T200915: Allow SlotRoleHandlers to control page layout; removed: T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles.. TASK DETAILhttps://phabricator.wikimedia.org/T205459EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Updated] T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles.

2018-11-20 Thread daniel
daniel added a parent task: T200915: Allow SlotRoleHandlers to control page layout. TASK DETAILhttps://phabricator.wikimedia.org/T194046EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper, daniel, CucyNoiD, Nandana, NebulousIris

[Wikidata-bugs] [Maniphest] [Updated] T205891: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block

2018-11-20 Thread daniel
daniel added a subtask: T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles.. TASK DETAILhttps://phabricator.wikimedia.org/T205891EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: daniel, Agabi10, Cparle, Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles.

2018-11-20 Thread daniel
daniel edited parent tasks, added: T205891: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block; removed: T200915: Allow SlotRoleHandlers to control page layout. TASK DETAILhttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Updated] T205891: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block

2018-11-20 Thread daniel
daniel added a subtask: T209924: Introduce PageTypeHandler. TASK DETAILhttps://phabricator.wikimedia.org/T205891EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: daniel, Agabi10, Cparle, Aklapper, Jdforrester-WMF, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Commented On] T205891: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block

2018-11-20 Thread daniel
daniel added a comment. Please clarify: per the task description, one could assume that the desired order of things on a file description page would become: [File] [MediaInfo] [Wikitext] [File history] [Usage] [Exif] Buf if I understand correctly, the desired layout is actually [File

[Wikidata-bugs] [Maniphest] [Updated] T205891: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block

2018-11-20 Thread daniel
daniel added a comment. We need to distinguish between two solutions for this: client side DOM manipulation, and server side layout during page rendering. The former can be done quickly but should probably be considered a temporary solution. The latter needs quite a bit of infrastructure

[Wikidata-bugs] [Maniphest] [Created] T209923: Surface hidden and "undefined" slots via a single slot view

2018-11-20 Thread daniel
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Core Platform Team Backlog (Next), Core Platform Team (MCR). TASK DESCRIPTIONCertain slots may be hidden per default, or may have become "undefined" when the exte

[Wikidata-bugs] [Maniphest] [Changed Project Column] T174031: MCR: Include all slots in XML dumps

2018-11-19 Thread daniel
daniel moved this task from Doing to Ready on the Core Platform Team Kanban board.daniel edited projects, added Core Platform Team Kanban; removed Core Platform Team Kanban (Doing). TASK DETAILhttps://phabricator.wikimedia.org/T174031WORKBOARDhttps://phabricator.wikimedia.org/project/board/3696

[Wikidata-bugs] [Maniphest] [Changed Project Column] T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles.

2018-11-19 Thread daniel
daniel moved this task from Ready to Doing on the Core Platform Team Kanban board.daniel edited projects, added Core Platform Team Kanban (Doing); removed Core Platform Team Kanban. TASK DETAILhttps://phabricator.wikimedia.org/T194046WORKBOARDhttps://phabricator.wikimedia.org/project/board/3696

[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId

2018-11-16 Thread daniel
daniel added a comment. In T194299#4753796, @Addshore wrote: That will indeed work: INSERT INTO wb_id_counters (id_type, id_value) VALUES ('wikibase-item', 1) ON DUPLICATE KEY UPDATE id_value = LAST_INSERT_ID(id_value + 1); SELECT LAST_INSERT_ID(); This solution is specific to MySQL, right? I

[Wikidata-bugs] [Maniphest] [Commented On] T190066: Expose all slots to the search interface

2018-11-09 Thread daniel
daniel added a comment. @Cparle this ticket here *is* about making sure all slots are passed to cirrus. Cirrus should then also pass them on via its own hooks. Changing a hook signature isn't trivial though, it's generally better to introduce a new hook. I think this ticket here is sufficient

[Wikidata-bugs] [Maniphest] [Commented On] T190066: Expose all slots to the search interface

2018-11-09 Thread daniel
daniel added a comment. In T190066#4732969, @Jdforrester-WMF wrote: Update: We switched to CirrusSearchBuildDocumentParse in 2a0610b8a2d05d872878da292117f140520f5098. That hook's interface is actually not MCR compatible, since it only takes a singe Content object. I commented on the patch here

[Wikidata-bugs] [Maniphest] [Updated] T107595: [RFC] Multi-Content Revisions

2018-11-08 Thread daniel
daniel added a subtask: T209044: Introduce a ContentStore service to allow certain types of content to not be stored as serialized blobs.. TASK DETAILhttps://phabricator.wikimedia.org/T107595EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: brion, danielCc

[Wikidata-bugs] [Maniphest] [Unblock] T204582: Verify that abuse-/spam-related extensions work with Wikibase MediaInfo

2018-11-06 Thread daniel
daniel closed subtask T208767: Ensure that SpamBlacklist applies to the content of all MCR slots as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T204582EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Anooprao, Keegan, Jdfor

[Wikidata-bugs] [Maniphest] [Edited] T204582: Verify that abuse-/spam-related extensions work with Wikibase MediaInfo

2018-11-06 Thread daniel
daniel updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Wikibase //should// provide automatic integration with these via the EditFilterHookRunner class, which should work for all Wikibase edits, regardless of MCR. But this needs to be verified before deployment. Related

[Wikidata-bugs] [Maniphest] [Unblock] T174031: MCR: Include all slots in XML dumps

2018-11-05 Thread daniel
daniel closed subtask T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T174031EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc:

[Wikidata-bugs] [Maniphest] [Closed] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-11-05 Thread daniel
daniel closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlenn, danielCc: mako, FaFlo, Halfak, vrandezo, Denny, kchapman, tstarling, awight, JAllemandou, ho

[Wikidata-bugs] [Maniphest] [Created] T208633: Enable injection of RC records on wikidata org.

2018-11-02 Thread daniel
daniel created this task.daniel added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONThis will cause RecentChanges to show changes to Items as changes on pages that use the item. This functionality is enabled on all

[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId

2018-11-02 Thread daniel
daniel added a comment. @aaron yea, but using CONN_TRX_AUTO in places where we want a different connection, but don't care at all about the TRX mode, is just bad. It obfuscates the code. If you read something like this for the first time, you can end up spending hours trying to understand why

[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId

2018-11-01 Thread daniel
daniel added a comment. In T194299#4714614, @aaron wrote: openConnection is badly named and still reuses connections. You'd probably want getConnection with CONN_TRX_AUTO I hate this hack. This may *still* re-use connections, if anything else used CONN_TRX_AUTO. We should have CONN_NEW.TASK

[Wikidata-bugs] [Maniphest] [Commented On] T208279: Show protection status of pages listed as sitelinks on each Wikidata item

2018-11-01 Thread daniel
daniel added a comment. @abian this would perhaps be possible, though it would mean introducing a new cross-wiki event flow. Each client wiki would have to trigger a RefreshLinksJob for the entity page on the repo. But the repo would still have to poll the protection status of all wikis

[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId

2018-11-01 Thread daniel
daniel added a comment. In T194299#4712763, @Addshore wrote: One idea that @daniel and I had for this was simply to spread the ItemId counter out over 2 or more rows.. having one row deal with an odd counter and another deal with an even counter. For context, note that we are not using an auto

[Wikidata-bugs] [Maniphest] [Commented On] T208279: Show protection status of pages listed as sitelinks on each Wikidata item

2018-11-01 Thread daniel
daniel added a comment. The protection status for each wiki is recorded in that wiki's database. Running a separate query for each wiki takes too long, especially since this information is not cacheable, and has to be re-checked on every page view. The query could be batched per db-cluster using

[Wikidata-bugs] [Maniphest] [Updated] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-10-31 Thread daniel
daniel edited projects, added TechCom-RFC (TechCom-Approved); removed TechCom-RFC.daniel added a comment. Approved as amended, per today's TechCom meetingTASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T198308: Enable MCR migration stage "write both, read new" on live systems

2018-10-18 Thread daniel
daniel added a comment. I had a cursory eye on stats and logs for commons over the week, and didn't see anything alarming. So I suppose we can enable this on more wikis. Do we want to make more smaller steps, or go all-in now?TASK DETAILhttps://phabricator.wikimedia.org/T198308EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-10-18 Thread daniel
daniel added a comment. Looks good to me!TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlenn, danielCc: mako, FaFlo, Halfak, vrandezo, Denny, kchapman, tstarling, awight, JAllemandou, hoo, pmiazga

[Wikidata-bugs] [Maniphest] [Unblock] T174044: Deploy MCR storage layer

2018-10-18 Thread daniel
daniel closed subtask T205808: Ensure Revision::getRevisionText continues to function with MCR read-new mode as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T174044EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Stashbot

[Wikidata-bugs] [Maniphest] [Commented On] T207168: Provide JSON-LD support for Wikidata

2018-10-17 Thread daniel
daniel added a comment. @Tpt embedding will be hard to do due to the streaming nature of purtle. But let's discuss that when you file the new ticket.TASK DETAILhttps://phabricator.wikimedia.org/T207168EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cscott

[Wikidata-bugs] [Maniphest] [Commented On] T112127: [Story] Move RDF ontology from beta to release status

2018-10-17 Thread daniel
daniel added a comment. I don't have objections. Any clients that have ontology uris hard-coded will break, there is no way to avoid this. We could provide same-as triples that map the old to the new uris. That would be nice, and in *theory* that means we stay backwards compatible. But very few

[Wikidata-bugs] [Maniphest] [Commented On] T135155: Create an adapter that implements SiteLookup on top of InterwikiLookup

2018-10-16 Thread daniel
daniel added a comment. The status of this is "I really want to work on this but other stuff keeps being more urgent"... The code for this is mostly finished. The biggest issue is migrating old installs to the new system without losing any data.TASK DETAILhttps://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T207168: Provide JSON-LD support for Wikidata

2018-10-16 Thread daniel
daniel added a comment. @Tpt If I understand you correctly, structure you propose would fail if there is more than one entity, though. Which is typically indeed the case, since we return stub representations of referenced entities along with the data about the requested entity.TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-10-15 Thread daniel
daniel added a comment. As the above conversation seems to converge on having the combined hash in the revision level tag, this raises the question where to put the main slot's content hash. I personally prefer to use an attribute on the tag, but we could also go for or .TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-10-15 Thread daniel
daniel added a comment. @Halfak to clarify - you originally said the top level tag should be the hash of the main slot's content, but you now let yourself be convinced that it's more useful to have the combined revision hash there?TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-10-09 Thread daniel
daniel added a comment. What is the "revision hash"? A combined hash the identifies the content of the slot across all revisions. It's stored in rev_sha1 in the database, and used by stuff on labs to detect manual reverts. It's also available from the API as rvprop=sha1.TASK D

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-10-09 Thread daniel
daniel added a comment. Ok, so if we use the tag on the revision level for the main tag hash, where do we put the revision hash? Or do we just ignore it? Note that the revision has is in the database, and is exposed via the API. It's not made up for the purpose of the dumps.TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-10-09 Thread daniel
daniel added a comment. Well, we are trying to keep compatibility for most clients that just ignore stuff they don't know. They would still be able to process the dumps as before. Removing the tag would be cleaner and safer, but it would also be a hard B/C break. So, IF we keep it, should we keep

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-10-09 Thread daniel
daniel added a comment. @Halfak having per-slot hashes is not controversial, the question is what to do with the tag that currently exists on the revision level. If we make this the has of the main slot, we will break the assumption that two revisions that have the same hash there have the same

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-10-09 Thread daniel
daniel added subscribers: Denny, vrandezo, Halfak.daniel added a comment. What I'm getting at is that folks have until now been studying article or other page content. Sure, there hasn't been other content available for them to examine, but I imagine that a vast majority of folks will still

[Wikidata-bugs] [Maniphest] [Reopened] T174035: Allow the view action to show multiple slots [MCR]

2018-10-08 Thread daniel
daniel reopened this task as "Open".daniel raised the priority of this task from "Normal" to "High".daniel added a comment. Re-opening, since we missed the fact that RefreshLinksJob will only re-render the main slot, and then place the ParserOutput for only the main

[Wikidata-bugs] [Maniphest] [Block] T174036: Diffs page should show diffs and content from multiple slots [MCR]

2018-10-08 Thread daniel
daniel reopened subtask T174035: Allow the view action to show multiple slots [MCR] as "Open". TASK DETAILhttps://phabricator.wikimedia.org/T174036EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: CCicalese_WMF, gerritbot, Tgr, Anom

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-10-04 Thread daniel
daniel added a comment. Re the ìd`attribute being optional or not: turns out, it's optional already: The "use" attribute of the element in an xml schema is indeed optional, and its default value is "optional" :) The fact that this is declared for all other attribute

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-10-04 Thread daniel
daniel added a comment. I can't imagine any script is going to care about the revision sha1 as separate from the sha1 of the content of each slot separately; if you want to know if an edit was reverted, you can look at the sha1 of the individual slots, and I imagine that much analysis will focus

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-10-04 Thread daniel
daniel added a comment. Note that text location and id attrs might be omitted in the case where the text is deleted (in practice, this is what the code does), and yet id has never been marked as optional, so I am not marking location as optional either. I'd rather argue that the spec should

[Wikidata-bugs] [Maniphest] [Commented On] T174031: MCR: Include all slots in XML dumps

2018-10-04 Thread daniel
daniel added a comment. In T174031#4641387, @ArielGlenn wrote: Yes, we certainly do. There's a maintenance script in the Flow extension for that, which generates both 'current' and 'history' Flow dumps. Ah, ok, that's a completely separate mechanism. Makes sense.TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Commented On] T174031: MCR: Include all slots in XML dumps

2018-10-04 Thread daniel
daniel added a comment. @ArielGlenn Flow is in the main slot, but the content it has there isn't really its content. It's just a reference to where the actual content is stored, which is completely separate from the normal storage mechanisms. Do we currently have Flow content in dumps at all? I

[Wikidata-bugs] [Maniphest] [Changed Project Column] T174032: Make relevant API modules aware of MCR

2018-10-04 Thread daniel
daniel moved this task from MCR: New Features to MCR: Tech Debt on the Core Platform Team board.daniel edited projects, added Core Platform Team (MCR: Tech Debt); removed Core Platform Team (MCR: New Features). TASK DETAILhttps://phabricator.wikimedia.org/T174032WORKBOARDhttps

[Wikidata-bugs] [Maniphest] [Changed Project Column] T189808: Make undo work with multiple slots.

2018-10-04 Thread daniel
daniel moved this task from MCR: Tech Debt to MCR: New Features on the Core Platform Team board.daniel edited projects, added Core Platform Team (MCR: New Features); removed Core Platform Team (MCR: Tech Debt). TASK DETAILhttps://phabricator.wikimedia.org/T189808WORKBOARDhttps

[Wikidata-bugs] [Maniphest] [Changed Project Column] T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles.

2018-10-04 Thread daniel
daniel moved this task from MCR: Tech Debt to MCR: New Features on the Core Platform Team board.daniel edited projects, added Core Platform Team (MCR: New Features); removed Core Platform Team (MCR: Tech Debt). TASK DETAILhttps://phabricator.wikimedia.org/T194046WORKBOARDhttps

[Wikidata-bugs] [Maniphest] [Changed Project Column] T174037: Implement single-slot UI [MCR]

2018-10-04 Thread daniel
daniel moved this task from MCR: Tech Debt to MCR: New Features on the Core Platform Team board.daniel edited projects, added Core Platform Team (MCR: New Features); removed Core Platform Team (MCR: Tech Debt). TASK DETAILhttps://phabricator.wikimedia.org/T174037WORKBOARDhttps

[Wikidata-bugs] [Maniphest] [Changed Project Column] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-10-04 Thread daniel
daniel moved this task from MCR: Tech Debt to MCR: New Features on the Core Platform Team board.daniel edited projects, added Core Platform Team (MCR: New Features); removed Core Platform Team (MCR: Tech Debt). TASK DETAILhttps://phabricator.wikimedia.org/T199121WORKBOARDhttps

[Wikidata-bugs] [Maniphest] [Changed Project Column] T174031: MCR: Include all slots in XML dumps

2018-10-04 Thread daniel
daniel moved this task from MCR: Tech Debt to MCR: New Features on the Core Platform Team board.daniel edited projects, added Core Platform Team (MCR: New Features); removed Core Platform Team (MCR: Tech Debt). TASK DETAILhttps://phabricator.wikimedia.org/T174031WORKBOARDhttps

[Wikidata-bugs] [Maniphest] [Changed Project Column] T195212: ServiceContainer: Allow extensions to manipulate services upon creation

2018-10-04 Thread daniel
daniel moved this task from MCR: Tech Debt to MCR: New Features on the Core Platform Team board.daniel edited projects, added Core Platform Team (MCR: New Features); removed Core Platform Team (MCR: Tech Debt). TASK DETAILhttps://phabricator.wikimedia.org/T195212WORKBOARDhttps

[Wikidata-bugs] [Maniphest] [Changed Project Column] T205459: Decide how SlotRoleHandlers can provide placeholders for missing slots

2018-10-04 Thread daniel
daniel moved this task from MCR: Tech Debt to MCR: New Features on the Core Platform Team board.daniel edited projects, added Core Platform Team (MCR: New Features); removed Core Platform Team (MCR: Tech Debt). TASK DETAILhttps://phabricator.wikimedia.org/T205459WORKBOARDhttps

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-10-04 Thread daniel
daniel added a comment. Side note re the id attribute becoming optional: hasn't it always be (formally) optional, because it was only emitted for stubs?TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Updated] T190066: Expose all slots to the search interface

2018-10-04 Thread daniel
daniel removed a project: Epic.daniel added a comment. not an empic, this is a concrete taskTASK DETAILhttps://phabricator.wikimedia.org/T190066EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, gerritbot, EBjune, EBernhardson, dcausse

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-10-04 Thread daniel
daniel added a comment. Quick addendum to @Tgr's last point: in theory a lot of resources could be saved if identical slot contents are only written out once (they will be a very frequent occurrence due to reverts) Reverts are not a new problem, and not the largest problem. Inherited slots

[Wikidata-bugs] [Maniphest] [Updated] T174044: Deploy MCR storage layer

2018-10-01 Thread daniel
daniel added a subtask: T205808: Ensure Revision::getRevisionText continues to function with MCR read-new mode. TASK DETAILhttps://phabricator.wikimedia.org/T174044EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Stashbot, Addshore, gerritbot, Anomie

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-09-27 Thread daniel
daniel added a comment. I'm reluctant to change anything about the formatting of the main slot this round. There are tools that convert xml dumps to sql suitable for import, and the text id may be used by some of these as a convenience for constructing the text table entry. Such tools will have

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-09-26 Thread daniel
daniel added a comment. I've added the location attr as optional for the main slot, with the intent that it gets used when we have some other schema than 'tt' in play. The next version would have the id attr as optional + deprecated for the main slot, only permitted to be written for blobs

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-09-26 Thread daniel
daniel added a comment. Hi Ariel! Thanks for updating. Sorry for the confusion about the address format, I thought you knew this was already in. This is what the content_address field contains. I tried to explain the idea in August, see T199121#4529353. Main slot still only gets an id number

[Wikidata-bugs] [Maniphest] [Created] T205459: Decide how SlotRoleHandlers can provide placeholders for missing slots

2018-09-25 Thread daniel
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Structured-Data-Commons, Patch-For-Review, Core-Platform-Team, Multi-Content-Revisions.Restricted Application removed a project: Patch-For-Review. TASK DESCRIPTIONSlotRoleHandlers shou

[Wikidata-bugs] [Maniphest] [Updated] T198308: Enable MCR migration stage "write both, read new" on live systems

2018-09-25 Thread daniel
daniel added a subtask: T205432: Database errors related to actor table on testwiki. TASK DETAILhttps://phabricator.wikimedia.org/T198308EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Keegan, Fjalapeno, CCicalese_WMF, Aklapper, Tgr, Anomie, Abit

[Wikidata-bugs] [Maniphest] [Updated] T194412: Make undo fail gracefully for non-main slots.

2018-09-25 Thread daniel
daniel added a subtask: T205101: McrUndoAction preview doesn't work. TASK DETAILhttps://phabricator.wikimedia.org/T194412EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, gerritbot, Anomie, Tgr, daniel, CCicalese_WMF, NebulousIris, Gaboe420

[Wikidata-bugs] [Maniphest] [Updated] T194413: Make action=undo work properly with multiple slots (phase 2)

2018-09-25 Thread daniel
daniel added a subtask: T205101: McrUndoAction preview doesn't work. TASK DETAILhttps://phabricator.wikimedia.org/T194413EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, daniel, CCicalese_WMF, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey

[Wikidata-bugs] [Maniphest] [Updated] T189808: Make undo work with multiple slots.

2018-09-25 Thread daniel
daniel removed a subtask: T205101: McrUndoAction preview doesn't work. TASK DETAILhttps://phabricator.wikimedia.org/T189808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Jdforrester-WMF, gerritbot, Tgr, CCicalese_WMF, Anomie, Aklapper, -jem

[Wikidata-bugs] [Maniphest] [Updated] T189808: Make undo work with multiple slots.

2018-09-25 Thread daniel
daniel added a subtask: T205101: McrUndoAction preview doesn't work. TASK DETAILhttps://phabricator.wikimedia.org/T189808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Jdforrester-WMF, gerritbot, Tgr, CCicalese_WMF, Anomie, Aklapper, -jem

[Wikidata-bugs] [Maniphest] [Closed] T204732: Provide a way to restore an old revision with multiple slots.

2018-09-25 Thread daniel
daniel closed this task as "Resolved".daniel moved this task from In Progress to Done on the Multi-Content-Revisions board. TASK DETAILhttps://phabricator.wikimedia.org/T204732WORKBOARDhttps://phabricator.wikimedia.org/project/board/3112/EMAIL PREFERENCEShttps://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] [Unblock] T204741: Remove undo and restore functionality from SubmitEntityAction

2018-09-25 Thread daniel
daniel closed subtask T204732: Provide a way to restore an old revision with multiple slots. as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T204741EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, daniel,

[Wikidata-bugs] [Maniphest] [Commented On] T585: Finalize high-level API

2018-09-24 Thread daniel
daniel added a comment. @Kelson I can only refer you to @Ramsey-WMF and @MarkTraceurTASK DETAILhttps://phabricator.wikimedia.org/T585EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: MarkTraceur, Abit, Ramsey-WMF, atgo, Matanya, Nemo_bis, Ricordisamoa

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-09-21 Thread daniel
daniel added a comment. I just realized that the proposed dump format is still using numeric text IDs. That cannot be guaranteed to work, text blobs are now identified by URL-like blob addresses: "tt:12345" is the address of text row 12345, and we may start using "ext:DB:...&quo

[Wikidata-bugs] [Maniphest] [Reopened] T194729: Allow Wikibase Entities to be stored in alternative slots [MCR]

2018-09-21 Thread daniel
daniel reopened this task as "Open".daniel reassigned this task from daniel to Addshore.daniel added a comment. Re-opening, since issues were found. To be concrete, entities can be stored in extra slots, but Wikibase gets confused when finding a page that exists, could have

[Wikidata-bugs] [Maniphest] [Block] T159708: Deploy WikibaseMediaInfo extension to production

2018-09-21 Thread daniel
daniel reopened subtask T194729: Allow Wikibase Entities to be stored in alternative slots [MCR] as "Open". TASK DETAILhttps://phabricator.wikimedia.org/T159708EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Jdforrester-WMF, Addshore, Ri

[Wikidata-bugs] [Maniphest] [Block] T180981: Deploy WikibaseMediaInfo extension to beta

2018-09-21 Thread daniel
daniel reopened subtask T194729: Allow Wikibase Entities to be stored in alternative slots [MCR] as "Open". TASK DETAILhttps://phabricator.wikimedia.org/T180981EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Jdforrester-WMF,

[Wikidata-bugs] [Maniphest] [Block] T194750: Deploy Structured Data on Commons baseline

2018-09-21 Thread daniel
daniel reopened subtask T194729: Allow Wikibase Entities to be stored in alternative slots [MCR] as "Open". TASK DETAILhttps://phabricator.wikimedia.org/T194750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, Aklapper, Abit,

[Wikidata-bugs] [Maniphest] [Block] T200903: Have MediaInfo store its entities in an MCR slot on the associated file page

2018-09-21 Thread daniel
daniel reopened subtask T194729: Allow Wikibase Entities to be stored in alternative slots [MCR] as "Open". TASK DETAILhttps://phabricator.wikimedia.org/T200903EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Cparle, danielCc: gerritbot, Cpar

[Wikidata-bugs] [Maniphest] [Commented On] T585: Finalize high-level API

2018-09-20 Thread daniel
daniel added a comment. @Kelson I suppose this has been obsoleted by https://commons.wikimedia.org/wiki/Commons:Structured_data. Or maybe the plan is to pick it up again once that project has progressed a bit.TASK DETAILhttps://phabricator.wikimedia.org/T585EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-09-19 Thread daniel
daniel added a comment. I'd really like to move this forward. Ideally, we'd get the new dump format into the 1.32 release. @ArielGlenn is there anything holding this back? Can we have an IRC discussion on this soon?TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Commented On] T176852: Redirects should not be in wb_terms table

2018-09-19 Thread daniel
daniel added a comment. They should not? If Q10 is a redirect to Q17, and I have a reference to Q10 in a statement, how do I look up labels for Q10 when rendering the statement for display? Does the code in question resolve redirects first?TASK DETAILhttps://phabricator.wikimedia.org/T176852EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T204732: Provide a way to restore an old revision with multiple slots.

2018-09-18 Thread daniel
daniel added a parent task: T204741: Remove undo and restore functionality from SubmitEntityAction. TASK DETAILhttps://phabricator.wikimedia.org/T204732EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper, daniel, Gaboe420, Versusxo

[Wikidata-bugs] [Maniphest] [Updated] T204741: Remove undo and restore functionality from SubmitEntityAction

2018-09-18 Thread daniel
daniel added a subtask: T204732: Provide a way to restore an old revision with multiple slots.. TASK DETAILhttps://phabricator.wikimedia.org/T204741EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, daniel, Lahi, Gq86, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] [Created] T204741: Remove undo and restore functionality from SubmitEntityAction

2018-09-18 Thread daniel
daniel created this task.daniel added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONWith T204732 and T189808 in place, core has support for undoing and reverting not just revisions with multiple slots, but also

[Wikidata-bugs] [Maniphest] [Edited] T204732: Provide a way to restore an old revision with multiple slots.

2018-09-18 Thread daniel
daniel updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Until {T174033} is implemented, we need an alternative way to restore old revisions. This could be done in the same way that undo is currently implemented for MCR, per {T189808}. Note that the same mechanism should

[Wikidata-bugs] [Maniphest] [Claimed] T204732: Provide a way to restore an old revision with multiple slots.

2018-09-18 Thread daniel
daniel claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T204732EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] [Created] T204732: Provide a way to restore an old revision with multiple slots.

2018-09-18 Thread daniel
daniel created this task.daniel added projects: Multi-Content-Revisions, Structured-Data-Commons.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata. TASK DESCRIPTIONCurrently, old revisions can be restored by loading them into the EditPage using

[Wikidata-bugs] [Maniphest] [Updated] T204732: Provide a way to restore an old revision with multiple slots.

2018-09-18 Thread daniel
daniel added a subtask: T194750: Deploy Structured Data on Commons baseline . TASK DETAILhttps://phabricator.wikimedia.org/T204732EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF

[Wikidata-bugs] [Maniphest] [Updated] T194750: Deploy Structured Data on Commons baseline

2018-09-18 Thread daniel
daniel added a parent task: T204732: Provide a way to restore an old revision with multiple slots.. TASK DETAILhttps://phabricator.wikimedia.org/T194750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, Aklapper, Abit, Ramsey-WMF, daniel, Lahi

[Wikidata-bugs] [Maniphest] [Updated] T200072: MCR broke Undelete action (and made Cognate tests fail) "The given Title does not belong to page ID"

2018-09-18 Thread daniel
daniel added subscribers: Yann, De728631, Reedy, Krenair, Ankry.daniel merged a task: T200121: Fatal exception of type "InvalidArgumentException" while undeleting a file on Commons in RevisionStoreRecord.php: The given Title does not belong to page ID 50301569 but actually belongs t

[Wikidata-bugs] [Maniphest] [Updated] T199352: Deploy Structured Data on Commons with arbitrary Statements

2018-09-17 Thread daniel
daniel removed a subtask: T204582: Verify that AbuseFilter and SpamBlacklist work with Wikibase MediaInfo. TASK DETAILhttps://phabricator.wikimedia.org/T199352EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, Aklapper, daniel, Lahi, PDrouin

[Wikidata-bugs] [Maniphest] [Updated] T204582: Verify that AbuseFilter and SpamBlacklist work with Wikibase MediaInfo

2018-09-17 Thread daniel
daniel edited parent tasks, added: T194750: Deploy Structured Data on Commons baseline ; removed: T199352: Deploy Structured Data on Commons with arbitrary Statements. TASK DETAILhttps://phabricator.wikimedia.org/T204582EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T194750: Deploy Structured Data on Commons baseline

2018-09-17 Thread daniel
daniel added a subtask: T204582: Verify that AbuseFilter and SpamBlacklist work with Wikibase MediaInfo. TASK DETAILhttps://phabricator.wikimedia.org/T194750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, Aklapper, Abit, Ramsey-WMF, daniel

[Wikidata-bugs] [Maniphest] [Commented On] T204582: Verify that AbuseFilter and SpamBlacklist work with Wikibase MediaInfo

2018-09-17 Thread daniel
daniel added a comment. @Jdforrester-WMF You are right. I was mostly thinking of spam links, but dick jokes in file captions also suck (no pun intended). Changing.TASK DETAILhttps://phabricator.wikimedia.org/T204582EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Closed] T194037: Track dependencies for multiple Content objects per page

2018-09-17 Thread daniel
daniel closed this task as "Resolved".daniel moved this task from Backlog to Done on the Multi-Content-Revisions (MCR-SDC Statement Support - phase 3) board. TASK DETAILhttps://phabricator.wikimedia.org/T194037WORKBOARDhttps://phabricator.wikimedia.org/project/board/3464/EMAIL PREFER

<    1   2   3   4   5   6   7   8   9   10   >