[Wikidata-bugs] [Maniphest] T362660: WikidataPageBanner doesn't seem to use wpb_banner wpb_banner_focus_x or wpb_banner_focus_y page properties

2024-04-26 Thread thiemowmde
thiemowmde added a comment. There is a single place in the code <https://phabricator.wikimedia.org/diffusion/EWDP/browse/master/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js$48> that uses the data-pos-x and data-pos-y attributes from the

[Wikidata-bugs] [Maniphest] T362505: Failing Wikibase InfoAction tests block CI

2024-04-18 Thread thiemowmde
thiemowmde added a project: WMDE-TechWish-Sprint-2024-04-12. thiemowmde claimed this task. thiemowmde closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T362505 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thi

[Wikidata-bugs] [Maniphest] T362505: Failing Wikibase InfoAction tests block CI

2024-04-16 Thread thiemowmde
thiemowmde lowered the priority of this task from "Unbreak Now!" to "Needs Triage". thiemowmde added a comment. Thanks a lot for looking into this! So far it really looks like some state makes it from one test to the next – but where exactly this happens we don't know,

[Wikidata-bugs] [Maniphest] T362660: WikidataPageBanner doesn't seem to use wpb_banner wpb_banner_focus_x or wpb_banner_focus_y page properties

2024-04-16 Thread thiemowmde
thiemowmde added a comment. I found T114424#7554051 <https://phabricator.wikimedia.org/T114424#7554051>. It makes it sound like this was indeed never used. TASK DETAIL https://phabricator.wikimedia.org/T362660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] T362505: Failing Wikibase InfoAction tests block CI

2024-04-15 Thread thiemowmde
thiemowmde triaged this task as "Unbreak Now!" priority. thiemowmde added subscribers: Lydia_Pintscher, Lucas_Werkmeister_WMDE, hoo. thiemowmde added a comment. `{{WBREPONAME}}` is a custom magic word that comes with Wikibase. The test results make it look like it just stopped worki

[Wikidata-bugs] [Maniphest] T362505: Failing Wikibase InfoAction tests block CI

2024-04-15 Thread thiemowmde
thiemowmde created this task. thiemowmde added projects: Wikidata, MediaWiki-extensions-WikibaseClient, Move-Files-To-Commons. TASK DESCRIPTION I really have no idea what's going on. Neither the failing InfoActionHookHandlerTest nor anything related to core's InfoAction was touched the past

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

2024-04-09 Thread thiemowmde
thiemowmde added a subscriber: WMDE-Fisch. thiemowmde added a comment. I still try to understand what needs to be done here? I can see that mw:Stable interface policy/Frontend <https://www.mediawiki.org/wiki/Stable_interface_policy/Frontend> talks about hooks, and a few WMDE products

[Wikidata-bugs] [Maniphest] T323778: [ACTION-API] [TECH] Wikibase doesn’t validate formatter options, can crash with different TypeErrors

2024-02-16 Thread thiemowmde
thiemowmde added a comment. Quick response from a dev who worked with this code back in 2014 and is at least partially responsible for the mess. ️ The formatter options are (mis)used for two, maybe three different purposes. 1. Only very few options are meant to accept values

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2023-12-18 Thread thiemowmde
thiemowmde added a subscriber: WMDE-leszek. thiemowmde added a comment. Oh, got it. It's the wrong way around. The weird code was added in patchset 20 in July 2018, apparently by @WMDE-leszek: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/441203/19..20/lib/includes

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2023-12-15 Thread thiemowmde
thiemowmde added a comment. > though “correct” in that the methods perform their inverse operations […] we’re just putting JSONified mojibake in the inner cache. The `utf8_decode` documentation says "UTF-8 characters which do not exist in ISO-8859-1 (that is, code points abov

[Wikidata-bugs] [Maniphest] T288813: Decrease template maintenance with Lua conversion, Wikidata and completed TemplateData

2023-11-21 Thread thiemowmde
thiemowmde closed this task as "Declined". thiemowmde removed projects: VisualEditor, Wikidata, TemplateData. thiemowmde added a comment. This sounds like a super abstract project idea that didn't went anywhere. Or did it? As far as I can tell this is about potentially //using/

[Wikidata-bugs] [Maniphest] T351630: Special:PagesWithBadges broken on wikidata.org

2023-11-20 Thread thiemowmde
thiemowmde closed this task as "Invalid". thiemowmde added a comment. Oh, I'm sorry. I somehow expected this to list the Wikidata items that have the badge assigned. But that's not what the special page is designed to do. TASK DETAIL https://phabricator.wikimedia.org/T351

[Wikidata-bugs] [Maniphest] T351630: Special:PagesWithBadges broken on wikidata.org

2023-11-20 Thread thiemowmde
thiemowmde created this task. thiemowmde added projects: Wikidata, Wikidata Dev Team (Wikidata.org Slice). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Special:PagesWithBadges appears to be completely broken. It doesn't list anything. Example: https://www.wikidata.org

[Wikidata-bugs] [Maniphest] T349240: Create list of places likely going to break due to pseudo-Entity Ids

2023-10-24 Thread thiemowmde
thiemowmde added a comment. I see. Thanks for the clarification. Sure, it should "break" in a reliable way and ideally with a message that helps the user understand what's going on, and what options they have. TASK DETAIL https://phabricator.wikimedia.org/T349240 EMAIL P

[Wikidata-bugs] [Maniphest] T349240: Create list of places likely going to break due to pseudo-Entity Ids

2023-10-24 Thread thiemowmde
thiemowmde added a comment. I'm curious if Lua integration and parser functions like `{{#statements:…}}` are even needed for EntitySchemas? What would be the use case? Or to ask this question the other way around: Isn't it much easier to leave it disconnected as it is for the moment

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review code on mw object and mark (un)stable interfaces before 1.42.0

2023-10-04 Thread thiemowmde
thiemowmde added a comment. The ticket claims to be about "code on mw object". But the #wmde-techwish <https://phabricator.wikimedia.org/tag/wmde-techwish/> products I'm responsible for don't look like <https://codesearch.wmcloud.org/search/?q=%5Cbmw%5C.=%5C.js%24=Extensi

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review code on mw object and mark (un)stable interfaces before 1.42.0

2023-10-04 Thread thiemowmde
thiemowmde removed projects: Revision-Slider, Advanced-Search. thiemowmde added a comment. I'm afraid I don't understand how the #wmde-techwish <https://phabricator.wikimedia.org/tag/wmde-techwish/> products are affected. I had a brief look at the codebases but couldn't spot any susp

[Wikidata-bugs] [Maniphest] T344609: Revisit the EntitySchema v2 Technical Decision

2023-09-28 Thread thiemowmde
thiemowmde added a comment. It might be a good idea to expand that ADR then. It appears to be incomplete. I miss, for example, an explanation what that mental load is, and how it compares to the problems that come with EntityDocument. If you want you can think of EntityDocument

[Wikidata-bugs] [Maniphest] T344609: Revisit the EntitySchema v2 Technical Decision

2023-09-25 Thread thiemowmde
thiemowmde added a subscriber: Lydia_Pintscher. thiemowmde added a comment. I don't want to fuel this discussion unnecessarily. Unfortunately it feels like this comes up every few years. We had the same fights back then in 2014 when I had my head deep <https://github.com/w

[Wikidata-bugs] [Maniphest] T344609: Revisit the EntitySchema v2 Technical Decision

2023-09-25 Thread thiemowmde
thiemowmde added a comment. I don't want to fuel this discussion unnecessarily. Unfortunately it feels like this comes up every few years. We had the same fights back then in 2014 when I had my head deep <https://github.com/wmde/WikibaseDataModel/graphs/contributors> in the Dat

[Wikidata-bugs] [Maniphest] T313048: Can reference tooltips be moved out of beta mode?

2023-09-07 Thread thiemowmde
thiemowmde edited projects, added WMDE-TechWish; removed wdwb-tech, Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T313048 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Galobtter, Manuel, Aklapper, Jdlrobson, jdfraine

[Wikidata-bugs] [Maniphest] T145171: without lat/long should use coordinates from Wikidata

2023-08-29 Thread thiemowmde
thiemowmde closed this task as "Resolved". thiemowmde added a comment. While this is probably more semi-automatic, this is now possible since T307695: Display coordinate markers in Kartographer maps from QID <https://phabricator.wikimedia.org/T307695>. Minimal e

[Wikidata-bugs] [Maniphest] T337228: Kartographer maps embedded in Wikibase entity pages refer to a dummy page title, leading to errors from maps.wikimedia.org

2023-08-23 Thread thiemowmde
thiemowmde added a comment. @hoo, can you please try setting the ParserOptions in your CachingKartographerEmbeddingHandler to be in preview mode? (Or section preview, if you prefer.) Not for the entire page but really only for the parsing of the `` tag. This will partially disable

[Wikidata-bugs] [Maniphest] T321532: Console error - 'Error: View mediainfoview does not exist' on Commons File pages

2023-07-21 Thread thiemowmde
thiemowmde renamed this task from "[commons-wmf.6] Console error - 'Error: View mediainfoview does not exist' on File pages" to "Console error - 'Error: View mediainfoview does not exist' on Commons File pages". TASK DETAIL https://phabricator.wikimedia.org/T321532 EMAIL

[Wikidata-bugs] [Maniphest] T321532: [commons-wmf.6] Console error - 'Error: View mediainfoview does not exist' on File pages

2023-07-21 Thread thiemowmde
thiemowmde added a project: Wikidata-UX. thiemowmde added subscribers: Lucas_Werkmeister_WMDE, Lydia_Pintscher. thiemowmde added a comment. The piece of code that fails turns out to be part of the good old Wikidata entity page UI that's build with jQuery UI. See https

[Wikidata-bugs] [Maniphest] T321532: [commons-wmf.6] Console error - 'Error: View mediainfoview does not exist' on File pages

2023-07-21 Thread thiemowmde
thiemowmde added a comment. I currently get this error on every single File page on Commons, even when I am not logged in. counterexample Error: View mediainfoview does not exist at SELF._getView (load.php?debug=1=en=codex-search-styles%2CdataValues%2Cjquery%2Coojs%2Coojs-ui

[Wikidata-bugs] [Maniphest] T336601: Error: View mediainfoview does not exist

2023-07-21 Thread thiemowmde
thiemowmde closed this task as a duplicate of T321532: [commons-wmf.6] Console error - Error: View mediainfoview does not exist on File pages. TASK DETAIL https://phabricator.wikimedia.org/T336601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T321532: [commons-wmf.6] Console error - 'Error: View mediainfoview does not exist' on File pages

2023-07-21 Thread thiemowmde
thiemowmde merged a task: T336601: Error: View mediainfoview does not exist. thiemowmde added a subscriber: Jdlrobson. TASK DETAIL https://phabricator.wikimedia.org/T321532 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Jdlrobson

[Wikidata-bugs] [Maniphest] T341409: Use LanguageNameUtils::ALL for monolingual text and lexemes

2023-07-17 Thread thiemowmde
thiemowmde added subscribers: Manuel, Lydia_Pintscher, Amire80, jhsoby, Lucas_Werkmeister_WMDE, thiemowmde. thiemowmde added a comment. I might get this wrong. But as I understand the proposal it would make the currently established processes of how languages on wikidata.org are managed

[Wikidata-bugs] [Maniphest] T341210: FlaggedRevs ReviewHandlerTest::testWithMinParams fails in EntitySchema CI

2023-07-07 Thread thiemowmde
thiemowmde added a comment. We have T256296 <https://phabricator.wikimedia.org/T256296>, T340004 <https://phabricator.wikimedia.org/T340004>, and this now, all attacking the probably same issue from different perspectives. I still can't explain it 100%. As o

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

2023-06-23 Thread thiemowmde
thiemowmde added a comment. I think the problem we have are the unknown unknowns – situations we currently can't think of. I would love to ask the question the other way around: When does it make sense to cut off an arbitrary part of a button label? Or maybe like this: What's worse

[Wikidata-bugs] [Maniphest] T174443: Some extension name are localized though most are not

2023-06-15 Thread thiemowmde
thiemowmde removed a project: WMDE-TechWish-Maintenance. thiemowmde closed this task as "Invalid". thiemowmde added a comment. I don't think there is anything to do here. If you think a specific extension should be translatable (or not be translated) please open separate bug re

[Wikidata-bugs] [Maniphest] T326908: Update WMDE Engineering-owned products that may be affected by IP Masking

2023-05-25 Thread thiemowmde
thiemowmde removed a project: WMDE-TechWish-Maintenance. TASK DETAIL https://phabricator.wikimedia.org/T326908 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: WMDE-Fisch, WMDE-leszek, ItamarWMDE, Niharika, ARamirez_WMF, SCherukuwada

[Wikidata-bugs] [Maniphest] T211676: Inline Kartographer mapframes: Take precision into account

2023-04-06 Thread thiemowmde
thiemowmde added a comment. There is a highly relevant piece of code in the #Kartographer <https://phabricator.wikimedia.org/tag/kartographer/> extension that does the opposite: The input is a zoom factor from 0 to 19 and the output a precision. You "just" need to turn th

[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens

2023-03-24 Thread thiemowmde
thiemowmde added a comment. As someone still watching this ticket: I honestly never understood why OOUI hard-codes <https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/src/styles/elements/ButtonElement.less$15> a `nowrap` in this situation. It's never helpful, espe

[Wikidata-bugs] [Maniphest] T214002: Wikidata web form recognizes Japanese date 2001年8月31日 but not 2016年7月1日

2023-03-14 Thread thiemowmde
thiemowmde added a comment. > or worse, Wikibase might even fall back to another parser and still successfully parse the date […] … which might be good or bad: - Unambiguous dates will be parsed just fine by one of the later, more relaxed parsers. These will ignore the

[Wikidata-bugs] [Maniphest] T90852: Create a system to store and query links to books

2023-02-21 Thread thiemowmde
thiemowmde added a project: WMDE-References-FocusArea. TASK DETAIL https://phabricator.wikimedia.org/T90852 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: PokestarFan, Elitre, VIGNERON, Sumit, Minervaxox, Shrutika719, Mvolz

[Wikidata-bugs] [Maniphest] T166304: Consider making a WikiCite extension for cross-cluster loading of structured citations (replacing Cite extension for those uses)

2023-02-21 Thread thiemowmde
thiemowmde added a project: WMDE-References-FocusArea. TASK DETAIL https://phabricator.wikimedia.org/T166304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Carn, Izno, PokestarFan, Jdforrester-WMF, Aklapper, 1313, Astuthiodit_1

[Wikidata-bugs] [Maniphest] T326768: OutOfRangeException: Lexeme L136328 doesn't have Form L136328-F2

2023-01-13 Thread thiemowmde
thiemowmde added a comment. It was the other way around. I suggested to remove the problematic `hasForm` after the "unchecked errors" patch got stale. Reading the discussion I still don't understand why it wasn't merged. (Well, not being linked to a ticket definitely pla

[Wikidata-bugs] [Maniphest] T204813: Allow looking for items and lexemes namespaces together by default

2022-08-02 Thread thiemowmde
thiemowmde added a comment. #Wikidata <https://phabricator.wikimedia.org/tag/wikidata/> is not owned by Search. Please try to be more careful. TASK DETAIL https://phabricator.wikimedia.org/T204813 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] T204813: Allow looking for items and lexemes namespaces together by default

2022-08-02 Thread thiemowmde
thiemowmde reopened this task as "Open". TASK DETAIL https://phabricator.wikimedia.org/T204813 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, MPhamWMF, So9q, EBernhardson, dcausse, abian, Smalyshev, Lydia

[Wikidata-bugs] [Maniphest] T209035: When creating a statement linking to a Sense show all Senses of a Lexeme in entity selector if Lexeme ID is entered

2022-08-02 Thread thiemowmde
thiemowmde removed a project: Discovery-Search. thiemowmde added a comment. #Wikidata <https://phabricator.wikimedia.org/tag/wikidata/> is not owned by Search. Please try to be more careful. TASK DETAIL https://phabricator.wikimedia.org/T209035 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T209035: When creating a statement linking to a Sense show all Senses of a Lexeme in entity selector if Lexeme ID is entered

2022-08-02 Thread thiemowmde
thiemowmde reopened this task as "Open". TASK DETAIL https://phabricator.wikimedia.org/T209035 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, MPhamWMF, Infovarius, EBernhardson, dcausse, Smalyshev, Lydia

[Wikidata-bugs] [Maniphest] T202254: Use ExtensionRegistry instead of class_exists to check for CirrusSearch in Wikibase

2022-08-02 Thread thiemowmde
thiemowmde changed the task status from "Declined" to "Resolved". thiemowmde removed projects: CirrusSearch, Discovery-Search. TASK DETAIL https://phabricator.wikimedia.org/T202254 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T189744: Add hints parameter to wbsearchentities

2022-08-02 Thread thiemowmde
thiemowmde reopened this task as "Open". thiemowmde added a comment. #Wikidata <https://phabricator.wikimedia.org/tag/wikidata/> is not owned by Search. Please try to be more careful. TASK DETAIL https://phabricator.wikimedia.org/T189744 EMAIL PRE

[Wikidata-bugs] [Maniphest] T189736: [Epic] Lexeme search

2022-08-02 Thread thiemowmde
thiemowmde reopened subtask T189737: [Epic] Implement completion search for Lexemes as Open. TASK DETAIL https://phabricator.wikimedia.org/T189736 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Liuxinyu970226, Esc3300, debt, EBjune

[Wikidata-bugs] [Maniphest] T189737: [Epic] Implement completion search for Lexemes

2022-08-02 Thread thiemowmde
thiemowmde reopened this task as "Open". thiemowmde added a comment. #Wikidata <https://phabricator.wikimedia.org/tag/wikidata/> is not owned by Search. Please try to be more careful. TASK DETAIL https://phabricator.wikimedia.org/T189737 EMAIL PRE

[Wikidata-bugs] [Maniphest] T189737: [Epic] Implement completion search for Lexemes

2022-08-02 Thread thiemowmde
thiemowmde reopened subtask T189744: Add hints parameter to wbsearchentities as Open. TASK DETAIL https://phabricator.wikimedia.org/T189737 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, thiemowmde Cc: Aklapper, daniel, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] T188291: Display point features (coordinates) from the results of a SPARQL query on a map in Wikipedia

2022-02-23 Thread thiemowmde
thiemowmde closed subtask T300042: Investigation: display SPARQL queries in a map in Wikipedia as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T188291 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Abbe98, Conny, Theklan

[Wikidata-bugs] [Maniphest] T145171: without lat/long should use coordinates from Wikidata

2022-02-11 Thread thiemowmde
thiemowmde added a project: WMDE-GeoInfo-FocusArea. TASK DETAIL https://phabricator.wikimedia.org/T145171 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Pikne, Ayack, Liuxinyu970226, daniel, MaxSem, Lydia_Pintscher, Aklapper, Yurik

[Wikidata-bugs] [Maniphest] T188291: Display point features (coordinates) from the results of a SPARQL query on a map in Wikipedia

2022-02-04 Thread thiemowmde
thiemowmde added a subtask: T300042: Investigation: display SPARQL queries in a map in Wikipedia. TASK DETAIL https://phabricator.wikimedia.org/T188291 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Abbe98, Conny, Theklan

[Wikidata-bugs] [Maniphest] T300306: successbox, errorbox and warningbox classes will no longer function in 1.39 release

2022-02-01 Thread thiemowmde
thiemowmde closed subtask T300349: Fix use of errorbox in TemplateData as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T300306 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, thiemowmde Cc: Volker_E, Esanders, Aklapper

[Wikidata-bugs] [Maniphest] T300306: successbox, errorbox and warningbox classes will no longer function in 1.39 release

2022-02-01 Thread thiemowmde
thiemowmde closed subtask T300342: Fix use of warningbox in TwoColConflict as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T300306 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, thiemowmde Cc: Volker_E, Esanders, Aklapper

[Wikidata-bugs] [Maniphest] T300306: successbox, errorbox and warningbox classes will no longer function in 1.39 release

2022-02-01 Thread thiemowmde
thiemowmde closed subtask T300343: Fix uses of error- and warningbox in FileImporter as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T300306 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, thiemowmde Cc: Volker_E, Esanders

[Wikidata-bugs] [Maniphest] T174443: Some extension name are localized though most are not

2022-01-19 Thread thiemowmde
thiemowmde added a project: WMDE-Technical-Wishes-Maintenance. TASK DETAIL https://phabricator.wikimedia.org/T174443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Jdlrobson, Legoktm, Aklapper, Bugreporter, Invadibot, maantietaja

[Wikidata-bugs] [Maniphest] T165488: [Hackathon 2017] "Progressive Enhancement": Added JS makes UI jump

2022-01-07 Thread thiemowmde
thiemowmde removed a project: TCB-Team (now WMDE-TechWish). TASK DETAIL https://phabricator.wikimedia.org/T165488 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher, thiemowmde Cc: Volker_E, Lea_WMDE, Aklapper, WMDE-Fisch

[Wikidata-bugs] [Maniphest] T144616: Enable the revisionslider on test.wikidata.org

2022-01-07 Thread thiemowmde
thiemowmde removed a project: TCB-Team (now WMDE-TechWish). TASK DETAIL https://phabricator.wikimedia.org/T144616 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, thiemowmde Cc: Lea_Lacroix_WMDE, Glorian_Yapinus, gerritbot, Sjoerddebruin

[Wikidata-bugs] [Maniphest] T174443: Some extension name are localized though most are not

2022-01-07 Thread thiemowmde
thiemowmde removed a project: TCB-Team (now WMDE-TechWish). TASK DETAIL https://phabricator.wikimedia.org/T174443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Jdlrobson, Legoktm, Aklapper, Bugreporter, Invadibot, maantietaja

[Wikidata-bugs] [Maniphest] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions

2022-01-07 Thread thiemowmde
thiemowmde removed a project: TCB-Team (now WMDE-TechWish). TASK DETAIL https://phabricator.wikimedia.org/T183096 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, thiemowmde Cc: TheDJ, gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo

[Wikidata-bugs] [Maniphest] T196166: Add Wikibase-specific search-options to Advanced search

2022-01-07 Thread thiemowmde
thiemowmde removed a project: TCB-Team (now WMDE-TechWish). TASK DETAIL https://phabricator.wikimedia.org/T196166 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: gabriel-wmde, Aklapper, MichaelSchoenitzer_WMDE, Invadibot, maantietaja

[Wikidata-bugs] [Maniphest] T214002: Wikidata web form recognizes Japanese date 2001年8月31日 but not 2016年7月1日

2021-07-02 Thread thiemowmde
thiemowmde added a comment. I can explain this behavior, if it helps. The first date is unambiguous. We do have a parser that ignores all punctuation. It checks if it can find 3 numbers, and if there is only one way these 3 numbers can be mapped to a year, month, and day. This works

[Wikidata-bugs] [Maniphest] T47925: [Task] Apply normalization to string values in statements

2021-06-30 Thread thiemowmde
thiemowmde added a comment. I suggest two separate data types for strings that should be trimmed (which should be the norm) and "binary" strings that aren't. TASK DETAIL https://phabricator.wikimedia.org/T47925 EMAIL PREFERENCES https://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

2021-04-29 Thread thiemowmde
thiemowmde added a comment. I'm not working with these codebases any more. But since I created this ticket once, I had a quick look at some random codebases I could find. These execute phpcs as part of `composer test`: - https://github.com/wmde/Number/blob/master/composer.json#L56

[Wikidata-bugs] [Maniphest] T260178: Use html entity for space in wikibaselexeme-formidformatter-separator-grammatical-features

2021-02-28 Thread thiemowmde
thiemowmde assigned this task to Umherirrender. thiemowmde set the point value for this task to "1". thiemowmde closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T260178 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/pa

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

2021-01-22 Thread thiemowmde
thiemowmde added a comment. I feel like we need to talk about this a little more. > We call them the Wikimedia coding standards. Yes, and no. Sure, one of the purposes of the #mediawiki-codesniffer <https://phabricator.wikimedia.org/tag/mediawiki-codesniffer/> is to enco

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

2020-12-12 Thread thiemowmde
thiemowmde added a comment. James, such a passive-aggressive tone is inakzeptable. If you are unable to explain yourself then please don't comment, especially if you are not even asked for your opinion. TASK DETAIL https://phabricator.wikimedia.org/T229939 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

2020-12-11 Thread thiemowmde
thiemowmde added a subscriber: TheDJ. thiemowmde added a comment. I know this is frustrating. WMDE staff is happy to help, but is currently not in a position to invest substantial resources into the Math extension. According to https://www.mediawiki.org/wiki/Developers/Maintainers the owner

[Wikidata-bugs] [Maniphest] T269232: Localized precision in geocoordinate inputs

2020-12-09 Thread thiemowmde
thiemowmde added a comment. > - 1/1' > > Should we make that […] translatable as well? Yes, I suggest to make it translatable. One might want to localize this as "1/1 of a second", or something like "1/10.000 Sekunde" in German. It

[Wikidata-bugs] [Maniphest] T157673: Don't use PHP serialization to determine revision size for Entities

2020-11-05 Thread thiemowmde
thiemowmde added a subscriber: Lydia_Pintscher. thiemowmde added a comment. It sounds like the only place that uses these numbers is the history. It displays both the page size for each revision (in a tooltip), as well as +/- changes. Touching this code will have these consequences

[Wikidata-bugs] [Maniphest] T221949: Remove uses of Title::moveTo

2020-11-04 Thread thiemowmde
thiemowmde edited projects, added MediaWiki-extensions-WikimediaMaintenance; removed MediaWiki-extensions-Maintenance. TASK DETAIL https://phabricator.wikimedia.org/T221949 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712, thiemowmde Cc

[Wikidata-bugs] [Maniphest] T236891: AdvancedSearch does not offer nor describe “incoming_links_desc” sort

2020-11-03 Thread thiemowmde
thiemowmde removed a project: MediaWiki-extensions-Maintenance. TASK DETAIL https://phabricator.wikimedia.org/T236891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY

[Wikidata-bugs] [Maniphest] T236891: AdvancedSearch does not offer nor describe “incoming_links_desc” sort

2020-11-03 Thread thiemowmde
thiemowmde added a project: MediaWiki-extensions-Maintenance. TASK DETAIL https://phabricator.wikimedia.org/T236891 WORKBOARD https://phabricator.wikimedia.org/project/board/2323/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc

[Wikidata-bugs] [Maniphest] T236891: AdvancedSearch does not offer nor describe “incoming_links_desc” sort

2020-11-02 Thread thiemowmde
thiemowmde removed a project: archived--TCB-Team. TASK DETAIL https://phabricator.wikimedia.org/T236891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, Akuckartz

[Wikidata-bugs] [Maniphest] T236891: AdvancedSearch does not offer nor describe “incoming_links_desc” sort

2020-10-30 Thread thiemowmde
thiemowmde added a project: WMDE-Technical-Wishes-Team. TASK DETAIL https://phabricator.wikimedia.org/T236891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, dueltodeath

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 or v32.1 and retire wikibase-codesniffer

2020-10-29 Thread thiemowmde
thiemowmde added a comment. My suggestion for this migration would be to copy-paste the entire file https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/ruleset.xml to every codebase that currently uses the WikibaseCodeSniffer, and slowly simplify it, e.g. remove exclusions you

[Wikidata-bugs] [Maniphest] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS

2020-10-29 Thread thiemowmde
thiemowmde added a comment. No, as far as I can see this was everything. I suggest to copy-paste the entire file https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/ruleset.xml to every codebase that currently uses the WikibaseCodeSniffer, and slowly simplify it, e.g

[Wikidata-bugs] [Maniphest] T265992: Argument 1 passed to ViolationMessageSerializer::serializeEntityId() must be an instance of EntityId, string given

2020-10-29 Thread thiemowmde
thiemowmde moved this task from incoming to Features/bugs for next release on the Wikibase-Quality-Constraints board. thiemowmde added a project: WMDE-QWERTY-Sprint-2020-10-21. TASK DETAIL https://phabricator.wikimedia.org/T265992 WORKBOARD https://phabricator.wikimedia.org/project/board

[Wikidata-bugs] [Maniphest] T265992: Argument 1 passed to ViolationMessageSerializer::serializeEntityId() must be an instance of EntityId, string given

2020-10-27 Thread thiemowmde
thiemowmde claimed this task. thiemowmde added a project: Unplanned-Sprint-Work. thiemowmde set the point value for this task to "2". TASK DETAIL https://phabricator.wikimedia.org/T265992 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thi

[Wikidata-bugs] [Maniphest] T122711: Appending ".json" to an entity url should work (Feature Request)

2020-10-11 Thread thiemowmde
thiemowmde reopened this task as "Open". thiemowmde added a comment. With all the respect, but the task specifically asks to make https://www.wikidata.org/wiki/Q269728.json work. It might be that this is not something the Wikidata team want's to implement and maintain. If this is

[Wikidata-bugs] [Maniphest] T109420: [Story] Make exports formats more visible

2020-10-11 Thread thiemowmde
thiemowmde reopened subtask T122711: Appending .json to an entity url should work (Feature Request) as Open. TASK DETAIL https://phabricator.wikimedia.org/T109420 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Ivanhercaz

[Wikidata-bugs] [Maniphest] T169559: Imageheader Gadget at Wikidata - zoom of image

2020-09-16 Thread thiemowmde
thiemowmde closed this task as "Invalid". thiemowmde added a comment. Given this is 3 years old and not much information was given in the first place (no examples, no screen resolution), I will be a bit bold and close this for now. This doesn't mean the gadget can't be improved. It

[Wikidata-bugs] [Maniphest] T229939: Use wikidata entity selector in OOUI input field

2020-09-15 Thread thiemowmde
thiemowmde added a comment. I might oversimplify this, but exposing the API endpoint should be possible like that: name=In SpecialMathWikibase.php $settings = WikibaseClient::getDefaultInstance()->getSettings(); $url = $settings->getSetting( 'repoUrl' ); $scri

[Wikidata-bugs] [Maniphest] T229939: Use wikidata entity selector in OOUI input field

2020-09-14 Thread thiemowmde
thiemowmde added a comment. @Physikerwelt, sorry for not responding earlier. My advice is: don't use jquery.wikibase.entityselector. Write your own code, ideally based on OOUI, not jQuery. Seriously. It's your code then, and it does exactly what you want, which isn't that much. The existing

[Wikidata-bugs] [Maniphest] T229939: Use wikidata entity selector in OOUI input field

2020-09-10 Thread thiemowmde
thiemowmde added a comment. As far as I understand the issue is that whatever method you choose to load a module, it only works when the module is //known//, i.e. it is registered in the extension registration. The `jquery.wikibase.entityselector` module is part of WikibaseView. I had

[Wikidata-bugs] [Maniphest] T259783: LanguageFallbackChain does not end in 'en'

2020-08-06 Thread thiemowmde
thiemowmde added a comment. I believe this caused both T259744 <https://phabricator.wikimedia.org/T259744> and T259745 <https://phabricator.wikimedia.org/T259745>. I already created T259779 <https://phabricator.wikimedia.org/T259779> where I describe an idea that is a lit

[Wikidata-bugs] [Maniphest] T259779: LanguageFallbackChainFactory returns empty fallback chain when it shouldn't

2020-08-06 Thread thiemowmde
thiemowmde added a comment. T259744#6364309 <https://phabricator.wikimedia.org/T259744#6364309> mentions the patch that changed the behavior of the factory. It's now possible that language chains can be empty when the interface language is not a valid term language. There are a few la

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

2020-08-06 Thread thiemowmde
thiemowmde added a comment. This is actually the exact same root cause as in T259745 <https://phabricator.wikimedia.org/T259745>: The language fallback chain in question is empty, and calling `$languageCode = $languageCodes[0]` on an empty array results in the language code bein

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-06 Thread thiemowmde
thiemowmde added subscribers: Umherirrender, thiemowmde. thiemowmde added a comment. The problematic `...` was added in patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/538388 (T224772 <https://phabricator.wikimedia.org/T224772>) by @Umherirrender 10

[Wikidata-bugs] [Maniphest] T259779: LanguageFallbackChainFactory returns empty fallback chain when it shouldn't

2020-08-06 Thread thiemowmde
thiemowmde created this task. thiemowmde added projects: WikibaseMediaInfo, Wikidata, Wikimedia-production-error. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION While working on a hot-fix for T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag

[Wikidata-bugs] [Maniphest] T239208: Lexemes: Grammatical form can render as `[object Object]`

2020-08-04 Thread thiemowmde
thiemowmde added a comment. I was working on T249167 <https://phabricator.wikimedia.org/T249167> and T258337 <https://phabricator.wikimedia.org/T258337> and found what causes this: Never call `setLabel()` with anything but plain text. When you want a more complex HTML label

[Wikidata-bugs] [Maniphest] [Updated] T253624: Evaluate the future of wikibase-codesniffer

2020-06-26 Thread thiemowmde
thiemowmde added a comment. Related tickets: - In T243296#5820465 <https://phabricator.wikimedia.org/T243296#5820465> we briefly talked about the past and future of the custom Wikibase CodeSniffer already. - Via T164653 <https://phabricator.wikimedia.org/T164

[Wikidata-bugs] [Maniphest] [Updated] T255319: Eventually deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

2020-06-17 Thread thiemowmde
thiemowmde removed a project: Move-Files-To-Commons. TASK DETAIL https://phabricator.wikimedia.org/T255319 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Krinkle, Ammarpad, Jdlrobson, Blissjay007, Oblanco79, Llanddewi

[Wikidata-bugs] [Maniphest] [Commented On] T252803: AffectedPagesFinder: Call to a member function exists() on null

2020-05-15 Thread thiemowmde
thiemowmde added a comment. This is caused by https://gerrit.wikimedia.org/r/594610, merged 9 days ago. Wikibase had a custom TitleFactory that was introduced very early, in 2014, see https://gerrit.wikimedia.org/r/168579. The duplicate in core was introduced very late, in 2019, see

[Wikidata-bugs] [Maniphest] [Commented On] T214300: Square brackets not allowed in URLs on Wikidata

2020-03-20 Thread thiemowmde
thiemowmde added a comment. Yes, I believe so. Short answer: It's not Wikibase, it's MediaWiki. https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/repo/includes/Validators/UrlSchemeValidators.php$53 https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes

[Wikidata-bugs] [Maniphest] [Commented On] T92009: Support more fine-grained date fields than xsd:dateTime

2020-03-18 Thread thiemowmde
thiemowmde added a comment. The question was: A lot of time values in the Wikidata database name a year only. Does it even make sense to export these as xsd:dateTime? Shouldn't we export these as xsd:gYear? TASK DETAIL https://phabricator.wikimedia.org/T92009 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T247458: PHP Notice: Undefined index: wgKartographerLiveData

2020-03-12 Thread thiemowmde
thiemowmde added a comment. I do not know the involved CachingKartographerEmbeddingHandler class in Wikibase very well. But according to what I see in https://codesearch.wmflabs.org/search/?q=wgKartographerLiveData I suspect that: 1. I believe this is **not** a serious issue. Just

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

2020-03-11 Thread thiemowmde
thiemowmde added a comment. When someone is able and willing to identify the original issue, we can undo code changes that are not needed any more then. As long as this is not the case let us please, please unblock people from working on these codebases. TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

2020-02-28 Thread thiemowmde
thiemowmde added a comment. I dug into the code and indeed found the place that creates constants based on what's said in extension.json: https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/registration/ExtensionRegistry.php$512. But this appears to be more like

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

2020-02-26 Thread thiemowmde
thiemowmde added a comment. I would like to ask another question: How is it a good idea do define a **PHP** constant in a .json file? How is my IDE supposed to find it there? In other words: As far as I'm concerned the duplication is a **must**. TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

2020-02-26 Thread thiemowmde
thiemowmde added a comment. Even if it's true that this started failing when a specific change in core was made. I still believe it is the extension that must be fixed. I might get this wrong, but my idea is: Code should not assume that the "namespaces" section from exte

  1   2   3   4   5   6   7   8   9   10   >