JeroenDeDauw added a comment.
👎
TASK DETAIL
https://phabricator.wikimedia.org/T188395
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: bete, JeroenDeDauw
Cc: Addshore, JeroenDeDauw, Ladsgroup, Jonas, Lucas_Werkmeister_WMDE, Rzuwig,
thiemowmde
JeroenDeDauw added a comment.
@dcausse: will anything bad happen if the URL comparison that is currently
failing is removed? And is that applicable to people running their own Wikibase?
TASK DETAIL
https://phabricator.wikimedia.org/T263427
EMAIL PREFERENCES
https
JeroenDeDauw added a comment.
@dcausse is it realistic to expect this bug to be fixed by Wikimedia in the
near future? Several institutuions that we are helping with Wikibase adoption
are running into it.
TASK DETAIL
https://phabricator.wikimedia.org/T263427
EMAIL PREFERENCES
https
JeroenDeDauw created this task.
JeroenDeDauw added projects: Wikidata-Query-Service, Wikibase.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.
TASK DESCRIPTION
The query service fails when it gets updates from a non-English wiki
JeroenDeDauw added a comment.
Use cases for DNB:
- Always end up with the same IDs when importing the dataset in a fresh wiki
- Access data in Wikibase with existing IDs (both for internal DNB tools and
the GND ecosystem users)
- Do not allow changing GND IDs
- Ability to create an
JeroenDeDauw closed this task as "Resolved".
JeroenDeDauw added a comment.
Looks like this is a QuickStatement issue that is already tracked:
https://github.com/magnusmanske/quickstatements/pull/1
TASK DETAIL
https://phabricator.wikimedia.org/T27
EMAIL PREFERENC
JeroenDeDauw added a comment.
After the latest fix the
`extensions/OAuth/maintenance/createOAuthConsumer.php` script is running
without error.
Now when I go to the quickstatements UI and click login I get
Fatal error: Uncaught Exception: Error retrieving token1:
{"e
JeroenDeDauw added a comment.
I just tried the latest version and am now getting an error for a different
field:
php /var/www/html/extensions/OAuth/maintenance/createOAuthConsumer.php
--approve --callbackUrl http://localhost:9191/api.php --callbackIsPrefix true
--user AdminUser
JeroenDeDauw created this task.
JeroenDeDauw added a project: Wikibase-Containers.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.
TASK DESCRIPTION
F34004945: image.png <https://phabricator.wikimedia.org/F34004945>
Steps to rep
JeroenDeDauw created this task.
JeroenDeDauw added projects: Wikidata, Wikibase.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
Wikibase currently only support item IDs that are a number prefixed with Q.
Example: `Q123`. IDs in different formats, like `123-4X`, are not
JeroenDeDauw closed this task as "Resolved".
JeroenDeDauw added a comment.
We put the data type in a new extension. In retrospect perhaps we should have
done that right away.
TASK DETAIL
https://phabricator.wikimedia.org/T258932
EMAIL PREFERENCES
https://phabricator.wik
JeroenDeDauw added a comment.
https://github.com/wmde/WikibaseDataModelServices/pull/219
TASK DETAIL
https://phabricator.wikimedia.org/T220150
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: Lucas_Werkmeister_WMDE, sarhan.alaa
JeroenDeDauw closed this task as "Invalid".
TASK DETAIL
https://phabricator.wikimedia.org/T221699
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: JeroenDeDauw, Aklapper, Addshore, Ladsgroup, sarhan.alaa, alaa_wmde,
Nan
JeroenDeDauw closed subtask T221699: Introduce appropriate abstraction for
clean up invocation in wikibase-term-store as "Invalid".
TASK DETAIL
https://phabricator.wikimedia.org/T220150
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jeroe
JeroenDeDauw added a comment.
Ready for review:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/507954
TASK DETAIL
https://phabricator.wikimedia.org/T219894
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc
JeroenDeDauw added a comment.
One thing left in the maintenance script itself: support property id ranges.
I will work on this today
TASK DETAIL
https://phabricator.wikimedia.org/T219894
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To
JeroenDeDauw added a comment.
I think something along these lines makes sense, please comment here:
https://github.com/wmde/doctrine-term-store/pull/8/files
The diff tells us which terms to remove, which is the minimum info we need to
give to the cleanup code.
As far as I can tell
JeroenDeDauw added a comment.
I am also not happy with this task, as again it specifies a solution, not an
outcome. I much rather have "avoid expensive cleanup during the request to the
degree this is possible" as acceptance criteria in the story.
TASK DETA
JeroenDeDauw added a comment.
We talked about this (two weeks ago?) and concluded there likely is no need
to introduce anything in wikibase/term-store. I'm pretty annoyed with this task
now since it specifies a solution rather than a problem that needs to be solved.
TASK DETAIL
JeroenDeDauw added a comment.
> WikibaseImport contains a limited number of items and properties
What does this mean? I thought WikibaseImport gets items and properties from
Wikidata. How does it contain a limited number?
TASK DETAIL
https://phabricator.wikimedia.org/T220210
EM
JeroenDeDauw added a comment.
https://www.mediawiki.org/wiki/Manual:Job_queue
TASK DETAIL
https://phabricator.wikimedia.org/T220150
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: sarhan.alaa, Ladsgroup, Addshore, alaa_wmde
JeroenDeDauw added a comment.
This means we have to go with the "smart update using diff" approach, since
otherwise we do not know which terms have been removed. Not clear to me it will
make sense to do the cleanup in post-request, we might end up only delaying a
few % of t
JeroenDeDauw added a comment.
@alaa_wmde what is the status of this?
TASK DETAIL
https://phabricator.wikimedia.org/T221568
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: alaa_wmde, Aklapper, JeroenDeDauw, Nandana, Lahi, Gq86
JeroenDeDauw created this task.
JeroenDeDauw added projects: Wikidata wb_terms Trailblazing, Patch-For-Review,
Wikidata.
Restricted Application removed a project: Patch-For-Review.
TASK DESCRIPTION
Improve the way we access the MediaWiki mysqli or PDO connection.
https://github.com/wmde
JeroenDeDauw added a comment.
We already did some of this while working on the property script:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/505679
TASK DETAIL
https://phabricator.wikimedia.org/T221564
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings
JeroenDeDauw created this task.
JeroenDeDauw added projects: Wikidata wb_terms Trailblazing, Wikidata.
TASK DESCRIPTION
TASK DETAIL
https://phabricator.wikimedia.org/T221564
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: alaa_wmde
JeroenDeDauw added a comment.
F28732813: image.png <https://phabricator.wikimedia.org/F28732813>
TASK DETAIL
https://phabricator.wikimedia.org/T220210
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: alaa_wmde, JeroenDeDauw
Cc: Ak
JeroenDeDauw added a comment.
Yesterday while thinking about design stuff I randomly realized that we might
not need a script like this. Can't we just use
https://github.com/Wikidata/WikibaseImport to important a bunch of real
entities? If that is too slow, then perhaps we can use
JeroenDeDauw closed this task as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T219296
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup, JeroenDeDauw
Cc: Ladsgroup, Aklapper, alaa_wmde, joker88john, CucyNoi
JeroenDeDauw closed this task as "Resolved".
JeroenDeDauw claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T219295
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: JeroenDeDauw, Aklapper, alaa_wmde, j
JeroenDeDauw closed subtask T219295: Create service for writing property terms
as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T219121
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: Aklapper, alaa_wmde, Nan
JeroenDeDauw closed subtask T220155: Implement Doctrine DBAL Driver Connection
wrapper for MW db connection as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T219120
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jeroe
JeroenDeDauw added a subtask: T220150: Clean up unused records.
TASK DETAIL
https://phabricator.wikimedia.org/T219121
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: Aklapper, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic
JeroenDeDauw removed a subtask: T220150: Clean up unused records.
TASK DETAIL
https://phabricator.wikimedia.org/T219295
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: JeroenDeDauw, Aklapper, alaa_wmde, joker88john, CucyNoiD, Nandana
JeroenDeDauw added a parent task: T219121: [Checkpoint 2] Refactor Write &
Migration code for Properties.
TASK DETAIL
https://phabricator.wikimedia.org/T220150
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: sarhan.alaa, Ladsg
JeroenDeDauw removed a parent task: T219295: Create service for writing
property terms.
TASK DETAIL
https://phabricator.wikimedia.org/T220150
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: sarhan.alaa, Ladsgroup, Addshore
JeroenDeDauw added a comment.
First step:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/502781
TASK DETAIL
https://phabricator.wikimedia.org/T219297
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: JeroenDeDauw
JeroenDeDauw added a comment.
"delete everything" means deleting all terms for an item/property in the
item/property_terms table, rather than just those that actually need to be
removed.
TASK DETAIL
https://phabricator.wikimedia.org/T220150
EMAIL PREFERENC
JeroenDeDauw closed this task as "Declined".
JeroenDeDauw added a comment.
We won't be doing this as per https://phabricator.wikimedia.org/T220150
TASK DETAIL
https://phabricator.wikimedia.org/T220169
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/e
JeroenDeDauw closed subtask T220169: Optimize term updating as
"Declined".
TASK DETAIL
https://phabricator.wikimedia.org/T219295
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: JeroenDeDauw, Aklapper, alaa_wmde, j
JeroenDeDauw added a comment.
We figured we go with delete and insert everything. Task description updated
to reflect this.
TASK DETAIL
https://phabricator.wikimedia.org/T220150
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc
JeroenDeDauw renamed this task from "Decide on initial cleanup strategy" to
"Clean up unused records".
JeroenDeDauw updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T220150
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/e
JeroenDeDauw added a comment.
While not the best fro a design or flexibility perspective, I suspect the
most pragmatic approach here is to just create a MW maintenance script in
Wikibase (Repo?).
TASK DETAIL
https://phabricator.wikimedia.org/T220210
EMAIL PREFERENCES
https
JeroenDeDauw added a comment.
@alaa_wmde are you working on this? If so, please link the stuff you have so
far.
TASK DETAIL
https://phabricator.wikimedia.org/T220210
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: alaa_wmde, JeroenDeDauw
Cc
JeroenDeDauw added a comment.
Also part of this: https://github.com/wmde/wikibase-term-store/pull/7
TASK DETAIL
https://phabricator.wikimedia.org/T219144
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: JeroenDeDauw, Aklapper
JeroenDeDauw added a comment.
First step
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/501992
TASK DETAIL
https://phabricator.wikimedia.org/T219144
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: JeroenDeDauw
JeroenDeDauw added a comment.
The updating optimization ticket <https://phabricator.wikimedia.org/T220169>
is relevant for this cleanup. We now have two main approaches:
**delete and insert everything**
Downside: performance penalty for re-inserting things that did not
JeroenDeDauw added a comment.
I came to a similar conclusion after trying to write some code without
looking at this ticket first :) It might still be worth it to do the diff
because it helps https://phabricator.wikimedia.org/T220150. I'll comment more
there.
TASK DETAIL
JeroenDeDauw added a comment.
@alaa_wmde seems to have a different idea of how the maintenance script would
work then I do.
My thoughts where that the script would need to go through each record and
then do some query to find out if it is unused. That means the script would run
the
JeroenDeDauw added a comment.
So this is semi-blocked on figuring out what we do for labs, since that
impacts the reasons for immediate cleanup.
We can already think about this question though: if labs is not a concern,
can we get away with not spending effort onto this? (no cleanup (1
JeroenDeDauw updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T220150
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: Ladsgroup, Addshore, alaa_wmde, Aklapper, JeroenDeDauw, Nandana, Lahi,
Gq86
JeroenDeDauw updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T220150
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: Ladsgroup, Addshore, alaa_wmde, Aklapper, JeroenDeDauw, Nandana, Lahi,
Gq86
JeroenDeDauw updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T220150
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: Ladsgroup, Addshore, alaa_wmde, Aklapper, JeroenDeDauw, Nandana, Lahi,
Gq86
JeroenDeDauw updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T220150
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: Ladsgroup, Addshore, alaa_wmde, Aklapper, JeroenDeDauw, Nandana, Lahi,
Gq86
JeroenDeDauw added a comment.
I was wondering about how much extra complexity the post request approach (4)
would bring. In particular, which info do we need to give to the job. Giving
the property id is not sufficient. You could give the ids of the text records
and then in the job check if
JeroenDeDauw removed alaa_wmde as the assignee of this task.
TASK DETAIL
https://phabricator.wikimedia.org/T220169
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: alaa_wmde, Aklapper, JeroenDeDauw, Nandana, Lahi, Gq86
JeroenDeDauw removed alaa_wmde as the assignee of this task.
TASK DETAIL
https://phabricator.wikimedia.org/T219295
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: JeroenDeDauw, Aklapper, alaa_wmde, CucyNoiD, Nandana, NebulousIris
JeroenDeDauw created this task.
JeroenDeDauw added projects: Wikidata wb_terms Trailblazing, Wikidata,
Patch-For-Review.
Restricted Application removed a project: Patch-For-Review.
TASK DESCRIPTION
Currently the new service (DoctrinePropertyTermStore) uses naive updating. It
deletes
JeroenDeDauw added a comment.
I renamed this back to an implementation agnostic task, since else we don't
have anything to track the completion of the service implementation, and a
parent task for more detailed things such as the cleanup logic.
TASK DETAIL
JeroenDeDauw added a comment.
huh. Why is the DBAL connection part of this checkpoint and not checkpoint 2?
I was expecting it to be part of checkpoint 2
TASK DETAIL
https://phabricator.wikimedia.org/T219120
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
JeroenDeDauw renamed this task from "Adjust current write logic to write
proerty terms to new schema" to "Adjust current write logic to write property
terms to new schema".
TASK DETAIL
https://phabricator.wikimedia.org/T219297
EMAIL PREFERENCES
https://phabricator.wi
JeroenDeDauw added a subtask: T220155: Implement Doctrine DBAL Driver
Connection wrapper for mw context.
TASK DETAIL
https://phabricator.wikimedia.org/T219295
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: alaa_wmde, JeroenDeDauw
Cc: Aklapper
JeroenDeDauw renamed this task from "[MW DBAL] Implement the new interface for
writing property terms" to "Create service for writing property terms".
TASK DETAIL
https://phabricator.wikimedia.org/T219295
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/pa
JeroenDeDauw closed this task as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T219294
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup, JeroenDeDauw
Cc: Aklapper, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420
JeroenDeDauw closed subtask T219294: Create interface for writing and deleting
entity terms as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T219121
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: Aklapper,
JeroenDeDauw updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T220150
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: Ladsgroup, Addshore, alaa_wmde, Aklapper, JeroenDeDauw, Nandana, Lahi,
Gq86
JeroenDeDauw removed alaa_wmde as the assignee of this task.
JeroenDeDauw added subscribers: Amire80, Addshore.
TASK DETAIL
https://phabricator.wikimedia.org/T220150
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: Addshore, Amire80
JeroenDeDauw updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T220150
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: alaa_wmde, JeroenDeDauw
Cc: alaa_wmde, Aklapper, JeroenDeDauw, Nandana, Lahi, Gq86, GoranSMilovanovic
JeroenDeDauw created this task.
JeroenDeDauw added projects: Wikidata wb_terms Trailblazing, Wikidata,
Patch-For-Review.
Restricted Application removed a project: Patch-For-Review.
TASK DESCRIPTION
Because of the normalization we are ending up with unused records in the DB.
When the terms
JeroenDeDauw renamed this task from "Update update.php with the new SQL files"
to "Register schema schanges with MW update mechanism".
JeroenDeDauw updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T219144
EMAIL PREFERENCES
https://phabr
JeroenDeDauw added a comment.
-- Approach 1: leaving JS as it is
WikibaseLexeme/
extension/
i18n/
maintenance/
resources/
includes/ -- Contents of current src/MediaWiki/
Actions/
Api/
...
tests/
browser
JeroenDeDauw added a comment.
This is done now except for the 5 trillion rountrips with the CS on Gerrit that will likely still happen.
Wikibase change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/477031
Wikibase Lexeme change: https://gerrit.wikimedia.org/r/c/mediawiki
JeroenDeDauw added a comment.
I take it this commit and the follow ups can be abandoned? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/450399/TASK DETAILhttps://phabricator.wikimedia.org/T184933EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To
JeroenDeDauw added a comment.
The initial pass over the structure is done. Having a single mostly-sane UC is almost done. See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/472159 and dependent commits. After that the tests will also need to be reorganized. I do not need
JeroenDeDauw added a comment.
I made two commits simplifying the involved code in preparation of implementing the behavior change:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/472483
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/472732
Discussed how to
JeroenDeDauw closed this task as "Resolved".JeroenDeDauw claimed this task.JeroenDeDauw added a comment.
Already fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseQualityConstraints/+/471046TASK DETAILhttps://phabricator.wikimedia.org/T208534EMAIL PREFER
JeroenDeDauw created this task.JeroenDeDauw added a project: Wikibase-Quality-Constraints.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONThis change https://gerrit.wikimedia.org/r/c/mediawiki/extensions
JeroenDeDauw renamed this task from "Outdated version of CS used on Gerrit" to "Outdated version of CS cause failures on Gerrit".
TASK DETAILhttps://phabricator.wikimedia.org/T208534EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JeroenDe
JeroenDeDauw added a comment.
Release PR: https://github.com/wmde/WikibaseDataModel/pull/801TASK DETAILhttps://phabricator.wikimedia.org/T206325EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JeroenDeDauwCc: JeroenDeDauw, gerritbot, Aklapper, Pablo-WMDE
JeroenDeDauw added a comment.
As @Addshore said, that composer info does not look right. You'll get the error you are getting when the code is not loaded. So my guess is that you do not have it loaded.TASK DETAILhttps://phabricator.wikimedia.org/T208500EMAIL PREFERENCES
JeroenDeDauw added a comment.
AFAIK Wikibase does not use Geo 4.x, since Geo 4.x requires PHP 7.1. So it is not clear to me how the 4.1 release could affect Wikibase.
It is also not clear this issue is related to "GlobeCoordinateValue no longer extends DataValueObject". The c
JeroenDeDauw added a comment.
Ready for review : https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseQualityConstraints/+/463740TASK DETAILhttps://phabricator.wikimedia.org/T204714EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore
JeroenDeDauw added a comment.
I'll amend the changeTASK DETAILhttps://phabricator.wikimedia.org/T204714EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, JeroenDeDauwCc: JeroenDeDauw, Jonas, gerritbot, Addshore, Aklapper, Lucas_Werkmeister
JeroenDeDauw added a comment.
Someone will need to follow up on Jonas his PRTASK DETAILhttps://phabricator.wikimedia.org/T204714EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, JeroenDeDauwCc: JeroenDeDauw, Jonas, gerritbot, Addshore, Aklapper
JeroenDeDauw added a comment.
One thing we could do is revert the change causing all the pain. EntityDocument extending ClearableEntity might be nice, though likely not worth all this effort.TASK DETAILhttps://phabricator.wikimedia.org/T206325EMAIL PREFERENCEShttps://phabricator.wikimedia.org
JeroenDeDauw added a comment.
I've started cleaning up the existing interactor to correspond to what an interactor normally is and to respect architectural boundaries. This is mostly done. Chain of commits starting with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseL
JeroenDeDauw added a comment.
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/469367TASK DETAILhttps://phabricator.wikimedia.org/T206619EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JeroenDeDauwCc: Tarrow, Aklapper, JeroenDeDauw
JeroenDeDauw added a comment.
Chain partially merged. First commit that still needs merging: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/466682/TASK DETAILhttps://phabricator.wikimedia.org/T206619EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
JeroenDeDauw added a comment.
Initial moving is done, ending with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/466691
The linked commit is the only one that does something other than directory/NS move. After this I want to look at things in a bit more detail, likely
JeroenDeDauw added a comment.
Started with moving : https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/466614
All changes are on branch "move". Starting with the second change there is a CS failure on Jenkins since some lines are now longer than 110 chars. I'm
JeroenDeDauw updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...**[1]**
These extensions cannot be compatible with DM 7.x and 8.x at the same time
because DataModel's EntityDocument already implements ClearableEntity as of 8.0TASK DETAILhttps://phabricator.wikimedi
JeroenDeDauw claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T206619EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JeroenDeDauwCc: Aklapper, JeroenDeDauw, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs
JeroenDeDauw added a comment.
The original setup was as follows:
composer ci: runs all ci checks
composer test: runs all tests
composer cs: runs all style checks
This was done intentionally. And there was disagreement before about changing this. So I think this should NOT be a volunteer
JeroenDeDauw added a comment.
Right ok, that makes sense.TASK DETAILhttps://phabricator.wikimedia.org/T204541EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JeroenDeDauwCc: Lucas_Werkmeister_WMDE, Aklapper, Addshore, JeroenDeDauw, Pablo-WMDE, Nandana, Lahi
JeroenDeDauw added a comment.
I don’t see the benefit of removing the entity ID from the statement GUID.
Having it in there creates a bunch of problems:
Entities that do not have an ID yet can have statements. This forces us to have nullable GUIDs
Statements can exist loose from Entities. For
JeroenDeDauw added a comment.
I poked at this stuff way back in 2013(?) and remember we had some problems with the default config. I believe one of the issues we had is that we could not manage the permissions ourselves. That is many years ago though, with presumably the default config having
JeroenDeDauw added a comment.
If I'm not mistaken we talked about moving the PHP code of that package directly into Wikibase.git two years ago or so. I can't remember if there was a reason to not do that, or if simply no one got to it.TASK DETAILhttps://phabricator.wikimedia.org/T1
JeroenDeDauw added a comment.
How about wikibase/data-types instead? Same for the package name.
Reasoning: this package is not part of data-values, which is why it is not at https://github.com/DataValues/TASK DETAILhttps://phabricator.wikimedia.org/T180456EMAIL PREFERENCEShttps
JeroenDeDauw added a comment.
If you add this code to the Wikivase.git repository you likely make it even harder to split that repository into clean well-defined parts. Suppose you want to put the client and repository extensions in their own git repository, then you'll also need to deal
JeroenDeDauw updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... - con: dependencies on MediaWiki, Wikibase and other libs can creep in without being caught by CI
- con: code provided by those libs is no longer versioned as now - all only work with current Wikibase master
1 - 100 of 385 matches
Mail list logo
